209036 2020-03-12 19:51:28 -0700 Remove unused SmartMagnificationController Magnify message 2020-03-13 09:50:08 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham commit-queue thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1629461 0 bfulgham 2020-03-12 19:51:28 -0700 Remove the unused Magnify message from the SmartMagnificationController, since this is dead code. 1629462 1 bfulgham 2020-03-12 19:51:40 -0700 <rdar://problem/59678060> 1629466 2 393445 bfulgham 2020-03-12 19:56:34 -0700 Created attachment 393445 Patch 1629653 3 393445 commit-queue 2020-03-13 09:50:06 -0700 Comment on attachment 393445 Patch Clearing flags on attachment: 393445 Committed r258403: <https://trac.webkit.org/changeset/258403> 1629654 4 commit-queue 2020-03-13 09:50:08 -0700 All reviewed patches have been landed. Closing bug. 393445 2020-03-12 19:56:34 -0700 2020-03-13 09:50:06 -0700 Patch bug-209036-20200312195634.patch text/plain 5497 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4Mzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGViNzk1MzkyNTY5ZTE4OGVk MTcyZDIwOTVkZTkwYjdiZWM0YTBlY2YuLjM2YTk3MzA1OTBjOTdiZjdiMDA0OGRmNTg1NWZiYzFl ZDMzMjJlYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDMtMTIgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHVudXNlZCBTbWFy dE1hZ25pZmljYXRpb25Db250cm9sbGVyIE1hZ25pZnkgbWVzc2FnZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MDM2CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS81OTY3ODA2MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBSZW1vdmUgdGhlIHVudXNlZCBNYWduaWZ5IG1lc3NhZ2UgZnJvbSB0aGUgU21h cnRNYWduaWZpY2F0aW9uQ29udHJvbGxlciwgc2luY2UgdGhpcyBpcyBkZWFkIGNvZGUuCisKKyAg ICAgICAgKiBVSVByb2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIuaDoKKyAg ICAgICAgKiBVSVByb2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIubWVzc2Fn ZXMuaW46CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9TbWFydE1hZ25pZmljYXRpb25Db250cm9s bGVyLm1tOgorICAgICAgICAoV2ViS2l0OjpTbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVyOjpt YWduaWZ5KTogRGVsZXRlZC4KKwogMjAyMC0wMy0xMiAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJA YXBwbGUuY29tPgogCiAgICAgICAgIFdlYlBhZ2VQcm94eTo6U2F2ZUltYWdlVG9MaWJyYXJ5IHNo b3VsZCB2YWxpZGF0ZSBpdHMgYGltYWdlU2l6ZWAgcGFyYW1ldGVyCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvU21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlci5oIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIu aAppbmRleCAwMjAxMTY3OWI3OTFmOGUwYWQxMWYxYThmNTI3MzFhZmEzMDg1NzI0Li4yOGY3YTk2 NzY4ZDM3MWQ4ZmIwNTlkYmZhNzRiOWJjNGIzMTU1NzAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvU21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlci5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9TbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVyLmgK QEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDEzLCAyMDE0IEFwcGxlIElu Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxMy0yMDIwIEFwcGxl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cwpAQCAtMjMsOCArMjMsNyBAQAogICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgog ICovCiAKLSNpZm5kZWYgU21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlcl9oCi0jZGVmaW5lIFNt YXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXJfaAorI3ByYWdtYSBvbmNlCiAKICNpZiBQTEFURk9S TShJT1NfRkFNSUxZKQogCkBAIC01Niw3ICs1NSw2IEBAIHByaXZhdGU6CiAgICAgdm9pZCBkaWRS ZWNlaXZlTWVzc2FnZShJUEM6OkNvbm5lY3Rpb24mLCBJUEM6OkRlY29kZXImKSBvdmVycmlkZTsK IAogICAgIHZvaWQgZGlkQ29sbGVjdEdlb21ldHJ5Rm9yU21hcnRNYWduaWZpY2F0aW9uR2VzdHVy ZShXZWJDb3JlOjpGbG9hdFBvaW50IG9yaWdpbiwgV2ViQ29yZTo6RmxvYXRSZWN0IHJlbmRlclJl Y3QsIFdlYkNvcmU6OkZsb2F0UmVjdCB2aXNpYmxlQ29udGVudEJvdW5kcywgYm9vbCBmaXRFbnRp cmVSZWN0LCBkb3VibGUgdmlld3BvcnRNaW5pbXVtU2NhbGUsIGRvdWJsZSB2aWV3cG9ydE1heGlt dW1TY2FsZSk7Ci0gICAgdm9pZCBtYWduaWZ5KFdlYkNvcmU6OkZsb2F0UG9pbnQgb3JpZ2luLCBX ZWJDb3JlOjpGbG9hdFJlY3QgdGFyZ2V0UmVjdCwgV2ViQ29yZTo6RmxvYXRSZWN0IHZpc2libGVD b250ZW50UmVjdCwgZG91YmxlIHZpZXdwb3J0TWluaW11bVNjYWxlLCBkb3VibGUgdmlld3BvcnRN YXhpbXVtU2NhbGUpOwogICAgIHZvaWQgc2Nyb2xsVG9SZWN0KFdlYkNvcmU6OkZsb2F0UG9pbnQg b3JpZ2luLCBXZWJDb3JlOjpGbG9hdFJlY3QgdGFyZ2V0UmVjdCk7CiAgICAgc3RkOjp0dXBsZTxX ZWJDb3JlOjpGbG9hdFJlY3QsIGRvdWJsZSwgZG91YmxlPiBzbWFydE1hZ25pZmljYXRpb25UYXJn ZXRSZWN0QW5kWm9vbVNjYWxlcyhXZWJDb3JlOjpGbG9hdFJlY3QgdGFyZ2V0UmVjdCwgZG91Ymxl IG1pbmltdW1TY2FsZSwgZG91YmxlIG1heGltdW1TY2FsZSwgYm9vbCBhZGRNYWduaWZpY2F0aW9u UGFkZGluZyk7CiAKQEAgLTY3LDUgKzY1LDMgQEAgcHJpdmF0ZToKIH0gLy8gbmFtZXNwYWNlIFdl YktpdAogCiAjZW5kaWYgLy8gUExBVEZPUk0oSU9TX0ZBTUlMWSkKLQotI2VuZGlmIC8vIFNtYXJ0 TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXJfaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNhdGlvbkNvbnRyb2xsZXIubWVzc2FnZXMuaW4gYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvU21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlci5tZXNz YWdlcy5pbgppbmRleCAzYWE5ZjYzNWFhMzMyN2JhMmFmNTRjZjZjZjI3OWIwMWQyNWU3ZjM1Li5k NzNjZGJiMGIxZmJmZTRmZmJiZjJmZGYzNzI2YzgzOTM2MTMzZGYyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvU21hcnRNYWduaWZpY2F0aW9uQ29udHJvbGxlci5tZXNz YWdlcy5pbgorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvU21hcnRNYWduaWZpY2F0 aW9uQ29udHJvbGxlci5tZXNzYWdlcy5pbgpAQCAtMSw0ICsxLDQgQEAKLSMgQ29weXJpZ2h0IChD KSAyMDE0IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAy MDE0LTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogIwogIyBSZWRpc3RyaWJ1 dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK ICMgbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2lu ZyBjb25kaXRpb25zCkBAIC0yNCw3ICsyNCw2IEBACiAKIG1lc3NhZ2VzIC0+IFNtYXJ0TWFnbmlm aWNhdGlvbkNvbnRyb2xsZXIgTm90UmVmQ291bnRlZCB7CiAgICAgRGlkQ29sbGVjdEdlb21ldHJ5 Rm9yU21hcnRNYWduaWZpY2F0aW9uR2VzdHVyZShXZWJDb3JlOjpGbG9hdFBvaW50IG9yaWdpbiwg V2ViQ29yZTo6RmxvYXRSZWN0IHJlbmRlclJlY3QsIFdlYkNvcmU6OkZsb2F0UmVjdCB2aXNpYmxl Q29udGVudEJvdW5kcywgYm9vbCBmaXRFbnRpcmVSZWN0LCBkb3VibGUgdmlld3BvcnRNaW5pbXVt U2NhbGUsIGRvdWJsZSB2aWV3cG9ydE1heGltdW1TY2FsZSkKLSAgICBNYWduaWZ5KFdlYkNvcmU6 OkZsb2F0UG9pbnQgb3JpZ2luLCBXZWJDb3JlOjpGbG9hdFJlY3QgdGFyZ2V0UmVjdCwgV2ViQ29y ZTo6RmxvYXRSZWN0IHZpc2libGVDb250ZW50UmVjdCwgZG91YmxlIHZpZXdwb3J0TWluaW11bVNj YWxlLCBkb3VibGUgdmlld3BvcnRNYXhpbXVtU2NhbGUpCiAgICAgU2Nyb2xsVG9SZWN0KFdlYkNv cmU6OkZsb2F0UG9pbnQgb3JpZ2luLCBXZWJDb3JlOjpGbG9hdFJlY3QgdGFyZ2V0UmVjdCkKIH0K IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1NtYXJ0TWFnbmlmaWNh dGlvbkNvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvU21hcnRNYWdu aWZpY2F0aW9uQ29udHJvbGxlci5tbQppbmRleCBkMDUyOWJkNTg5YmEyN2Q3ZjY3ZGQzM2Q5MTg3 MDFjYjAxMjJkZWQxLi42ZThkNWJkOTc1YmNiMDhmY2EwMmM4NzBiZjExZmNhZTVhNTg1ZmM3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvU21hcnRNYWduaWZpY2F0aW9u Q29udHJvbGxlci5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvU21hcnRNYWdu aWZpY2F0aW9uQ29udHJvbGxlci5tbQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQg KEMpIDIwMTQgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChD KSAyMDE0LTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlz dHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0 aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZv bGxvd2luZyBjb25kaXRpb25zCkBAIC0xMzQsMTMgKzEzNCw2IEBAIHZvaWQgU21hcnRNYWduaWZp Y2F0aW9uQ29udHJvbGxlcjo6ZGlkQ29sbGVjdEdlb21ldHJ5Rm9yU21hcnRNYWduaWZpY2F0aW9u R2VzdHVyCiAgICAgW21fY29udGVudFZpZXcgX3pvb21Ub0luaXRpYWxTY2FsZVdpdGhPcmlnaW46 b3JpZ2luXTsKIH0KIAotdm9pZCBTbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVyOjptYWduaWZ5 KEZsb2F0UG9pbnQgb3JpZ2luLCBGbG9hdFJlY3QgdGFyZ2V0UmVjdCwgRmxvYXRSZWN0IHZpc2li bGVDb250ZW50UmVjdCwgZG91YmxlIHZpZXdwb3J0TWluaW11bVNjYWxlLCBkb3VibGUgdmlld3Bv cnRNYXhpbXVtU2NhbGUpCi17Ci0gICAgYXV0byBbYWRqdXN0ZWRUYXJnZXRSZWN0LCBtaW5pbXVt U2NhbGUsIG1heGltdW1TY2FsZV0gPSBzbWFydE1hZ25pZmljYXRpb25UYXJnZXRSZWN0QW5kWm9v bVNjYWxlcyh0YXJnZXRSZWN0LCB2aWV3cG9ydE1pbmltdW1TY2FsZSwgdmlld3BvcnRNYXhpbXVt U2NhbGUsIHRydWUpOwotCi0gICAgW21fY29udGVudFZpZXcgX3pvb21Ub1JlY3Q6YWRqdXN0ZWRU YXJnZXRSZWN0IHdpdGhPcmlnaW46b3JpZ2luIGZpdEVudGlyZVJlY3Q6Tk8gbWluaW11bVNjYWxl Om1pbmltdW1TY2FsZSBtYXhpbXVtU2NhbGU6bWF4aW11bVNjYWxlIG1pbmltdW1TY3JvbGxEaXN0 YW5jZTowXTsKLX0KLQogdm9pZCBTbWFydE1hZ25pZmljYXRpb25Db250cm9sbGVyOjpzY3JvbGxU b1JlY3QoRmxvYXRQb2ludCBvcmlnaW4sIEZsb2F0UmVjdCB0YXJnZXRSZWN0KQogewogICAgIFtt X2NvbnRlbnRWaWV3IF9zY3JvbGxUb1JlY3Q6dGFyZ2V0UmVjdCB3aXRoT3JpZ2luOm9yaWdpbiBt aW5pbXVtU2Nyb2xsRGlzdGFuY2U6MF07Cg==