20903 2008-09-17 14:35:31 -0700 transition end event when -webkit-transition-property: all puts wrong propertyName in event 2008-09-22 13:20:12 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cmarrin cmarrin dino simon.fraser oldest_to_newest 91523 0 cmarrin 2008-09-17 14:35:31 -0700 The propertyName in the event is empty if the transition-property is set to all (or left as the default). If you transition multiple properties it is impossible to tell which event is firing for which property. You can see this, for instance, in LayoutTests/transitions/transition-end-event-all-properties.html. It logs an empty propertyName for each event. 91525 1 23509 cmarrin 2008-09-17 14:38:34 -0700 Created attachment 23509 Patch, including modified layout test 92175 2 simon.fraser 2008-09-22 13:20:12 -0700 Committed r36774 M WebCore/ChangeLog M WebCore/page/animation/ImplicitAnimation.cpp M LayoutTests/ChangeLog M LayoutTests/transitions/transition-end-event-all-properties.html M LayoutTests/transitions/transition-end-event-all-properties-expected.txt r36774 = 0f83a518dda6b9973d30f2bae7a1b82083bc5b29 (trunk) 23509 2008-09-17 14:38:34 -0700 2008-09-19 14:23:08 -0700 Patch, including modified layout test 20903.patch text/plain 5278 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzNjU1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDgtMDktMTcgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHRy YW5zaXRpb24gZW5kIGV2ZW50IHdoZW4gLXdlYmtpdC10cmFuc2l0aW9uLXByb3BlcnR5OiBhbGwg cHV0cyB3cm9uZyBwcm9wZXJ0eU5hbWUgaW4gZXZlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwOTAzCisKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlv bi9JbXBsaWNpdEFuaW1hdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbXBsaWNpdEFuaW1h dGlvbjo6c2VuZFRyYW5zaXRpb25FdmVudCk6CisKIDIwMDgtMDktMTcgIEJldGggRGFraW4gIDxi ZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCkluZGV4 OiBXZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0ltcGxpY2l0QW5pbWF0aW9uLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0ltcGxpY2l0QW5pbWF0aW9uLmNwcAkocmV2aXNp b24gMzY1NDIpCisrKyBXZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0ltcGxpY2l0QW5pbWF0aW9uLmNw cAkod29ya2luZyBjb3B5KQpAQCAtOTksMTAgKzk5LDEwIEBAIGJvb2wgSW1wbGljaXRBbmltYXRp b246OnNlbmRUcmFuc2l0aW9uRXYKICAgICAgICAgaWYgKHNob3VsZFNlbmRFdmVudEZvckxpc3Rl bmVyKGxpc3RlbmVyVHlwZSkpIHsKICAgICAgICAgICAgIGlmIChFbGVtZW50KiBlbGVtZW50ID0g ZWxlbWVudEZvckV2ZW50RGlzcGF0Y2goKSkgewogICAgICAgICAgICAgICAgIFN0cmluZyBwcm9w ZXJ0eU5hbWU7Ci0gICAgICAgICAgICAgICAgaWYgKG1fdHJhbnNpdGlvblByb3BlcnR5ICE9IGNB bmltYXRlQWxsKQotICAgICAgICAgICAgICAgICAgICBwcm9wZXJ0eU5hbWUgPSBnZXRQcm9wZXJ0 eU5hbWUoc3RhdGljX2Nhc3Q8Q1NTUHJvcGVydHlJRD4obV90cmFuc2l0aW9uUHJvcGVydHkpKTsK KyAgICAgICAgICAgICAgICBpZiAobV9hbmltYXRpbmdQcm9wZXJ0eSAhPSBjQW5pbWF0ZUFsbCkK KyAgICAgICAgICAgICAgICAgICAgcHJvcGVydHlOYW1lID0gZ2V0UHJvcGVydHlOYW1lKHN0YXRp Y19jYXN0PENTU1Byb3BlcnR5SUQ+KG1fYW5pbWF0aW5nUHJvcGVydHkpKTsKICAgICAgICAgICAg ICAgICBtX3dhaXRpbmdGb3JFbmRFdmVudCA9IHRydWU7Ci0gICAgICAgICAgICAgICAgbV9hbmlt YXRpb25FdmVudERpc3BhdGNoZXIuc3RhcnRUaW1lcihlbGVtZW50LCBwcm9wZXJ0eU5hbWUsIG1f dHJhbnNpdGlvblByb3BlcnR5LCB0cnVlLCBldmVudFR5cGUsIGVsYXBzZWRUaW1lKTsKKyAgICAg ICAgICAgICAgICBtX2FuaW1hdGlvbkV2ZW50RGlzcGF0Y2hlci5zdGFydFRpbWVyKGVsZW1lbnQs IHByb3BlcnR5TmFtZSwgbV9hbmltYXRpbmdQcm9wZXJ0eSwgdHJ1ZSwgZXZlbnRUeXBlLCBlbGFw c2VkVGltZSk7CiAgICAgICAgICAgICAgICAgcmV0dXJuIHRydWU7IC8vIERpZCBkaXNwYXRjaCBh biBldmVudAogICAgICAgICAgICAgfQogICAgICAgICB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAzNjU1 OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEz IEBACisyMDA4LTA5LTE3ICBDaHJpcyBNYXJyaW4gIDxjbWFycmluQGFwcGxlLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICB0cmFuc2l0aW9uIGVu ZCBldmVudCB3aGVuIC13ZWJraXQtdHJhbnNpdGlvbi1wcm9wZXJ0eTogYWxsIHB1dHMgd3Jvbmcg cHJvcGVydHlOYW1lIGluIGV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDkwMworCisgICAgICAgICogdHJhbnNpdGlvbnMvdHJhbnNpdGlvbi1l bmQtZXZlbnQtYWxsLXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHRyYW5zaXRp b25zL3RyYW5zaXRpb24tZW5kLWV2ZW50LWFsbC1wcm9wZXJ0aWVzLmh0bWw6CisKIDIwMDgtMDkt MTcgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFkYW0gUm9iZW4uCkluZGV4OiBMYXlvdXRUZXN0cy90cmFuc2l0aW9ucy90cmFuc2l0aW9uLWVu ZC1ldmVudC1hbGwtcHJvcGVydGllcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0 VGVzdHMvdHJhbnNpdGlvbnMvdHJhbnNpdGlvbi1lbmQtZXZlbnQtYWxsLXByb3BlcnRpZXMtZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAzNjU0MikKKysrIExheW91dFRlc3RzL3RyYW5zaXRpb25zL3Ry YW5zaXRpb24tZW5kLWV2ZW50LWFsbC1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dAkod29ya2luZyBj b3B5KQpAQCAtMSwxMCArMSwxMCBAQAogSW5pdGlhdGluZyB0cmFuc2l0aW9ucyBvbiB2YXJpb3Vz IHByb3BlcnRpZXMgb2YgYWxsIGJveGVzLgogCi1FeHBlY3RlZCBQcm9wZXJ0eTogVGFyZ2V0OiBi b3gxIFR5cGU6IHdlYmtpdFRyYW5zaXRpb25FbmQgRWxhcHNlZCBUaW1lOiAwLjUgLS0gUEFTUwot RXhwZWN0ZWQgUHJvcGVydHk6IFRhcmdldDogYm94MiBUeXBlOiB3ZWJraXRUcmFuc2l0aW9uRW5k IEVsYXBzZWQgVGltZTogMC41IC0tIFBBU1MKLUV4cGVjdGVkIFByb3BlcnR5OiBUYXJnZXQ6IGJv eDIgVHlwZTogd2Via2l0VHJhbnNpdGlvbkVuZCBFbGFwc2VkIFRpbWU6IDAuNSAtLSBQQVNTCi1F eHBlY3RlZCBQcm9wZXJ0eTogVGFyZ2V0OiBib3gzIFR5cGU6IHdlYmtpdFRyYW5zaXRpb25FbmQg RWxhcHNlZCBUaW1lOiAwLjcgLS0gUEFTUwotRXhwZWN0ZWQgUHJvcGVydHk6IFRhcmdldDogYm94 MyBUeXBlOiB3ZWJraXRUcmFuc2l0aW9uRW5kIEVsYXBzZWQgVGltZTogMC43IC0tIFBBU1MKLUV4 cGVjdGVkIFByb3BlcnR5OiBUYXJnZXQ6IGJveDMgVHlwZTogd2Via2l0VHJhbnNpdGlvbkVuZCBF bGFwc2VkIFRpbWU6IDAuNyAtLSBQQVNTCi1FeHBlY3RlZCBQcm9wZXJ0eTogVGFyZ2V0OiBib3gz IFR5cGU6IHdlYmtpdFRyYW5zaXRpb25FbmQgRWxhcHNlZCBUaW1lOiAwLjcgLS0gUEFTUworRXhw ZWN0ZWQgUHJvcGVydHk6IGJhY2tncm91bmQtY29sb3IgVGFyZ2V0OiBib3gyIFR5cGU6IHdlYmtp dFRyYW5zaXRpb25FbmQgRWxhcHNlZCBUaW1lOiAwLjUgLS0gUEFTUworRXhwZWN0ZWQgUHJvcGVy dHk6IGJhY2tncm91bmQtY29sb3IgVGFyZ2V0OiBib3gzIFR5cGU6IHdlYmtpdFRyYW5zaXRpb25F bmQgRWxhcHNlZCBUaW1lOiAwLjcgLS0gUEFTUworRXhwZWN0ZWQgUHJvcGVydHk6IGhlaWdodCBU YXJnZXQ6IGJveDMgVHlwZTogd2Via2l0VHJhbnNpdGlvbkVuZCBFbGFwc2VkIFRpbWU6IDAuNyAt LSBQQVNTCitFeHBlY3RlZCBQcm9wZXJ0eTogbGVmdCBUYXJnZXQ6IGJveDEgVHlwZTogd2Via2l0 VHJhbnNpdGlvbkVuZCBFbGFwc2VkIFRpbWU6IDAuNSAtLSBQQVNTCitFeHBlY3RlZCBQcm9wZXJ0 eTogbGVmdCBUYXJnZXQ6IGJveDIgVHlwZTogd2Via2l0VHJhbnNpdGlvbkVuZCBFbGFwc2VkIFRp bWU6IDAuNSAtLSBQQVNTCitFeHBlY3RlZCBQcm9wZXJ0eTogbGVmdCBUYXJnZXQ6IGJveDMgVHlw ZTogd2Via2l0VHJhbnNpdGlvbkVuZCBFbGFwc2VkIFRpbWU6IDAuNyAtLSBQQVNTCitFeHBlY3Rl ZCBQcm9wZXJ0eTogd2lkdGggVGFyZ2V0OiBib3gzIFR5cGU6IHdlYmtpdFRyYW5zaXRpb25FbmQg RWxhcHNlZCBUaW1lOiAwLjcgLS0gUEFTUwogCkluZGV4OiBMYXlvdXRUZXN0cy90cmFuc2l0aW9u cy90cmFuc2l0aW9uLWVuZC1ldmVudC1hbGwtcHJvcGVydGllcy5odG1sCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3RyYW5zaXRpb25zL3RyYW5zaXRpb24tZW5kLWV2ZW50LWFsbC1wcm9wZXJ0 aWVzLmh0bWwJKHJldmlzaW9uIDM2NTQyKQorKysgTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvdHJh bnNpdGlvbi1lbmQtZXZlbnQtYWxsLXByb3BlcnRpZXMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MzgsMTMgKzM4LDEzIEBACiAgICAgfQogCiAgICAgdmFyIGV4cGVjdGVkID0gWwotICAgICAgWyIi LCAiYm94MSIsICJ3ZWJraXRUcmFuc2l0aW9uRW5kIiwgMC41XSwKLSAgICAgIFsiIiwgImJveDIi LCAid2Via2l0VHJhbnNpdGlvbkVuZCIsIDAuNV0sCi0gICAgICBbIiIsICJib3gyIiwgIndlYmtp dFRyYW5zaXRpb25FbmQiLCAwLjVdLAotICAgICAgWyIiLCAiYm94MyIsICJ3ZWJraXRUcmFuc2l0 aW9uRW5kIiwgMC43XSwKLSAgICAgIFsiIiwgImJveDMiLCAid2Via2l0VHJhbnNpdGlvbkVuZCIs IDAuN10sCi0gICAgICBbIiIsICJib3gzIiwgIndlYmtpdFRyYW5zaXRpb25FbmQiLCAwLjddLAot ICAgICAgWyIiLCAiYm94MyIsICJ3ZWJraXRUcmFuc2l0aW9uRW5kIiwgMC43XQorICAgICAgWyJi YWNrZ3JvdW5kLWNvbG9yIiwgImJveDIiLCAid2Via2l0VHJhbnNpdGlvbkVuZCIsIDAuNV0sCisg ICAgICBbImJhY2tncm91bmQtY29sb3IiLCAiYm94MyIsICJ3ZWJraXRUcmFuc2l0aW9uRW5kIiwg MC43XSwKKyAgICAgIFsiaGVpZ2h0IiwgImJveDMiLCAid2Via2l0VHJhbnNpdGlvbkVuZCIsIDAu N10sCisgICAgICBbImxlZnQiLCAiYm94MSIsICJ3ZWJraXRUcmFuc2l0aW9uRW5kIiwgMC41XSwK KyAgICAgIFsibGVmdCIsICJib3gyIiwgIndlYmtpdFRyYW5zaXRpb25FbmQiLCAwLjVdLAorICAg ICAgWyJsZWZ0IiwgImJveDMiLCAid2Via2l0VHJhbnNpdGlvbkVuZCIsIDAuN10sCisgICAgICBb IndpZHRoIiwgImJveDMiLCAid2Via2l0VHJhbnNpdGlvbkVuZCIsIDAuN10KICAgICBdOwogICAg IAogICAgIGZ1bmN0aW9uIHN0YXJ0VHJhbnNpdGlvbigpCg==