209026 2020-03-12 16:21:21 -0700 [iOS WK2] Some pointerevents tests time out 2020-03-13 10:17:27 -0700 1 1 1 Unclassified WebKit UI Events WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser graouts simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1629410 0 simon.fraser 2020-03-12 16:21:21 -0700 [iOS WK2] Some pointerevents tests time out 1629413 1 393427 simon.fraser 2020-03-12 16:24:49 -0700 Created attachment 393427 Patch 1629414 2 simon.fraser 2020-03-12 16:24:53 -0700 <rdar://problem/60338691> 1629419 3 393427 wenson_hsieh 2020-03-12 16:55:31 -0700 Comment on attachment 393427 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393427&action=review > LayoutTests/pointerevents/utils.js:146 > setTimeout(resolve, durationInSeconds * 1000) Not for this patch, but it looks like we should fix this to actually listen for the zooming UIScriptController callbacks to know when the zooming animation is done instead of having a hard-coded timeout. > LayoutTests/pointerevents/utils.js:231 > + console.log(script); Was this console.log intended? 1629520 4 393427 graouts 2020-03-13 00:48:12 -0700 Comment on attachment 393427 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393427&action=review > LayoutTests/pointerevents/utils.js:230 > + let script = `uiController.${command}(${args}, () => uiController.uiScriptComplete());`; You could use `const` here instead of `let`. 1629671 5 simon.fraser 2020-03-13 10:17:27 -0700 https://trac.webkit.org/changeset/258406/webkit 393427 2020-03-12 16:24:49 -0700 2020-03-12 16:55:31 -0700 Patch bug-209026-20200312162447.patch text/plain 4519 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MzQyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzgyY2Q5N2I3NGVmNjE5MzFlZmEy ODMwNmRmNjNiODJiMmZiOTE0YS4uZTIxNGExZTc2ZTZiN2U5MmE1YmZjMDg1NDUwZGNiOTA1NGMz NGFiMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDIwLTAzLTEyICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBTb21lIHBvaW50ZXJl dmVudHMgdGVzdHMgdGltZSBvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIwOTAyNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAzMzg2OTE+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUG9pbnRlcmV2 ZW50cyB0ZXN0cyB0aGF0IHVzZWQgdWkuKiBmdW5jdGlvbnMgdGhyZXcgZXJyb3JzIGluIHRoZSBV SS1zaWRlIHNjcmlwdCBiZWNhdXNlIHVpLl9ydW4oKSBidW5nbGVkCisgICAgICAgIHRoZSBjYWxs YmFja3MuIEZpeCB1aS5fcnVuKCkgdG8gdGFrZSB0d28gYXJndW1lbnRzLCB0aGUgY29tbWFuZCBu YW1lIGFuZCBhbGwgYXJndW1lbnRzIGV4Y2VwdCB0aGUgY2FsbGJhY2ssCisgICAgICAgIHdoaWNo IGl0IGFkZHMuCisKKyAgICAgICAgVGhlIHRlc3RzIGFyZSBza2lwcGVkIGluIE9wZW4gU291cmNl IGJlY2F1c2UgbW9zdCBvZiB0aGVtIHJlcXVpcmUgdG91Y2ggZXZlbnRzLiAKKworICAgICAgICAq IHBvaW50ZXJldmVudHMvdXRpbHMuanM6CisgICAgICAgIChjb25zdC51aS5uZXcuVUlDb250cm9s bGVyLnByb3RvdHlwZS5zd2lwZSk6CisgICAgICAgIChjb25zdC51aS5uZXcuVUlDb250cm9sbGVy LnByb3RvdHlwZS50YXApOgorICAgICAgICAoY29uc3QudWkubmV3LlVJQ29udHJvbGxlci5wcm90 b3R5cGUuZG91YmxlVGFwKToKKyAgICAgICAgKGNvbnN0LnVpLm5ldy5VSUNvbnRyb2xsZXIucHJv dG90eXBlLmRvdWJsZVRhcFRvWm9vbSk6CisgICAgICAgIChjb25zdC51aS5uZXcuVUlDb250cm9s bGVyLnByb3RvdHlwZS50YXBTdHlsdXMpOgorICAgICAgICAoY29uc3QudWkubmV3LlVJQ29udHJv bGxlci5wcm90b3R5cGUuX3J1bkV2ZW50cyk6CisgICAgICAgIChjb25zdC51aS5uZXcuVUlDb250 cm9sbGVyLnByb3RvdHlwZS5fcnVuKToKKyAgICAgICAgKGNvbnN0LnVpLm5ldy5VSUNvbnRyb2xs ZXIpOgorICAgICAgICAoY29uc3QudWkubmV3LlVJQ29udHJvbGxlci5wcm90b3R5cGUuX3J1bi4p OiBEZWxldGVkLgorICAgICAgICAoY29uc3QudWkubmV3LlVJQ29udHJvbGxlci5wcm90b3R5cGUu X3J1bi5yZXR1cm4ubmV3LlByb21pc2UpOiBEZWxldGVkLgorCiAyMDIwLTAzLTEyICBTaW1vbiBG cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIy NTc5MzgpOiBTb21lIHBvaW50ZXJldmVudHMvaW9zL3RvdWNoLWFjdGlvbi1yZWdpb24gdGVzdHMg c3RhcnRlZCB0byBmYWlsCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wb2ludGVyZXZlbnRzL3V0 aWxzLmpzIGIvTGF5b3V0VGVzdHMvcG9pbnRlcmV2ZW50cy91dGlscy5qcwppbmRleCA0NzIxZjUz MDYxNGZkMDYyMGIxMzllYzQ1OGVlOGRmYTk0M2U4MDY3Li4xN2VkMGIzOWEzNWQ2ZDE3YjkyZjgz MzI4MzAwNWIyMWQwN2MwMjdjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wb2ludGVyZXZlbnRz L3V0aWxzLmpzCisrKyBiL0xheW91dFRlc3RzL3BvaW50ZXJldmVudHMvdXRpbHMuanMKQEAgLTEy NCwyOCArMTI0LDI3IEBAIGNvbnN0IHVpID0gbmV3IChjbGFzcyBVSUNvbnRyb2xsZXIgewogICAg IHN3aXBlKGZyb20sIHRvKQogICAgIHsKICAgICAgICAgY29uc3QgZHVyYXRpb25JblNlY29uZHMg PSAwLjE7Ci0gICAgICAgIHJldHVybiBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHRoaXMuX3J1bihg dWlDb250cm9sbGVyLmRyYWdGcm9tUG9pbnRUb1BvaW50KCR7ZnJvbS54fSwgJHtmcm9tLnl9LCAk e3RvLnh9LCAke3RvLnl9LCAke2R1cmF0aW9uSW5TZWNvbmRzfSlgKS50aGVuKCgpID0+CisgICAg ICAgIHJldHVybiBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHRoaXMuX3J1bignZHJhZ0Zyb21Qb2lu dFRvUG9pbnQnLCBgJHtmcm9tLnh9LCAke2Zyb20ueX0sICR7dG8ueH0sICR7dG8ueX0sICR7ZHVy YXRpb25JblNlY29uZHN9YCkudGhlbigoKSA9PgogICAgICAgICAgICAgc2V0VGltZW91dChyZXNv bHZlLCBkdXJhdGlvbkluU2Vjb25kcyAqIDEwMDApCiAgICAgICAgICkpOwogICAgIH0KIAogICAg IHRhcChvcHRpb25zKQogICAgIHsKLSAgICAgICAgcmV0dXJuIHRoaXMuX3J1bihgdWlDb250cm9s bGVyLnNpbmdsZVRhcEF0UG9pbnQoJHtvcHRpb25zLnh9LCAke29wdGlvbnMueX0pYCk7CisgICAg ICAgIHJldHVybiB0aGlzLl9ydW4oJ3NpbmdsZVRhcEF0UG9pbnQnLCBgJHtvcHRpb25zLnh9LCAk e29wdGlvbnMueX1gKTsKICAgICB9CiAKICAgICBkb3VibGVUYXAob3B0aW9ucykKICAgICB7Ci0g ICAgICAgIHJldHVybiB0aGlzLl9ydW4oYHVpQ29udHJvbGxlci5kb3VibGVUYXBBdFBvaW50KCR7 b3B0aW9ucy54fSwgJHtvcHRpb25zLnl9LCAwLCAoKSA9PiB1aUNvbnRyb2xsZXIudWlTY3JpcHRD b21wbGV0ZSgpKWApOworICAgICAgICByZXR1cm4gdGhpcy5fcnVuKCdkb3VibGVUYXBBdFBvaW50 JywgYCR7b3B0aW9ucy54fSwgJHtvcHRpb25zLnl9LCAwYCk7CiAgICAgfQogCiAgICAgZG91Ymxl VGFwVG9ab29tKG9wdGlvbnMpCiAgICAgewogICAgICAgICBjb25zdCBkdXJhdGlvbkluU2Vjb25k cyA9IDAuMzU7Ci0gICAgICAgIHJldHVybiBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHRoaXMuX3J1 bihgdWlDb250cm9sbGVyLmRvdWJsZVRhcEF0UG9pbnQoJHtvcHRpb25zLnh9LCAke29wdGlvbnMu eX0sIDApYCkudGhlbigoKSA9PgorICAgICAgICByZXR1cm4gbmV3IFByb21pc2UocmVzb2x2ZSA9 PiB0aGlzLl9ydW4oJ2RvdWJsZVRhcEF0UG9pbnQnLCBgJHtvcHRpb25zLnh9LCAke29wdGlvbnMu eX0sIDBgKS50aGVuKCgpID0+CiAgICAgICAgICAgICBzZXRUaW1lb3V0KHJlc29sdmUsIGR1cmF0 aW9uSW5TZWNvbmRzICogMTAwMCkKICAgICAgICAgKSk7Ci0gICAgICAgIHJldHVybiB0aGlzLl9y dW4oKTsKICAgICB9CiAKICAgICBwaW5jaE91dChvcHRpb25zKQpAQCAtMjE4LDIwICsyMTcsMTkg QEAgY29uc3QgdWkgPSBuZXcgKGNsYXNzIFVJQ29udHJvbGxlciB7CiAgICAgICAgIG9wdGlvbnMu YXppbXV0aEFuZ2xlID0gb3B0aW9ucy5hemltdXRoQW5nbGUgfHwgMDsKICAgICAgICAgb3B0aW9u cy5hbHRpdHVkZUFuZ2xlID0gb3B0aW9ucy5hbHRpdHVkZUFuZ2xlIHx8IDA7CiAgICAgICAgIG9w dGlvbnMucHJlc3N1cmUgPSBvcHRpb25zLnByZXNzdXJlIHx8IDA7Ci0gICAgICAgIHJldHVybiB0 aGlzLl9ydW4oYHVpQ29udHJvbGxlci5zdHlsdXNUYXBBdFBvaW50KCR7b3B0aW9ucy54fSwgJHtv cHRpb25zLnl9LCAke29wdGlvbnMuYXppbXV0aEFuZ2xlfSwgJHtvcHRpb25zLmFsdGl0dWRlQW5n bGV9LCAke29wdGlvbnMucHJlc3N1cmV9KWApOworICAgICAgICByZXR1cm4gdGhpcy5fcnVuKCdz dHlsdXNUYXBBdFBvaW50JywgYCR7b3B0aW9ucy54fSwgJHtvcHRpb25zLnl9LCAke29wdGlvbnMu YXppbXV0aEFuZ2xlfSwgJHtvcHRpb25zLmFsdGl0dWRlQW5nbGV9LCAke29wdGlvbnMucHJlc3N1 cmV9YCk7CiAgICAgfQogCiAgICAgX3J1bkV2ZW50cyhldmVudHMpCiAgICAgewotICAgICAgICBy ZXR1cm4gdGhpcy5fcnVuKGB1aUNvbnRyb2xsZXIuc2VuZEV2ZW50U3RyZWFtKCcke0pTT04uc3Ry aW5naWZ5KHsgZXZlbnRzIH0pfScpYCk7CisgICAgICAgIHJldHVybiB0aGlzLl9ydW4oJ3NlbmRF dmVudFN0cmVhbScsIGAnJHtKU09OLnN0cmluZ2lmeSh7IGV2ZW50cyB9KX0nYCk7CiAgICAgfQog Ci0gICAgX3J1bihjb21tYW5kKQorICAgIF9ydW4oY29tbWFuZCwgYXJncykKICAgICB7Ci0gICAg ICAgIHJldHVybiBuZXcgUHJvbWlzZShyZXNvbHZlID0+IHRlc3RSdW5uZXIucnVuVUlTY3JpcHQo YChmdW5jdGlvbigpIHsKLSAgICAgICAgICAgIChmdW5jdGlvbigpIHsgJHtjb21tYW5kfSB9KSgp OwotICAgICAgICAgICAgdWlDb250cm9sbGVyLnVpU2NyaXB0Q29tcGxldGUoKTsKLSAgICAgICAg fSkoKTtgLCByZXNvbHZlKSk7CisgICAgICAgIGxldCBzY3JpcHQgPSBgdWlDb250cm9sbGVyLiR7 Y29tbWFuZH0oJHthcmdzfSwgKCkgPT4gdWlDb250cm9sbGVyLnVpU2NyaXB0Q29tcGxldGUoKSk7 YDsKKyAgICAgICAgY29uc29sZS5sb2coc2NyaXB0KTsKKyAgICAgICAgcmV0dXJuIG5ldyBQcm9t aXNlKHJlc29sdmUgPT4gdGVzdFJ1bm5lci5ydW5VSVNjcmlwdChzY3JpcHQsIHJlc29sdmUpKTsK ICAgICB9CiAKIH0pKCk7Cg==