209025 2020-03-12 16:12:46 -0700 REGRESSION (r257739): [ iOS ] fast/events/autoscroll-in-iframe.html is still flaky failing 2022-02-12 22:12:35 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=208520 InRadar P2 Normal --- 1 jacob_uphoff webkit-unassigned andresg_22 bfulgham cfleizach webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1629402 0 jacob_uphoff 2020-03-12 16:12:46 -0700 fast/events/autoscroll-in-iframe.html This test has been flaky failing for all of iOS since around r257740 Started off failing more consistently but now is failing more flakily. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fevents%2Fautoscroll-in-iframe.html&platform=ios Diff: --- /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-results/fast/events/autoscroll-in-iframe-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-debug-tests-wk2/build/layout-test-results/fast/events/autoscroll-in-iframe-actual.txt @@ -1,3 +1,4 @@ +FAILED: Clicking in the iframe scrolled the page (window.scrollTops is 0) PASSED: selecting in the iframe did not scroll the page. 1629403 1 webkit-bug-importer 2020-03-12 16:13:10 -0700 <rdar://problem/60392238> 1629411 2 jacob_uphoff 2020-03-12 16:22:15 -0700 Set expectations here: https://trac.webkit.org/changeset/258370/webkit 1629634 3 ap 2020-03-13 09:18:20 -0700 There was an attempt to fix these in r208520, which improved the situation. But it's still failing around half of the time. 1629635 4 ap 2020-03-13 09:19:19 -0700 I meant to say, in bug 208520. 1629698 5 cfleizach 2020-03-13 10:49:35 -0700 (In reply to Alexey Proskuryakov from comment #4) > I meant to say, in bug 208520. if we really think r257740 is the cause of this, it's likely the reason is that accessibility is being enabled on iOS unexpectedly. that is what I'll look for 1629708 6 cfleizach 2020-03-13 11:05:48 -0700 (In reply to chris fleizach from comment #5) > (In reply to Alexey Proskuryakov from comment #4) > > I meant to say, in bug 208520. > > if we really think r257740 is the cause of this, it's likely the reason is > that accessibility is being enabled on iOS unexpectedly. that is what I'll > look for Must have been https://bugs.webkit.org/show_bug.cgi?id=208434 1629723 7 cfleizach 2020-03-13 11:24:28 -0700 So there was clearly something enabling accessibility previously. That was clearly fixed. Looking through original patch, this is the only thing that does something different. - return textMarkerRangeFromVisiblePositions(self.axBackingObject->axObjectCache(), startPosition, endPosition); + auto* backingObject = self.updateObjectBackingStore; + if (!backingObject) + return nil; + + return textMarkerRangeFromVisiblePositions(backingObject->axObjectCache(), startPosition, endPosition); by calling self.updateObjectBackingStore 1629776 8 andresg_22 2020-03-13 12:40:10 -0700 (In reply to chris fleizach from comment #7) > So there was clearly something enabling accessibility previously. That was > clearly fixed. Looking through original patch, this is the only thing that > does something different. > > - return > textMarkerRangeFromVisiblePositions(self.axBackingObject->axObjectCache(), > startPosition, endPosition); > + auto* backingObject = self.updateObjectBackingStore; > + if (!backingObject) > + return nil; > + > + return > textMarkerRangeFromVisiblePositions(backingObject->axObjectCache(), > startPosition, endPosition); > > by calling self.updateObjectBackingStore that was fix in patch for bug: https://bugs.webkit.org/show_bug.cgi?id=208648 so that cannot be the cause if this is still failing.