209019 2020-03-12 13:52:30 -0700 -Wredundant-move in CSSPropertyParserHelpers.cpp 2020-03-13 03:32:15 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson mcatanzaro menard webkit-bug-importer youennf oldest_to_newest 1629348 0 mcatanzaro 2020-03-12 13:52:30 -0700 In file included from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26, from /home/mcatanzaro/Projects/WebKit/Source/WebCore/config.h:56, from /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParser.cpp:30, from DerivedSources/WebCore/unified-sources/UnifiedSource-2f84417a-16.cpp:1: /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp: In function ‘WTF::RefPtr<WebCore::CSSValue> WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient(WebCore::CSSParserTokenRange&, WebCore::CSSParserMode, WebCore::CSSGradientRepeat)’: DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:495:58: warning: redundant move in return statement [-Wredundant-move] 495 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1176:12: note: in expansion of macro ‘WTFMove’ 1176 | return WTFMove(result); | ^~~~~~~ DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:495:58: note: remove ‘std::move’ call 495 | #define WTFMove(value) std::move<WTF::CheckMoveParameter>(value) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1176:12: note: in expansion of macro ‘WTFMove’ 1176 | return WTFMove(result); | ^~~~~~~ 1629349 1 393411 mcatanzaro 2020-03-12 13:54:27 -0700 Created attachment 393411 Patch 1629558 2 393411 commit-queue 2020-03-13 03:31:50 -0700 Comment on attachment 393411 Patch Clearing flags on attachment: 393411 Committed r258392: <https://trac.webkit.org/changeset/258392> 1629559 3 commit-queue 2020-03-13 03:31:52 -0700 All reviewed patches have been landed. Closing bug. 1629560 4 webkit-bug-importer 2020-03-13 03:32:15 -0700 <rdar://problem/60412242> 393411 2020-03-12 13:54:27 -0700 2020-03-13 03:31:50 -0700 Patch bug-209019-20200312155427.patch text/plain 1564 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY4YjQ3ZmRlMjM3YTUy YzM0MmI0M2JkZGI2ZTU2MmM4ZTZkZmZkOC4uNTY2ZjVhOWM3ZmYzYjVkNmVkYmFhODEyYzY3MGM2 ZmQzZDczNjMxMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTEyICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIC1XcmVkdW5k YW50LW1vdmUgaW4gQ1NTUHJvcGVydHlQYXJzZXJIZWxwZXJzLmNwcAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MDE5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2lsZW5jZSBjb21waWxlciB3YXJuaW5n IGJ5IHJlbW92aW5nIGltcHJvcGVyIFdURk1vdmUoKS4KKworICAgICAgICAqIGNzcy9wYXJzZXIv Q1NTUHJvcGVydHlQYXJzZXJIZWxwZXJzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1Byb3Bl cnR5UGFyc2VySGVscGVyczo6Y29uc3VtZURlcHJlY2F0ZWRSYWRpYWxHcmFkaWVudCk6CisKIDIw MjAtMDMtMTIgIEFuZHJlcyBHb256YWxleiAgPGFuZHJlc2dfMjJAYXBwbGUuY29tPgogCiAgICAg ICAgIEF0dHJpYnV0ZXMgU2VsZWN0aW9uVGV4dE1hcmtlclJhbmdlIGFuZCBTdGFydC9FbmRUZXh0 TWFya2VyIG5lZWQgdG8gcnVuIG9uIHRoZSBtYWluIHRocmVhZC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXJIZWxwZXJzLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXJIZWxwZXJzLmNwcAppbmRleCBm YjA0MmM3ODM5YWNiZjU3ZTMwYjc5M2FjNWFmYWFmYTRjNGIwODc0Li44MWYxNWU0ZmU1Yzg4Njcy NTM5M2U3OGNmNTg2NDZjY2U5ODYyOTIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv cGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VySGVscGVycy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv Y3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlckhlbHBlcnMuY3BwCkBAIC0xMTczLDcgKzExNzMs NyBAQCBzdGF0aWMgUmVmUHRyPENTU1ZhbHVlPiBjb25zdW1lRGVwcmVjYXRlZFJhZGlhbEdyYWRp ZW50KENTU1BhcnNlclRva2VuUmFuZ2UmIGFyZwogICAgIHJlc3VsdC0+c2V0U2hhcGUoV1RGTW92 ZShzaGFwZSkpOwogICAgIHJlc3VsdC0+c2V0U2l6aW5nQmVoYXZpb3IoV1RGTW92ZShzaXplS2V5 d29yZCkpOwogCi0gICAgcmV0dXJuIFdURk1vdmUocmVzdWx0KTsKKyAgICByZXR1cm4gcmVzdWx0 OwogfQogCiBzdGF0aWMgUmVmUHRyPENTU1ZhbHVlPiBjb25zdW1lUmFkaWFsR3JhZGllbnQoQ1NT UGFyc2VyVG9rZW5SYW5nZSYgYXJncywgQ1NTUGFyc2VyTW9kZSBjc3NQYXJzZXJNb2RlLCBDU1NH cmFkaWVudFJlcGVhdCByZXBlYXRpbmcpCg==