<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>209017</bug_id>
          
          <creation_ts>2020-03-12 13:48:55 -0700</creation_ts>
          <short_desc>pep8.py:110: FutureWarning: Possible nested set at position 1</short_desc>
          <delta_ts>2020-07-19 06:54:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>214531</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>jbedard</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1629344</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-12 13:48:55 -0700</bug_when>
    <thetext>This warning occurs when running webkit-patch with python 3.7.6:

$ webkit-patch upload --request-commit
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/pep8.py:110: FutureWarning: Possible nested set at position 1
  EXTRANEOUS_WHITESPACE_REGEX = re.compile(r&apos;[[({] | []}),;:]&apos;)

I think we need to update our autoinstalled modules to replace pep8 with its replacement, pycodestyle.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629350</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-03-12 13:54:59 -0700</bug_when>
    <thetext>Hm, sometimes I also see:

/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:3599: FutureWarning: Possible nested set at position 101
  check_identifier_name_in_declaration(filename, line_number, line, file_state, error)
/home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/style/checkers/cpp.py:3599: FutureWarning: Possible nested set at position 73
  check_identifier_name_in_declaration(filename, line_number, line, file_state, error)

These are in our own code, though.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1629598</commentid>
    <comment_count>2</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2020-03-13 07:37:16 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #0)
&gt; This warning occurs when running webkit-patch with python 3.7.6:
&gt; 
&gt; $ webkit-patch upload --request-commit
&gt; /home/mcatanzaro/Projects/WebKit/Tools/Scripts/webkitpy/thirdparty/
&gt; autoinstalled/pep8.py:110: FutureWarning: Possible nested set at position 1
&gt;   EXTRANEOUS_WHITESPACE_REGEX = re.compile(r&apos;[[({] | []}),;:]&apos;)
&gt; 
&gt; I think we need to update our autoinstalled modules to replace pep8 with its
&gt; replacement, pycodestyle.

Does pycodestyle work with Python 2.7?

Our automation is still primarily Python 2.7. Although all scripts should be Python 3 compliant now, we still aren&apos;t running things that way in most places.

I think our oldest supported OS is now Mojave, so we probably aren&apos;t far from a post-Python 2 world in WebKit, but I haven&apos;t had any conversations about that it the last few weeks.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1672882</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2020-07-19 06:54:43 -0700</bug_when>
    <thetext>(In reply to Jonathan Bedard from comment #2)
&gt; Does pycodestyle work with Python 2.7?

Apparently so.

*** This bug has been marked as a duplicate of bug 214531 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>