209015 2020-03-12 13:20:50 -0700 [ANGLE] Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: implicitly-declared ‘egl::AttributeMap& egl::AttributeMap::operator=(const egl::AttributeMap&)’ is deprecated [-Wdeprecated-copy] 2020-03-16 19:17:57 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro annulen commit-queue darin dino ews-watchlist graouts gyuyoung.kim jdarpinian justin_fan kbr kondapallykalyan mcatanzaro ryuan.choi sergio webkit-bug-importer oldest_to_newest 1629330 0 mcatanzaro 2020-03-12 13:20:50 -0700 [398/1919] Building CXX object Source/...r/src/libANGLE/FrameCapture_mock.cpp.o In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/entry_points_utils.h:17, from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture.h:16, from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp:10: /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Display.h: In member function ‘void egl::Display::setAttributes(const egl::AttributeMap&)’: /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Display.h:221:73: warning: implicitly-declared ‘egl::AttributeMap& egl::AttributeMap::operator=(const egl::AttributeMap&)’ is deprecated [-Wdeprecated-copy] 221 | void setAttributes(const AttributeMap &attribMap) { mAttributeMap = attribMap; } | ^~~~~~~~~ In file included from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Debug.h:15, from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/State.h:18, from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/Context.h:52, from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture.h:14, from /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/FrameCapture_mock.cpp:10: /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/libANGLE/AttributeMap.h:24:5: note: because ‘egl::AttributeMap’ has user-provided ‘egl::AttributeMap::AttributeMap(const egl::AttributeMap&)’ 24 | AttributeMap(const AttributeMap &other); | ^~~~~~~~~~~~ 1629342 1 393410 mcatanzaro 2020-03-12 13:47:05 -0700 Created attachment 393410 Patch 1629343 2 ews-watchlist 2020-03-12 13:47:54 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1630238 3 393410 commit-queue 2020-03-15 18:41:19 -0700 Comment on attachment 393410 Patch Clearing flags on attachment: 393410 Committed r258483: <https://trac.webkit.org/changeset/258483> 1630239 4 commit-queue 2020-03-15 18:41:21 -0700 All reviewed patches have been landed. Closing bug. 1630240 5 webkit-bug-importer 2020-03-15 18:42:18 -0700 <rdar://problem/60478335> 1630241 6 393410 annulen 2020-03-15 19:00:53 -0700 Comment on attachment 393410 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393410&action=review > Source/ThirdParty/ANGLE/ChangeLog:10 > + using. That's fine, but I guess it would be a good idea to CC ANGLE folks 1630604 7 kbr 2020-03-16 19:17:57 -0700 Thanks for the CC. Filed this against the ANGLE project as https://bugs.chromium.org/p/angleproject/issues/detail?id=4486 . 393410 2020-03-12 13:47:05 -0700 2020-03-15 18:41:19 -0700 Patch bug-209015-20200312154704.patch text/plain 1630 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMDI2OWYwMGExOTZjYjUxMmFhYmRiZDA3NDNjM2Q0MzRhMmRmYjVmMC4uY2RiNWQzYWFiMWUx NjdmZGEyOWZiNDZmYzQ2YWE4YTFmN2IwNTAzOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTEyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtBTkdMRV0gU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2xpYkFOR0xFL0Rpc3BsYXkuaDoyMjE6NzM6IHdhcm5pbmc6IGltcGxpY2l0bHktZGVj bGFyZWQg4oCYZWdsOjpBdHRyaWJ1dGVNYXAmIGVnbDo6QXR0cmlidXRlTWFwOjpvcGVyYXRvcj0o Y29uc3QgZWdsOjpBdHRyaWJ1dGVNYXAmKeKAmSBpcyBkZXByZWNhdGVkIFstV2RlcHJlY2F0ZWQt Y29weV0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw OTAxNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFN1 cHByZXNzIGNvbXBpbGVyIHdhcm5pbmcuIElmIHRoaXMgd2VyZSBXZWJLaXQgY29kZSwgSSBtaWdo dCB0YWtlIHRoZSB0aW1lIHRvIGZpeCBpdCwgYnV0CisgICAgICAgIHdpdGggdGhpcmQtcGFydHkg Y29kZSBpdCdzIHByb2JhYmx5IGJlc3QgdG8ganVzdCB0dXJuIG9mZiB3YXJuaW5ncyB0aGF0IHVw c3RyZWFtIGlzIG5vdAorICAgICAgICB1c2luZy4KKworICAgICAgICAqIENNYWtlTGlzdHMudHh0 OgorCiAyMDIwLTAzLTAyICBBbGFuIENvb24gIDxhbGFuY29vbkBhcHBsZS5jb20+CiAKICAgICAg ICAgQWRkIG5ldyBNYWMgdGFyZ2V0IG51bWJlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBh cnR5L0FOR0xFL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvQ01ha2VM aXN0cy50eHQKaW5kZXggODFmMjdkOWRjMDdjZTFhMzdkYjBmODJiMmVmOGE3MzM2OGU0YTJmZS4u OTdkOWYwM2IyNjE1ZTEyNzg4YzhjN2MxNGVkY2ZjNTQzODg2ZjdhZCAxMDA2NDQKLS0tIGEvU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ01ha2VMaXN0cy50eHQKQEAgLTE2Niw2ICsxNjYsNyBAQCBlbmRpZiAoKQogCiBp ZiAoQ09NUElMRVJfSVNfR0NDX09SX0NMQU5HKQogICAgIFdFQktJVF9BRERfVEFSR0VUX0NYWF9G TEFHUyhBTkdMRSAtV25vLWNhc3QtYWxpZ24KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgLVduby1kZXByZWNhdGVkLWNvcHkKICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgLVduby1zdWdnZXN0LWF0dHJpYnV0ZT1mb3JtYXQKICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgLVduby10eXBlLWxpbWl0cwogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAtV25vLXVuZGVmCg==