209014 2020-03-12 13:18:13 -0700 [ANGLE] Source/ThirdParty/ANGLE/src/common/utilities.cpp:10: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] 2020-03-15 19:09:17 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro commit-queue darin dino ews-watchlist graouts kondapallykalyan mcatanzaro webkit-bug-importer oldest_to_newest 1629329 0 mcatanzaro 2020-03-12 13:18:13 -0700 ANGLE is using #pragma clang diagnostic outside of clang guards: [214/1919] Building CXX object Source/...s/ANGLE.dir/src/common/utilities.cpp.o /home/mcatanzaro/Projects/WebKit/Source/ThirdParty/ANGLE/src/common/utilities.cpp:10: warning: ignoring #pragma clang diagnostic [-Wunknown-pragmas] 10 | #pragma clang diagnostic ignored "-Wglobal-constructors" | All uses need to be guarded properly. GCC will warn whenever it sees another compiler's pragma. 1629336 1 mcatanzaro 2020-03-12 13:33:10 -0700 It's a downstream WebKit problem, added in our changes.diff: diff --git a/src/common/utilities.cpp b/src/common/utilities.cpp index 87932a53f..83ea168e2 100644 --- a/src/common/utilities.cpp +++ b/src/common/utilities.cpp @@ -6,6 +6,9 @@ // utilities.cpp: Conversion functions and other utility routines. +// Older clang versions have a false positive on this warning here. +#pragma clang diagnostic ignored "-Wglobal-constructors" + #include "common/utilities.h" #include <GLSLANG/ShaderVars.h> #include "GLES3/gl3.h" 1629337 2 393408 mcatanzaro 2020-03-12 13:40:04 -0700 Created attachment 393408 Patch 1629338 3 ews-watchlist 2020-03-12 13:41:10 -0700 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1630242 4 393408 commit-queue 2020-03-15 19:08:24 -0700 Comment on attachment 393408 Patch Clearing flags on attachment: 393408 Committed r258484: <https://trac.webkit.org/changeset/258484> 1630243 5 commit-queue 2020-03-15 19:08:25 -0700 All reviewed patches have been landed. Closing bug. 1630244 6 webkit-bug-importer 2020-03-15 19:09:17 -0700 <rdar://problem/60478777> 393408 2020-03-12 13:40:04 -0700 2020-03-15 19:08:24 -0700 Patch bug-209014-20200312154003.patch text/plain 2200 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MzUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMDI2OWYwMGExOTZjYjUxMmFhYmRiZDA3NDNjM2Q0MzRhMmRmYjVmMC4uNGI0MmE1MWJlY2Fh NzdmZjY1ODI5NTYyY2U5Y2QzM2EwY2ZkMjA0YSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTEyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtBTkdMRV0gU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2NvbW1vbi91dGlsaXRpZXMuY3BwOjEwOiB3YXJuaW5nOiBpZ25vcmluZyAjcHJhZ21h IGNsYW5nIGRpYWdub3N0aWMgWy1XdW5rbm93bi1wcmFnbWFzXQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA5MDE0CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2lsZW5jZSBjb21waWxlciB3YXJuaW5nLgor CisgICAgICAgICogY2hhbmdlcy5kaWZmOgorICAgICAgICAqIHNyYy9jb21tb24vdXRpbGl0aWVz LmNwcDoKKwogMjAyMC0wMy0wMiAgQWxhbiBDb29uICA8YWxhbmNvb25AYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZCBuZXcgTWFjIHRhcmdldCBudW1iZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9jaGFuZ2VzLmRpZmYgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9jaGFu Z2VzLmRpZmYKaW5kZXggOTY1NWY3NTIxNDc2OWE3NWM1Zjg3YjFhNWU4NzQ5NzVkNzJhYWVlNy4u YmUzNjIxOWVjMGY4ZGE0ZjExYzM3MTYzNzBjY2I1ODg2NmUzNDQwZSAxMDA2NDQKLS0tIGEvU291 cmNlL1RoaXJkUGFydHkvQU5HTEUvY2hhbmdlcy5kaWZmCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5 L0FOR0xFL2NoYW5nZXMuZGlmZgpAQCAtMiwxMiArMiwxNCBAQCBkaWZmIC0tZ2l0IGEvc3JjL2Nv bW1vbi91dGlsaXRpZXMuY3BwIGIvc3JjL2NvbW1vbi91dGlsaXRpZXMuY3BwCiBpbmRleCA4Nzkz MmE1M2YuLjgzZWExNjhlMiAxMDA2NDQKIC0tLSBhL3NyYy9jb21tb24vdXRpbGl0aWVzLmNwcAog KysrIGIvc3JjL2NvbW1vbi91dGlsaXRpZXMuY3BwCi1AQCAtNiw2ICs2LDkgQEAKK0BAIC02LDYg KzYsMTEgQEAKICAKICAvLyB1dGlsaXRpZXMuY3BwOiBDb252ZXJzaW9uIGZ1bmN0aW9ucyBhbmQg b3RoZXIgdXRpbGl0eSByb3V0aW5lcy4KICAKICsvLyBPbGRlciBjbGFuZyB2ZXJzaW9ucyBoYXZl IGEgZmFsc2UgcG9zaXRpdmUgb24gdGhpcyB3YXJuaW5nIGhlcmUuCisrI2lmIGRlZmluZWQoX19j bGFuZ19fKQogKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBpZ25vcmVkICItV2dsb2JhbC1jb25z dHJ1Y3RvcnMiCisrI2VuZGlmCiArCiAgI2luY2x1ZGUgImNvbW1vbi91dGlsaXRpZXMuaCIKICAj aW5jbHVkZSA8R0xTTEFORy9TaGFkZXJWYXJzLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvY29tbW9uL3V0aWxpdGllcy5jcHAgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9zcmMvY29tbW9uL3V0aWxpdGllcy5jcHAKaW5kZXggODNlYTE2OGUyY2I2OTllZThlMmY3 NjA2NDlhMGJmMDA1OWMxYzE0NC4uNTAwMzE4NmIxMmEzZjkyYTNkNGFmY2UwZjNlOWU4MjdhNmRj NDA4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2NvbW1vbi91dGls aXRpZXMuY3BwCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9jb21tb24vdXRpbGl0 aWVzLmNwcApAQCAtNyw3ICs3LDkgQEAKIC8vIHV0aWxpdGllcy5jcHA6IENvbnZlcnNpb24gZnVu Y3Rpb25zIGFuZCBvdGhlciB1dGlsaXR5IHJvdXRpbmVzLgogCiAvLyBPbGRlciBjbGFuZyB2ZXJz aW9ucyBoYXZlIGEgZmFsc2UgcG9zaXRpdmUgb24gdGhpcyB3YXJuaW5nIGhlcmUuCisjaWYgZGVm aW5lZChfX2NsYW5nX18pCiAjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgaWdub3JlZCAiLVdnbG9i YWwtY29uc3RydWN0b3JzIgorI2VuZGlmCiAKICNpbmNsdWRlICJjb21tb24vdXRpbGl0aWVzLmgi CiAjaW5jbHVkZSA8R0xTTEFORy9TaGFkZXJWYXJzLmg+Cg==