208996 2020-03-12 07:53:55 -0700 Attributes SelectionTextMarkerRange and Start/EndTextMarker need to run on the main thread. 2020-03-12 13:26:58 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach commit-queue darin dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1629181 0 andresg_22 2020-03-12 07:53:55 -0700 Attributes SelectionTextMarkerRange and Start/EndTextMarker need to run on the main thread. 1629183 1 393376 andresg_22 2020-03-12 07:56:57 -0700 Created attachment 393376 Patch 1629294 2 393376 commit-queue 2020-03-12 12:07:00 -0700 Comment on attachment 393376 Patch Clearing flags on attachment: 393376 Committed r258349: <https://trac.webkit.org/changeset/258349> 1629295 3 commit-queue 2020-03-12 12:07:01 -0700 All reviewed patches have been landed. Closing bug. 1629296 4 webkit-bug-importer 2020-03-12 12:07:17 -0700 <rdar://problem/60381174> 1629304 5 393376 darin 2020-03-12 12:28:13 -0700 Comment on attachment 393376 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393376&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2830 > + return Accessibility::retrieveAutoreleasedValueFromMainThread<id>([protectedSelf = RetainPtr<WebAccessibilityObjectWrapper>(self)] () -> RetainPtr<id> { Maybe we can write this more elegantly using the retainPtr helper function? [protectedSelf = retainPtr(self)] 1629333 6 andresg_22 2020-03-12 13:26:58 -0700 (In reply to Darin Adler from comment #5) > Comment on attachment 393376 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393376&action=review > > > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2830 > > + return Accessibility::retrieveAutoreleasedValueFromMainThread<id>([protectedSelf = RetainPtr<WebAccessibilityObjectWrapper>(self)] () -> RetainPtr<id> { > > Maybe we can write this more elegantly using the retainPtr helper function? > > [protectedSelf = retainPtr(self)] Agree, I'll make a separate change with a sweep through all the instances of this construct. Thanks. 393376 2020-03-12 07:56:57 -0700 2020-03-12 12:07:00 -0700 Patch bug-208996-20200312105656.patch text/plain 3381 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZlOTdlZDNhNmVmODE0 MzkyNzBiNjVmMzBiNGNjODEzYmQzZGJjYi4uNDdmOGM4ZTFlOWU1YzllYjA5ZDRjMDA5NjA0Yjk0 ZjM2YzFjZTRmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAzLTEyICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBdHRyaWJ1dGVz IFNlbGVjdGlvblRleHRNYXJrZXJSYW5nZSBhbmQgU3RhcnQvRW5kVGV4dE1hcmtlciBuZWVkIHRv IHJ1biBvbiB0aGUgbWFpbiB0aHJlYWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDg5OTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgIERp c3BhdGNoIHRvIHRoZSBtYWluIHRocmVhZCB0aGUgY29tcHV0YXRpb24gb2YgdGhlc2UgYWNjZXNz aWJpbGl0eSBhdHRyaWJ1dGVzLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNj ZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW06CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVyIGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTpdKToKKwogMjAyMC0w My0xMiAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgQWNjdXJh dGUgc3R5bGUgaW52YWxpZGF0aW9uIGZvciB1c2VyIGFjdGlvbiBwc2V1ZG8gY2xhc3NlcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0 eU9iamVjdFdyYXBwZXJNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQppbmRleCA5MDAxN2FkOTk0OTdiOTU3 ZGFkMmU5Y2FjMmE5MjNlN2E4YzdlYjEyLi5jNmZlMzZiMzEzM2RmZDU0ODRmYzE0MmNiZDg0Y2Y4 ZjRlODhjNjVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L21hYy9X ZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L21hYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlck1hYy5tbQpAQCAt MjgyNiwxMyArMjgyNiwyNyBAQCBBTExPV19ERVBSRUNBVEVEX0lNUExFTUVOVEFUSU9OU19FTkQK ICAgICBpZiAoYmFja2luZ09iamVjdC0+aXNMaXN0KCkgJiYgW2F0dHJpYnV0ZU5hbWUgaXNFcXVh bFRvU3RyaW5nOk5TQWNjZXNzaWJpbGl0eU9yaWVudGF0aW9uQXR0cmlidXRlXSkKICAgICAgICAg cmV0dXJuIE5TQWNjZXNzaWJpbGl0eVZlcnRpY2FsT3JpZW50YXRpb25WYWx1ZTsKIAotICAgIGlm IChbYXR0cmlidXRlTmFtZSBpc0VxdWFsVG9TdHJpbmc6IEAiQVhTZWxlY3RlZFRleHRNYXJrZXJS YW5nZSJdKQotICAgICAgICByZXR1cm4gW3NlbGYgdGV4dE1hcmtlclJhbmdlRm9yU2VsZWN0aW9u XTsKKyAgICBpZiAoW2F0dHJpYnV0ZU5hbWUgaXNFcXVhbFRvU3RyaW5nOkAiQVhTZWxlY3RlZFRl eHRNYXJrZXJSYW5nZSJdKSB7CisgICAgICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5OjpyZXRyaWV2 ZUF1dG9yZWxlYXNlZFZhbHVlRnJvbU1haW5UaHJlYWQ8aWQ+KFtwcm90ZWN0ZWRTZWxmID0gUmV0 YWluUHRyPFdlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyPihzZWxmKV0gKCkgLT4gUmV0YWlu UHRyPGlkPiB7CisgICAgICAgICAgICByZXR1cm4gW3Byb3RlY3RlZFNlbGYgdGV4dE1hcmtlclJh bmdlRm9yU2VsZWN0aW9uXTsKKyAgICAgICAgfSk7CisgICAgfQorCisgICAgaWYgKFthdHRyaWJ1 dGVOYW1lIGlzRXF1YWxUb1N0cmluZzpAIkFYU3RhcnRUZXh0TWFya2VyIl0pIHsKKyAgICAgICAg cmV0dXJuIEFjY2Vzc2liaWxpdHk6OnJldHJpZXZlQXV0b3JlbGVhc2VkVmFsdWVGcm9tTWFpblRo cmVhZDxpZD4oW3Byb3RlY3RlZFNlbGYgPSBSZXRhaW5QdHI8V2ViQWNjZXNzaWJpbGl0eU9iamVj dFdyYXBwZXI+KHNlbGYpXSAoKSAtPiBSZXRhaW5QdHI8aWQ+IHsKKyAgICAgICAgICAgIGlmIChh dXRvKiBiYWNraW5nT2JqZWN0ID0gcHJvdGVjdGVkU2VsZi5nZXQoKS5heEJhY2tpbmdPYmplY3Qp CisgICAgICAgICAgICAgICAgcmV0dXJuIFtwcm90ZWN0ZWRTZWxmIHRleHRNYXJrZXJGb3JWaXNp YmxlUG9zaXRpb246c3RhcnRPZkRvY3VtZW50KGJhY2tpbmdPYmplY3QtPmRvY3VtZW50KCkpXTsK KyAgICAgICAgICAgIHJldHVybiBuaWw7CisgICAgICAgIH0pOworICAgIH0KIAotICAgIGlmIChb YXR0cmlidXRlTmFtZSBpc0VxdWFsVG9TdHJpbmc6IEAiQVhTdGFydFRleHRNYXJrZXIiXSkKLSAg ICAgICAgcmV0dXJuIFtzZWxmIHRleHRNYXJrZXJGb3JWaXNpYmxlUG9zaXRpb246c3RhcnRPZkRv Y3VtZW50KGJhY2tpbmdPYmplY3QtPmRvY3VtZW50KCkpXTsKLSAgICBpZiAoW2F0dHJpYnV0ZU5h bWUgaXNFcXVhbFRvU3RyaW5nOiBAIkFYRW5kVGV4dE1hcmtlciJdKQotICAgICAgICByZXR1cm4g W3NlbGYgdGV4dE1hcmtlckZvclZpc2libGVQb3NpdGlvbjplbmRPZkRvY3VtZW50KGJhY2tpbmdP YmplY3QtPmRvY3VtZW50KCkpXTsKKyAgICBpZiAoW2F0dHJpYnV0ZU5hbWUgaXNFcXVhbFRvU3Ry aW5nOkAiQVhFbmRUZXh0TWFya2VyIl0pIHsKKyAgICAgICAgcmV0dXJuIEFjY2Vzc2liaWxpdHk6 OnJldHJpZXZlQXV0b3JlbGVhc2VkVmFsdWVGcm9tTWFpblRocmVhZDxpZD4oW3Byb3RlY3RlZFNl bGYgPSBSZXRhaW5QdHI8V2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXI+KHNlbGYpXSAoKSAt PiBSZXRhaW5QdHI8aWQ+IHsKKyAgICAgICAgICAgIGlmIChhdXRvKiBiYWNraW5nT2JqZWN0ID0g cHJvdGVjdGVkU2VsZi5nZXQoKS5heEJhY2tpbmdPYmplY3QpCisgICAgICAgICAgICAgICAgcmV0 dXJuIFtwcm90ZWN0ZWRTZWxmIHRleHRNYXJrZXJGb3JWaXNpYmxlUG9zaXRpb246ZW5kT2ZEb2N1 bWVudChiYWNraW5nT2JqZWN0LT5kb2N1bWVudCgpKV07CisgICAgICAgICAgICByZXR1cm4gbmls OworICAgICAgICB9KTsKKyAgICB9CiAKICAgICBpZiAoW2F0dHJpYnV0ZU5hbWUgaXNFcXVhbFRv U3RyaW5nOk5TQWNjZXNzaWJpbGl0eUJsb2NrUXVvdGVMZXZlbEF0dHJpYnV0ZV0pCiAgICAgICAg IHJldHVybiBbTlNOdW1iZXIgbnVtYmVyV2l0aFVuc2lnbmVkSW50OmJhY2tpbmdPYmplY3QtPmJs b2NrcXVvdGVMZXZlbCgpXTsK