208970 2020-03-11 19:38:05 -0700 [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc 2020-03-21 08:22:11 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro annulen bugs-noreply commit-queue ews-watchlist gyuyoung.kim lantw44 mcatanzaro ryuan.choi sergio oldest_to_newest 1628991 0 mcatanzaro 2020-03-11 19:38:05 -0700 Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than #!/usr/bin/env python. #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu probably has similar rules. Note this is the only script that attempts to use /usr/bin/python in tarball builds. Everything else that does so is probably only used by webkit-build. 1628992 1 393330 mcatanzaro 2020-03-11 19:40:33 -0700 Created attachment 393330 Patch 1629054 2 dbates 2020-03-11 22:21:47 -0700 https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes 1629056 3 393330 dbates 2020-03-11 22:32:16 -0700 Comment on attachment 393330 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393330&action=review This change looks good. > Tools/ChangeLog:10 > + Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than This is ok as-is. No change is needed. The optimal ChangeLog would move all the text in this line and later ABOVE the file name so as to be the description of the change because: 1. There is only one file changed in this patch so there's no need for per file comments. 2. Per file/function comments should be concise, no longer than a single paragraph. They are meant to provide more fine grain descriptions of the charges in the patch. > Tools/ChangeLog:13 > + #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu This is ok as-is. No change is needed. A slightly better description would reference the official documentation by URL, along with date accessed (if the URL doesn't look permanent - encode a date or version) and optionally include an excerpt from it if the URL does not look permanent. In other words, a slightly better description provides irrefutable proof why the change was made in a way that a third party in the future can verify the claim. 1629173 4 393372 mcatanzaro 2020-03-12 07:34:38 -0700 Created attachment 393372 Patch for landing 1629192 5 393372 commit-queue 2020-03-12 08:25:53 -0700 Comment on attachment 393372 Patch for landing Clearing flags on attachment: 393372 Committed r258328: <https://trac.webkit.org/changeset/258328> 1629193 6 commit-queue 2020-03-12 08:25:55 -0700 All reviewed patches have been landed. Closing bug. 1632466 7 lantw44 2020-03-21 06:18:02 -0700 This breaks build-webkit script on FreeBSD. I typed "./Tools/Scripts/build-webkit --gtk --cmakeargs='-DENABLE_GTKDOC=ON -DENABLE_MINIBROWSER=ON -DENABLE_TOOLS=ON -DUSE_SYSTEMD=OFF' --no-experimental-features" and it failed at generate-gtkdoc with "No such file or directory" because there is no /usr/bin/python3. (In reply to Michael Catanzaro from comment #0) > Fedora and Ubuntu are both patching generate-gtkdoc to use > #!/usr/bin/python3 rather than #!/usr/bin/env python. I think we can just use "#!/usr/bin/env python3" to avoid the dependency on the version-less python executable. > #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I > guess Ubuntu probably has similar rules. "#!/usr/bin/env" is only banned in packaged files. For the source code, I think it should be acceptable to rely on PATH to find executables used during the build. > Note this is the only script that attempts to use /usr/bin/python in tarball > builds. Everything else that does so is probably only used by webkit-build. 1632468 8 mcatanzaro 2020-03-21 06:44:12 -0700 (In reply to Ting-Wei Lan from comment #7) > "#!/usr/bin/env" is only banned in packaged files. For the source code, I > think it should be acceptable to rely on PATH to find executables used > during the build. You're right. Because the script is not installed, we are indeed allowed to use #!/usr/bin/env. 1632475 9 394167 mcatanzaro 2020-03-21 07:32:10 -0700 Created attachment 394167 Patch 1632479 10 ews-feeder 2020-03-21 08:22:10 -0700 Committed r258808: <https://trac.webkit.org/changeset/258808> All reviewed patches have been landed. Closing bug and clearing flags on attachment 394167. 393330 2020-03-11 19:40:33 -0700 2020-03-12 07:34:35 -0700 Patch bug-208970-20200311214032.patch text/plain 1453 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTNjODRkY2ZhOTRmY2U4NTkwMTgyNzBhZjViOTlhNWYz ZTZlNjI5OS4uMTQ5M2Y2NTMxM2UzYWMyODViMDhlODJiY2FjNDMxOGRkZmIwOWZmOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx IEBACisyMDIwLTAzLTExICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIFtHVEtdIFVzZSAjIS91c3IvYmluL3B5dGhvbjMgc2hlYmFuZyB0byBydW4g Z2VuZXJhdGUtZ3RrZG9jCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDg5NzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGd0a2RvYy9nZW5lcmF0ZS1ndGtkb2M6CisKKyAgICAgICAgRmVkb3JhIGFuZCBV YnVudHUgYXJlIGJvdGggcGF0Y2hpbmcgZ2VuZXJhdGUtZ3RrZG9jIHRvIHVzZSAjIS91c3IvYmlu L3B5dGhvbjMgcmF0aGVyIHRoYW4KKyAgICAgICAgIyEvdXNyL2Jpbi9lbnYgcHl0aG9uLgorCisg ICAgICAgICMhL3Vzci9iaW4vZW52IGFuZCAvdXNyL2Jpbi9weXRob24gYXJlIGJvdGggYmFubmVk IGluIEZlZG9yYSBwYWNrYWdlcy4gSSBndWVzcyBVYnVudHUKKyAgICAgICAgcHJvYmFibHkgaGFz IHNpbWlsYXIgcnVsZXMuCisKKyAgICAgICAgTm90ZSB0aGlzIGlzIHRoZSBvbmx5IHNjcmlwdCB0 aGF0IGF0dGVtcHRzIHRvIHVzZSAvdXNyL2Jpbi9weXRob24gaW4gdGFyYmFsbCBidWlsZHMuCisg ICAgICAgIEV2ZXJ5dGhpbmcgZWxzZSB0aGF0IGRvZXMgc28gaXMgcHJvYmFibHkgb25seSB1c2Vk IGJ5IHdlYmtpdC1idWlsZC4KKwogMjAyMC0wMy0xMSAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlu b0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFN3aXRjaCBFV1MgYXBpLWd0ayBib3QgZnJv bSBidWlsZEFuZFRlc3QgdG8gdGVzdE9ubHkKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0a2RvYy9nZW5l cmF0ZS1ndGtkb2MgYi9Ub29scy9ndGtkb2MvZ2VuZXJhdGUtZ3RrZG9jCmluZGV4IDdhMDZkNDk0 ZWM5ZGNjYTViY2NlYmFmMDA5ODVhNDJjYmFmOTdkMjQuLmEzOGEwMmZhZDRjMjdmODczMWNhOTg2 NjE1NjRhZDhhMTgyOTFkMDEgMTAwNzU1Ci0tLSBhL1Rvb2xzL2d0a2RvYy9nZW5lcmF0ZS1ndGtk b2MKKysrIGIvVG9vbHMvZ3RrZG9jL2dlbmVyYXRlLWd0a2RvYwpAQCAtMSw0ICsxLDQgQEAKLSMh L3Vzci9iaW4vZW52IHB5dGhvbgorIyEvdXNyL2Jpbi9weXRob24zCiAjIENvcHlyaWdodCAoQykg MjAxMSBJZ2FsaWEgUy5MLgogIwogIyBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0d2FyZTsgeW91 IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCg== 393372 2020-03-12 07:34:38 -0700 2020-03-21 07:32:08 -0700 Patch for landing bug-208970-20200312093437.patch text/plain 1554 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjcxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTNjODRkY2ZhOTRmY2U4NTkwMTgyNzBhZjViOTlhNWYz ZTZlNjI5OS4uYjFhZDJhYTAyNDJlMWE4NTMxZDdlZTFmZGU5MmQwMzQyNWJmMTE2NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIwLTAzLTExICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3Jn PgorCisgICAgICAgIFtHVEtdIFVzZSAjIS91c3IvYmluL3B5dGhvbjMgc2hlYmFuZyB0byBydW4g Z2VuZXJhdGUtZ3RrZG9jCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDg5NzAKKworICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwgQmF0ZXMuCisKKyAg ICAgICAgRmVkb3JhIGFuZCBVYnVudHUgYXJlIGJvdGggcGF0Y2hpbmcgZ2VuZXJhdGUtZ3RrZG9j IHRvIHVzZSAjIS91c3IvYmluL3B5dGhvbjMgcmF0aGVyIHRoYW4KKyAgICAgICAgIyEvdXNyL2Jp bi9lbnYgcHl0aG9uLgorCisgICAgICAgICMhL3Vzci9iaW4vZW52IGFuZCAvdXNyL2Jpbi9weXRo b24gYXJlIGJvdGggYmFubmVkIGluIEZlZG9yYSBwYWNrYWdlcy4gSSBndWVzcyBVYnVudHUKKyAg ICAgICAgcHJvYmFibHkgaGFzIHNpbWlsYXIgcnVsZXMuCisKKyAgICAgICAgTm90ZSB0aGlzIGlz IHRoZSBvbmx5IHNjcmlwdCB0aGF0IGF0dGVtcHRzIHRvIHVzZSAvdXNyL2Jpbi9weXRob24gaW4g dGFyYmFsbCBidWlsZHMuCisgICAgICAgIEV2ZXJ5dGhpbmcgZWxzZSB0aGF0IGRvZXMgc28gaXMg cHJvYmFibHkgb25seSB1c2VkIGJ5IHdlYmtpdC1idWlsZC4KKworICAgICAgICBodHRwczovL2Rv Y3MuZmVkb3JhcHJvamVjdC5vcmcvZW4tVVMvcGFja2FnaW5nLWd1aWRlbGluZXMvUHl0aG9uLyNf bXVsdGlwbGVfcHl0aG9uX3J1bnRpbWVzCisKKyAgICAgICAgKiBndGtkb2MvZ2VuZXJhdGUtZ3Rr ZG9jOgorCiAyMDIwLTAzLTExICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gU3dpdGNoIEVXUyBhcGktZ3RrIGJvdCBmcm9tIGJ1aWxkQW5kVGVz dCB0byB0ZXN0T25seQpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrZG9jL2dlbmVyYXRlLWd0a2RvYyBi L1Rvb2xzL2d0a2RvYy9nZW5lcmF0ZS1ndGtkb2MKaW5kZXggN2EwNmQ0OTRlYzlkY2NhNWJjY2Vi YWYwMDk4NWE0MmNiYWY5N2QyNC4uYTM4YTAyZmFkNGMyN2Y4NzMxY2E5ODY2MTU2NGFkOGExODI5 MWQwMSAxMDA3NTUKLS0tIGEvVG9vbHMvZ3RrZG9jL2dlbmVyYXRlLWd0a2RvYworKysgYi9Ub29s cy9ndGtkb2MvZ2VuZXJhdGUtZ3RrZG9jCkBAIC0xLDQgKzEsNCBAQAotIyEvdXNyL2Jpbi9lbnYg cHl0aG9uCisjIS91c3IvYmluL3B5dGhvbjMKICMgQ29weXJpZ2h0IChDKSAyMDExIElnYWxpYSBT LkwuCiAjCiAjIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJp YnV0ZSBpdCBhbmQvb3IK 394167 2020-03-21 07:32:10 -0700 2020-03-21 08:22:10 -0700 Patch bug-208970-20200321093209.patch text/plain 2940 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4Nzk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvR3Rr RG9jLmNtYWtlIGIvU291cmNlL2NtYWtlL0d0a0RvYy5jbWFrZQppbmRleCBiMGZiMzFjYWZhOGFh NmY1ZTI0ZThlMTIzYzQxMzE3MGRiYTI1NDA1Li4xOGU4NjQ0ODlmNjg4YTQwMDQ4NDEyZDUwOTFm MDRiOTA0MmRkYWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvR3RrRG9jLmNtYWtlCisrKyBi L1NvdXJjZS9jbWFrZS9HdGtEb2MuY21ha2UKQEAgLTQsNyArNCw3IEBAIG1hY3JvKEFERF9HVEtE T0NfR0VORVJBVE9SIF9zdGFtcF9uYW1lIF9leHRyYV9hcmdzKQogICAgIGFkZF9jdXN0b21fY29t bWFuZCgKICAgICAgICAgT1VUUFVUICIke0NNQUtFX0JJTkFSWV9ESVJ9LyR7X3N0YW1wX25hbWV9 IgogICAgICAgICBERVBFTkRTICR7RG9jdW1lbnRhdGlvbkRlcGVuZGVuY2llc30KLSAgICAgICAg Q09NTUFORCAke0NNQUtFX0NPTU1BTkR9IC1FIGVudiAiQ0M9JHtDTUFLRV9DX0NPTVBJTEVSfSIg IkNGTEFHUz0ke0NNQUtFX0NfRkxBR1N9IC1Xbm8tdW51c2VkLXBhcmFtZXRlciIgIkxERkxBR1M9 JHtDTUFLRV9FWEVfTElOS0VSX0ZMQUdTfSIgJHtDTUFLRV9TT1VSQ0VfRElSfS9Ub29scy9ndGtk b2MvZ2VuZXJhdGUtZ3RrZG9jICR7X2V4dHJhX2FyZ3N9CisgICAgICAgIENPTU1BTkQgJHtDTUFL RV9DT01NQU5EfSAtRSBlbnYgIkNDPSR7Q01BS0VfQ19DT01QSUxFUn0iICJDRkxBR1M9JHtDTUFL RV9DX0ZMQUdTfSAtV25vLXVudXNlZC1wYXJhbWV0ZXIiICJMREZMQUdTPSR7Q01BS0VfRVhFX0xJ TktFUl9GTEFHU30iICR7UFlUSE9OX0VYRUNVVEFCTEV9ICR7Q01BS0VfU09VUkNFX0RJUn0vVG9v bHMvZ3RrZG9jL2dlbmVyYXRlLWd0a2RvYyAke19leHRyYV9hcmdzfQogICAgICAgICBDT01NQU5E IHRvdWNoICR7X3N0YW1wX25hbWV9CiAgICAgICAgIFdPUktJTkdfRElSRUNUT1JZICIke0NNQUtF X0JJTkFSWV9ESVJ9IgogICAgICAgICBWRVJCQVRJTQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGM0ZjhlZGE3NzlkZWU1YTMyNmI4OTE1ZDk3OGY1 ODVhMTAwOWQ3MGYuLmRlMGJjMjhhNGEwNjZkNGVhOTM5OTBkOWI1Mjg5ZDI0YmI4ZjNiYWIgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNiBAQAorMjAyMC0wMy0yMSAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdub21l Lm9yZz4KKworICAgICAgICBbR1RLXSBVc2UgJHtQWVRIT05fRVhFQ1VUQUJMRX0gdG8gcnVuIGdl bmVyYXRlLWd0a2RvYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjA4OTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgV2UgYXJlIGFsbG93ZWQgdG8gdXNlIC91c3IvYmluL2VudiBpbiB0aGlzIHNjcmlwdCBi ZWNhdXNlIGl0J3Mgbm90IGluc3RhbGxlZCAoc28gbm90CisgICAgICAgIHBhY2thZ2VkKS4gVGhl cmVmb3JlIHdlIGNhbiBtYWtlIHRoZSBzaGViYW5nIGNvbXBhdGlibGUgd2l0aCBGcmVlQlNEIGlu IHRoaXMgcGFydGljdWxhcmwKKyAgICAgICAgY2FzZS4KKworICAgICAgICAqIGd0a2RvYy9nZW5l cmF0ZS1ndGtkb2M6CisKIDIwMjAtMDMtMjAgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBw bGUuY29tPgogCiAgICAgICAgIGNvbW1pdC1xdWV1ZSBzaG91bGQgc2tpcCBidWlsZGluZyBhbmQg dGVzdGluZyBpZiBwYXRjaCBhbHJlYWR5IHBhc3NlZCB0ZXN0cyBvbiBtYWMtd2syIHF1ZXVlCmRp ZmYgLS1naXQgYS9Ub29scy9ndGtkb2MvZ2VuZXJhdGUtZ3RrZG9jIGIvVG9vbHMvZ3RrZG9jL2dl bmVyYXRlLWd0a2RvYwppbmRleCBhMzhhMDJmYWQ0YzI3Zjg3MzFjYTk4NjYxNTY0YWQ4YTE4Mjkx ZDAxLi5lZmM3NGQyYTkyNjdhYTI0YTVkNWFiYTRhYmI1YjJlZjNhYzIyY2M3IDEwMDc1NQotLS0g YS9Ub29scy9ndGtkb2MvZ2VuZXJhdGUtZ3RrZG9jCisrKyBiL1Rvb2xzL2d0a2RvYy9nZW5lcmF0 ZS1ndGtkb2MKQEAgLTEsNCArMSw0IEBACi0jIS91c3IvYmluL3B5dGhvbjMKKyMhL3Vzci9iaW4v ZW52IHB5dGhvbjMKICMgQ29weXJpZ2h0IChDKSAyMDExIElnYWxpYSBTLkwuCiAjCiAjIFRoaXMg bGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2FuIHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IK ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA3MzZhMDZhMjQ3MzJlNzk4 ZGI0YTA4ODA1M2IyYTU3ZDU2NTM2NzQ3Li45ZjNhMTFlN2UyYmU1MDRiYzJkZTIwZjRhZjBkODRl Y2ZmOWQ4N2Q5IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjAtMDMtMjEgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0Bnbm9t ZS5vcmc+CisKKyAgICAgICAgW0dUS10gVXNlICR7UFlUSE9OX0VYRUNVVEFCTEV9IHRvIHJ1biBn ZW5lcmF0ZS1ndGtkb2MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwODk3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoZXJlJ3Mgbm8gbmVlZCB0byByZWx5IG9uIHNoZWJhbmdzIHdoZW4gZXhlY3V0aW5n IHB5dGhvbiBzY3JpcHRzIGZyb20gQ01ha2UuIFRoaXMgc2hvdWxkCisgICAgICAgIGVuc3VyZSB0 aGUgc2NyaXB0IGFsd2F5cyB3b3JrcyBldmVuIGlmIHRoZSBzaGViYW5nIGRvZXMgbm90LgorCisg ICAgICAgICogU291cmNlL2NtYWtlL0d0a0RvYy5jbWFrZToKKwogMjAyMC0wMy0yMCAgSnVzdGlu IE1pY2hhdWQgIDxqdXN0aW5AanVzdGlubWljaGF1ZC5jb20+CiAKICAgICAgICAgRml4IEpTQ09u bHkgYnVpbGQgd2l0aG91dCB1bmlmaWVkIHNvdXJjZXMK