208969 2020-03-11 19:27:33 -0700 REGRESSION(r254389): Cordova throws an exception because it expects a hyphen inside navigator.locale 2020-03-18 12:28:46 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 209030 1 mmaxfield mmaxfield achristensen benjamin cdumez cmarcelo darin dino ews-watchlist ggaren jonlee krollin simon.fraser thorton webkit-bug-importer oldest_to_newest 1628986 0 mmaxfield 2020-03-11 19:27:33 -0700 REGRESSION(r254389): Cordova throws an exception because it expects a hyphen inside navigator.locale 1628988 1 393329 mmaxfield 2020-03-11 19:29:15 -0700 Created attachment 393329 Patch 1628989 2 mmaxfield 2020-03-11 19:29:18 -0700 <rdar://problem/59845517> 1629022 3 393329 krollin 2020-03-11 20:52:42 -0700 Comment on attachment 393329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393329&action=review > Source/WTF/wtf/cocoa/LanguageCocoa.mm:40 > +#elif PLATFORM(IOS_FAMILY) > + static bool applicationVersionCheck = dyld_get_program_sdk_version() >= DYLD_IOS_VERSION_13_4; I want to make sure this platform and version checking is correct. The PLATFORM(IOS_FAMILY) check will be True for tvOS and watchOS, as well as iOS. But that DYLD_IOS_VERSION_13_4 seems to be iOS-only. So should the pre-processor conditional actually be just PLATFORM(IOS)? And what should happen with macCatalyst? PLATFORM(IOS) will return False for macCatalyst, so if we want to support that platform, we'd also need a PLATFORM(MACCATALYST) check (I assume the iOS version number would be appropriate for that platform?). 1629178 4 393329 cdumez 2020-03-12 07:41:54 -0700 Comment on attachment 393329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393329&action=review > Source/WTF/wtf/cocoa/LanguageCocoa.mm:38 > + static bool applicationVersionCheck = dyld_get_program_sdk_version() >= DYLD_MACOSX_VERSION_10_15_4; I don't think calling dyld_get_program_sdk_version() in the WebKit2 WebContent process will do what you want. AFAIK, dyld_get_program_sdk_version() will only do what you want in the wK2 UIProcess or WK1. 1629439 5 393329 mmaxfield 2020-03-12 18:04:27 -0700 Comment on attachment 393329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393329&action=review >> Source/WTF/wtf/cocoa/LanguageCocoa.mm:38 >> + static bool applicationVersionCheck = dyld_get_program_sdk_version() >= DYLD_MACOSX_VERSION_10_15_4; > > I don't think calling dyld_get_program_sdk_version() in the WebKit2 WebContent process will do what you want. AFAIK, dyld_get_program_sdk_version() will only do what you want in the wK2 UIProcess or WK1. Good catch! I'm pursuing this in https://bugs.webkit.org/show_bug.cgi?id=209030. 1629816 6 393329 mmaxfield 2020-03-13 13:52:21 -0700 Comment on attachment 393329 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393329&action=review >> Source/WTF/wtf/cocoa/LanguageCocoa.mm:40 >> + static bool applicationVersionCheck = dyld_get_program_sdk_version() >= DYLD_IOS_VERSION_13_4; > > I want to make sure this platform and version checking is correct. The PLATFORM(IOS_FAMILY) check will be True for tvOS and watchOS, as well as iOS. But that DYLD_IOS_VERSION_13_4 seems to be iOS-only. So should the pre-processor conditional actually be just PLATFORM(IOS)? And what should happen with macCatalyst? PLATFORM(IOS) will return False for macCatalyst, so if we want to support that platform, we'd also need a PLATFORM(MACCATALYST) check (I assume the iOS version number would be appropriate for that platform?). From my testing: tvOS: 0xD0400 watchOS: 0xD0200 macOS: 0xA0F04 iOS: 0xD0400 1629945 7 393557 mmaxfield 2020-03-13 16:49:00 -0700 Created attachment 393557 WIP 1629969 8 393565 mmaxfield 2020-03-13 18:07:35 -0700 Created attachment 393565 Patch 1630224 9 393565 darin 2020-03-15 17:31:24 -0700 Comment on attachment 393565 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393565&action=review > Source/WTF/wtf/cocoa/LanguageCocoa.mm:44 > +#if PLATFORM(MAC) > + static bool applicationVersionCheck = applicationSDKVersion() >= DYLD_MACOSX_VERSION_10_15_4; > +#elif PLATFORM(IOS) > + static bool applicationVersionCheck = applicationSDKVersion() >= DYLD_IOS_VERSION_13_4; > +#elif > + static bool applicationVersionCheck = true; > +#endif > + static bool result = applicationVersionCheck && [NSLocale respondsToSelector:@selector(minimizedLanguagesFromLanguages:)]; I suggest static const bool or static constexpr for all of these. But also, not elegant to have two globals since the first is only used to compute the second. So write it like this: static const bool result = [] { #if PLATFORM(MAC) if (applicationSDKVersion() < DYLD_MACOSX_VERSION_10_15_4) return false; #endif #if PLATFORM(IOS) if (applicationSDKVersion() < DYLD_IOS_VERSION_13_4) return false; #elif return [NSLocale respondsToSelector:@selector(minimizedLanguagesFromLanguages:)]; }(); 1630988 10 393810 mmaxfield 2020-03-17 19:17:08 -0700 Created attachment 393810 Patch for committing 1631299 11 ews-feeder 2020-03-18 12:28:44 -0700 Committed r258658: <https://trac.webkit.org/changeset/258658> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393810. 393329 2020-03-11 19:29:15 -0700 2020-03-13 16:48:59 -0700 Patch bug-208969-20200311192915.patch text/plain 1899 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MTgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGZjYTI4M2M4ZmY1ZmQ0MTYwYWQxZDQx N2YxMjRiYzRmMGFhNWI5ZTEuLjI4ZGFiNWZlY2RiYTU3Y2YxNDUyOGVlNDc4ZWM2MzRhZDE0ZGJj YTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDMtMTEgIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTQzODkpOiBDb3Jk b3ZhIHRocm93cyBhbiBleGNlcHRpb24gYmVjYXVzZSBpdCBleHBlY3RzIGEgaHlwaGVuIGluc2lk ZSBuYXZpZ2F0b3IubG9jYWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDg5NjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5ODQ1NTE3PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGxpbmtl ZC1vbi1vci1hZnRlciBjaGVjay4gRm9sbG93IHRoZSBleGFtcGxlIG9mIEpTV3JhcHBlck1hcCBm cm9tIEphdmFzY3JpcHRDb3JlIGZvciBob3cgdG8gYWNoaWV2ZSB0aGlzLgorCisgICAgICAgICog d3RmL2NvY29hL0xhbmd1YWdlQ29jb2EubW06CisgICAgICAgIChXVEY6OmNhbk1pbmltaXplTGFu Z3VhZ2VzKToKKwogMjAyMC0wMy0wOCAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+ CiAKICAgICAgICAgUmVtZW1iZXIgY29tcGxldGVkIHN1YnJhbmdlcyBkdXJpbmcgaW5jcmVtZW50 YWwgUERGIGxvYWRpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9jb2NvYS9MYW5ndWFn ZUNvY29hLm1tIGIvU291cmNlL1dURi93dGYvY29jb2EvTGFuZ3VhZ2VDb2NvYS5tbQppbmRleCA3 OGJhZGZmYzM1OWFkMjQyMDIzNzE0ZjY0NWQ5ZjhhYjcyNWViMTMxLi5kMzJhN2U1ZjNkMjAzNWU4 Nzk2M2I2ZTU2YmY5NjBmZjBjNTk3ODBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9jb2Nv YS9MYW5ndWFnZUNvY29hLm1tCisrKyBiL1NvdXJjZS9XVEYvd3RmL2NvY29hL0xhbmd1YWdlQ29j b2EubW0KQEAgLTI4LDEyICsyOCwyMCBAQAogCiAjaW1wb3J0IDx3dGYvTmV2ZXJEZXN0cm95ZWQu aD4KICNpbXBvcnQgPHd0Zi9zcGkvY29jb2EvTlNMb2NhbGVTUEkuaD4KKyNpbXBvcnQgPHd0Zi9z cGkvZGFyd2luL2R5bGRTUEkuaD4KIAogbmFtZXNwYWNlIFdURiB7CiAKIGJvb2wgY2FuTWluaW1p emVMYW5ndWFnZXMoKQogewotICAgIHN0YXRpYyBib29sIHJlc3VsdCA9IFtOU0xvY2FsZSByZXNw b25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKG1pbmltaXplZExhbmd1YWdlc0Zyb21MYW5ndWFnZXM6 KV07CisjaWYgUExBVEZPUk0oTUFDKQorICAgIHN0YXRpYyBib29sIGFwcGxpY2F0aW9uVmVyc2lv bkNoZWNrID0gZHlsZF9nZXRfcHJvZ3JhbV9zZGtfdmVyc2lvbigpID49IERZTERfTUFDT1NYX1ZF UlNJT05fMTBfMTVfNDsKKyNlbGlmIFBMQVRGT1JNKElPU19GQU1JTFkpCisgICAgc3RhdGljIGJv b2wgYXBwbGljYXRpb25WZXJzaW9uQ2hlY2sgPSBkeWxkX2dldF9wcm9ncmFtX3Nka192ZXJzaW9u KCkgPj0gRFlMRF9JT1NfVkVSU0lPTl8xM180OworI2Vsc2UKKyAgICBzdGF0aWMgYm9vbCBhcHBs aWNhdGlvblZlcnNpb25DaGVjayA9IHRydWU7CisjZW5kaWYKKyAgICBzdGF0aWMgYm9vbCByZXN1 bHQgPSBhcHBsaWNhdGlvblZlcnNpb25DaGVjayAmJiBbTlNMb2NhbGUgcmVzcG9uZHNUb1NlbGVj dG9yOkBzZWxlY3RvcihtaW5pbWl6ZWRMYW5ndWFnZXNGcm9tTGFuZ3VhZ2VzOildOwogICAgIHJl dHVybiByZXN1bHQ7CiB9CiAK 393557 2020-03-13 16:49:00 -0700 2020-03-13 18:07:33 -0700 WIP bug-208969-20200313164900.patch text/plain 2236 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJhYzRmYzBmYzVkMzJlYjE4Yjc1ZTRm ZGI5ZjY5YzM1Y2JkOGQ5NTUuLjQzMzA0MDFkODkyMDNjZjUxOGU3YWQzODI5NWNjNWJlZTYzMDUz ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDMtMTMgIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTQzODkpOiBDb3Jk b3ZhIHRocm93cyBhbiBleGNlcHRpb24gYmVjYXVzZSBpdCBleHBlY3RzIGEgaHlwaGVuIGluc2lk ZSBuYXZpZ2F0b3IubG9jYWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDg5NjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5ODQ1NTE3PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHdhbnQgdG8g dGh3YXJ0IGZpbmdlcnByaW50aW5nIGJ5IG1pbmltaXppbmcgdGhlIGxpc3Qgb2YgbG9jYWxlcywg YnV0IHdlIGFsc28gZG9uJ3Qgd2FudCB0byBicmVhayBleGlzdGluZyBhcHBzLgorICAgICAgICBX ZSBjYW4gYWNoaWV2ZSBib3RoIGJ5IGEgbGlua2VkLW9uLW9yLWFmdGVyIGNoZWNrLgorCisgICAg ICAgICogd3RmL2NvY29hL0xhbmd1YWdlQ29jb2EubW06CisgICAgICAgIChXVEY6OmNhbk1pbmlt aXplTGFuZ3VhZ2VzKToKKwogMjAyMC0wMy0xMyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4Zmll bGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gUHVzaCBhcHBsaWNhdGlvblNES1ZlcnNp b24oKSBkb3duIGZyb20gV2ViQ29yZSBpbnRvIFdURgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvY29jb2EvTGFuZ3VhZ2VDb2NvYS5tbSBiL1NvdXJjZS9XVEYvd3RmL2NvY29hL0xhbmd1YWdl Q29jb2EubW0KaW5kZXggNzhiYWRmZmMzNTlhZDI0MjAyMzcxNGY2NDVkOWY4YWI3MjVlYjEzMS4u MzEzYmNhMTE5YzRmNGU1Y2VkY2JhYTcxNDFiMjVhNWI1NTA2YWE4MiAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvY29jb2EvTGFuZ3VhZ2VDb2NvYS5tbQorKysgYi9Tb3VyY2UvV1RGL3d0Zi9j b2NvYS9MYW5ndWFnZUNvY29hLm1tCkBAIC0yNywxMyArMjcsMjUgQEAKICNpbXBvcnQgPHd0Zi9M YW5ndWFnZS5oPgogCiAjaW1wb3J0IDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KKyNpbXBvcnQgPHd0 Zi9jb2NvYS9SdW50aW1lQXBwbGljYXRpb25DaGVja3NDb2NvYS5oPgogI2ltcG9ydCA8d3RmL3Nw aS9jb2NvYS9OU0xvY2FsZVNQSS5oPgogCiBuYW1lc3BhY2UgV1RGIHsKIAogYm9vbCBjYW5NaW5p bWl6ZUxhbmd1YWdlcygpCiB7Ci0gICAgc3RhdGljIGJvb2wgcmVzdWx0ID0gW05TTG9jYWxlIHJl c3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IobWluaW1pemVkTGFuZ3VhZ2VzRnJvbUxhbmd1YWdl czopXTsKKyNpZiBQTEFURk9STShNQUMpCisgICAgc3RhdGljIGJvb2wgYXBwbGljYXRpb25WZXJz aW9uQ2hlY2sgPSBhcHBsaWNhdGlvblNES1ZlcnNpb24oKSA+PSBEWUxEX01BQ09TWF9WRVJTSU9O XzEwXzE1XzQ7CisjZWxpZiBpZiBQTEFURk9STShJT1MpCisgICAgc3RhdGljIGJvb2wgYXBwbGlj YXRpb25WZXJzaW9uQ2hlY2sgPSBhcHBsaWNhdGlvblNES1ZlcnNpb24oKSA+PSBEWUxEX0lPU19W RVJTSU9OXzEzXzQ7CisjZWxpZiBpZiBQTEFURk9STShXQVRDSE9TKQorICAgIHN0YXRpYyBib29s IGFwcGxpY2F0aW9uVmVyc2lvbkNoZWNrID0gYXBwbGljYXRpb25TREtWZXJzaW9uKCkgPj0gRFlM RF9JT1NfVkVSU0lPTl8xM18yOworI2VsaWYgaWYgUExBVEZPUk0oVFZPUykKKyAgICBzdGF0aWMg Ym9vbCBhcHBsaWNhdGlvblZlcnNpb25DaGVjayA9IGFwcGxpY2F0aW9uU0RLVmVyc2lvbigpID49 IERZTERfSU9TX1ZFUlNJT05fMTNfNDsKKyNlbGlmCisgICAgc3RhdGljIGJvb2wgYXBwbGljYXRp b25WZXJzaW9uQ2hlY2sgPSB0cnVlOworI2VuZGlmCisgICAgc3RhdGljIGJvb2wgcmVzdWx0ID0g YXBwbGljYXRpb25WZXJzaW9uQ2hlY2sgJiYgW05TTG9jYWxlIHJlc3BvbmRzVG9TZWxlY3RvcjpA c2VsZWN0b3IobWluaW1pemVkTGFuZ3VhZ2VzRnJvbUxhbmd1YWdlczopXTsKICAgICByZXR1cm4g cmVzdWx0OwogfQogCg== 393565 2020-03-13 18:07:35 -0700 2020-03-15 17:31:24 -0700 Patch bug-208969-20200313180735.patch text/plain 1994 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NDQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGJhYzRmYzBmYzVkMzJlYjE4Yjc1ZTRm ZGI5ZjY5YzM1Y2JkOGQ5NTUuLjQzMzA0MDFkODkyMDNjZjUxOGU3YWQzODI5NWNjNWJlZTYzMDUz ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDMtMTMgIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTQzODkpOiBDb3Jk b3ZhIHRocm93cyBhbiBleGNlcHRpb24gYmVjYXVzZSBpdCBleHBlY3RzIGEgaHlwaGVuIGluc2lk ZSBuYXZpZ2F0b3IubG9jYWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDg5NjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5ODQ1NTE3PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHdhbnQgdG8g dGh3YXJ0IGZpbmdlcnByaW50aW5nIGJ5IG1pbmltaXppbmcgdGhlIGxpc3Qgb2YgbG9jYWxlcywg YnV0IHdlIGFsc28gZG9uJ3Qgd2FudCB0byBicmVhayBleGlzdGluZyBhcHBzLgorICAgICAgICBX ZSBjYW4gYWNoaWV2ZSBib3RoIGJ5IGEgbGlua2VkLW9uLW9yLWFmdGVyIGNoZWNrLgorCisgICAg ICAgICogd3RmL2NvY29hL0xhbmd1YWdlQ29jb2EubW06CisgICAgICAgIChXVEY6OmNhbk1pbmlt aXplTGFuZ3VhZ2VzKToKKwogMjAyMC0wMy0xMyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4Zmll bGRAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0gUHVzaCBhcHBsaWNhdGlvblNES1ZlcnNp b24oKSBkb3duIGZyb20gV2ViQ29yZSBpbnRvIFdURgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvY29jb2EvTGFuZ3VhZ2VDb2NvYS5tbSBiL1NvdXJjZS9XVEYvd3RmL2NvY29hL0xhbmd1YWdl Q29jb2EubW0KaW5kZXggNzhiYWRmZmMzNTlhZDI0MjAyMzcxNGY2NDVkOWY4YWI3MjVlYjEzMS4u MDZmZjllNWQ3NzQ1YTVkOWEwOWIzMmI3NWEzNzlkMTkyZWIwZmZiMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvY29jb2EvTGFuZ3VhZ2VDb2NvYS5tbQorKysgYi9Tb3VyY2UvV1RGL3d0Zi9j b2NvYS9MYW5ndWFnZUNvY29hLm1tCkBAIC0yNywxMyArMjcsMjEgQEAKICNpbXBvcnQgPHd0Zi9M YW5ndWFnZS5oPgogCiAjaW1wb3J0IDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KKyNpbXBvcnQgPHd0 Zi9jb2NvYS9SdW50aW1lQXBwbGljYXRpb25DaGVja3NDb2NvYS5oPgogI2ltcG9ydCA8d3RmL3Nw aS9jb2NvYS9OU0xvY2FsZVNQSS5oPgogCiBuYW1lc3BhY2UgV1RGIHsKIAogYm9vbCBjYW5NaW5p bWl6ZUxhbmd1YWdlcygpCiB7Ci0gICAgc3RhdGljIGJvb2wgcmVzdWx0ID0gW05TTG9jYWxlIHJl c3BvbmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IobWluaW1pemVkTGFuZ3VhZ2VzRnJvbUxhbmd1YWdl czopXTsKKyNpZiBQTEFURk9STShNQUMpCisgICAgc3RhdGljIGJvb2wgYXBwbGljYXRpb25WZXJz aW9uQ2hlY2sgPSBhcHBsaWNhdGlvblNES1ZlcnNpb24oKSA+PSBEWUxEX01BQ09TWF9WRVJTSU9O XzEwXzE1XzQ7CisjZWxpZiBQTEFURk9STShJT1MpCisgICAgc3RhdGljIGJvb2wgYXBwbGljYXRp b25WZXJzaW9uQ2hlY2sgPSBhcHBsaWNhdGlvblNES1ZlcnNpb24oKSA+PSBEWUxEX0lPU19WRVJT SU9OXzEzXzQ7CisjZWxpZgorICAgIHN0YXRpYyBib29sIGFwcGxpY2F0aW9uVmVyc2lvbkNoZWNr ID0gdHJ1ZTsKKyNlbmRpZgorICAgIHN0YXRpYyBib29sIHJlc3VsdCA9IGFwcGxpY2F0aW9uVmVy c2lvbkNoZWNrICYmIFtOU0xvY2FsZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKG1pbmlt aXplZExhbmd1YWdlc0Zyb21MYW5ndWFnZXM6KV07CiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAo= 393810 2020-03-17 19:17:08 -0700 2020-03-18 12:28:45 -0700 Patch for committing bug-208969-20200317191704.patch text/plain 2032 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY3ZjM0NDc1Mzk4YzQ5YjVjNDZjMmNm OTdlNjU4MjVjMmM0NmQwY2YuLjE5MWY4MzYzNDAwMzFlZjg1NTZhZjYwYWEzNzA1NmUwOTcwNDA1 NTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDMtMTcgIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTQzODkpOiBDb3Jk b3ZhIHRocm93cyBhbiBleGNlcHRpb24gYmVjYXVzZSBpdCBleHBlY3RzIGEgaHlwaGVuIGluc2lk ZSBuYXZpZ2F0b3IubG9jYWxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDg5NjkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU5ODQ1NTE3PgorCisg ICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIFdlIHdhbnQgdG8gdGh3 YXJ0IGZpbmdlcnByaW50aW5nIGJ5IG1pbmltaXppbmcgdGhlIGxpc3Qgb2YgbG9jYWxlcywgYnV0 IHdlIGFsc28gZG9uJ3Qgd2FudCB0byBicmVhayBleGlzdGluZyBhcHBzLgorICAgICAgICBXZSBj YW4gYWNoaWV2ZSBib3RoIGJ5IGEgbGlua2VkLW9uLW9yLWFmdGVyIGNoZWNrLgorCisgICAgICAg ICogd3RmL2NvY29hL0xhbmd1YWdlQ29jb2EubW06CisgICAgICAgIChXVEY6OmNhbk1pbmltaXpl TGFuZ3VhZ2VzKToKKwogMjAyMC0wMy0xNyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjI1NDg1NikgQWRkIGV4Y2VwdGlv biBmb3Igd2luZG93Lm9wZW5EYXRhYmFzZSB0byBub3QgbWFzcXVlcmFkZSBhcyB1bmRlZmluZWQg aW4gY3VycmVudGx5IHNoaXBwaW5nIEplc3VzIENhbGxpbmcgRGV2b3Rpb25hbCBhcHAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvd3RmL2NvY29hL0xhbmd1YWdlQ29jb2EubW0gYi9Tb3VyY2UvV1RG L3d0Zi9jb2NvYS9MYW5ndWFnZUNvY29hLm1tCmluZGV4IDc4YmFkZmZjMzU5YWQyNDIwMjM3MTRm NjQ1ZDlmOGFiNzI1ZWIxMzEuLjViYWI3YzdiMjY3YzBhZGQyNTViMmZlNjc2MmVlNjQwZTA1ODg5 OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL2NvY29hL0xhbmd1YWdlQ29jb2EubW0KKysr IGIvU291cmNlL1dURi93dGYvY29jb2EvTGFuZ3VhZ2VDb2NvYS5tbQpAQCAtMjcsMTMgKzI3LDI0 IEBACiAjaW1wb3J0IDx3dGYvTGFuZ3VhZ2UuaD4KIAogI2ltcG9ydCA8d3RmL05ldmVyRGVzdHJv eWVkLmg+CisjaW1wb3J0IDx3dGYvY29jb2EvUnVudGltZUFwcGxpY2F0aW9uQ2hlY2tzQ29jb2Eu aD4KICNpbXBvcnQgPHd0Zi9zcGkvY29jb2EvTlNMb2NhbGVTUEkuaD4KIAogbmFtZXNwYWNlIFdU RiB7CiAKIGJvb2wgY2FuTWluaW1pemVMYW5ndWFnZXMoKQogewotICAgIHN0YXRpYyBib29sIHJl c3VsdCA9IFtOU0xvY2FsZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKG1pbmltaXplZExh bmd1YWdlc0Zyb21MYW5ndWFnZXM6KV07CisgICAgc3RhdGljIGNvbnN0IGJvb2wgcmVzdWx0ID0g W10oKSAtPiBib29sIHsKKyNpZiBQTEFURk9STShNQUMpCisgICAgICAgIGlmIChhcHBsaWNhdGlv blNES1ZlcnNpb24oKSA8IERZTERfTUFDT1NYX1ZFUlNJT05fMTBfMTVfNCkKKyAgICAgICAgICAg IHJldHVybiBmYWxzZTsKKyNlbmRpZgorI2lmIFBMQVRGT1JNKElPUykKKyAgICAgICAgaWYgKGFw cGxpY2F0aW9uU0RLVmVyc2lvbigpIDwgRFlMRF9JT1NfVkVSU0lPTl8xM180KQorICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOworI2VuZGlmCisgICAgICAgIHJldHVybiBbTlNMb2NhbGUgcmVzcG9u ZHNUb1NlbGVjdG9yOkBzZWxlY3RvcihtaW5pbWl6ZWRMYW5ndWFnZXNGcm9tTGFuZ3VhZ2VzOild OworICAgIH0oKTsKICAgICByZXR1cm4gcmVzdWx0OwogfQogCg==