208962 2020-03-11 17:32:47 -0700 [GPUP] Use standard int type in RemoteMediaPlayerState 2020-03-12 06:56:12 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206697 1 don.olmstead don.olmstead commit-queue eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1628948 0 don.olmstead 2020-03-11 17:32:47 -0700 Encoder/Decoder for RemoteMediaPlayerState.h is having problems with unsigned long long. In file included from ../../Source/WebKit/Platform/IPC\Connection.h:31: ../../Source/WebKit/Platform/IPC\Decoder.h:181:31: error: no matching member function for call to 'decode' if (ArgumentCoder<T>::decode(*this, t)) { ~~~~~~~~~~~~~~~~~~^~~~~~ ../../Source/WebKit/WebProcess/GPU/media\RemoteMediaPlayerState.h:196:17: note: in instantiation of function template specialization 'IPC::Decoder::operator>><unsigned long long, nullptr>' requested here decoder >> totalBytes; 1628951 1 393315 don.olmstead 2020-03-11 17:42:23 -0700 Created attachment 393315 Patch 1628953 2 393316 don.olmstead 2020-03-11 17:42:47 -0700 Created attachment 393316 Patch 1629162 3 393316 commit-queue 2020-03-12 06:55:14 -0700 Comment on attachment 393316 Patch Clearing flags on attachment: 393316 Committed r258323: <https://trac.webkit.org/changeset/258323> 1629164 4 commit-queue 2020-03-12 06:55:15 -0700 All reviewed patches have been landed. Closing bug. 1629165 5 webkit-bug-importer 2020-03-12 06:56:12 -0700 <rdar://problem/60369435> 393315 2020-03-11 17:42:23 -0700 2020-03-11 17:42:47 -0700 Patch bug-208962.diff text/plain 900 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggY2NhOTY5ZGE3YmQ4Li5mYTYxYWY3MGJkMDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMjAtMDMtMTEgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNv bT4KKworICAgICAgICBbR1BVUF0gVXNlIHN0YW5kYXJkIGludCB0eXBlIGluIFJlbW90ZU1lZGlh UGxheWVyU3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwODk2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFuIHVuc2lnbmVkIGxvbmcgbG9uZyBpcyBhdCBsZWFzdCA2NC1iaXRzIHNvIHVzZSB1aW50 NjRfdCBpbnN0ZWFkLiBUaGlzIGlzc3VlCisgICAgICAgIHdhcyBmb3VuZCB3aGVuIGNvbXBpbGlu ZyBvdXQgdGhlIEdQVSBQcm9jZXNzLiBObyBzcGVjaWFsaXphdGlvbiBvZiB1bnNpZ25lZCBsb25n CisgICAgICAgIGxvbmcgd2FzIGZvdW5kIHdoaWNoIHJlc3VsdGVkIGluIGVycm9ycy4gVGhpcyBh cHBlYXJzIHRvIGJlIGEgbm9uLUNvY29hIHByb2JsZW0uCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L0dQVS9tZWRpYS9SZW1vdGVNZWRpYVBsYXllclN0YXRlLmg6CisgICAgICAgIChXZWJLaXQ6OlJl bW90ZU1lZGlhUGxheWVyU3RhdGU6OmRlY29kZSk6CisKIDIwMjAtMDMtMTEgIFBlciBBcm5lIFZv bGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gX0FYU0FwcGxpY2F0 aW9uQWNjZXNzaWJpbGl0eUVuYWJsZWQgc2hvdWxkIG5vdCBiZSBjYWxsZWQK 393316 2020-03-11 17:42:47 -0700 2020-03-12 06:55:14 -0700 Patch bug-208962.diff text/plain 1894 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggY2NhOTY5ZGE3YmQ4Li5mYTYxYWY3MGJkMDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMjAtMDMtMTEgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNv bT4KKworICAgICAgICBbR1BVUF0gVXNlIHN0YW5kYXJkIGludCB0eXBlIGluIFJlbW90ZU1lZGlh UGxheWVyU3RhdGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwODk2MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFuIHVuc2lnbmVkIGxvbmcgbG9uZyBpcyBhdCBsZWFzdCA2NC1iaXRzIHNvIHVzZSB1aW50 NjRfdCBpbnN0ZWFkLiBUaGlzIGlzc3VlCisgICAgICAgIHdhcyBmb3VuZCB3aGVuIGNvbXBpbGlu ZyBvdXQgdGhlIEdQVSBQcm9jZXNzLiBObyBzcGVjaWFsaXphdGlvbiBvZiB1bnNpZ25lZCBsb25n CisgICAgICAgIGxvbmcgd2FzIGZvdW5kIHdoaWNoIHJlc3VsdGVkIGluIGVycm9ycy4gVGhpcyBh cHBlYXJzIHRvIGJlIGEgbm9uLUNvY29hIHByb2JsZW0uCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L0dQVS9tZWRpYS9SZW1vdGVNZWRpYVBsYXllclN0YXRlLmg6CisgICAgICAgIChXZWJLaXQ6OlJl bW90ZU1lZGlhUGxheWVyU3RhdGU6OmRlY29kZSk6CisKIDIwMjAtMDMtMTEgIFBlciBBcm5lIFZv bGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gX0FYU0FwcGxpY2F0 aW9uQWNjZXNzaWJpbGl0eUVuYWJsZWQgc2hvdWxkIG5vdCBiZSBjYWxsZWQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJTdGF0 ZS5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9tZWRpYS9SZW1vdGVNZWRpYVBsYXll clN0YXRlLmgKaW5kZXggNzMwNzVhZjAyZmJmLi43MGIyMzU2ODdhNjggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJTdGF0ZS5o CisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvbWVkaWEvUmVtb3RlTWVkaWFQbGF5 ZXJTdGF0ZS5oCkBAIC01Myw3ICs1Myw3IEBAIHN0cnVjdCBSZW1vdGVNZWRpYVBsYXllclN0YXRl IHsKICAgICBkb3VibGUgbWluRmFzdFJldmVyc2VSYXRlIHsgMCB9OwogICAgIGRvdWJsZSBzZWVr YWJsZVRpbWVSYW5nZXNMYXN0TW9kaWZpZWRUaW1lIHsgMCB9OwogICAgIGRvdWJsZSBsaXZlVXBk YXRlSW50ZXJ2YWwgeyAwIH07Ci0gICAgdW5zaWduZWQgbG9uZyBsb25nIHRvdGFsQnl0ZXMgeyAw IH07CisgICAgdWludDY0X3QgdG90YWxCeXRlcyB7IDAgfTsKICAgICBPcHRpb25hbDxib29sPiB3 b3VsZFRhaW50RG9jdW1lbnRTZWN1cml0eU9yaWdpbiB7IHRydWUgfTsKICAgICBib29sIHBhdXNl ZCB7IHRydWUgfTsKICAgICBib29sIGxvYWRpbmdQcm9ncmVzc2VkIHsgZmFsc2UgfTsKQEAgLTE5 Miw3ICsxOTIsNyBAQCBzdHJ1Y3QgUmVtb3RlTWVkaWFQbGF5ZXJTdGF0ZSB7CiAgICAgICAgIGlm ICghbGl2ZVVwZGF0ZUludGVydmFsKQogICAgICAgICAgICAgcmV0dXJuIFdURjo6bnVsbG9wdDsK IAotICAgICAgICBPcHRpb25hbDx1bnNpZ25lZCBsb25nIGxvbmc+IHRvdGFsQnl0ZXM7CisgICAg ICAgIE9wdGlvbmFsPHVpbnQ2NF90PiB0b3RhbEJ5dGVzOwogICAgICAgICBkZWNvZGVyID4+IHRv dGFsQnl0ZXM7CiAgICAgICAgIGlmICghdG90YWxCeXRlcykKICAgICAgICAgICAgIHJldHVybiBX VEY6Om51bGxvcHQ7Cg==