208958 2020-03-11 17:06:33 -0700 [GPUP] Add special handling of MediaTime within message generator 2020-03-11 19:02:49 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206697 1 don.olmstead don.olmstead commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1628933 0 don.olmstead 2020-03-11 17:06:33 -0700 GPU Process added MediaTime to messages.in files. The messages.py script wasn't updated for special handling of this. Pretty sure the only reason this works is because of a .cpp file being included in a unified build. For non-unified builds the following happens In file included from ../../Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp:35: WebKit/DerivedSources\MediaPlayerPrivateRemoteMessages.h:546:75: error: unknown type name 'MediaTime' typedef std::tuple<const WebKit::TrackPrivateRemoteIdentifier&, const MediaTime&, const MediaTime&, const IPC::DataReference&> Arguments; 1628944 1 393313 don.olmstead 2020-03-11 17:20:38 -0700 Created attachment 393313 Patch 1628974 2 393313 commit-queue 2020-03-11 18:35:31 -0700 Comment on attachment 393313 Patch Clearing flags on attachment: 393313 Committed r258305: <https://trac.webkit.org/changeset/258305> 1628975 3 commit-queue 2020-03-11 18:35:33 -0700 All reviewed patches have been landed. Closing bug. 1628976 4 webkit-bug-importer 2020-03-11 18:36:17 -0700 <rdar://problem/60351441> 393313 2020-03-11 17:20:38 -0700 2020-03-11 18:35:31 -0700 Patch bug-208958.diff text/plain 2344 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggY2NhOTY5ZGE3YmQ4Li4zZDEyN2JiZmJlZDcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMjAtMDMtMTEgIERvbiBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNv bT4KKworICAgICAgICBbR1BVUF0gQWRkIHNwZWNpYWwgaGFuZGxpbmcgb2YgTWVkaWFUaW1lIHdp dGhpbiBtZXNzYWdlIGdlbmVyYXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA4OTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2hlbiBjb21waWxpbmcgdGhlIEdQVSBQcm9jZXNzIHNvdXJjZXMgd2l0 aG91dCB1bmlmaWVkIHNvdXJjZXMgdGhlcmUgd2VyZQorICAgICAgICBudW1lcm91cyBjb21waWxh dGlvbiBlcnJvcnMgYXJvdW5kIE1lZGlhVGltZS4gT25seSBHUFUgUHJvY2VzcyAubWVzc2FnZXMu aW4KKyAgICAgICAgZmlsZXMgcmVmZXJlbmNlIHRoaXMgdHlwZSBzbyB0aGVyZSB3YXMgbm8gc3Bl Y2lhbCBoYW5kbGluZyB3aXRoaW4gbWVzc2FnZXMucHkuCisgICAgICAgIEFkZGluZyBleHBsaWNp dCByZWZlcmVuY2VzIHRvIE1lZGlhVGltZSBzbyB0aGUgcHJvcGVyIGhlYWRlciBpcyB1c2VkIGFu ZCBhbGwKKyAgICAgICAgc291cmNlcyBjb21waWxlLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXQvbWVzc2FnZXMucHk6CisKIDIwMjAtMDMtMTEgIFBlciBBcm5lIFZvbGxhbiAgPHB2b2xsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU10gX0FYU0FwcGxpY2F0aW9uQWNjZXNzaWJpbGl0 eUVuYWJsZWQgc2hvdWxkIG5vdCBiZSBjYWxsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv U2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHkgYi9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvd2Via2l0 L21lc3NhZ2VzLnB5CmluZGV4IDY2NWY1YTIyMTA4ZS4uZGY1NzczMDVkODMwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvd2Via2l0L21lc3NhZ2VzLnB5CisrKyBiL1NvdXJjZS9X ZWJLaXQvU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHkKQEAgLTIwNCw2ICsyMDQsNyBAQCBkZWYg Zm9yd2FyZF9kZWNsYXJhdGlvbnNfZm9yX25hbWVzcGFjZShuYW1lc3BhY2UsIGtpbmRfYW5kX3R5 cGVzKToKIGRlZiB0eXBlc190aGF0X2Nhbm5vdF9iZV9mb3J3YXJkX2RlY2xhcmVkKCk6CiAgICAg cmV0dXJuIGZyb3plbnNldChbCiAgICAgICAgICdNYWNoU2VuZFJpZ2h0JywKKyAgICAgICAgJ01l ZGlhVGltZScsCiAgICAgICAgICdTdHJpbmcnLAogICAgICAgICAnV2ViQ29yZTo6Q29sb3JTcGFj ZScsCiAgICAgICAgICdXZWJDb3JlOjpEb2N1bWVudElkZW50aWZpZXInLApAQCAtMjc5LDYgKzI4 MCw3IEBAIGRlZiBmb3J3YXJkX2RlY2xhcmF0aW9uc19hbmRfaGVhZGVycyhyZWNlaXZlcik6CiAK ICAgICBub25fdGVtcGxhdGVfd3RmX3R5cGVzID0gZnJvemVuc2V0KFsKICAgICAgICAgJ01hY2hT ZW5kUmlnaHQnLAorICAgICAgICAnTWVkaWFUeXBlJywKICAgICAgICAgJ1N0cmluZycsCiAgICAg XSkKIApAQCAtMzMyLDYgKzMzNCw3IEBAIGRlZiBmb3J3YXJkX2RlY2xhcmF0aW9uc19hbmRfaGVh ZGVyc19mb3JfcmVwbGllcyhyZWNlaXZlcik6CiAKICAgICBub25fdGVtcGxhdGVfd3RmX3R5cGVz ID0gZnJvemVuc2V0KFsKICAgICAgICAgJ01hY2hTZW5kUmlnaHQnLAorICAgICAgICAnTWVkaWFU aW1lJywKICAgICAgICAgJ1N0cmluZycsCiAgICAgXSkKIApAQCAtNTYyLDYgKzU2NSw3IEBAIGRl ZiBoZWFkZXJzX2Zvcl90eXBlKHR5cGUpOgogICAgICAgICAnSlNDOjpNZXNzYWdlU291cmNlJzog Wyc8SmF2YVNjcmlwdENvcmUvQ29uc29sZVR5cGVzLmg+J10sCiAgICAgICAgICdJbnNwZWN0b3I6 Okluc3BlY3RvclRhcmdldFR5cGUnOiBbJzxKYXZhU2NyaXB0Q29yZS9JbnNwZWN0b3JUYXJnZXQu aD4nXSwKICAgICAgICAgJ0luc3BlY3Rvcjo6RnJvbnRlbmRDaGFubmVsOjpDb25uZWN0aW9uVHlw ZSc6IFsnPEphdmFTY3JpcHRDb3JlL0luc3BlY3RvckZyb250ZW5kQ2hhbm5lbC5oPiddLAorICAg ICAgICAnTWVkaWFUaW1lJzogWyc8d3RmL01lZGlhVGltZS5oPiddLAogICAgICAgICAnTW9ub3Rv bmljVGltZSc6IFsnPHd0Zi9Nb25vdG9uaWNUaW1lLmg+J10sCiAgICAgICAgICdTZWNvbmRzJzog Wyc8d3RmL1NlY29uZHMuaD4nXSwKICAgICAgICAgJ1dhbGxUaW1lJzogWyc8d3RmL1dhbGxUaW1l Lmg+J10sCg==