208954 2020-03-11 16:27:31 -0700 Make flatpack import for run-webkit-tests only happen on linux systems 2020-03-12 12:01:58 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jlewis3 jlewis3 clopez commit-queue jbedard mcatanzaro pnormand webkit-bug-importer oldest_to_newest 1628906 0 jlewis3 2020-03-11 16:27:31 -0700 import Flatpack was added to run-webkit-test as a required import and means that we can't run the script without it on any other platforms, even when not needed. We should be able to run the script and determine at call time if we need the import. 1628907 1 webkit-bug-importer 2020-03-11 16:27:50 -0700 <rdar://problem/60346729> 1628926 2 393308 jlewis3 2020-03-11 16:57:18 -0700 Created attachment 393308 Patch 1628942 3 393308 jbedard 2020-03-11 17:17:00 -0700 Comment on attachment 393308 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393308&action=review This looks correct to be, but I'd like the folks more familiar with how we actually use flatpak. Another alternative approach would be to conditionalize on if flatpak can be found in the provided directory. > Tools/Scripts/run-webkit-tests:16 > +# * Neither the Google name nor the names of its No reason to make this change 1629101 4 393308 pnormand 2020-03-12 02:16:53 -0700 Comment on attachment 393308 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393308&action=review > Tools/Scripts/run-webkit-tests:39 > +if sys.platform.startswith('Linux'): lower-case linux 1629228 5 393386 jlewis3 2020-03-12 10:03:43 -0700 Created attachment 393386 Patch 1629290 6 393386 commit-queue 2020-03-12 12:01:56 -0700 Comment on attachment 393386 Patch Clearing flags on attachment: 393386 Committed r258347: <https://trac.webkit.org/changeset/258347> 1629291 7 commit-queue 2020-03-12 12:01:58 -0700 All reviewed patches have been landed. Closing bug. 393308 2020-03-11 16:57:18 -0700 2020-03-12 10:03:42 -0700 Patch bug-208954-20200311165718.patch text/plain 2316 jlewis3 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjI1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDRhNTM4MzEyN2QwMDQ0MWZiNDU0YmQwMjE1OTdlZTA3 NWU5NWFkMy4uZmZiZjQ0ODgwN2YzM2FhYzYyNDY0NjgxNGNhNDFmZjBlN2YxNGY1NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTAzLTExICBNYXR0IExld2lzICA8amxld2lzM0BhcHBsZS5jb20+CisKKyAgICAg ICAgTWFrZSBmbGF0cGFjayBpbXBvcnQgZm9yIHJ1bi13ZWJraXQtdGVzdHMgb25seSBoYXBwZW4g b24gbGludXggc3lzdGVtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA4OTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHM6IEFkZGVkIGFuIGlmIHN0YXRlbWVu dCB0byBmaW5kIHRoZSBzeXN0ZW0gcGxhdGZvcm0KKyAgICAgICAgdG8gZGV0ZXJtaW5lIGlmIHdl IG5lZWQgdGhlIGZsYXRwYWNrdXRpbHMgaW1wb3J0LiAKKwogMjAyMC0wMy0xMCAgRG9uIE9sbXN0 ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAgICAgIFN5bmMgRmVhdHVyZUxpc3Qu cG0gd2l0aCBDTWFrZSBkZWZpbml0aW9ucwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4t d2Via2l0LXRlc3RzIGIvVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCmluZGV4IGZkODdl ODcwZGY2ZWRmZmI3YjczMTBlZDE1ZDE5MzUyMzg5ZTA0MWEuLjExZmI3NzczNWYzMGUyMDIyYWQ1 NDRkMzdjM2IyYzEzZjA3OGM1YzggMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtp dC10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKQEAgLTEsNSArMSw3 IEBACiAjIS91c3IvYmluL2VudiBweXRob24KKwogIyBDb3B5cmlnaHQgKEMpIDIwMTEgR29vZ2xl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMgQ29weXJpZ2h0IChDKSAyMDIwIEFwcGxlIElu Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMKICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBz b3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwg YXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUK QEAgLTExLDcgKzEzLDcgQEAKICMgY29weXJpZ2h0IG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRp dGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lcgogIyBpbiB0aGUgZG9jdW1lbnRhdGlv biBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCiAjIGRpc3RyaWJ1dGlv bi4KLSMgICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVz IG9mIGl0cworIyAgICAgKiBOZWl0aGVyIHRoZSBHb29nbGUgbmFtZSBub3IgdGhlIG5hbWVzIG9m IGl0cwogIyBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHBy b2R1Y3RzIGRlcml2ZWQgZnJvbQogIyB0aGlzIHNvZnR3YXJlIHdpdGhvdXQgc3BlY2lmaWMgcHJp b3Igd3JpdHRlbiBwZXJtaXNzaW9uLgogIwpAQCAtMzQsOCArMzYsOSBAQCBpbXBvcnQgc3lzCiBm cm9tIHdlYmtpdHB5LmNvbW1vbiBpbXBvcnQgbXVsdGlwcm9jZXNzaW5nX2Jvb3RzdHJhcAogCiB0 b3BfbGV2ZWxfZGlyZWN0b3J5ID0gb3MucGF0aC5ub3JtcGF0aChvcy5wYXRoLmpvaW4ob3MucGF0 aC5kaXJuYW1lKF9fZmlsZV9fKSwgJy4uJywgJy4uJykpCi1zeXMucGF0aC5pbnNlcnQoMCwgb3Mu cGF0aC5qb2luKHRvcF9sZXZlbF9kaXJlY3RvcnksICdUb29scycsICdmbGF0cGFrJykpCi1pbXBv cnQgZmxhdHBha3V0aWxzCi1mbGF0cGFrdXRpbHMucnVuX2luX3NhbmRib3hfaWZfYXZhaWxhYmxl KHN5cy5hcmd2KQoraWYgc3lzLnBsYXRmb3JtLnN0YXJ0c3dpdGgoJ0xpbnV4Jyk6CisgICAgc3lz LnBhdGguaW5zZXJ0KDAsIG9zLnBhdGguam9pbih0b3BfbGV2ZWxfZGlyZWN0b3J5LCAnVG9vbHMn LCAnZmxhdHBhaycpKQorICAgIGltcG9ydCBmbGF0cGFrdXRpbHMKKyAgICBmbGF0cGFrdXRpbHMu cnVuX2luX3NhbmRib3hfaWZfYXZhaWxhYmxlKHN5cy5hcmd2KQogCiBtdWx0aXByb2Nlc3Npbmdf Ym9vdHN0cmFwLnJ1bignd2Via2l0cHknLCAnbGF5b3V0X3Rlc3RzJywgJ3J1bl93ZWJraXRfdGVz dHMucHknKQpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUK 393386 2020-03-12 10:03:43 -0700 2020-03-12 12:01:56 -0700 Patch bug-208954-20200312100343.patch text/plain 2003 jlewis3 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MzM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzY0ZDM0NDJjZGVmNmUxNTRmYzY0ZGExYjEyNzNhZjUw YmI5MjYwYS4uMzdjNDY5MGYwZmQzNTFiNzI3MmUwY2UxOTVmMzUzYWIzZDk3MjAxNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIwLTAzLTEyICBNYXR0IExld2lzICA8amxld2lzM0BhcHBsZS5jb20+CisKKyAgICAg ICAgTWFrZSBmbGF0cGFjayBpbXBvcnQgZm9yIHJ1bi13ZWJraXQtdGVzdHMgb25seSBoYXBwZW4g b24gbGludXggc3lzdGVtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA4OTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHM6IEFkZGVkIGFuIGlmIHN0YXRlbWVu dCB0byBmaW5kIHRoZSBzeXN0ZW0gcGxhdGZvcm0KKyAgICAgICAgdG8gZGV0ZXJtaW5lIGlmIHdl IG5lZWQgdGhlIGZsYXRwYWNrdXRpbHMgaW1wb3J0LiAKKwogMjAyMC0wMy0xMiAgRGFuaWVsIEJh dGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgRm9jdXNDb250cm9sbGVyOjpzZXRG b2N1c2VkRWxlbWVudCgpIHNob3VsZCB0ZWxsIGNsaWVudCBvZiByZWZvY3VzZWQgZWxlbWVudApk aWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzIGIvVG9vbHMvU2NyaXB0 cy9ydW4td2Via2l0LXRlc3RzCmluZGV4IGZkODdlODcwZGY2ZWRmZmI3YjczMTBlZDE1ZDE5MzUy Mzg5ZTA0MWEuLjU5NmEyYzcxYjQ3MWZhMWU0MmViNjVlOTc1ODIwMTZlNGE4YmNkMjMgMTAwNzU1 Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cworKysgYi9Ub29scy9TY3JpcHRz L3J1bi13ZWJraXQtdGVzdHMKQEAgLTEsNSArMSw3IEBACiAjIS91c3IvYmluL2VudiBweXRob24K KwogIyBDb3B5cmlnaHQgKEMpIDIwMTEgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4K KyMgQ29weXJpZ2h0IChDKSAyMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMK ICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0 aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0 IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucyBhcmUKQEAgLTM0LDggKzM2LDkgQEAgaW1wb3J0IHN5 cwogZnJvbSB3ZWJraXRweS5jb21tb24gaW1wb3J0IG11bHRpcHJvY2Vzc2luZ19ib290c3RyYXAK IAogdG9wX2xldmVsX2RpcmVjdG9yeSA9IG9zLnBhdGgubm9ybXBhdGgob3MucGF0aC5qb2luKG9z LnBhdGguZGlybmFtZShfX2ZpbGVfXyksICcuLicsICcuLicpKQotc3lzLnBhdGguaW5zZXJ0KDAs IG9zLnBhdGguam9pbih0b3BfbGV2ZWxfZGlyZWN0b3J5LCAnVG9vbHMnLCAnZmxhdHBhaycpKQot aW1wb3J0IGZsYXRwYWt1dGlscwotZmxhdHBha3V0aWxzLnJ1bl9pbl9zYW5kYm94X2lmX2F2YWls YWJsZShzeXMuYXJndikKK2lmIHN5cy5wbGF0Zm9ybS5zdGFydHN3aXRoKCdsaW51eCcpOgorICAg IHN5cy5wYXRoLmluc2VydCgwLCBvcy5wYXRoLmpvaW4odG9wX2xldmVsX2RpcmVjdG9yeSwgJ1Rv b2xzJywgJ2ZsYXRwYWsnKSkKKyAgICBpbXBvcnQgZmxhdHBha3V0aWxzCisgICAgZmxhdHBha3V0 aWxzLnJ1bl9pbl9zYW5kYm94X2lmX2F2YWlsYWJsZShzeXMuYXJndikKIAotbXVsdGlwcm9jZXNz aW5nX2Jvb3RzdHJhcC5ydW4oJ3dlYmtpdHB5JywgJ2xheW91dF90ZXN0cycsICdydW5fd2Via2l0 X3Rlc3RzLnB5JykKXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCittdWx0aXByb2Nlc3Npbmdf Ym9vdHN0cmFwLnJ1bignd2Via2l0cHknLCAnbGF5b3V0X3Rlc3RzJywgJ3J1bl93ZWJraXRfdGVz dHMucHknKQo=