208952 2020-03-11 16:10:35 -0700 [CMake] Warning when ccache is not installed 2020-03-14 09:10:32 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro annulen commit-queue don.olmstead ews-watchlist gyuyoung.kim mcatanzaro ryuan.choi sergio oldest_to_newest 1628898 0 mcatanzaro 2020-03-11 16:10:35 -0700 This warning is not useful: CMake Warning at Source/cmake/WebKitCCache.cmake:25 (message): Enabling ccache: Couldn't find ccache program. Not enabling it. Call Stack (most recent call first): Source/cmake/WebKitCommon.cmake:51 (include) CMakeLists.txt:169 (include) 1628899 1 393301 mcatanzaro 2020-03-11 16:11:56 -0700 Created attachment 393301 Patch 1630023 2 393301 dbates 2020-03-13 23:38:06 -0700 Comment on attachment 393301 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393301&action=review > ChangeLog:10 > + Change the warning when ccache is not installed to a status message. We shouldn't be Same things as in bug 208970, comment 3, Again patch is OK as-is. NO CHANGE NEEDED. [[ This is ok as-is. No change is needed. The optimal ChangeLog would move all the text in this line and later ABOVE the file name so as to be the description of the change because: 1. There is only one file changed in this patch so there's no need for per file comments. 2. Per file/function comments should be concise, no longer than a single paragraph. They are meant to provide more fine grain descriptions of the charges in the patch. ]] 1630047 3 mcatanzaro 2020-03-14 08:19:45 -0700 Thanks Daniel. I see I'm getting rusty with ChangeLogs.... 1630048 4 393584 mcatanzaro 2020-03-14 08:20:42 -0700 Created attachment 393584 Patch for landing 1630050 5 393584 commit-queue 2020-03-14 09:10:30 -0700 Comment on attachment 393584 Patch for landing Clearing flags on attachment: 393584 Committed r258467: <https://trac.webkit.org/changeset/258467> 1630051 6 commit-queue 2020-03-14 09:10:32 -0700 All reviewed patches have been landed. Closing bug. 393301 2020-03-11 16:11:56 -0700 2020-03-14 08:20:40 -0700 Patch bug-208952-20200311181155.patch text/plain 1304 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0Q0NhY2hlLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENDYWNoZS5jbWFrZQppbmRleCA4 Zjk5OWJjODhiNWU0MDQzZTcwMjI3MTI1MjUzZjJiMzM3Nzg0ZmE4Li5mOWU3OTM4OTY2YjZhNDk3 MmE1ZTIyMjg3NzcwNGE4NmNmNmU1YzAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q0NhY2hlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDQ2FjaGUuY21ha2UKQEAgLTIy LDcgKzIyLDcgQEAgaWYgKE5PVCAiJEVOVntXS19VU0VfQ0NBQ0hFfSIgU1RSRVFVQUwgIk5PIikK ICAgICAgICAgICAgIGVuZGlmICgpCiAgICAgICAgIGVuZGlmICgpCiAgICAgZWxzZSAoKQotICAg ICAgICBtZXNzYWdlKFdBUk5JTkcgIkVuYWJsaW5nIGNjYWNoZTogQ291bGRuJ3QgZmluZCBjY2Fj aGUgcHJvZ3JhbS4gTm90IGVuYWJsaW5nIGl0LiIpCisgICAgICAgIG1lc3NhZ2UoU1RBVFVTICJF bmFibGluZyBjY2FjaGU6IENvdWxkbid0IGZpbmQgY2NhY2hlIHByb2dyYW0uIE5vdCBlbmFibGlu ZyBpdC4iKQogICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cg Yi9DaGFuZ2VMb2cKaW5kZXggZTg4Mjk2MDE3ODE4ZmY0OGNmOGE1ZDBiOGQ5MzNhMTY0NjEyY2Fl Ni4uNTkzNzY2YTA3ZjExNWNhMTk0ZWU0ZjgwMmI1MDNhMzM3M2Q2N2M2OSAxMDA2NDQKLS0tIGEv Q2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTExICBN aWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtDTWFr ZV0gV2FybmluZyB3aGVuIGNjYWNoZSBpcyBub3QgaW5zdGFsbGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg5NTIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRDQ2Fj aGUuY21ha2U6CisKKyAgICAgICAgQ2hhbmdlIHRoZSB3YXJuaW5nIHdoZW4gY2NhY2hlIGlzIG5v dCBpbnN0YWxsZWQgdG8gYSBzdGF0dXMgbWVzc2FnZS4gV2Ugc2hvdWxkbid0IGJlCisgICAgICAg IHByaW50aW5nIHdhcm5pbmdzIGV4Y2VwdCB3aGVuIHRoZXJlIGlzIGFuIGFjdHVhbCBwcm9ibGVt LgorCiAyMDIwLTAzLTA5ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAK ICAgICAgICAgQWRkIHNjcmlwdCB0byBzZWFyY2ggZm9yIGZlYXR1cmUgZGVmaW5lcwo= 393584 2020-03-14 08:20:42 -0700 2020-03-14 09:10:30 -0700 Patch for landing bug-208952-20200314102041.patch text/plain 1342 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4NDY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0Q0NhY2hlLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENDYWNoZS5jbWFrZQppbmRleCA4 Zjk5OWJjODhiNWU0MDQzZTcwMjI3MTI1MjUzZjJiMzM3Nzg0ZmE4Li5mOWU3OTM4OTY2YjZhNDk3 MmE1ZTIyMjg3NzcwNGE4NmNmNmU1YzAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q0NhY2hlLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDQ2FjaGUuY21ha2UKQEAgLTIy LDcgKzIyLDcgQEAgaWYgKE5PVCAiJEVOVntXS19VU0VfQ0NBQ0hFfSIgU1RSRVFVQUwgIk5PIikK ICAgICAgICAgICAgIGVuZGlmICgpCiAgICAgICAgIGVuZGlmICgpCiAgICAgZWxzZSAoKQotICAg ICAgICBtZXNzYWdlKFdBUk5JTkcgIkVuYWJsaW5nIGNjYWNoZTogQ291bGRuJ3QgZmluZCBjY2Fj aGUgcHJvZ3JhbS4gTm90IGVuYWJsaW5nIGl0LiIpCisgICAgICAgIG1lc3NhZ2UoU1RBVFVTICJF bmFibGluZyBjY2FjaGU6IENvdWxkbid0IGZpbmQgY2NhY2hlIHByb2dyYW0uIE5vdCBlbmFibGlu ZyBpdC4iKQogICAgIGVuZGlmICgpCiBlbmRpZiAoKQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cg Yi9DaGFuZ2VMb2cKaW5kZXggMzM0ZmRhZDg4YmQ2YTdmNjA1NTg3YjcxNjMwZmMxZmUzOWUwMDdk OC4uZmEwYTEyZGZlMjhiMTJhMGRiNTljMjk5MDQyMjg0MThiNDhiMjk3OCAxMDA2NDQKLS0tIGEv Q2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTE0ICBN aWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFtDTWFr ZV0gV2FybmluZyB3aGVuIGNjYWNoZSBpcyBub3QgaW5zdGFsbGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg5NTIKKworICAgICAgICBSZXZpZXdl ZCBieSBEYW5pZWwgQmF0ZXMuCisKKyAgICAgICAgQ2hhbmdlIHRoZSB3YXJuaW5nIHdoZW4gY2Nh Y2hlIGlzIG5vdCBpbnN0YWxsZWQgdG8gYSBzdGF0dXMgbWVzc2FnZS4gV2Ugc2hvdWxkbid0IGJl CisgICAgICAgIHByaW50aW5nIHdhcm5pbmdzIGV4Y2VwdCB3aGVuIHRoZXJlIGlzIGFuIGFjdHVh bCBwcm9ibGVtLgorCisgICAgICAgICogU291cmNlL2NtYWtlL1dlYktpdENDYWNoZS5jbWFrZToK KwogMjAyMC0wMy0xMyAgS29uc3RhbnRpbiBUb2thcmV2ICA8YW5udWxlbkB5YW5kZXgucnU+CiAK ICAgICAgICAgW0NNYWtlXSBFbGVtaW5hdGUgbWlzbWF0Y2hlcyBiZXR3ZWVuIEZpbmQqIG1vZHVs ZSBuYW1lcyBhbmQgdmFyaWFibGVzIHRoZXkgc2V0Cg==