208950 2020-03-11 15:27:49 -0700 AX: Isolated tree: enabling secondary thread for the wrong clients 2020-03-11 16:56:50 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall andresg_22 apinheiro commit-queue dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1628879 0 cfleizach 2020-03-11 15:27:49 -0700 It looks like we have an error in the patch where we are initializing the secondary thread for all clients 1628880 1 webkit-bug-importer 2020-03-11 15:28:00 -0700 <rdar://problem/60344018> 1628881 2 393295 cfleizach 2020-03-11 15:29:45 -0700 Created attachment 393295 patch 1628895 3 393299 andresg_22 2020-03-11 16:04:47 -0700 Created attachment 393299 Patch 1628924 4 393299 commit-queue 2020-03-11 16:56:48 -0700 Comment on attachment 393299 Patch Clearing flags on attachment: 393299 Committed r258297: <https://trac.webkit.org/changeset/258297> 1628925 5 commit-queue 2020-03-11 16:56:50 -0700 All reviewed patches have been landed. Closing bug. 393295 2020-03-11 15:29:45 -0700 2020-03-11 15:37:10 -0700 patch file_208950.txt text/plain 2702 cfleizach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwDQppbmRl eCBlMjVlYmMxMDk5Zi4uZDkwMDQzYmRhMmEgMTAwNjQ0DQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nl c3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwDQpAQCAtMzkyLDExICszOTIsNyBAQCBBWENvcmVP YmplY3QqIEFYT2JqZWN0Q2FjaGU6Omlzb2xhdGVkVHJlZUZvY3VzZWRPYmplY3QoRG9jdW1lbnQm IGRvY3VtZW50KQ0KICAgICBhdXRvIHRyZWUgPSBBWElzb2xhdGVkVHJlZTo6dHJlZUZvclBhZ2VJ RCgqcGFnZUlEKTsNCiAgICAgaWYgKCF0cmVlKSB7DQogICAgICAgICB0cmVlID0gZ2VuZXJhdGVJ c29sYXRlZFRyZWUoKnBhZ2VJRCwgZG9jdW1lbnQpOw0KLSAgICAgICAgLy8gTm93IHRoYXQgd2Ug aGF2ZSBjcmVhdGVkIG91ciB0cmVlLCBpbml0aWFsaXplIHRoZSBzZWNvbmRhcnkgdGhyZWFkLA0K LSAgICAgICAgLy8gc28gZnV0dXJlIHJlcXVlc3RzIGNvbWUgaW4gb24gdGhlIG90aGVyIHRocmVh ZC4NCi0gICAgICAgIGlmIChfQVhTSXNvbGF0ZWRUcmVlTW9kZUZ1bmN0aW9uSXNBdmFpbGFibGUo KSAmJiBfQVhTSXNvbGF0ZWRUcmVlTW9kZV9Tb2Z0KCkgPT0gQVhTSXNvbGF0ZWRUcmVlTW9kZVNl Y29uZGFyeVRocmVhZCkNCi0gICAgICAgICAgICBfQVhVSUVsZW1lbnRVc2VTZWNvbmRhcnlBWFRo cmVhZCh0cnVlKTsNCi0gICAgICAgIF9BWFVJRWxlbWVudFVzZVNlY29uZGFyeUFYVGhyZWFkKHRy dWUpOw0KKyAgICAgICAgaW5pdGlhbGl6ZVNlY29uZGFyeUFYVGhyZWFkKCk7DQogICAgIH0NCiAN CiAgICAgaWYgKHRyZWUpDQpAQCAtNzQ5LDYgKzc0NSwxNSBAQCBBWENvcmVPYmplY3QqIEFYT2Jq ZWN0Q2FjaGU6OnJvb3RPYmplY3QoKQ0KIH0NCiANCiAjaWYgRU5BQkxFKEFDQ0VTU0lCSUxJVFlf SVNPTEFURURfVFJFRSkNCisNCit2b2lkIEFYT2JqZWN0Q2FjaGU6OmluaXRpYWxpemVTZWNvbmRh cnlBWFRocmVhZCgpDQorew0KKyAgICAvLyBOb3cgdGhhdCB3ZSBoYXZlIGNyZWF0ZWQgb3VyIHRy ZWUsIGluaXRpYWxpemUgdGhlIHNlY29uZGFyeSB0aHJlYWQsDQorICAgIC8vIHNvIGZ1dHVyZSBy ZXF1ZXN0cyBjb21lIGluIG9uIHRoZSBvdGhlciB0aHJlYWQuDQorICAgIGlmIChfQVhTSXNvbGF0 ZWRUcmVlTW9kZUZ1bmN0aW9uSXNBdmFpbGFibGUoKSAmJiBfQVhTSXNvbGF0ZWRUcmVlTW9kZV9T b2Z0KCkgPT0gQVhTSXNvbGF0ZWRUcmVlTW9kZVNlY29uZGFyeVRocmVhZCkNCisgICAgICAgIF9B WFVJRWxlbWVudFVzZVNlY29uZGFyeUFYVGhyZWFkKHRydWUpOw0KK30NCisNCiBBWENvcmVPYmpl Y3QqIEFYT2JqZWN0Q2FjaGU6Omlzb2xhdGVkVHJlZVJvb3RPYmplY3QoKQ0KIHsNCiAgICAgaWYg KCFtX3BhZ2VJRCkNCkBAIC03NTksMTEgKzc2NCw3IEBAIEFYQ29yZU9iamVjdCogQVhPYmplY3RD YWNoZTo6aXNvbGF0ZWRUcmVlUm9vdE9iamVjdCgpDQogICAgICAgICB0cmVlID0gQWNjZXNzaWJp bGl0eTo6cmV0cmlldmVWYWx1ZUZyb21NYWluVGhyZWFkPFJlZlB0cjxBWElzb2xhdGVkVHJlZT4+ KFt0aGlzXSAoKSAtPiBSZWZQdHI8QVhJc29sYXRlZFRyZWU+IHsNCiAgICAgICAgICAgICByZXR1 cm4gZ2VuZXJhdGVJc29sYXRlZFRyZWUoKm1fcGFnZUlELCBtX2RvY3VtZW50KTsNCiAgICAgICAg IH0pOw0KLQ0KLSAgICAgICAgLy8gTm93IHRoYXQgd2UgaGF2ZSBjcmVhdGVkIG91ciB0cmVlLCBp bml0aWFsaXplIHRoZSBzZWNvbmRhcnkgdGhyZWFkLA0KLSAgICAgICAgLy8gc28gZnV0dXJlIHJl cXVlc3RzIGNvbWUgaW4gb24gdGhlIG90aGVyIHRocmVhZC4NCi0gICAgICAgIGlmIChfQVhTSXNv bGF0ZWRUcmVlTW9kZUZ1bmN0aW9uSXNBdmFpbGFibGUoKSAmJiBfQVhTSXNvbGF0ZWRUcmVlTW9k ZV9Tb2Z0KCkgPT0gQVhTSXNvbGF0ZWRUcmVlTW9kZVNlY29uZGFyeVRocmVhZCkNCi0gICAgICAg ICAgICBfQVhVSUVsZW1lbnRVc2VTZWNvbmRhcnlBWFRocmVhZCh0cnVlKTsNCisgICAgICAgIGlu aXRpYWxpemVTZWNvbmRhcnlBWFRocmVhZCgpOw0KICAgICB9DQogDQogICAgIGlmICh0cmVlKQ0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5o IGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmgNCmluZGV4IDc2 ZGU4OTAwNDExLi44NDZhNzlmNTY2ZCAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvQVhPYmplY3RDYWNoZS5oDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FYT2JqZWN0Q2FjaGUuaA0KQEAgLTM2MCw2ICszNjAsNyBAQCBwcml2YXRlOg0KICAgICB2 b2lkIHNldElzb2xhdGVkVHJlZUZvY3VzZWRPYmplY3QoTm9kZSopOw0KICAgICBzdGF0aWMgUmVm PEFYSXNvbGF0ZWRUcmVlPiBnZW5lcmF0ZUlzb2xhdGVkVHJlZShQYWdlSWRlbnRpZmllciwgRG9j dW1lbnQmKTsNCiAgICAgdm9pZCB1cGRhdGVJc29sYXRlZFRyZWUoQVhDb3JlT2JqZWN0KiwgQVhO b3RpZmljYXRpb24pOw0KKyAgICB2b2lkIGluaXRpYWxpemVTZWNvbmRhcnlBWFRocmVhZCgpOw0K ICNlbmRpZg0KIA0KIHByb3RlY3RlZDo= 393299 2020-03-11 16:04:47 -0700 2020-03-11 16:56:48 -0700 Patch bug-208950-20200311190446.patch text/plain 3796 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDQxY2IxYTM0MTM0Yjk0 MjExNmMyYjk4YjRlYzk3ZGQ1YWFjMzA4NC4uMjhmNWNiNzRlODYzMDM0MmQzMWVjOTU2MGI1MGY5 Mzg0NjI5NTgxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAzLTExICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogSXNvbGF0 ZWQgdHJlZTogZW5hYmxpbmcgc2Vjb25kYXJ5IHRocmVhZCBmb3IgdGhlIHdyb25nIGNsaWVudHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODk1MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZWQg aW5jb3JyZWN0IGNhbGwgdG8gX0FYVUlFbGVtZW50VXNlU2Vjb25kYXJ5QVhUaHJlYWQgYW5kIHdy YXAgaXQKKyAgICAgICAgaW4gaW5pdGlhbGl6ZVNlY29uZGFyeUFYVGhyZWFkIHdpdGggdGhlIGFw cHJvcHJpYXRlIGNoZWNrcy4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNo ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjppc29sYXRlZFRyZWVGb2N1 c2VkT2JqZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkFYT2JqZWN0Q2FjaGU6OmluaXRpYWxpemVT ZWNvbmRhcnlBWFRocmVhZCk6CisgICAgICAgIChXZWJDb3JlOjpBWE9iamVjdENhY2hlOjppc29s YXRlZFRyZWVSb290T2JqZWN0KToKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2Fj aGUuaDoKKwogMjAyMC0wMy0xMCAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAg ICAgICAgU2V0IGltcG9ydGFudCBFR0wgY29udGV4dCBhdHRyaWJ1dGVzCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYT2JqZWN0Q2FjaGUuY3BwIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BWE9iamVjdENhY2hlLmNwcAppbmRleCBlMjVlYmMxMDk5ZjM1 YmUxZTllOWM2MmQwMGI3Y2RiYzgwNmUzYmIwLi5mY2FlOGFhZWE4ZDQyOWYyNWMxOTQ0YzFmODA4 NjgzODk4MTU2YzM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FY T2JqZWN0Q2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmpl Y3RDYWNoZS5jcHAKQEAgLTM5MiwxMSArMzkyLDcgQEAgQVhDb3JlT2JqZWN0KiBBWE9iamVjdENh Y2hlOjppc29sYXRlZFRyZWVGb2N1c2VkT2JqZWN0KERvY3VtZW50JiBkb2N1bWVudCkKICAgICBh dXRvIHRyZWUgPSBBWElzb2xhdGVkVHJlZTo6dHJlZUZvclBhZ2VJRCgqcGFnZUlEKTsKICAgICBp ZiAoIXRyZWUpIHsKICAgICAgICAgdHJlZSA9IGdlbmVyYXRlSXNvbGF0ZWRUcmVlKCpwYWdlSUQs IGRvY3VtZW50KTsKLSAgICAgICAgLy8gTm93IHRoYXQgd2UgaGF2ZSBjcmVhdGVkIG91ciB0cmVl LCBpbml0aWFsaXplIHRoZSBzZWNvbmRhcnkgdGhyZWFkLAotICAgICAgICAvLyBzbyBmdXR1cmUg cmVxdWVzdHMgY29tZSBpbiBvbiB0aGUgb3RoZXIgdGhyZWFkLgotICAgICAgICBpZiAoX0FYU0lz b2xhdGVkVHJlZU1vZGVGdW5jdGlvbklzQXZhaWxhYmxlKCkgJiYgX0FYU0lzb2xhdGVkVHJlZU1v ZGVfU29mdCgpID09IEFYU0lzb2xhdGVkVHJlZU1vZGVTZWNvbmRhcnlUaHJlYWQpCi0gICAgICAg ICAgICBfQVhVSUVsZW1lbnRVc2VTZWNvbmRhcnlBWFRocmVhZCh0cnVlKTsKLSAgICAgICAgX0FY VUlFbGVtZW50VXNlU2Vjb25kYXJ5QVhUaHJlYWQodHJ1ZSk7CisgICAgICAgIGluaXRpYWxpemVT ZWNvbmRhcnlBWFRocmVhZCgpOwogICAgIH0KIAogICAgIGlmICh0cmVlKQpAQCAtNzQ5LDYgKzc0 NSwxNSBAQCBBWENvcmVPYmplY3QqIEFYT2JqZWN0Q2FjaGU6OnJvb3RPYmplY3QoKQogfQogCiAj aWYgRU5BQkxFKEFDQ0VTU0lCSUxJVFlfSVNPTEFURURfVFJFRSkKKwordm9pZCBBWE9iamVjdENh Y2hlOjppbml0aWFsaXplU2Vjb25kYXJ5QVhUaHJlYWQoKQoreworICAgIC8vIE5vdyB0aGF0IHdl IGhhdmUgY3JlYXRlZCBvdXIgdHJlZSwgaW5pdGlhbGl6ZSB0aGUgc2Vjb25kYXJ5IHRocmVhZCwK KyAgICAvLyBzbyBmdXR1cmUgcmVxdWVzdHMgY29tZSBpbiBvbiB0aGUgb3RoZXIgdGhyZWFkLgor ICAgIGlmIChfQVhTSXNvbGF0ZWRUcmVlTW9kZUZ1bmN0aW9uSXNBdmFpbGFibGUoKSAmJiBfQVhT SXNvbGF0ZWRUcmVlTW9kZV9Tb2Z0KCkgPT0gQVhTSXNvbGF0ZWRUcmVlTW9kZVNlY29uZGFyeVRo cmVhZCkKKyAgICAgICAgX0FYVUlFbGVtZW50VXNlU2Vjb25kYXJ5QVhUaHJlYWQodHJ1ZSk7Cit9 CisKIEFYQ29yZU9iamVjdCogQVhPYmplY3RDYWNoZTo6aXNvbGF0ZWRUcmVlUm9vdE9iamVjdCgp CiB7CiAgICAgaWYgKCFtX3BhZ2VJRCkKQEAgLTc1OSwxMSArNzY0LDcgQEAgQVhDb3JlT2JqZWN0 KiBBWE9iamVjdENhY2hlOjppc29sYXRlZFRyZWVSb290T2JqZWN0KCkKICAgICAgICAgdHJlZSA9 IEFjY2Vzc2liaWxpdHk6OnJldHJpZXZlVmFsdWVGcm9tTWFpblRocmVhZDxSZWZQdHI8QVhJc29s YXRlZFRyZWU+PihbdGhpc10gKCkgLT4gUmVmUHRyPEFYSXNvbGF0ZWRUcmVlPiB7CiAgICAgICAg ICAgICByZXR1cm4gZ2VuZXJhdGVJc29sYXRlZFRyZWUoKm1fcGFnZUlELCBtX2RvY3VtZW50KTsK ICAgICAgICAgfSk7Ci0KLSAgICAgICAgLy8gTm93IHRoYXQgd2UgaGF2ZSBjcmVhdGVkIG91ciB0 cmVlLCBpbml0aWFsaXplIHRoZSBzZWNvbmRhcnkgdGhyZWFkLAotICAgICAgICAvLyBzbyBmdXR1 cmUgcmVxdWVzdHMgY29tZSBpbiBvbiB0aGUgb3RoZXIgdGhyZWFkLgotICAgICAgICBpZiAoX0FY U0lzb2xhdGVkVHJlZU1vZGVGdW5jdGlvbklzQXZhaWxhYmxlKCkgJiYgX0FYU0lzb2xhdGVkVHJl ZU1vZGVfU29mdCgpID09IEFYU0lzb2xhdGVkVHJlZU1vZGVTZWNvbmRhcnlUaHJlYWQpCi0gICAg ICAgICAgICBfQVhVSUVsZW1lbnRVc2VTZWNvbmRhcnlBWFRocmVhZCh0cnVlKTsKKyAgICAgICAg QVhPYmplY3RDYWNoZTo6aW5pdGlhbGl6ZVNlY29uZGFyeUFYVGhyZWFkKCk7CiAgICAgfQogCiAg ICAgaWYgKHRyZWUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FY T2JqZWN0Q2FjaGUuaCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNo ZS5oCmluZGV4IDc2ZGU4OTAwNDExOTAyZjExZjNhY2UzMGUzOWJiOTEwYjdjMTk2MjYuLmU3NDUy ODJiZTI3YTZmYjY4Zjk1ZDk5MzdjM2Y3NGJlNGZmYTNmMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oCkBAIC0zNjAsNiArMzYwLDcgQEAgcHJpdmF0 ZToKICAgICB2b2lkIHNldElzb2xhdGVkVHJlZUZvY3VzZWRPYmplY3QoTm9kZSopOwogICAgIHN0 YXRpYyBSZWY8QVhJc29sYXRlZFRyZWU+IGdlbmVyYXRlSXNvbGF0ZWRUcmVlKFBhZ2VJZGVudGlm aWVyLCBEb2N1bWVudCYpOwogICAgIHZvaWQgdXBkYXRlSXNvbGF0ZWRUcmVlKEFYQ29yZU9iamVj dCosIEFYTm90aWZpY2F0aW9uKTsKKyAgICBzdGF0aWMgdm9pZCBpbml0aWFsaXplU2Vjb25kYXJ5 QVhUaHJlYWQoKTsKICNlbmRpZgogCiBwcm90ZWN0ZWQ6Cg==