208947 2020-03-11 14:48:00 -0700 REGRESSION (r257502): HitTestLocation::HitTestLocation(const FloatPoint&, const FloatQuad&) should set m_isRectBased to true 2020-03-11 17:42:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 208254 1 dbates dbates esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1628857 0 dbates 2020-03-11 14:48:00 -0700 In bug #208254 I inadvertently removed setting m_isRectBased to true in the constructor HitTestLocation::HitTestLocation(const FloatPoint&, const FloatQuad&). So, it is now set to false. This does not match the original intention of the code and should be reverted. 1628860 1 393290 dbates 2020-03-11 14:52:37 -0700 Created attachment 393290 Patch 1628863 2 393290 dbates 2020-03-11 14:57:38 -0700 Comment on attachment 393290 Patch Clearing flags on attachment: 393290 Committed r258287: <https://trac.webkit.org/changeset/258287> 1628864 3 dbates 2020-03-11 14:57:39 -0700 All reviewed patches have been landed. Closing bug. 1628866 4 webkit-bug-importer 2020-03-11 14:58:16 -0700 <rdar://problem/60342598> 1628949 5 simon.fraser 2020-03-11 17:35:33 -0700 Did the error cause layout test failures? Should this patch have landed with a test? 1628952 6 dbates 2020-03-11 17:42:26 -0700 (In reply to Simon Fraser (smfr) from comment #5) > Did the error cause layout test failures? Should this patch have landed with > a test? I don't know. I found this issue by code inspection. When I have a moment I will look to write one. 393290 2020-03-11 14:52:37 -0700 2020-03-11 14:57:38 -0700 Patch bug-208947-20200311145237.patch text/plain 1604 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTEwYjhlZWY4YjhmZDdk YjlkZjRmNmI3ZjI2MDA2NGM5ZDI3ZDZhYi4uMGE5ZDY0Y2QyNGU2YWE4NzhlYzI4ZDhiYjhlMThl ZjU0YWQzMjI5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTExICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjU3 NTAyKTogSGl0VGVzdExvY2F0aW9uOjpIaXRUZXN0TG9jYXRpb24oY29uc3QgRmxvYXRQb2ludCYs IGNvbnN0IEZsb2F0UXVhZCYpIHNob3VsZCBzZXQgbV9pc1JlY3RCYXNlZCB0byB0cnVlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg5NDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQYXJ0aWFsIHJldmVy dCBvZiByMjU3NTAyLiBJIGFjY2lkZW50YWxseSByZW1vdmVkIGluaXRpYWxpemF0aW9uIG9mIG1f aXNSZWN0QmFzZWQgd2hlbiByZWZhY3RvcmluZworICAgICAgICB0aGUgY29kZSBpbiBIaXRUZXN0 TG9jYXRpb246OkhpdFRlc3RMb2NhdGlvbihjb25zdCBGbG9hdFBvaW50JiwgY29uc3QgRmxvYXRR dWFkJikuIFJldmVydCB0aGlzIHRvCisgICAgICAgIGJlIGZhaXRoZnVsIHRvIHRoZSBjb2RlIGJl Zm9yZSBteSBjaGFuZ2UuCisKKyAgICAgICAgKiByZW5kZXJpbmcvSGl0VGVzdExvY2F0aW9uLmNw cDoKKwogMjAyMC0wMy0xMCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAg ICAgICAgRm9jdXNDb250cm9sbGVyOjpzZXRGb2N1c2VkRWxlbWVudCgpIHNob3VsZCB0ZWxsIGNs aWVudCBvZiByZWZvY3VzZWQgZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL0hpdFRlc3RMb2NhdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0 VGVzdExvY2F0aW9uLmNwcAppbmRleCBhNTYxM2I4MzFmNGZlZjY1ZTNjYmQ2MzkxMjQxODFmMTVi OTVjYWNhLi4xNjFmMjI5NWUxODM5NDVkNmE5ODY4Y2Q0YmQ1Y2FmNzVhYjMzMTAyIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdExvY2F0aW9uLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdExvY2F0aW9uLmNwcApAQCAtNDQsNiArNDQs NyBAQCBIaXRUZXN0TG9jYXRpb246OkhpdFRlc3RMb2NhdGlvbihjb25zdCBGbG9hdFBvaW50JiBw b2ludCwgY29uc3QgRmxvYXRRdWFkJiBxdWFkKQogICAgICwgbV9ib3VuZGluZ0JveCB7IHF1YWQu ZW5jbG9zaW5nQm91bmRpbmdCb3goKSB9CiAgICAgLCBtX3RyYW5zZm9ybWVkUG9pbnQgeyBwb2lu dCB9CiAgICAgLCBtX3RyYW5zZm9ybWVkUmVjdCB7IHF1YWQgfQorICAgICwgbV9pc1JlY3RCYXNl ZCB7IHRydWUgfQogICAgICwgbV9pc1JlY3RpbGluZWFyIHsgcXVhZC5pc1JlY3RpbGluZWFyKCkg fQogewogfQo=