<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>208945</bug_id>
          
          <creation_ts>2020-03-11 14:05:59 -0700</creation_ts>
          <short_desc>[macOS] Crash under WebKit::WebProcessPool::platformInitialize()</short_desc>
          <delta_ts>2020-03-11 15:19:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Per Arne Vollan">pvollan</reporter>
          <assigned_to name="Per Arne Vollan">pvollan</assigned_to>
          <cc>benjamin</cc>
    
    <cc>bfulgham</cc>
    
    <cc>cdumez</cc>
    
    <cc>cmarcelo</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1628842</commentid>
    <comment_count>0</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-03-11 14:05:59 -0700</bug_when>
    <thetext>Fix null pointer crash on macOS under WebKit::WebProcessPool::platformInitialize().</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628843</commentid>
    <comment_count>1</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-03-11 14:06:14 -0700</bug_when>
    <thetext>rdar://problem/60330751</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628846</commentid>
    <comment_count>2</comment_count>
      <attachid>393287</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-03-11 14:12:13 -0700</bug_when>
    <thetext>Created attachment 393287
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628847</commentid>
    <comment_count>3</comment_count>
      <attachid>393287</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2020-03-11 14:19:36 -0700</bug_when>
    <thetext>Comment on attachment 393287
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393287&amp;action=review

r=me

&gt; Source/WTF/wtf/cocoa/SoftLinking.h:53
&gt; +}

I am shocked this doesn&apos;t already exist -- but it doesn&apos;t!

&gt; Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:702
&gt; +        [[NSNotificationCenter defaultCenter] removeObserver:m_accessibilityEnabledObserver.get()];

Isn&apos;t it okay to remove nil objects? I can&apos;t remember (though of course, some containers blow up if you use nil things so maybe this is one of those cases).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628849</commentid>
    <comment_count>4</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-03-11 14:25:58 -0700</bug_when>
    <thetext>Committed r258284: &lt;https://trac.webkit.org/changeset/258284/webkit&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628850</commentid>
    <comment_count>5</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-03-11 14:31:25 -0700</bug_when>
    <thetext>(In reply to Brent Fulgham from comment #3)
&gt; Comment on attachment 393287 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=393287&amp;action=review
&gt; 
&gt; r=me
&gt; 
&gt; &gt; Source/WTF/wtf/cocoa/SoftLinking.h:53
&gt; &gt; +}
&gt; 
&gt; I am shocked this doesn&apos;t already exist -- but it doesn&apos;t!
&gt; 
&gt; &gt; Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:702
&gt; &gt; +        [[NSNotificationCenter defaultCenter] removeObserver:m_accessibilityEnabledObserver.get()];
&gt; 
&gt; Isn&apos;t it okay to remove nil objects? I can&apos;t remember (though of course,
&gt; some containers blow up if you use nil things so maybe this is one of those
&gt; cases).

I believe the null check is needed.

Thanks for reviewing!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628861</commentid>
    <comment_count>6</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-03-11 14:56:02 -0700</bug_when>
    <thetext>Reopening to attach new patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628862</commentid>
    <comment_count>7</comment_count>
      <attachid>393291</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-03-11 14:56:03 -0700</bug_when>
    <thetext>Created attachment 393291
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628867</commentid>
    <comment_count>8</comment_count>
      <attachid>393291</attachid>
    <who name="Brent Fulgham">bfulgham</who>
    <bug_when>2020-03-11 14:58:47 -0700</bug_when>
    <thetext>Comment on attachment 393291
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=393291&amp;action=review

Looks like Tim already got it, but r=me, too!

&gt; Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:458
&gt; +    if (libAccessibilityLibrary() &amp;&amp; _AXSApplicationAccessibilityEnabled()) {

Oops!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628871</commentid>
    <comment_count>9</comment_count>
      <attachid>393292</attachid>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-03-11 15:17:34 -0700</bug_when>
    <thetext>Created attachment 393292
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1628872</commentid>
    <comment_count>10</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-03-11 15:19:06 -0700</bug_when>
    <thetext>Committed unreviewed build fix: &lt;https://trac.webkit.org/changeset/258289/webkit&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>393287</attachid>
            <date>2020-03-11 14:12:13 -0700</date>
            <delta_ts>2020-03-11 14:19:36 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-208945-20200311141212.patch</filename>
            <type>text/plain</type>
            <size>4372</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh
bmdlTG9nCShyZXZpc2lvbiAyNTgyNjYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu
ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAzLTExICBQZXIgQXJuZSBWb2xsYW4gIDxw
dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIENyYXNoIHVuZGVyIFdlYktpdDo6
V2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZSgpCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg5NDUKKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWFjcm8gdG8gb3B0aW9uYWxseSBzb2Z0
IGxpbmsgbGlicmFyeS4KKworICAgICAgICAqIHd0Zi9jb2NvYS9Tb2Z0TGlua2luZy5oOgorCiAy
MDIwLTAzLTA5ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAg
ICAgICAgQnVpbGQgRml4CkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9jb2NvYS9Tb2Z0TGlua2luZy5o
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL2NvY29hL1NvZnRMaW5raW5nLmgJKHJldmlz
aW9uIDI1ODI2NikKKysrIFNvdXJjZS9XVEYvd3RmL2NvY29hL1NvZnRMaW5raW5nLmgJKHdvcmtp
bmcgY29weSkKQEAgLTQyLDYgKzQyLDE2IEBACiAgICAgICAgIHJldHVybiBkeWxpYjsgXAogICAg
IH0KIAorI2RlZmluZSBTT0ZUX0xJTktfTElCUkFSWV9PUFRJT05BTChsaWIpIFwKK3N0YXRpYyB2
b2lkKiBsaWIjI0xpYnJhcnkoKSBcCit7IFwKKyAgICBzdGF0aWMgdm9pZCogZHlsaWIgPSBeeyBc
CisgICAgICAgIHZvaWQgKnJlc3VsdCA9IGRsb3BlbigiL3Vzci9saWIvIiAjbGliICIuZHlsaWIi
LCBSVExEX05PVyk7IFwKKyAgICAgICAgcmV0dXJuIHJlc3VsdDsgXAorICAgIH0oKTsgXAorICAg
IHJldHVybiBkeWxpYjsgXAorfQorCiAjZGVmaW5lIFNPRlRfTElOS19GUkFNRVdPUksoZnJhbWV3
b3JrKSBcCiAgICAgc3RhdGljIHZvaWQqIGZyYW1ld29yayMjTGlicmFyeSgpIFwKICAgICB7IFwK
SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTgyODMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAzLTExICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIENyYXNoIHVuZGVy
IFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZSgpCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg5NDUKKyAgICAgICAgPHJk
YXI6Ly9wcm9ibGVtLzYwMzMwNzUxPgorICAgICAgICAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hlY2sgdGhhdCBhY2Nlc3NpYmlsaXR5IGxpYnJhcnkg
aXMgcHJlc2VudCBiZWZvcmUgYXR0ZW1wdGluZyB0byB1c2UgY29uc3RhbnRzIGZyb20gaXQuCisK
KyAgICAgICAgTm8gbmV3IHRlc3RzLCBzaW5jZSBJIGFtIHVuYWJsZSB0byByZXByb2R1Y2UuCisK
KyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbToKKyAgICAg
ICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnJlZ2lzdGVyTm90aWZpY2F0aW9uT2JzZXJ2ZXJz
KToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnVucmVnaXN0ZXJOb3RpZmljYXRp
b25PYnNlcnZlcnMpOgorCiAyMDIwLTAzLTExICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu
c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRW5hYmxlIHNhZmUgYnJvd3Npbmcgd2FybmluZ3Mg
aW4gTWFjIENhdGFseXN0IFdlYktpdApJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29j
b2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJ
UHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1tCShyZXZpc2lvbiAyNTgyNjYpCisr
KyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1tCSh3
b3JraW5nIGNvcHkpCkBAIC0xMTgsNiArMTE4LDEwIEBAIFNPRlRfTElOS19QUklWQVRFX0ZSQU1F
V09SSyhCYWNrQm9hcmRTZXIKIFNPRlRfTElOSyhCYWNrQm9hcmRTZXJ2aWNlcywgQktTRGlzcGxh
eUJyaWdodG5lc3NHZXRDdXJyZW50LCBmbG9hdCwgKCksICgpKTsKICNlbmRpZgogCisjaWYgUExB
VEZPUk0oQ09DT0EpCitTT0ZUX0xJTktfTElCUkFSWV9PUFRJT05BTChsaWJBY2Nlc3NpYmlsaXR5
KQorI2VuZGlmCisKICNkZWZpbmUgV0VCUFJPQ0VTU1BPT0xfUkVMRUFTRV9MT0coY2hhbm5lbCwg
Zm10LCAuLi4pIFJFTEVBU0VfTE9HKGNoYW5uZWwsICIlcCAtIFdlYlByb2Nlc3NQb29sOjoiIGZt
dCwgdGhpcywgIyNfX1ZBX0FSR1NfXykKIAogbmFtZXNwYWNlIFdlYktpdCB7CkBAIC02NjIsMTIg
KzY2NiwxNCBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjpyZWdpc3Rlck5vdGlmaWNhdGlvCiAjZW5k
aWYKICNlbmRpZiAvLyBQTEFURk9STShJT1MpCiAjZW5kaWYgLy8gIVBMQVRGT1JNKElPU19GQU1J
TFkpCi0gICAgbV9hY2Nlc3NpYmlsaXR5RW5hYmxlZE9ic2VydmVyID0gW1tOU05vdGlmaWNhdGlv
bkNlbnRlciBkZWZhdWx0Q2VudGVyXSBhZGRPYnNlcnZlckZvck5hbWU6KF9fYnJpZGdlIGlkKWtB
WFNBcHBsaWNhdGlvbkFjY2Vzc2liaWxpdHlFbmFibGVkTm90aWZpY2F0aW9uIG9iamVjdDpuaWwg
cXVldWU6W05TT3BlcmF0aW9uUXVldWUgY3VycmVudFF1ZXVlXSB1c2luZ0Jsb2NrOl4oTlNOb3Rp
ZmljYXRpb24gKikgewotICAgICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fcHJvY2Vzc2Vz
LnNpemUoKTsgKytpKSB7Ci0gICAgICAgICAgICBtX3Byb2Nlc3Nlc1tpXS0+dW5ibG9ja1ByZWZl
cmVuY2VTZXJ2aWNlSWZOZWVkZWQoKTsKLSAgICAgICAgICAgIG1fcHJvY2Vzc2VzW2ldLT51bmJs
b2NrQWNjZXNzaWJpbGl0eVNlcnZlcklmTmVlZGVkKCk7Ci0gICAgICAgIH0KLSAgICB9XTsKKyAg
ICBpZiAobGliQWNjZXNzaWJpbGl0eUxpYnJhcnkoKSkgeworICAgICAgICBtX2FjY2Vzc2liaWxp
dHlFbmFibGVkT2JzZXJ2ZXIgPSBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJd
IGFkZE9ic2VydmVyRm9yTmFtZTooX19icmlkZ2UgaWQpa0FYU0FwcGxpY2F0aW9uQWNjZXNzaWJp
bGl0eUVuYWJsZWROb3RpZmljYXRpb24gb2JqZWN0Om5pbCBxdWV1ZTpbTlNPcGVyYXRpb25RdWV1
ZSBjdXJyZW50UXVldWVdIHVzaW5nQmxvY2s6XihOU05vdGlmaWNhdGlvbiAqKSB7CisgICAgICAg
ICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IG1fcHJvY2Vzc2VzLnNpemUoKTsgKytpKSB7Cisg
ICAgICAgICAgICAgICAgbV9wcm9jZXNzZXNbaV0tPnVuYmxvY2tQcmVmZXJlbmNlU2VydmljZUlm
TmVlZGVkKCk7CisgICAgICAgICAgICAgICAgbV9wcm9jZXNzZXNbaV0tPnVuYmxvY2tBY2Nlc3Np
YmlsaXR5U2VydmVySWZOZWVkZWQoKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfV07CisgICAg
fQogfQogCiB2b2lkIFdlYlByb2Nlc3NQb29sOjp1bnJlZ2lzdGVyTm90aWZpY2F0aW9uT2JzZXJ2
ZXJzKCkKQEAgLTY5Miw3ICs2OTgsOCBAQCB2b2lkIFdlYlByb2Nlc3NQb29sOjp1bnJlZ2lzdGVy
Tm90aWZpY2F0CiAjZW5kaWYKICNlbmRpZiAvLyBQTEFURk9STShJT1MpCiAjZW5kaWYgLy8gIVBM
QVRGT1JNKElPU19GQU1JTFkpCi0gICAgW1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2Vu
dGVyXSByZW1vdmVPYnNlcnZlcjptX2FjY2Vzc2liaWxpdHlFbmFibGVkT2JzZXJ2ZXIuZ2V0KCld
OworICAgIGlmIChtX2FjY2Vzc2liaWxpdHlFbmFibGVkT2JzZXJ2ZXIuZ2V0KCkpCisgICAgICAg
IFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gcmVtb3ZlT2JzZXJ2ZXI6bV9h
Y2Nlc3NpYmlsaXR5RW5hYmxlZE9ic2VydmVyLmdldCgpXTsKIH0KIAogc3RhdGljIENGVVJMU3Rv
cmFnZVNlc3Npb25SZWYgcHJpdmF0ZUJyb3dzaW5nU2Vzc2lvbigpCg==
</data>
<flag name="review"
          id="408663"
          type_id="1"
          status="+"
          setter="bfulgham"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>393291</attachid>
            <date>2020-03-11 14:56:03 -0700</date>
            <delta_ts>2020-03-11 14:57:51 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-208945-20200311145602.patch</filename>
            <type>text/plain</type>
            <size>2536</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTgyODYpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAzLTExICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIENyYXNoIHVuZGVy
IFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZSgpCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg5NDUKKworICAgICAgICBS
ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGVjayB0aGF0IGFjY2Vzc2li
aWxpdHkgbGlicmFyeSBpcyBwcmVzZW50IGJlZm9yZSBhdHRlbXB0aW5nIHRvIGNhbGwgZnVuY3Rp
b25zIGluIGl0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgc2luY2UgSSBhbSBub3QgYWJsZSB0
byByZXByb2R1Y2UuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xD
b2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlh
bGl6ZVdlYlByb2Nlc3MpOgorICAgICAgICAqIFVJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUHJv
eHlDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzc1Byb3h5Ojp1bmJsb2NrQWNj
ZXNzaWJpbGl0eVNlcnZlcklmTmVlZGVkKToKKwogMjAyMC0wMy0xMSAgUGVyIEFybmUgVm9sbGFu
ICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBDcmFzaCB1bmRlciBXZWJL
aXQ6OldlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemUoKQpJbmRleDogU291cmNlL1dl
YktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Bvb2xDb2NvYS5tbQo9PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t
LSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9jZXNzUG9vbENvY29hLm1tCShy
ZXZpc2lvbiAyNTgyODQpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9XZWJQcm9j
ZXNzUG9vbENvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00NTUsNyArNDU1LDcgQEAgdm9pZCBX
ZWJQcm9jZXNzUG9vbDo6cGxhdGZvcm1Jbml0aWFsaXplVwogICAgIH0KIAogI2lmIEVOQUJMRShD
RlBSRUZTX0RJUkVDVF9NT0RFKQotICAgIGlmIChfQVhTQXBwbGljYXRpb25BY2Nlc3NpYmlsaXR5
RW5hYmxlZCgpKSB7CisgICAgaWYgKGxpYkFjY2Vzc2liaWxpdHlMaWJyYXJ5KCkgJiYgX0FYU0Fw
cGxpY2F0aW9uQWNjZXNzaWJpbGl0eUVuYWJsZWQoKSkgewogICAgICAgICBTYW5kYm94RXh0ZW5z
aW9uOjpIYW5kbGUgcHJlZmVyZW5jZXNFeHRlbnNpb25IYW5kbGU7CiAgICAgICAgIFNhbmRib3hF
eHRlbnNpb246OmNyZWF0ZUhhbmRsZUZvck1hY2hMb29rdXAoImNvbS5hcHBsZS5jZnByZWZzZC5k
YWVtb24iLCBXVEY6Om51bGxvcHQsIHByZWZlcmVuY2VzRXh0ZW5zaW9uSGFuZGxlKTsKICAgICAg
ICAgcGFyYW1ldGVycy5wcmVmZXJlbmNlc0V4dGVuc2lvbkhhbmRsZSA9IFdURk1vdmUocHJlZmVy
ZW5jZXNFeHRlbnNpb25IYW5kbGUpOwpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29j
b2EvV2ViUHJvY2Vzc1Byb3h5Q29jb2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9V
SVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Byb3h5Q29jb2EubW0JKHJldmlzaW9uIDI1ODI4MykK
KysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQcm94eUNvY29hLm1t
CSh3b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCwxMCBAQAogI2ltcG9ydCA8SmF2YVNjcmlwdENv
cmUvUmVtb3RlSW5zcGVjdG9yQ29uc3RhbnRzLmg+CiAjZW5kaWYKIAorI2lmIFBMQVRGT1JNKENP
Q09BKQorU09GVF9MSU5LX0xJQlJBUllfT1BUSU9OQUwobGliQWNjZXNzaWJpbGl0eSkKKyNlbmRp
ZgorCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAogc3RhdGljIGNvbnN0IFNlY29uZHMgdW5leHBlY3Rl
ZEFjdGl2aXR5RHVyYXRpb24gPSAxMF9zOwpAQCAtMjEwLDYgKzIxNCw4IEBAIHZvaWQgV2ViUHJv
Y2Vzc1Byb3h5Ojp1bmJsb2NrQWNjZXNzaWJpbGkKIHsKICAgICBpZiAobV9oYXNTZW50TWVzc2Fn
ZVRvVW5ibG9ja0FjY2Vzc2liaWxpdHlTZXJ2ZXIpCiAgICAgICAgIHJldHVybjsKKyAgICBpZiAo
IWxpYkFjY2Vzc2liaWxpdHlMaWJyYXJ5KCkpCisgICAgICAgIHJldHVybjsKICAgICBpZiAoIV9B
WFNBcHBsaWNhdGlvbkFjY2Vzc2liaWxpdHlFbmFibGVkKCkpCiAgICAgICAgIHJldHVybjsKICAg
ICBpZiAoIXByb2Nlc3NJZGVudGlmaWVyKCkpCg==
</data>
<flag name="review"
          id="408666"
          type_id="1"
          status="+"
          setter="thorton"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>393292</attachid>
            <date>2020-03-11 15:17:34 -0700</date>
            <delta_ts>2020-03-11 15:17:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-208945-20200311151732.patch</filename>
            <type>text/plain</type>
            <size>1684</size>
            <attacher name="Per Arne Vollan">pvollan</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL
aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTgyODgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv
Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTExICBQZXIgQXJuZSBW
b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIENyYXNoIHVuZGVy
IFdlYktpdDo6V2ViUHJvY2Vzc1Bvb2w6OnBsYXRmb3JtSW5pdGlhbGl6ZSgpCisgICAgICAgIGh0
dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg5NDUKKworICAgICAgICBV
bnJldmlld2VkIHRlbXBvcmFyeSBjb21waWxlIGZpeC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9D
b2NvYS9XZWJQcm9jZXNzUHJveHlDb2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vz
c1Byb3h5Ojp1bmJsb2NrQWNjZXNzaWJpbGl0eVNlcnZlcklmTmVlZGVkKToKKwogMjAyMC0wMy0x
MSAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09T
XSBDcmFzaCB1bmRlciBXZWJLaXQ6OldlYlByb2Nlc3NQb29sOjpwbGF0Zm9ybUluaXRpYWxpemUo
KQpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUHJvY2Vzc1Byb3h5Q29j
b2EubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvV2ViUHJv
Y2Vzc1Byb3h5Q29jb2EubW0JKHJldmlzaW9uIDI1ODI4OCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQ
cm9jZXNzL0NvY29hL1dlYlByb2Nlc3NQcm94eUNvY29hLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00
NCwxMiArNDQsMTIgQEAKICNpbXBvcnQgPEphdmFTY3JpcHRDb3JlL1JlbW90ZUluc3BlY3RvckNv
bnN0YW50cy5oPgogI2VuZGlmCiAKLSNpZiBQTEFURk9STShDT0NPQSkKK25hbWVzcGFjZSBXZWJL
aXQgeworCisjaWYgUExBVEZPUk0oTUFDKQogU09GVF9MSU5LX0xJQlJBUllfT1BUSU9OQUwobGli
QWNjZXNzaWJpbGl0eSkKICNlbmRpZgogCi1uYW1lc3BhY2UgV2ViS2l0IHsKLQogc3RhdGljIGNv
bnN0IFNlY29uZHMgdW5leHBlY3RlZEFjdGl2aXR5RHVyYXRpb24gPSAxMF9zOwogCiBjb25zdCBI
YXNoU2V0PFN0cmluZz4mIFdlYlByb2Nlc3NQcm94eTo6cGxhdGZvcm1QYXRoc1dpdGhBc3N1bWVk
UmVhZEFjY2VzcygpCkBAIC0yMTQsOCArMjE0LDEwIEBAIHZvaWQgV2ViUHJvY2Vzc1Byb3h5Ojp1
bmJsb2NrQWNjZXNzaWJpbGkKIHsKICAgICBpZiAobV9oYXNTZW50TWVzc2FnZVRvVW5ibG9ja0Fj
Y2Vzc2liaWxpdHlTZXJ2ZXIpCiAgICAgICAgIHJldHVybjsKLSAgICBpZiAoIWxpYkFjY2Vzc2li
aWxpdHlMaWJyYXJ5KCkpCisjaWYgUExBVEZPUk0oTUFDKQorICAgIGlmICghV2ViS2l0OjpsaWJB
Y2Nlc3NpYmlsaXR5TGlicmFyeSgpKQogICAgICAgICByZXR1cm47CisjZW5kaWYKICAgICBpZiAo
IV9BWFNBcHBsaWNhdGlvbkFjY2Vzc2liaWxpdHlFbmFibGVkKCkpCiAgICAgICAgIHJldHVybjsK
ICAgICBpZiAoIXByb2Nlc3NJZGVudGlmaWVyKCkpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>