208936 2020-03-11 12:37:39 -0700 [GPU Process] encodeNativeImage() should pass imageSize to GraphicsContext::drawNativeImage() 2020-03-11 21:26:17 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue dino mmaxfield simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1628792 0 sabouhallawa 2020-03-11 12:37:39 -0700 The current call in encodeNativeImage() passes an empty FloatSize for the argument 'imageSize'. This causes the NativeImage not be be drawn to the ShareableBitmap. So encoding the NativeImage was always sending zero image from the WebProcess to the GPUProcess. 1628794 1 393277 sabouhallawa 2020-03-11 12:44:02 -0700 Created attachment 393277 Patch 1628795 2 sabouhallawa 2020-03-11 12:44:35 -0700 This patch lowers the failures of the command run-webkit-tests --debug --no-retry LayoutTests/canvas/ LayoutTests/fast/canvas --internal-feature RenderCanvasInGPUProcessEnabled from 69 to 45 (after the patch of https://bugs.webkit.org/show_bug.cgi?id=208876 and https://bugs.webkit.org/show_bug.cgi?id=208931). 1629031 3 393277 commit-queue 2020-03-11 21:25:04 -0700 Comment on attachment 393277 Patch Clearing flags on attachment: 393277 Committed r258312: <https://trac.webkit.org/changeset/258312> 1629032 4 commit-queue 2020-03-11 21:25:05 -0700 All reviewed patches have been landed. Closing bug. 1629036 5 webkit-bug-importer 2020-03-11 21:26:17 -0700 <rdar://problem/60355796> 393277 2020-03-11 12:44:02 -0700 2020-03-11 21:25:04 -0700 Patch bug-208936-20200311124402.patch text/plain 1604 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc4M2EwYTBmOWI5ZWZhZTZl NzM4MGMzMTc0YjVjOThmZDM2MTlhOTMuLmVlNzVhZjAyMWJhZDNiNWFhMmUyZGRjNWU3MTEwM2Jm NjAyYTMwMjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDMtMTEgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVIFByb2Nl c3NdIGVuY29kZU5hdGl2ZUltYWdlKCkgc2hvdWxkIHBhc3MgaW1hZ2VTaXplIHRvIEdyYXBoaWNz Q29udGV4dDo6ZHJhd05hdGl2ZUltYWdlKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwODkzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFBhc3NpbmcgYW4gZW1wdHkgRmxvYXRTaXplIG1ha2VzIGRyYXdO YXRpdmVJbWFnZSgpIGRyYXdzIG5vdGhpbmcgdG8KKyAgICAgICAgdGhlIFNoYXJlYWJsZUJpdG1h cAorCisgICAgICAgICogU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHA6CisgICAgICAg IChJUEM6OmVuY29kZU5hdGl2ZUltYWdlKToKKwogMjAyMC0wMy0xMCAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgRG8gbm90IGNyZWF0ZSBhIHNlcnZpY2Ugd29y a2VyIGNvbm5lY3Rpb24gaWYgc2VydmljZSB3b3JrZXIgaXMgbm90IGVuYWJsZWQgaW4gbmV0d29y ayBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJDb3JlQXJndW1l bnRDb2RlcnMuY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJz LmNwcAppbmRleCAzY2ViNGM3N2U1OTA4NDIyOWE0MDU5Mzk4NmRiM2VjZTBhMWE3OGRjLi5hZDdm MWQxOTE3MWU5NzZhNDAyNDZhYWUzYzc5NTU3ODFlOTE5NGU2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC9XZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHAKQEAgLTEwODIsNyArMTA4Miw3IEBA IHN0YXRpYyB2b2lkIGVuY29kZU5hdGl2ZUltYWdlKEVuY29kZXImIGVuY29kZXIsIE5hdGl2ZUlt YWdlUHRyIGltYWdlKQogICAgIGlmICghZ3JhcGhpY3NDb250ZXh0KQogICAgICAgICByZXR1cm47 CiAKLSAgICBncmFwaGljc0NvbnRleHQtPmRyYXdOYXRpdmVJbWFnZShpbWFnZSwgeyB9LCBGbG9h dFJlY3QoeyB9LCBpbWFnZVNpemUpLCBGbG9hdFJlY3QoeyB9LCBpbWFnZVNpemUpKTsKKyAgICBn cmFwaGljc0NvbnRleHQtPmRyYXdOYXRpdmVJbWFnZShpbWFnZSwgaW1hZ2VTaXplLCBGbG9hdFJl Y3QoeyB9LCBpbWFnZVNpemUpLCBGbG9hdFJlY3QoeyB9LCBpbWFnZVNpemUpKTsKIAogICAgIFNo YXJlYWJsZUJpdG1hcDo6SGFuZGxlIGhhbmRsZTsKICAgICBiaXRtYXAtPmNyZWF0ZUhhbmRsZSho YW5kbGUpOwo=