208931 2020-03-11 11:22:45 -0700 [GPU Process] RemoteImageBuffer::getImageData() has to clear its DisplayList after calling flushDrawingContext() 2020-03-11 21:21:18 -0700 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa commit-queue dino mmaxfield simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1628766 0 sabouhallawa 2020-03-11 11:22:45 -0700 Otherwise the same drawing commands will be replayed back anytime the backend is checked for uncommitted drawing. 1628768 1 393269 sabouhallawa 2020-03-11 11:27:52 -0700 Created attachment 393269 Patch 1628782 2 sabouhallawa 2020-03-11 12:16:42 -0700 This patch lowers the failures of the command run-webkit-tests --debug --no-retry LayoutTests/canvas/ LayoutTests/fast/canvas --internal-feature RenderCanvasInGPUProcessEnabled from 100 to 68 (after the patch of https://bugs.webkit.org/show_bug.cgi?id=208876). 1629028 3 393269 commit-queue 2020-03-11 21:20:03 -0700 Comment on attachment 393269 Patch Clearing flags on attachment: 393269 Committed r258311: <https://trac.webkit.org/changeset/258311> 1629029 4 commit-queue 2020-03-11 21:20:05 -0700 All reviewed patches have been landed. Closing bug. 1629030 5 webkit-bug-importer 2020-03-11 21:21:18 -0700 <rdar://problem/60355642> 393269 2020-03-11 11:27:52 -0700 2020-03-11 21:20:03 -0700 Patch bug-208931-20200311112752.patch text/plain 5880 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc4M2EwYTBmOWI5ZWZhZTZl NzM4MGMzMTc0YjVjOThmZDM2MTlhOTMuLjljZGJkMzc2MjIzODU4NDIyZjBmZGNhOTQ3NWM0NGNh YWJiNjFkN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDMtMTEgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2Fib3VoYWxsYXdhQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdGVJbWFn ZUJ1ZmZlcjo6Z2V0SW1hZ2VEYXRhKCkgaGFzIHRvIGNsZWFyIGl0cyBEaXNwbGF5TGlzdCBhZnRl ciBjYWxsaW5nIGZsdXNoRHJhd2luZ0NvbnRleHQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4OTMxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVhZCBvZiBsZXR0aW5nIGV2ZXJ5IGNhbGxlciB0 byBmbHVzaERyYXdpbmdDb250ZXh0QW5kV2FpdENvbW1pdCgpIG9yCisgICAgICAgIGZsdXNoRHJh d2luZ0NvbnRleHQoKSBiZSByZXNwb25zaWJsZSBvZiBjbGVhcmluZyB0aGUgRGlzcGxheUxpc3Qs IHdlIGNhbgorICAgICAgICBtYWtlIHRoZXNlIGZ1bmN0aW9ucyB0YWtlIHRoaXMgcmVzcG9uc2li aWxpdHkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVJbWFnZUJ1 ZmZlci5oOgorICAgICAgICAqIFdlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVm ZmVyTWVzc2FnZUhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVJbWFnZUJ1ZmZl ck1lc3NhZ2VIYW5kbGVyOjpmbHVzaERyYXdpbmdDb250ZXh0KToKKyAgICAgICAgKFdlYktpdDo6 UmVtb3RlSW1hZ2VCdWZmZXJNZXNzYWdlSGFuZGxlcjo6Zmx1c2hEcmF3aW5nQ29udGV4dEFuZFdh aXRDb21taXQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdl QnVmZmVyTWVzc2FnZUhhbmRsZXIuaDoKKwogMjAyMC0wMy0xMCAgWW91ZW5uIEZhYmxldCAgPHlv dWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgRG8gbm90IGNyZWF0ZSBhIHNlcnZpY2Ugd29ya2Vy IGNvbm5lY3Rpb24gaWYgc2VydmljZSB3b3JrZXIgaXMgbm90IGVuYWJsZWQgaW4gbmV0d29yayBw cm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNz L1JlbW90ZUltYWdlQnVmZmVyLmggYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBo aWNzL1JlbW90ZUltYWdlQnVmZmVyLmgKaW5kZXggZWZlMDE3NDk2Y2FjYjUwYmMyMjk1MjlkOGYz YTQzMDBhZmU3YWFlOC4uMjZmZTUwZjE5ZWI3NDIzYzdhYzY4OGUxMjNlZDgxNzQ2ZjA5Mzk5ZiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVJ bWFnZUJ1ZmZlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3Mv UmVtb3RlSW1hZ2VCdWZmZXIuaApAQCAtNzUsNyArNzUsNyBAQCBwcm90ZWN0ZWQ6CiAKICAgICBS ZWZQdHI8V2ViQ29yZTo6SW1hZ2VEYXRhPiBnZXRJbWFnZURhdGEoV2ViQ29yZTo6QWxwaGFQcmVt dWx0aXBsaWNhdGlvbiBvdXRwdXRGb3JtYXQsIGNvbnN0IFdlYkNvcmU6OkludFJlY3QmIHNyY1Jl Y3QpIGNvbnN0IG92ZXJyaWRlCiAgICAgewotICAgICAgICBhdXRvJiBkaXNwbGF5TGlzdCA9IG1f ZHJhd2luZ0NvbnRleHQuZGlzcGxheUxpc3QoKTsKKyAgICAgICAgYXV0byYgZGlzcGxheUxpc3Qg PSBjb25zdF9jYXN0PFJlbW90ZUltYWdlQnVmZmVyKj4odGhpcyktPm1fZHJhd2luZ0NvbnRleHQu ZGlzcGxheUxpc3QoKTsKICAgICAgICAgY29uc3RfY2FzdDxSZW1vdGVJbWFnZUJ1ZmZlcio+KHRo aXMpLT5SZW1vdGVJbWFnZUJ1ZmZlck1lc3NhZ2VIYW5kbGVyOjpmbHVzaERyYXdpbmdDb250ZXh0 KGRpc3BsYXlMaXN0KTsKICAgICAgICAgYXV0byByZXN1bHQgPSBjb25zdF9jYXN0PFJlbW90ZUlt YWdlQnVmZmVyKj4odGhpcyktPlJlbW90ZUltYWdlQnVmZmVyTWVzc2FnZUhhbmRsZXI6OmdldElt YWdlRGF0YShvdXRwdXRGb3JtYXQsIHNyY1JlY3QpOwogICAgICAgICAvLyBnZXRJbWFnZURhdGEg aXMgc3luY2hyb25vdXMsIHdoaWNoIG1lYW5zIHdlJ3ZlIGFscmVhZHkgcmVjZWl2ZWQgdGhlIENv bW1pdEltYWdlQnVmZmVyRmx1c2hDb250ZXh0IG1lc3NhZ2UuCkBAIC05OSwyMCArOTksMTYgQEAg cHJvdGVjdGVkOgogICAgIHZvaWQgZmx1c2hEcmF3aW5nQ29udGV4dCgpIG92ZXJyaWRlCiAgICAg ewogICAgICAgICBhdXRvJiBkaXNwbGF5TGlzdCA9IG1fZHJhd2luZ0NvbnRleHQuZGlzcGxheUxp c3QoKTsKLSAgICAgICAgaWYgKGRpc3BsYXlMaXN0Lml0ZW1Db3VudCgpKSB7CisgICAgICAgIGlm IChkaXNwbGF5TGlzdC5pdGVtQ291bnQoKSkKICAgICAgICAgICAgIFJlbW90ZUltYWdlQnVmZmVy TWVzc2FnZUhhbmRsZXI6OmZsdXNoRHJhd2luZ0NvbnRleHRBbmRXYWl0Q29tbWl0KGRpc3BsYXlM aXN0KTsKLSAgICAgICAgICAgIGRpc3BsYXlMaXN0LmNsZWFyKCk7Ci0gICAgICAgIH0KICAgICB9 CiAgICAgCiAgICAgdm9pZCB3aWxsQXBwZW5kSXRlbShjb25zdCBXZWJDb3JlOjpEaXNwbGF5TGlz dDo6SXRlbSYpIG92ZXJyaWRlCiAgICAgewogICAgICAgICBjb25zdGV4cHIgc2l6ZV90IERpc3Bs YXlMaXN0QmF0Y2hTaXplID0gNTEyOwogICAgICAgICBhdXRvJiBkaXNwbGF5TGlzdCA9IG1fZHJh d2luZ0NvbnRleHQuZGlzcGxheUxpc3QoKTsKLSAgICAgICAgaWYgKGRpc3BsYXlMaXN0Lml0ZW1D b3VudCgpID49IERpc3BsYXlMaXN0QmF0Y2hTaXplKSB7CisgICAgICAgIGlmIChkaXNwbGF5TGlz dC5pdGVtQ291bnQoKSA+PSBEaXNwbGF5TGlzdEJhdGNoU2l6ZSkKICAgICAgICAgICAgIFJlbW90 ZUltYWdlQnVmZmVyTWVzc2FnZUhhbmRsZXI6OmZsdXNoRHJhd2luZ0NvbnRleHQoZGlzcGxheUxp c3QpOwotICAgICAgICAgICAgZGlzcGxheUxpc3QuY2xlYXIoKTsKLSAgICAgICAgfQogICAgIH0K IH07CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3Mv UmVtb3RlSW1hZ2VCdWZmZXJNZXNzYWdlSGFuZGxlci5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVmZmVyTWVzc2FnZUhhbmRsZXIuY3BwCmlu ZGV4IDMyMjA4MWUwMjgwOGNiYzUzODExNjM1ZGY0MzA0MjY3ZDRmZWQ1YjcuLjA2YzVhMTZjMDhi ODQ4MjcxMzA4YTg5YmNkOTA2OGZmNzhhMzg2ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJNZXNzYWdlSGFuZGxlci5j cHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVJbWFn ZUJ1ZmZlck1lc3NhZ2VIYW5kbGVyLmNwcApAQCAtNjksMjAgKzY5LDIyIEBAIHZvaWQgUmVtb3Rl SW1hZ2VCdWZmZXJNZXNzYWdlSGFuZGxlcjo6d2FpdEZvckNvbW1pdEltYWdlQnVmZmVyRmx1c2hD b250ZXh0KCkKICAgICAgICAgbV9yZW1vdGVSZW5kZXJpbmdCYWNrZW5kLT53YWl0Rm9yQ29tbWl0 SW1hZ2VCdWZmZXJGbHVzaENvbnRleHQoKTsKIH0KIAotdm9pZCBSZW1vdGVJbWFnZUJ1ZmZlck1l c3NhZ2VIYW5kbGVyOjpmbHVzaERyYXdpbmdDb250ZXh0KGNvbnN0IFdlYkNvcmU6OkRpc3BsYXlM aXN0OjpEaXNwbGF5TGlzdCYgZGlzcGxheUxpc3QpCit2b2lkIFJlbW90ZUltYWdlQnVmZmVyTWVz c2FnZUhhbmRsZXI6OmZsdXNoRHJhd2luZ0NvbnRleHQoV2ViQ29yZTo6RGlzcGxheUxpc3Q6OkRp c3BsYXlMaXN0JiBkaXNwbGF5TGlzdCkKIHsKICAgICBpZiAoIW1fcmVtb3RlUmVuZGVyaW5nQmFj a2VuZCkKICAgICAgICAgcmV0dXJuOwogICAgIAogICAgIG1fcmVtb3RlUmVuZGVyaW5nQmFja2Vu ZC0+c2VuZChNZXNzYWdlczo6UmVtb3RlUmVuZGVyaW5nQmFja2VuZFByb3h5OjpGbHVzaEltYWdl QnVmZmVyRHJhd2luZ0NvbnRleHQoZGlzcGxheUxpc3QsIG1faW1hZ2VCdWZmZXJJZGVudGlmaWVy KSwgbV9yZW1vdGVSZW5kZXJpbmdCYWNrZW5kLT5yZW5kZXJpbmdCYWNrZW5kSWRlbnRpZmllcigp KTsKKyAgICBkaXNwbGF5TGlzdC5jbGVhcigpOwogfQogCi12b2lkIFJlbW90ZUltYWdlQnVmZmVy TWVzc2FnZUhhbmRsZXI6OmZsdXNoRHJhd2luZ0NvbnRleHRBbmRXYWl0Q29tbWl0KGNvbnN0IFdl YkNvcmU6OkRpc3BsYXlMaXN0OjpEaXNwbGF5TGlzdCYgZGlzcGxheUxpc3QpCit2b2lkIFJlbW90 ZUltYWdlQnVmZmVyTWVzc2FnZUhhbmRsZXI6OmZsdXNoRHJhd2luZ0NvbnRleHRBbmRXYWl0Q29t bWl0KFdlYkNvcmU6OkRpc3BsYXlMaXN0OjpEaXNwbGF5TGlzdCYgZGlzcGxheUxpc3QpCiB7CiAg ICAgaWYgKCFtX3JlbW90ZVJlbmRlcmluZ0JhY2tlbmQpCiAgICAgICAgIHJldHVybjsKICAgICBt X3NlbnRGbHVzaElkZW50aWZpZXIgPSBJbWFnZUJ1ZmZlckZsdXNoSWRlbnRpZmllcjo6Z2VuZXJh dGUoKTsKICAgICBtX3JlbW90ZVJlbmRlcmluZ0JhY2tlbmQtPnNlbmQoTWVzc2FnZXM6OlJlbW90 ZVJlbmRlcmluZ0JhY2tlbmRQcm94eTo6Rmx1c2hJbWFnZUJ1ZmZlckRyYXdpbmdDb250ZXh0QW5k Q29tbWl0KGRpc3BsYXlMaXN0LCBtX3NlbnRGbHVzaElkZW50aWZpZXIsIG1faW1hZ2VCdWZmZXJJ ZGVudGlmaWVyKSwgbV9yZW1vdGVSZW5kZXJpbmdCYWNrZW5kLT5yZW5kZXJpbmdCYWNrZW5kSWRl bnRpZmllcigpKTsKKyAgICBkaXNwbGF5TGlzdC5jbGVhcigpOwogICAgIHdhaXRGb3JDb21taXRJ bWFnZUJ1ZmZlckZsdXNoQ29udGV4dCgpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZUltYWdlQnVmZmVyTWVzc2FnZUhhbmRsZXIu aCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZm ZXJNZXNzYWdlSGFuZGxlci5oCmluZGV4IDgwNTM1N2M5NjVjMGQ4NjM1OGQ3MWI4YTk4ZGFiN2Jk YjliYjU3YzkuLjBkODdiMjg4MmJlYTg2NzlmY2E1ZDBkMmI4ZjUxZjExYjEwNWQ3YTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvUmVtb3RlSW1hZ2VC dWZmZXJNZXNzYWdlSGFuZGxlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUv Z3JhcGhpY3MvUmVtb3RlSW1hZ2VCdWZmZXJNZXNzYWdlSGFuZGxlci5oCkBAIC02Niw4ICs2Niw4 IEBAIHByb3RlY3RlZDoKICAgICB2b2lkIHdhaXRGb3JDb21taXRJbWFnZUJ1ZmZlckZsdXNoQ29u dGV4dCgpOwogCiAgICAgLy8gTWVzc2FnZXMgdG8gYmUgc2VudC4gU2VlIFJlbW90ZVJlbmRlcmlu Z0JhY2tlbmRQcm94eS5tZXNzYWdlcy5pbi4KLSAgICB2b2lkIGZsdXNoRHJhd2luZ0NvbnRleHQo Y29uc3QgV2ViQ29yZTo6RGlzcGxheUxpc3Q6OkRpc3BsYXlMaXN0Jik7Ci0gICAgdm9pZCBmbHVz aERyYXdpbmdDb250ZXh0QW5kV2FpdENvbW1pdChjb25zdCBXZWJDb3JlOjpEaXNwbGF5TGlzdDo6 RGlzcGxheUxpc3QmKTsKKyAgICB2b2lkIGZsdXNoRHJhd2luZ0NvbnRleHQoV2ViQ29yZTo6RGlz cGxheUxpc3Q6OkRpc3BsYXlMaXN0Jik7CisgICAgdm9pZCBmbHVzaERyYXdpbmdDb250ZXh0QW5k V2FpdENvbW1pdChXZWJDb3JlOjpEaXNwbGF5TGlzdDo6RGlzcGxheUxpc3QmKTsKIAogcHJpdmF0 ZToKICAgICBXZWFrUHRyPFJlbW90ZVJlbmRlcmluZ0JhY2tlbmQ+IG1fcmVtb3RlUmVuZGVyaW5n QmFja2VuZDsK