208882 2020-03-10 14:20:29 -0700 [PlayStation] incomplete type 'WebCore::ScrollingStateFrameScrollingNode' named in nested name specifier 2020-03-10 16:37:16 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned cmarcelo commit-queue don.olmstead ews-watchlist fred.wang jamesr koivisto luiz ross.kirsling simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1628378 0 stephan.szabo 2020-03-10 14:20:29 -0700 We started seeing errors in the ENABLE(SCROLLING_THREAD) block with: ../../Source/WebCore\page/scrolling/ScrollingTreeScrollingNode.cpp:98:34: error: incomplete type 'WebCore::ScrollingStateFrameScrollingNode' named in nested name specifier if (state.hasChangedProperty(ScrollingStateFrameScrollingNode::ReasonsForSynchronousScrolling)) 1628379 1 393178 stephan.szabo 2020-03-10 14:23:37 -0700 Created attachment 393178 Patch Adding include for ScrollingStateFrameScrollingNode, checking if this is okay on the various EWS bots. 1628400 2 393178 ross.kirsling 2020-03-10 15:17:51 -0700 Comment on attachment 393178 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393178&action=review Seems like more than a PS port fix, this is a missing include from r258012? > Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:34 > +#if ENABLE(SCROLLING_THREAD) > +#include "ScrollingStateFrameScrollingNode.h" > +#endif Judging from other CPP files that include this, I think you can probably get away without guarding the include. 1628403 3 stephan.szabo 2020-03-10 15:26:18 -0700 I'm not sure if anyone else is hitting the code in question with the combination of enable flags, but noticed it from the PlayStation buildbot. I'd figured I'd guard the include to prevent bringing in the full include for cases that were okay with just the forward declaration, but can do it unconditionally. 1628427 4 393178 commit-queue 2020-03-10 16:36:43 -0700 Comment on attachment 393178 Patch Clearing flags on attachment: 393178 Committed r258238: <https://trac.webkit.org/changeset/258238> 1628428 5 commit-queue 2020-03-10 16:36:44 -0700 All reviewed patches have been landed. Closing bug. 1628429 6 webkit-bug-importer 2020-03-10 16:37:16 -0700 <rdar://problem/60297518> 393178 2020-03-10 14:23:37 -0700 2020-03-10 16:36:43 -0700 Patch 208882.1.diff text/plain 1361 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZDJlZjBmMTFjMy4uMGU3YTBlOWE2NDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMC0wMy0xMCAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29u eS5jb20+CisKKyAgICAgICAgW1BsYXlTdGF0aW9uXSBpbmNvbXBsZXRlIHR5cGUgJ1dlYkNvcmU6 OlNjcm9sbGluZ1N0YXRlRnJhbWVTY3JvbGxpbmdOb2RlJyBuYW1lZCBpbiBuZXN0ZWQgbmFtZSBz cGVjaWZpZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwODg4MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE5vIG5ldyB0ZXN0cywgYnVpbGQgZml4LgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvU2Ny b2xsaW5nVHJlZVNjcm9sbGluZ05vZGUuY3BwOgorICAgICAgICAgIEFkZCBpbmNsdWRlIG9mIFNj cm9sbGluZ1N0YXRlRnJhbWVTY3JvbGxpbmdOb2RlCisgICAgICAgICAgd2hlbiBFTkFCTEUoU0NS T0xMSU5HX1RIUkVBRCkgaXMgdHJ1ZS4KKwogMjAyMC0wMy0xMCAgU2FpZCBBYm91LUhhbGxhd2Eg IDxzYWJvdWhhbGxhd2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW92ZSB0aGUgc3BlY2lhbCBE aXNwbGF5TGlzdCBoYW5kbGluZyBpbiBDYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlU2Nyb2xs aW5nTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVl U2Nyb2xsaW5nTm9kZS5jcHAKaW5kZXggNmI3Zjc3NDUzZmMuLmVhMjhlMDk1NTMwIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlU2Nyb2xsaW5n Tm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJl ZVNjcm9sbGluZ05vZGUuY3BwCkBAIC0yOSw2ICsyOSw5IEBACiAjaWYgRU5BQkxFKEFTWU5DX1ND Uk9MTElORykKIAogI2luY2x1ZGUgIkxvZ2dpbmcuaCIKKyNpZiBFTkFCTEUoU0NST0xMSU5HX1RI UkVBRCkKKyNpbmNsdWRlICJTY3JvbGxpbmdTdGF0ZUZyYW1lU2Nyb2xsaW5nTm9kZS5oIgorI2Vu ZGlmCiAjaW5jbHVkZSAiU2Nyb2xsaW5nU3RhdGVTY3JvbGxpbmdOb2RlLmgiCiAjaW5jbHVkZSAi U2Nyb2xsaW5nU3RhdGVUcmVlLmgiCiAjaW5jbHVkZSAiU2Nyb2xsaW5nVHJlZS5oIgo=