208863 2020-03-10 08:47:38 -0700 Add release logging for when a navigation by a third-party (or untrusted) iframe is blocked 2020-03-10 10:27:14 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue esprehn+autocc ews-watchlist ggaren kangil.han keith_miller webkit-bug-importer youennf oldest_to_newest 1628263 0 cdumez 2020-03-10 08:47:38 -0700 Add release logging for when a navigation by a third-party (or untrusted) iframe is blocked, to help identify potential regressions in behavior. 1628264 1 393155 cdumez 2020-03-10 08:50:48 -0700 Created attachment 393155 Patch 1628303 2 393155 commit-queue 2020-03-10 10:26:49 -0700 Comment on attachment 393155 Patch Clearing flags on attachment: 393155 Committed r258214: <https://trac.webkit.org/changeset/258214> 1628304 3 commit-queue 2020-03-10 10:26:51 -0700 All reviewed patches have been landed. Closing bug. 1628305 4 webkit-bug-importer 2020-03-10 10:27:14 -0700 <rdar://problem/60278519> 393155 2020-03-10 08:50:48 -0700 2020-03-10 10:26:49 -0700 Patch bug-208863-20200310085047.patch text/plain 4606 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MjA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmQ2NWQ4MTk5NzAzZGNl YTQ3YTIwYzJiMTQyYzhiNGRiYTFiZWJhYS4uMDg4NzI1MDRjNjFiMmFlMzE0MGE1ZDY0NWY4Njlh MDRhNjZmZjc1NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAzLTEwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHJlbGVhc2UgbG9nZ2lu ZyBmb3Igd2hlbiBhIG5hdmlnYXRpb24gYnkgYSB0aGlyZC1wYXJ0eSAob3IgdW50cnVzdGVkKSBp ZnJhbWUgaXMgYmxvY2tlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA4ODYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIHJlbGVhc2UgbG9nZ2luZyBmb3Igd2hlbiBhIG5hdmlnYXRpb24gYnkgYSB0 aGlyZC1wYXJ0eSAob3IgdW50cnVzdGVkKSBpZnJhbWUgaXMgYmxvY2tlZCwgdG8KKyAgICAgICAg aGVscCBpZGVudGlmeSBwb3RlbnRpYWwgcmVncmVzc2lvbnMgaW4gYmVoYXZpb3IuCisKKyAgICAg ICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OmNhbk5h dmlnYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpmcmFtZUlEIGNvbnN0KToKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojppc0Fsd2F5c09uTG9nZ2luZ0FsbG93ZWQgY29uc3Qp OgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorCiAyMDIwLTAzLTEwICB5b3Vlbm4gZmFibGV0 ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgU2FtcGxlQnVmZmVyRGlzcGxh eUxheWVyIHN5bmMgSVBDCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCAzYzU1N2RlZDE2ZjA0 NmVlZDUxM2IzZGFmYWQ1NjljZTUzMGZmNDIxLi5mMmI2ZWRlODEyNTkzOWQ2MjUzNmQ5NmJiYWRi Y2E4ODYxNjVjYzI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTMzMCw2ICszMzAsOSBA QAogI2luY2x1ZGUgIkhUTUxWaWRlb0VsZW1lbnQuaCIKICNlbmRpZgogCisjZGVmaW5lIFJFTEVB U0VfTE9HX0lGX0FMTE9XRUQoY2hhbm5lbCwgZm10LCAuLi4pIFJFTEVBU0VfTE9HX0lGKGlzQWx3 YXlzT25Mb2dnaW5nQWxsb3dlZCgpLCBjaGFubmVsLCAiJXAgLSBbcGFnZUlEPSUiIFBSSXU2NCAi LCBmcmFtZUlEPSUiIFBSSXU2NCAiLCBtYWluPSVkXSBEb2N1bWVudDo6IiBmbXQsIHRoaXMsIHBh Z2VJRCgpLnZhbHVlT3IoUGFnZUlkZW50aWZpZXIgeyB9KS50b1VJbnQ2NCgpLCBmcmFtZUlEKCku dmFsdWVPcihGcmFtZUlkZW50aWZpZXIgeyB9KS50b1VJbnQ2NCgpLCB0aGlzID09ICZ0b3BEb2N1 bWVudCgpLCAjI19fVkFfQVJHU19fKQorI2RlZmluZSBSRUxFQVNFX0xPR19FUlJPUl9JRl9BTExP V0VEKGNoYW5uZWwsIGZtdCwgLi4uKSBSRUxFQVNFX0xPR19FUlJPUl9JRihpc0Fsd2F5c09uTG9n Z2luZ0FsbG93ZWQoKSwgY2hhbm5lbCwgIiVwIC0gW3BhZ2VJRD0lIiBQUkl1NjQgIiwgZnJhbWVJ RD0lIiBQUkl1NjQgIiwgbWFpbj0lZF0gRG9jdW1lbnQ6OiIgZm10LCB0aGlzLCBwYWdlSUQoKS52 YWx1ZU9yKFBhZ2VJZGVudGlmaWVyIHsgfSkudG9VSW50NjQoKSwgZnJhbWVJRCgpLnZhbHVlT3Io RnJhbWVJZGVudGlmaWVyIHsgfSkudG9VSW50NjQoKSwgdGhpcyA9PSAmdG9wRG9jdW1lbnQoKSwg IyNfX1ZBX0FSR1NfXykKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBXVEZfTUFLRV9JU09fQUxM T0NBVEVEX0lNUEwoRG9jdW1lbnQpOwpAQCAtMzM3NCw2ICszMzc3LDcgQEAgYm9vbCBEb2N1bWVu dDo6Y2FuTmF2aWdhdGUoRnJhbWUqIHRhcmdldEZyYW1lLCBjb25zdCBVUkwmIGRlc3RpbmF0aW9u VVJMKQogCiAgICAgaWYgKGlzTmF2aWdhdGlvbkJsb2NrZWRCeVRoaXJkUGFydHlJRnJhbWVSZWRp cmVjdEJsb2NraW5nKCp0YXJnZXRGcmFtZSwgZGVzdGluYXRpb25VUkwpKSB7CiAgICAgICAgIHBy aW50TmF2aWdhdGlvbkVycm9yTWVzc2FnZSgqdGFyZ2V0RnJhbWUsIHVybCgpLCAiVGhlIGZyYW1l IGF0dGVtcHRpbmcgbmF2aWdhdGlvbiBvZiB0aGUgdG9wLWxldmVsIHdpbmRvdyBpcyBjcm9zcy1v cmlnaW4gb3IgdW50cnVzdGVkIGFuZCB0aGUgdXNlciBoYXMgbmV2ZXIgaW50ZXJhY3RlZCB3aXRo IHRoZSBmcmFtZS4iX3MpOworICAgICAgICBSRUxFQVNFX0xPR19FUlJPUl9JRl9BTExPV0VEKExv YWRpbmcsICJOYXZpZ2F0aW9uIHdhcyBwcmV2ZW50ZWQgYmVjYXVzZSBpdCB3YXMgdHJpZ2dlcmVk IGJ5IGEgY3Jvc3Mtb3JpZ2luIG9yIHVudHJ1c3RlZCBpZnJhbWUiKTsKICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgIH0KIApAQCAtNzkxMyw2ICs3OTE3LDExIEBAIE9wdGlvbmFsPFBhZ2VJZGVu dGlmaWVyPiBEb2N1bWVudDo6cGFnZUlEKCkgY29uc3QKICAgICByZXR1cm4gbV9mcmFtZS0+bG9h ZGVyKCkuY2xpZW50KCkucGFnZUlEKCk7CiB9CiAKK09wdGlvbmFsPEZyYW1lSWRlbnRpZmllcj4g RG9jdW1lbnQ6OmZyYW1lSUQoKSBjb25zdAoreworICAgIHJldHVybiBtX2ZyYW1lLT5sb2FkZXIo KS5jbGllbnQoKS5mcmFtZUlEKCk7Cit9CisKIHZvaWQgRG9jdW1lbnQ6OnJlZ2lzdGVyQXJ0aWNs ZUVsZW1lbnQoRWxlbWVudCYgYXJ0aWNsZSkKIHsKICAgICBtX2FydGljbGVFbGVtZW50cy5hZGQo JmFydGljbGUpOwpAQCAtODM5Nyw2ICs4NDA2LDExIEBAIGJvb2wgRG9jdW1lbnQ6OnNob3VsZEln bm9yZVN5bmNYSFJzKCkgY29uc3QKICAgICByZXR1cm4gbV9udW1iZXJPZlJlamVjdGVkU3luY1hI UnMgPiBtYXhSZWplY3RlZFN5bmNYSFJzUGVyRXZlbnRMb29wSXRlcmF0aW9uOwogfQogCitib29s IERvY3VtZW50Ojppc0Fsd2F5c09uTG9nZ2luZ0FsbG93ZWQoKSBjb25zdAoreworICAgIHJldHVy biAhbV9mcmFtZSB8fCBtX2ZyYW1lLT5pc0Fsd2F5c09uTG9nZ2luZ0FsbG93ZWQoKTsKK30KKwog I2lmIEVOQUJMRShBUFBMRV9QQVkpCiAKIGJvb2wgRG9jdW1lbnQ6OmlzQXBwbGVQYXlBY3RpdmUo KSBjb25zdApAQCAtODQ2NCwzICs4NDc4LDYgQEAgTGF6eUxvYWRJbWFnZU9ic2VydmVyJiBEb2N1 bWVudDo6bGF6eUxvYWRJbWFnZU9ic2VydmVyKCkKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQorCisjdW5kZWYgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRAorI3VuZGVmIFJFTEVBU0VfTE9HX0VS Uk9SX0lGX0FMTE9XRUQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5o IGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKaW5kZXggZGE4ZGE1OTM2ZmI1MjZkZjQ4 MmQ5MTU0NDI3YzFlMWI5ZGNjZmRlNS4uMGY3YmE4NDI5NWNjOWY3MWYwOWRlMTU4MzQ5NmNiNzBj NjY5ZDQ1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKQEAgLTM3LDYgKzM3LDcgQEAKICNpbmNsdWRl ICJGb2N1c0RpcmVjdGlvbi5oIgogI2luY2x1ZGUgIkZvbnRTZWxlY3RvckNsaWVudC5oIgogI2lu Y2x1ZGUgIkZyYW1lRGVzdHJ1Y3Rpb25PYnNlcnZlci5oIgorI2luY2x1ZGUgIkZyYW1lSWRlbnRp Zmllci5oIgogI2luY2x1ZGUgIkZyYW1lTG9hZGVyVHlwZXMuaCIKICNpbmNsdWRlICJHZW5lcmlj VGFza1F1ZXVlLmgiCiAjaW5jbHVkZSAiR3JhcGhpY3NUeXBlcy5oIgpAQCAtNDI0LDYgKzQyNSw4 IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldFJlZmVycmVyUG9saWN5KFJlZmVycmVyUG9saWN5KTsK ICAgICBSZWZlcnJlclBvbGljeSByZWZlcnJlclBvbGljeSgpIGNvbnN0IGZpbmFsIHsgcmV0dXJu IG1fcmVmZXJyZXJQb2xpY3kudmFsdWVPcihSZWZlcnJlclBvbGljeTo6Tm9SZWZlcnJlcldoZW5E b3duZ3JhZGUpOyB9CiAKKyAgICBib29sIGlzQWx3YXlzT25Mb2dnaW5nQWxsb3dlZCgpIGNvbnN0 OworCiAgICAgV0VCQ09SRV9FWFBPUlQgRG9jdW1lbnRUeXBlKiBkb2N0eXBlKCkgY29uc3Q7CiAK ICAgICBXRUJDT1JFX0VYUE9SVCBET01JbXBsZW1lbnRhdGlvbiYgaW1wbGVtZW50YXRpb24oKTsK QEAgLTY0NSw2ICs2NDgsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCBjbGVhckFYT2JqZWN0Q2FjaGUo KTsKIAogICAgIFdFQkNPUkVfRVhQT1JUIE9wdGlvbmFsPFBhZ2VJZGVudGlmaWVyPiBwYWdlSUQo KSBjb25zdDsKKyAgICBPcHRpb25hbDxGcmFtZUlkZW50aWZpZXI+IGZyYW1lSUQoKSBjb25zdDsK KwogICAgIC8vIHRvIGdldCB2aXN1YWxseSBvcmRlcmVkIGhlYnJldyBhbmQgYXJhYmljIHBhZ2Vz IHJpZ2h0CiAgICAgdm9pZCBzZXRWaXN1YWxseU9yZGVyZWQoKTsKICAgICBib29sIHZpc3VhbGx5 T3JkZXJlZCgpIGNvbnN0IHsgcmV0dXJuIG1fdmlzdWFsbHlPcmRlcmVkOyB9Cg==