208862 2020-03-10 08:15:37 -0700 [ews] Add unit tests for commit queue factory 2020-03-10 11:32:15 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1628255 0 aakash_jain 2020-03-10 08:15:37 -0700 We should add unit tests for commit queue factory. 1628256 1 393152 aakash_jain 2020-03-10 08:17:15 -0700 Created attachment 393152 Patch 1628313 2 ews-feeder 2020-03-10 10:44:40 -0700 Committed r258217: <https://trac.webkit.org/changeset/258217> All reviewed patches have been landed. Closing bug and clearing flags on attachment 393152. 1628314 3 webkit-bug-importer 2020-03-10 10:45:17 -0700 <rdar://problem/60279482> 393152 2020-03-10 08:17:15 -0700 2020-03-10 10:44:40 -0700 Patch bug-208862-20200310111710.patch text/plain 2924 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1ODIxMCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTAzLTEwICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBBZGQgdW5pdCB0ZXN0cyBmb3IgY29tbWl0IHF1ZXVlIGZhY3Rv cnkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODg2 MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllc191bml0dGVzdC5weToKKyAgICAgICAg KFRlc3RDb21taXRRdWV1ZUZhY3RvcnkpOgorICAgICAgICAoVGVzdENvbW1pdFF1ZXVlRmFjdG9y eS50ZXN0X2NvbW1pdF9xdWV1ZV9mYWN0b3J5KTogQWRkZWQgdW5pdC10ZXN0IGZvciBjb21taXQt cXVldWUgZmFjdG9yeS4KKwogMjAyMC0wMy0xMCAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkIFZhbGlkYXRlQ29tbWl0ZXJBbmRSZXZpZXdlciBhbmQg VmFsaWRhdGVDaGFuZ2VMb2dBbmRSZXZpZXdlciBidWlsZCBzdGVwcyBpbiBjb21taXQtcXVldWUK SW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9mYWN0b3JpZXNfdW5pdHRl c3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2Zh Y3Rvcmllc191bml0dGVzdC5weQkocmV2aXNpb24gMjU4MjEwKQorKysgVG9vbHMvQnVpbGRTbGF2 ZVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllc191bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpA QCAtMTcyLDMgKzE3MiwzMSBAQCBjbGFzcyBUZXN0QnVpbGRBbmRUZXN0c0ZhY3RvcnkoVGVzdENh c2UpCiAgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5SdW5XZWJLaXQxVGVzdHMp LAogICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuU2V0QnVpbGRTdW1tYXJ5KSwK ICAgICAgICAgXSkKKworCitjbGFzcyBUZXN0Q29tbWl0UXVldWVGYWN0b3J5KFRlc3RDYXNlKToK KyAgICBkZWYgdGVzdF9jb21taXRfcXVldWVfZmFjdG9yeShzZWxmKToKKyAgICAgICAgZmFjdG9y eSA9IGZhY3Rvcmllcy5Db21taXRRdWV1ZUZhY3RvcnkocGxhdGZvcm09J21hYy1tb2phdmUnLCBj b25maWd1cmF0aW9uPSdyZWxlYXNlJywgYXJjaGl0ZWN0dXJlcz1bIng4Nl82NCJdKQorICAgICAg ICBzZWxmLmFzc2VydEJ1aWxkU3RlcHMoZmFjdG9yeS5zdGVwcywgWworICAgICAgICAgICAgX0J1 aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ29uZmlndXJlQnVpbGQsIHBsYXRmb3JtPSdtYWMtbW9qYXZl JywgY29uZmlndXJhdGlvbj0ncmVsZWFzZScsIGFyY2hpdGVjdHVyZXM9WyJ4ODZfNjQiXSwgYnVp bGRPbmx5PUZhbHNlLCB0cmlnZ2Vycz1Ob25lLCByZW1vdGVzPU5vbmUsIGFkZGl0aW9uYWxBcmd1 bWVudHM9Tm9uZSksCisgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5WYWxpZGF0 ZVBhdGNoLCB2ZXJpZnljcXBsdXM9VHJ1ZSksCisgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9y eShzdGVwcy5WYWxpZGF0ZUNvbW1pdGVyQW5kUmV2aWV3ZXIpLAorICAgICAgICAgICAgX0J1aWxk U3RlcEZhY3Rvcnkoc3RlcHMuUHJpbnRDb25maWd1cmF0aW9uKSwKKyAgICAgICAgICAgIF9CdWls ZFN0ZXBGYWN0b3J5KHN0ZXBzLkNoZWNrT3V0U291cmNlKSwKKyAgICAgICAgICAgIF9CdWlsZFN0 ZXBGYWN0b3J5KHN0ZXBzLlVwZGF0ZVdvcmtpbmdEaXJlY3RvcnkpLAorICAgICAgICAgICAgX0J1 aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQXBwbHlQYXRjaCksCisgICAgICAgICAgICBfQnVpbGRTdGVw RmFjdG9yeShzdGVwcy5WYWxpZGF0ZUNoYW5nZUxvZ0FuZFJldmlld2VyKSwKKyAgICAgICAgICAg IF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLktpbGxPbGRQcm9jZXNzZXMpLAorICAgICAgICAgICAg X0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ29tcGlsZVdlYktpdCwgc2tpcFVwbG9hZD1UcnVlKSwK KyAgICAgICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLktpbGxPbGRQcm9jZXNzZXMpLAor ICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuVmFsaWRhdGVQYXRjaCwgYWRkVVJM cz1GYWxzZSwgdmVyaWZ5Y3FwbHVzPVRydWUpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rv cnkoc3RlcHMuUnVuV2ViS2l0VGVzdHMpLAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnko c3RlcHMuVmFsaWRhdGVQYXRjaCwgYWRkVVJMcz1GYWxzZSwgdmVyaWZ5Y3FwbHVzPVRydWUpLAor ICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ2hlY2tPdXRTb3VyY2UpLAorICAg ICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuVXBkYXRlV29ya2luZ0RpcmVjdG9yeSks CisgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5BcHBseVBhdGNoKSwKKyAgICAg ICAgICAgIF9CdWlsZFN0ZXBGYWN0b3J5KHN0ZXBzLkZpbmRNb2RpZmllZENoYW5nZUxvZ3MpLAor ICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ3JlYXRlTG9jYWxHSVRDb21taXQp LAorICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuUHVzaENvbW1pdFRvV2ViS2l0 UmVwbyksCisgICAgICAgICAgICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5TZXRCdWlsZFN1bW1h cnkpLAorICAgICAgICBdKQo=