208851 2020-03-10 03:05:05 -0700 Do not create a service worker connection if service worker is not enabled in network process 2020-03-10 09:27:48 -0700 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen cdumez commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1628154 0 youennf 2020-03-10 03:05:05 -0700 Do not create a service worker connection if service worker is not enabled in network process 1628155 1 youennf 2020-03-10 03:07:32 -0700 <rdar://problem/58878768> 1628158 2 393130 youennf 2020-03-10 03:15:39 -0700 Created attachment 393130 Patch 1628278 3 393130 commit-queue 2020-03-10 09:27:46 -0700 Comment on attachment 393130 Patch Clearing flags on attachment: 393130 Committed r258213: <https://trac.webkit.org/changeset/258213> 1628279 4 commit-queue 2020-03-10 09:27:48 -0700 All reviewed patches have been landed. Closing bug. 393130 2020-03-10 03:15:39 -0700 2020-03-10 09:27:46 -0700 Patch bug-208851-20200310111537.patch text/plain 6861 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MTM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDU5MjBkYjlmZGFkZjI5Nzhk Yzk2ZjU2MjMyODU3YTRlMDc4ZDZiNGYuLmNjYTYwMzgxOWM2OGQxMzk3YWZlN2Y4MTAzMDUzZjhk ZWQxYTJkNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDMtMTAgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIERvIG5vdCBjcmVhdGUgYSBzZXJ2 aWNlIHdvcmtlciBjb25uZWN0aW9uIGlmIHNlcnZpY2Ugd29ya2VyIGlzIG5vdCBlbmFibGVkIGlu IG5ldHdvcmsgcHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA4ODUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSW4gY2FzZSBvZiBuYXZpZ2F0aW9uIHJlZGlyZWN0aW9uLCB3ZSB3ZXJlIHRyeWlu ZyB0byBnbyB0byBzZXJ2aWNlIHdvcmtlciB3aXRob3V0IGNoZWNraW5nIHRoZSBzZXJ2aWNlIHdv cmtlciBlbnRpdGxlbWVudC4KKyAgICAgICAgSW5zdGVhZCwgd2Ugc2hvdWxkIGNoZWNrIHRoZSBz ZXJ2aWNlIHdvcmtlciBlbnRpdGxlbWVudCBhbmQgcmV0dXJuIGVhcmx5IGluIHRoYXQgY2FzZS4K KworICAgICAgICBDb3ZlcmVkIGJ5IG1hbnVhbGx5IHJ1bm5pbmcgbWluaWJyb3dzZXIgb24gc2lt dWxhdG9yLgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dl YlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJv Y2Vzczo6aXNTZXJ2aWNlV29ya2VyQWxsb3dlZCBjb25zdCk6CisgICAgICAgIChXZWJLaXQ6Ok5l dHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjpjcmVhdGVGZXRjaFRhc2spOgorICAgICAgICAo V2ViS2l0OjpOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6c2NoZWR1bGVSZXNvdXJjZUxv YWQpOgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9j ZXNzLmg6CisgICAgICAgICogTmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNw cDoKKyAgICAgICAgKFdlYktpdDo6TmV0d29ya1Jlc291cmNlTG9hZGVyOjpjb250aW51ZVdpbGxT ZW5kUmVxdWVzdCk6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6c3Rh cnRXaXRoU2VydmljZVdvcmtlcik6CisKIDIwMjAtMDMtMDkgIHlvdWVubiBmYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgogCiAgICAgICAgIE1vdmUgQXVkaW9TZXNzaW9uIGludGVycnVwdGlvbiBs aXN0ZW5lciBjb2RlIHRvIEF1ZGlvU2Vzc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9O ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzcy5jcHAgYi9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcApp bmRleCA3Zjk4NGIxMTQ4YjM4YzA2ZWVkNzVmZTcxMzE4YjM4MjNmMWMyNjM2Li5kYzQ2ZTU5NjQz ZWYxOWQ4ZmYyOTJlMWViY2I4YWQ5NjUxMjlmMWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNz LmNwcApAQCAtNDA4LDExICs0MDgsMjUgQEAgVmVjdG9yPFJlZlB0cjxXZWJDb3JlOjpCbG9iRGF0 YUZpbGVSZWZlcmVuY2U+PiBOZXR3b3JrQ29ubmVjdGlvblRvV2ViUHJvY2Vzczo6cmUKICAgICBy ZXR1cm4gZmlsZXM7CiB9CiAKKyNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIpCitib29sIE5ldHdv cmtDb25uZWN0aW9uVG9XZWJQcm9jZXNzOjppc1NlcnZpY2VXb3JrZXJBbGxvd2VkKCkgY29uc3QK K3sKKyAgICByZXR1cm4gbV9uZXR3b3JrUHJvY2Vzcy0+cGFyZW50UHJvY2Vzc0hhc1NlcnZpY2VX b3JrZXJFbnRpdGxlbWVudCgpOworfQorCitzdGQ6OnVuaXF1ZV9wdHI8U2VydmljZVdvcmtlckZl dGNoVGFzaz4gTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nlc3M6OmNyZWF0ZUZldGNoVGFzayhO ZXR3b3JrUmVzb3VyY2VMb2FkZXImIGxvYWRlciwgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1 ZXN0KQoreworICAgIGlmICghaXNTZXJ2aWNlV29ya2VyQWxsb3dlZCgpKQorICAgICAgICByZXR1 cm4gbnVsbHB0cjsKKyAgICByZXR1cm4gc3dDb25uZWN0aW9uKCkuY3JlYXRlRmV0Y2hUYXNrKGxv YWRlciwgcmVxdWVzdCk7Cit9CisjZW5kaWYKKwogdm9pZCBOZXR3b3JrQ29ubmVjdGlvblRvV2Vi UHJvY2Vzczo6c2NoZWR1bGVSZXNvdXJjZUxvYWQoTmV0d29ya1Jlc291cmNlTG9hZFBhcmFtZXRl cnMmJiBsb2FkUGFyYW1ldGVycykKIHsKICNpZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIpCi0gICAg Ym9vbCBzZXJ2aWNlV29ya2VyQWxsb3dlZCA9IG1fbmV0d29ya1Byb2Nlc3MtPnBhcmVudFByb2Nl c3NIYXNTZXJ2aWNlV29ya2VyRW50aXRsZW1lbnQoKTsKLSAgICBpZiAoc2VydmljZVdvcmtlckFs bG93ZWQpIHsKKyAgICBib29sIGlzU2VydmljZVdvcmtlckFsbG93ZWQgPSB0aGlzLT5pc1NlcnZp Y2VXb3JrZXJBbGxvd2VkKCk7CisgICAgaWYgKGlzU2VydmljZVdvcmtlckFsbG93ZWQpIHsKICAg ICAgICAgYXV0byYgc2VydmVyID0gbV9uZXR3b3JrUHJvY2Vzcy0+c3dTZXJ2ZXJGb3JTZXNzaW9u KG1fc2Vzc2lvbklEKTsKICAgICAgICAgaWYgKCFzZXJ2ZXIuaXNJbXBvcnRDb21wbGV0ZWQoKSkg ewogICAgICAgICAgICAgc2VydmVyLndoZW5JbXBvcnRJc0NvbXBsZXRlZChbdGhpcywgcHJvdGVj dGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBsb2FkUGFyYW1ldGVycyA9IFdURk1vdmUobG9hZFBh cmFtZXRlcnMpXSgpIG11dGFibGUgewpAQCAtNDMzLDEwICs0NDcsMTAgQEAgdm9pZCBOZXR3b3Jr Q29ubmVjdGlvblRvV2ViUHJvY2Vzczo6c2NoZWR1bGVSZXNvdXJjZUxvYWQoTmV0d29ya1Jlc291 cmNlTG9hZFBhcmEKICAgICBhdXRvJiBsb2FkZXIgPSBtX25ldHdvcmtSZXNvdXJjZUxvYWRlcnMu YWRkKGlkZW50aWZpZXIsIE5ldHdvcmtSZXNvdXJjZUxvYWRlcjo6Y3JlYXRlKFdURk1vdmUobG9h ZFBhcmFtZXRlcnMpLCAqdGhpcykpLml0ZXJhdG9yLT52YWx1ZTsKIAogI2lmIEVOQUJMRShTRVJW SUNFX1dPUktFUikKLSAgICBpZiAoc2VydmljZVdvcmtlckFsbG93ZWQpIHsKKyAgICBpZiAoaXNT ZXJ2aWNlV29ya2VyQWxsb3dlZCkgewogICAgICAgICBsb2FkZXItPnN0YXJ0V2l0aFNlcnZpY2VX b3JrZXIoKTsKICAgICAgICAgcmV0dXJuOwotICAgIH0gZWxzZQorICAgIH0KICNlbmRpZgogICAg IGxvYWRlci0+c3RhcnQoKTsKIH0KQEAgLTEwMTMsNiArMTAyNyw3IEBAIHZvaWQgTmV0d29ya0Nv bm5lY3Rpb25Ub1dlYlByb2Nlc3M6OnNlcnZlclRvQ29udGV4dENvbm5lY3Rpb25Ob0xvbmdlck5l ZWRlZCgpCiAKIFdlYlNXU2VydmVyQ29ubmVjdGlvbiYgTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlBy b2Nlc3M6OnN3Q29ubmVjdGlvbigpCiB7CisgICAgQVNTRVJUKGlzU2VydmljZVdvcmtlckFsbG93 ZWQoKSk7CiAgICAgaWYgKCFtX3N3Q29ubmVjdGlvbikKICAgICAgICAgZXN0YWJsaXNoU1dTZXJ2 ZXJDb25uZWN0aW9uKCk7CiAgICAgcmV0dXJuICptX3N3Q29ubmVjdGlvbjsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dlYlByb2Nl c3MuaCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29ya0Nvbm5lY3Rpb25Ub1dl YlByb2Nlc3MuaAppbmRleCBkMGMxYTI1MzY4NDE0YzM3NDIzOGQ4MzhhOGY3ZDIyYzAxMTIzZWJl Li5iNzU5YzI5ZDI0ZDY3OWZiOTMwNDllZDJhYjlhNDRjZTRmMDE4NzUwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtDb25uZWN0aW9uVG9XZWJQcm9jZXNz LmgKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrQ29ubmVjdGlvblRv V2ViUHJvY2Vzcy5oCkBAIC03Niw2ICs3Niw3IEBAIGNsYXNzIE5ldHdvcmtSZXNvdXJjZUxvYWRQ YXJhbWV0ZXJzOwogY2xhc3MgTmV0d29ya1Nlc3Npb247CiBjbGFzcyBOZXR3b3JrU29ja2V0Q2hh bm5lbDsKIGNsYXNzIE5ldHdvcmtTb2NrZXRTdHJlYW07CitjbGFzcyBTZXJ2aWNlV29ya2VyRmV0 Y2hUYXNrOwogY2xhc3MgV2ViU1dTZXJ2ZXJDb25uZWN0aW9uOwogY2xhc3MgV2ViU1dTZXJ2ZXJU b0NvbnRleHRDb25uZWN0aW9uOwogdHlwZWRlZiB1aW50NjRfdCBSZXNvdXJjZUxvYWRJZGVudGlm aWVyOwpAQCAtMTY5LDYgKzE3MCw3IEBAIHB1YmxpYzoKICNpZiBFTkFCTEUoU0VSVklDRV9XT1JL RVIpCiAgICAgdm9pZCBzZXJ2ZXJUb0NvbnRleHRDb25uZWN0aW9uTm9Mb25nZXJOZWVkZWQoKTsK ICAgICBXZWJTV1NlcnZlckNvbm5lY3Rpb24mIHN3Q29ubmVjdGlvbigpOworICAgIHN0ZDo6dW5p cXVlX3B0cjxTZXJ2aWNlV29ya2VyRmV0Y2hUYXNrPiBjcmVhdGVGZXRjaFRhc2soTmV0d29ya1Jl c291cmNlTG9hZGVyJiwgY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXF1ZXN0Jik7CiAjZW5kaWYK IAogICAgIE5ldHdvcmtTY2hlbWVSZWdpc3RyeSYgc2NoZW1lUmVnaXN0cnkoKSB7IHJldHVybiBt X3NjaGVtZVJlZ2lzdHJ5LmdldCgpOyB9CkBAIC0yMzQsNiArMjM2LDcgQEAgcHJpdmF0ZToKICAg ICB2b2lkIGVzdGFibGlzaFNXQ29udGV4dENvbm5lY3Rpb24oV2ViQ29yZTo6UmVnaXN0cmFibGVE b21haW4mJiwgQ29tcGxldGlvbkhhbmRsZXI8dm9pZCgpPiYmKTsKICAgICB2b2lkIGNsb3NlU1dD b250ZXh0Q29ubmVjdGlvbigpOwogICAgIHZvaWQgdW5yZWdpc3RlclNXQ29ubmVjdGlvbigpOwor ICAgIGJvb2wgaXNTZXJ2aWNlV29ya2VyQWxsb3dlZCgpIGNvbnN0OwogI2VuZGlmCiAKICAgICB2 b2lkIGNyZWF0ZU5ld01lc3NhZ2VQb3J0Q2hhbm5lbChjb25zdCBXZWJDb3JlOjpNZXNzYWdlUG9y dElkZW50aWZpZXImIHBvcnQxLCBjb25zdCBXZWJDb3JlOjpNZXNzYWdlUG9ydElkZW50aWZpZXIm IHBvcnQyKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29y a1Jlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvTmV0d29y a1Jlc291cmNlTG9hZGVyLmNwcAppbmRleCBhNDhhY2M4NmI0NWRmZjZlYzcxZmI4OGIxNjM3ZWIw NTQ5MDc4MGIzLi4wNDVhODZhMjAxZmFlYzk1ODdmZDRhY2MyOGU0OWE1ZTE0Y2IyZjRiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRl ci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VM b2FkZXIuY3BwCkBAIC05MjQsNyArOTI0LDcgQEAgdm9pZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6 OmNvbnRpbnVlV2lsbFNlbmRSZXF1ZXN0KFJlc291cmNlUmVxdWVzdCYmIG5ld1JlcXVlc3QKIAog I2lmIEVOQUJMRShTRVJWSUNFX1dPUktFUikKICAgICBpZiAocGFyYW1ldGVycygpLm9wdGlvbnMu bW9kZSA9PSBGZXRjaE9wdGlvbnM6Ok1vZGU6Ok5hdmlnYXRlKSB7Ci0gICAgICAgIGlmIChhdXRv IHNlcnZpY2VXb3JrZXJGZXRjaFRhc2sgPSBtX2Nvbm5lY3Rpb24tPnN3Q29ubmVjdGlvbigpLmNy ZWF0ZUZldGNoVGFzaygqdGhpcywgbmV3UmVxdWVzdCkpIHsKKyAgICAgICAgaWYgKGF1dG8gc2Vy dmljZVdvcmtlckZldGNoVGFzayA9IG1fY29ubmVjdGlvbi0+Y3JlYXRlRmV0Y2hUYXNrKCp0aGlz LCBuZXdSZXF1ZXN0KSkgewogICAgICAgICAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgiY29u dGludWVXaWxsU2VuZFJlcXVlc3Q6IENyZWF0ZWQgYSBTZXJ2aWNlV29ya2VyRmV0Y2hUYXNrIHRv IGhhbmRsZSB0aGUgcmVkaXJlY3QgKGZldGNoSWRlbnRpZmllcj0lIiBQUkl1NjQgIikiLCBzZXJ2 aWNlV29ya2VyRmV0Y2hUYXNrLT5mZXRjaElkZW50aWZpZXIoKS50b1VJbnQ2NCgpKTsKICAgICAg ICAgICAgIG1fbmV0d29ya0xvYWQgPSBudWxscHRyOwogICAgICAgICAgICAgbV9zZXJ2aWNlV29y a2VyRmV0Y2hUYXNrID0gV1RGTW92ZShzZXJ2aWNlV29ya2VyRmV0Y2hUYXNrKTsKQEAgLTE0NDgs NyArMTQ0OCw3IEBAIHZvaWQgTmV0d29ya1Jlc291cmNlTG9hZGVyOjpzdGFydFdpdGhTZXJ2aWNl V29ya2VyKCkKIHsKICAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJzdGFydFdpdGhTZXJ2aWNl V29ya2VyOiIpOwogICAgIEFTU0VSVCghbV9zZXJ2aWNlV29ya2VyRmV0Y2hUYXNrKTsKLSAgICBt X3NlcnZpY2VXb3JrZXJGZXRjaFRhc2sgPSBtX2Nvbm5lY3Rpb24tPnN3Q29ubmVjdGlvbigpLmNy ZWF0ZUZldGNoVGFzaygqdGhpcywgb3JpZ2luYWxSZXF1ZXN0KCkpOworICAgIG1fc2VydmljZVdv cmtlckZldGNoVGFzayA9IG1fY29ubmVjdGlvbi0+Y3JlYXRlRmV0Y2hUYXNrKCp0aGlzLCBvcmln aW5hbFJlcXVlc3QoKSk7CiAgICAgaWYgKG1fc2VydmljZVdvcmtlckZldGNoVGFzaykgewogICAg ICAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJzdGFydFdpdGhTZXJ2aWNlV29ya2VyOiBDcmVh dGVkIGEgU2VydmljZVdvcmtlckZldGNoVGFzayAoZmV0Y2hJZGVudGlmaWVyPSUiIFBSSXU2NCAi KSIsIG1fc2VydmljZVdvcmtlckZldGNoVGFzay0+ZmV0Y2hJZGVudGlmaWVyKCkudG9VSW50NjQo KSk7CiAgICAgICAgIHJldHVybjsK