20884 2008-09-16 10:29:14 -0700 Fix LayoutTests that call notifyDone() twice 2008-12-17 20:17:28 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser abarth abarth rwlbuis oldest_to_newest 91391 0 simon.fraser 2008-09-16 10:29:14 -0700 Following on from bug 20875, some tests call notifyDone() twice. This used to result in memory corruption; now it results in test failure (possibly on some later test). 91395 1 simon.fraser 2008-09-16 10:38:13 -0700 I get occasional failures in fast/dom/gc-9.html, which suggest that fast/dom/gc-7.html or fast/dom/gc-8.html are doing something bad. 91412 2 simon.fraser 2008-09-16 12:43:47 -0700 A test prior to svg/custom/gradient-cycle-detection.html also seems to have issues. Bug 20881 covers animations/change-one-anim.html 91414 3 simon.fraser 2008-09-16 12:55:22 -0700 Looks like gradient-attr-update.svg can call notifyDone() twice because myfunc() is called both by the onload, and by the onclick. I'm not sure how to fix that test. 91421 4 23483 simon.fraser 2008-09-16 13:03:02 -0700 Created attachment 23483 Fix test to not call notifyDone() twice 91424 5 simon.fraser 2008-09-16 13:16:18 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/animations/change-one-anim.html M LayoutTests/svg/custom/gradient-attr-update.svg Committed r36520 Keeping bug open for fast/dom/gc-8.html 91531 6 23483 darin 2008-09-17 14:47:23 -0700 Comment on attachment 23483 Fix test to not call notifyDone() twice rs=me -- needs ChangeLog -- fix seems a little indirect to me, but should be fine 95263 7 abarth 2008-10-14 01:37:58 -0700 Will land. I'll add a ChangeLog because I'm that nice. 95270 8 23483 abarth 2008-10-14 02:05:21 -0700 Comment on attachment 23483 Fix test to not call notifyDone() twice Clearing review flag. This has already been landed. Keeping open per comment above. 102854 9 simon.fraser 2008-12-17 20:17:28 -0800 I don't think anything remains now. 23483 2008-09-16 13:03:02 -0700 2008-10-14 02:05:21 -0700 Fix test to not call notifyDone() twice svg_test_fix.txt text/plain 1244 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vZ3JhZGllbnQtYXR0ci11cGRhdGUu c3ZnIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9ncmFkaWVudC1hdHRyLXVwZGF0ZS5zdmcKaW5k ZXggN2I3MTdjYS4uZDBjZTM4NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9n cmFkaWVudC1hdHRyLXVwZGF0ZS5zdmcKKysrIGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9ncmFk aWVudC1hdHRyLXVwZGF0ZS5zdmcKQEAgLTEsNiArMSw2IEBACiA8P3htbCB2ZXJzaW9uPSIxLjAi IGVuY29kaW5nPSJVVEYtOCI/PgogPCFET0NUWVBFIHN2ZyBQVUJMSUMgIi0vL1czQy8vRFREIFNW RyAxLjEgQmFzaWMvL0VOIiAiaHR0cDovL3d3dy53My5vcmcvR3JhcGhpY3MvU1ZHLzEuMS9EVEQv c3ZnMTEtYmFzaWMuZHRkIj4KLTxzdmcgdmVyc2lvbj0iMS4xIiBiYXNlUHJvZmlsZT0iYmFzaWMi IHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyIgeG1sbnM6eGxpbms9Imh0dHA6Ly93 d3cudzMub3JnLzE5OTkveGxpbmsiIGlkPSJzdmctcm9vdCIgd2lkdGg9IjEwMCUiIGhlaWdodD0i MTAwJSIgb25sb2FkPSJteWZ1bmMoKSI+Cis8c3ZnIHZlcnNpb249IjEuMSIgYmFzZVByb2ZpbGU9 ImJhc2ljIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJo dHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rIiBpZD0ic3ZnLXJvb3QiIHdpZHRoPSIxMDAlIiBo ZWlnaHQ9IjEwMCUiIG9ubG9hZD0icGFnZUxvYWRlZCgpIj4KICAgICAgPHNjcmlwdD4KIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCiAgICAgd2luZG93LmxheW91dFRlc3RDb250cm9s bGVyLndhaXRVbnRpbERvbmUoKTsKQEAgLTIzLDYgKzIzLDEyIEBAIGZ1bmN0aW9uIGNsaWNrTm93 KCkgewogICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CiAgICAgfQogfQorCitmdW5jdGlv biBwYWdlTG9hZGVkKCkKK3sKKyAgaWYgKCF3aW5kb3cuZXZlbnRTZW5kZXIpICAvLyB3aGVuIG5v dCBydW5uaW5nIHVuZGVyIER1bXBSZW5kZXJUcmVlCisgICAgbXlmdW5jKCk7Cit9CiAgICAgIDwv c2NyaXB0PgogICAgICA8ZGVmcz4KICAgICAgICAgIDxyYWRpYWxHcmFkaWVudCBpZD0iZ3JhZGll bnQxIiBjeD0iNDUlIiBjeT0iNDglIiByPSIyMDAiIGZ4PSI1MCUiIGZ5PSI1MiUiIHNwcmVhZE1l dGhvZD0icmVmbGVjdCIgZ3JhZGllbnRVbml0cz0idXNlclNwYWNlT25Vc2UiPgo=