208823 2020-03-09 10:57:15 -0700 WebKitTestRunner bundleID should not be cleared before every test 2020-03-09 17:00:31 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham commit-queue pvollan webkit-bug-importer oldest_to_newest 1627850 0 katherine_cheney 2020-03-09 10:57:15 -0700 This is causing test failures for layout tests which rely on the Info.plist bundle identifier (not the one set via the override method) 1627851 1 katherine_cheney 2020-03-09 10:57:43 -0700 <rdar://problem/60204539> 1627856 2 393056 katherine_cheney 2020-03-09 11:14:09 -0700 Created attachment 393056 Patch 1627957 3 393056 pvollan 2020-03-09 14:20:38 -0700 Comment on attachment 393056 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393056&action=review > Tools/WebKitTestRunner/TestController.cpp:643 > + clearApplicationBundleIdentifierTestingOverride(); What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist? 1627959 4 katherine_cheney 2020-03-09 14:23:55 -0700 (In reply to Per Arne Vollan from comment #3) > Comment on attachment 393056 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393056&action=review > > > Tools/WebKitTestRunner/TestController.cpp:643 > > + clearApplicationBundleIdentifierTestingOverride(); > > What happens with the next test if this is executed? Will it use the new > bundle id, or fall back to the one from Info.plist? Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions. 1627961 5 393056 pvollan 2020-03-09 14:27:08 -0700 Comment on attachment 393056 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=393056&action=review R=me. >>> Tools/WebKitTestRunner/TestController.cpp:643 >>> + clearApplicationBundleIdentifierTestingOverride(); >> >> What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist? > > Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions. Sounds good! 1628013 6 katherine_cheney 2020-03-09 16:14:47 -0700 (In reply to Per Arne Vollan from comment #5) > Comment on attachment 393056 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=393056&action=review > > R=me. > > >>> Tools/WebKitTestRunner/TestController.cpp:643 > >>> + clearApplicationBundleIdentifierTestingOverride(); > >> > >> What happens with the next test if this is executed? Will it use the new bundle id, or fall back to the one from Info.plist? > > > > Every test will start out with the Info.plist bundle ID. It will only be changed from that if a test manually sets the bundleID using TestOptions. > > Sounds good! Thanks for the review! 1628035 7 393056 commit-queue 2020-03-09 16:59:45 -0700 Comment on attachment 393056 Patch Clearing flags on attachment: 393056 Committed r258178: <https://trac.webkit.org/changeset/258178> 1628036 8 commit-queue 2020-03-09 16:59:47 -0700 All reviewed patches have been landed. Closing bug. 1628037 9 webkit-bug-importer 2020-03-09 17:00:31 -0700 <rdar://problem/60250510> 393056 2020-03-09 11:14:09 -0700 2020-03-09 16:59:45 -0700 Patch bug-208823-20200309111409.patch text/plain 1989 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MTM3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTdlNmEyNjIwYjJjNzFjOWUyYmFlOGEwMGQ2YmZhZTZm MzUzMjA1ZC4uMWJmZGY3NDBlMDAyZGNjOWJjMTgyOWU0YWFiYjAxZjU4Njk2ODU4MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIwLTAzLTA5ICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVuZXlAYXBwbGUuY29t PgorCisgICAgICAgIFdlYktpdFRlc3RSdW5uZXIgYnVuZGxlSUQgc2hvdWxkIG5vdCBiZSBjbGVh cmVkIGJlZm9yZSBldmVyeSB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMDg4MjMKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYwMjA0NTM5Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMg Y2F1c2luZyB0ZXN0IGZhaWx1cmVzIGZvciBsYXlvdXQgdGVzdHMgd2hpY2ggcmVseSBvbiB0aGUg SW5mby5wbGlzdCAKKyAgICAgICAgYnVuZGxlIGlkZW50aWZpZXIgKG5vdCB0aGUgb25lIHNldCB2 aWEgdGhlIG92ZXJyaWRlIG1ldGhvZCkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL1Rl c3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6OmNyZWF0ZVdl YlZpZXdXaXRoT3B0aW9ucyk6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjplbnN1cmVW aWV3U3VwcG9ydHNPcHRpb25zRm9yVGVzdCk6CisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9j b2NvYS9UZXN0Q29udHJvbGxlckNvY29hLm1tOgorCiAyMDIwLTAzLTA5ICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtXUEVdIFN1cnJv dW5kaW5nIHRleHQgZm9yIGlucHV0IG1ldGhvZHMgc2hvdWxkIG5vdCBiZSBsaW1pdGVkIHRvIHRo ZSBjdXJyZW50IHBhcmFncmFwaApkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9U ZXN0Q29udHJvbGxlci5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVy LmNwcAppbmRleCA0ZGFjMmU2NzdmMDBmNjUxN2Y3YWJiN2ZmNjA3MjFiNzcyZjAyYmI3Li43MWMz NThhMjdkZTI2YzhmYzllNjhlNzJmYzY3NTNhNTJhNmE5MjdlIDEwMDY0NAotLS0gYS9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcAorKysgYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL1Rlc3RDb250cm9sbGVyLmNwcApAQCAtNjQwLDYgKzY0MCw3IEBAIHZvaWQgVGVzdENv bnRyb2xsZXI6OmNyZWF0ZVdlYlZpZXdXaXRoT3B0aW9ucyhjb25zdCBUZXN0T3B0aW9ucyYgb3B0 aW9ucykKICAgICAgICAgZXhpdCgxKTsKICAgICB9CiAgICAgaWYgKCFvcHRpb25zLmFwcGxpY2F0 aW9uQnVuZGxlSWRlbnRpZmllci5pc0VtcHR5KCkpIHsKKyAgICAgICAgY2xlYXJBcHBsaWNhdGlv bkJ1bmRsZUlkZW50aWZpZXJUZXN0aW5nT3ZlcnJpZGUoKTsKICAgICAgICAgc2V0QXBwbGljYXRp b25CdW5kbGVJZGVudGlmaWVyKG9wdGlvbnMuYXBwbGljYXRpb25CdW5kbGVJZGVudGlmaWVyKTsK ICAgICAgICAgbV9oYXNTZXRBcHBsaWNhdGlvbkJ1bmRsZUlkZW50aWZpZXIgPSB0cnVlOwogICAg IH0KQEAgLTgxMiw5ICs4MTMsNiBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjplbnN1cmVWaWV3U3Vw cG9ydHNPcHRpb25zRm9yVGVzdChjb25zdCBUZXN0SW52b2NhdGlvbiYgdGVzdAogICAgICAgICBt X2NyZWF0ZWRPdGhlclBhZ2UgPSBmYWxzZTsKICAgICB9CiAKLSNpZiBQTEFURk9STShDT0NPQSkK LSAgICBjbGVhckFwcGxpY2F0aW9uQnVuZGxlSWRlbnRpZmllclRlc3RpbmdPdmVycmlkZSgpOwot I2VuZGlmCiAKICAgICBjcmVhdGVXZWJWaWV3V2l0aE9wdGlvbnMob3B0aW9ucyk7CiAK