20881 2008-09-16 09:04:05 -0700 change-one-anim.html test causes crash in DRT 2008-09-16 13:16:29 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cmarrin webkit-unassigned dino simon.fraser oldest_to_newest 91363 0 cmarrin 2008-09-16 09:04:05 -0700 This test calls layoutTestController.notifyDone() twice. Simon and I tracked this down as the source of the crashes we have been seeing in DRT. It looks like the crash is happening because notifyDone is being called after the layoutTestController has been destroyed, causing memory corruption. Soon thereafter some random memory smasher happens. Simon is looking at fixing the norifyDone problem. I have also fixed the test to avoid the second call to notifyDone, and the crash goes away. Patch attached. 91364 1 23474 cmarrin 2008-09-16 09:07:50 -0700 Created attachment 23474 Patch to fix bug 91365 2 simon.fraser 2008-09-16 09:09:55 -0700 Change looks good to me. 91372 3 23474 darin 2008-09-16 09:47:25 -0700 Comment on attachment 23474 Patch to fix bug r=me It would be slightly better if the change log explained what was wrong and what the fix accomplishes. 91425 4 simon.fraser 2008-09-16 13:16:29 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/animations/change-one-anim.html M LayoutTests/svg/custom/gradient-attr-update.svg Committed r36520 23474 2008-09-16 09:07:50 -0700 2008-09-16 09:47:25 -0700 Patch to fix bug 20881.patch text/plain 1051 cmarrin SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM2NTAzKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDktMTYgIENocmlzIE1hcnJpbiAgPGNt YXJyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGNoYW5nZS1vbmUtYW5pbS5odG1sIHRlc3QgY2F1c2VzIGNyYXNoIGluIERSVAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4ODEKKwor ICAgICAgICAqIGFuaW1hdGlvbnMvY2hhbmdlLW9uZS1hbmltLmh0bWw6CisKIDIwMDgtMDktMTUg IFJvYiBCdWlzICA8YnVpc0BrZGUub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMuCklu ZGV4OiBMYXlvdXRUZXN0cy9hbmltYXRpb25zL2NoYW5nZS1vbmUtYW5pbS5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL2FuaW1hdGlvbnMvY2hhbmdlLW9uZS1hbmltLmh0bWwJKHJldmlz aW9uIDM2NDYwKQorKysgTGF5b3V0VGVzdHMvYW5pbWF0aW9ucy9jaGFuZ2Utb25lLWFuaW0uaHRt bAkod29ya2luZyBjb3B5KQpAQCAtNzAsOCArNzAsMTAgQEAKICAgICAgICAgICAgIH0KICAgICAg ICAgfQogCi0gICAgICAgIGZ1bmN0aW9uIHN0YXJ0KCkKKyAgICAgICAgZnVuY3Rpb24gc3RhcnQo ZXZlbnQpCiAgICAgICAgIHsKKyAgICAgICAgICAgIGlmIChldmVudC5hbmltYXRpb25OYW1lID09 ICJob3JpeiIpCisgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgc2V0VGltZW91 dCgicmVtb3ZlQW5pbSgpIiwgNTAwKTsKICAgICAgICAgICAgIHNldFRpbWVvdXQoInNuYXBzaG90 KCkiLCA3NTApOwogICAgICAgICAgICAgCg==