208803 2020-03-09 03:12:22 -0700 REGRESSION(r257977): [GTK] http/tests/media/hls/video-cookie.html is a flaky failure 2020-03-10 06:57:15 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino eocanha commit-queue eocanha eric.carlson ews-watchlist glenn jer.noble philipj pnormand sergio webkit-bug-importer oldest_to_newest 1627707 0 dpino 2020-03-09 03:12:22 -0700 Diff: --- /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/retries/http/tests/media/hls/video-cookie-expected.txt +++ /home/igalia/dpino/workspace/webkit-gtk/layout-test-results/retries/http/tests/media/hls/video-cookie-actual.txt @@ -1,4 +1,4 @@ -EVENT(play) +EVENT(stalled) TEST(false) FAIL END OF TEST 1627712 1 eocanha 2020-03-09 03:36:31 -0700 Thanks for finding this regression. It's caused by my patch from bug https://bugs.webkit.org/show_bug.cgi?id=205801 (doesn't happen without it, happens with it). I'm having a look at how to fix it. 1627832 2 393049 eocanha 2020-03-09 10:22:34 -0700 Created attachment 393049 Patch 1627841 3 eocanha 2020-03-09 10:29:21 -0700 Before the fix for bug 205801, when a streaming URL stalled a little bit or went slower than expected a duration for the stream was automatically (wrongly) set by WebKit GStreamer. Having a duration it was easier to trigger the end of the download when the actual end of a live stream was reached (and usually much before that). After the fix for bug 205801 the live streams kept their infinite duration. When the server cut the stream, WebKit GStreamer didn't have a way to tell the difference between that situation and a real stall (because of network/server conditions), so it concluded it was a stall. This patch fixed the test to "help" WebKit a little bit avoiding live streams. After all, testing for a cookie has nothing to do with live or non-liveness. 1627844 4 393052 eocanha 2020-03-09 10:37:10 -0700 Created attachment 393052 Patch 1628150 5 393128 eocanha 2020-03-10 02:45:27 -0700 Created attachment 393128 Patch 1628222 6 393128 commit-queue 2020-03-10 06:56:04 -0700 Comment on attachment 393128 Patch Clearing flags on attachment: 393128 Committed r258205: <https://trac.webkit.org/changeset/258205> 1628223 7 commit-queue 2020-03-10 06:56:06 -0700 All reviewed patches have been landed. Closing bug. 1628224 8 webkit-bug-importer 2020-03-10 06:57:15 -0700 <rdar://problem/60271204> 393049 2020-03-09 10:22:34 -0700 2020-03-09 10:37:06 -0700 Patch bug-208803-20200309172233.patch text/plain 1506 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NjcxCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDgyOGE4NTAxNGViMWNjMmVkNDZk NTFkM2NlNzcyMTMzM2RjODkwMC4uNGE2ZTlhNWQ0NWJlODE5MGRhYTA5NWFiNDMwODA0YjQ1YTNk ZjU1YSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTA5ICBFbnJpcXVlIE9jYcOxYSBH b256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjU3 OTc3KTogW0dUS10gaHR0cC90ZXN0cy9tZWRpYS9obHMvdmlkZW8tY29va2llLmh0bWwgaXMgYSBm bGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDg4MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTdXBwbHkgQ29udGVudC1MZW5ndGgsIHNvIFdlYktpdCBHU3RyZWFtZXIgY2FuIGFjdHVh bGx5IGtub3cgd2hlbiB0aGUgZG93bmxvYWQgaGFzIGZpbmlzaGVkCisgICAgICAgIHdpdGhvdXQg bWlzdGFraW5nIEVPRiB3aXRoIGEgc3RhbGwuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21lZGlh L3Jlc291cmNlcy92aWRlby1jb29raWUtY2hlY2stY29va2llLnBocDoKKwogMjAyMC0wMi0wNCAg QW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgQ1NTIFJ1bGVzIHdp dGggdGhlIHNhbWUgc2VsZWN0b3IgZnJvbSBzZXZlcmFsIGxhcmdlIHN0eWxlc2hlZXRzIGFyZSBh cHBsaWVkIGluIHRoZSB3cm9uZyBvcmRlcgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9tZWRpYS9yZXNvdXJjZXMvdmlkZW8tY29va2llLWNoZWNrLWNvb2tpZS5waHAgYi9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3Jlc291cmNlcy92aWRlby1jb29raWUtY2hlY2stY29v a2llLnBocAppbmRleCA0MmQ3NTBmNGM1NDJmYTgwMzYxMjhjNDVkMjRkOGVmOGNlZGZlMTc2Li44 ZWVkNWY4Mjg0ZTJjZDg0NmI0ZGUxMTdiNWRjMWNiODA4YTIyMzRmIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3Jlc291cmNlcy92aWRlby1jb29raWUtY2hlY2stY29v a2llLnBocAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3Jlc291cmNlcy92aWRl by1jb29raWUtY2hlY2stY29va2llLnBocApAQCAtMTYsNiArMTYsNyBAQAogCiAgICAgICAgIGhl YWRlcigiQ2FjaGUtQ29udHJvbDogbm8tc3RvcmUiKTsKICAgICAgICAgaGVhZGVyKCJDb25uZWN0 aW9uOiBjbG9zZSIpOworICAgICAgICBoZWFkZXIoIkNvbnRlbnQtTGVuZ3RoOiAiIC4gZmlsZXNp emUoJGZpbGVOYW1lKSk7CiAKICAgICAgICAgJGZuID0gZm9wZW4oJGZpbGVOYW1lLCAiciIpOwog ICAgICAgICBmcGFzc3RocnUoJGZuKTsK 393052 2020-03-09 10:37:10 -0700 2020-03-10 02:45:22 -0700 Patch bug-208803-20200309173708.patch text/plain 1536 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MTQ2CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDI2NjQ2MWQxYzVjMmM5MTVjYzEx YjUzOWY2Yzg1MTQ3MGFhY2Q2MS4uNWE3OThhMjQ2ZGVlYTQwM2E1Yjc3OTk3MDE0ZmIwOGU5OWEy NjIzYyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTA5ICBFbnJpcXVlIE9jYcOxYSBH b256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjU3 OTc3KTogW0dUS10gaHR0cC90ZXN0cy9tZWRpYS9obHMvdmlkZW8tY29va2llLmh0bWwgaXMgYSBm bGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDg4MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTdXBwbHkgQ29udGVudC1MZW5ndGgsIHNvIFdlYktpdCBHU3RyZWFtZXIgY2FuIGFjdHVh bGx5IGtub3cgd2hlbiB0aGUgZG93bmxvYWQgaGFzIGZpbmlzaGVkCisgICAgICAgIHdpdGhvdXQg bWlzdGFraW5nIEVPRiB3aXRoIGEgc3RhbGwuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21lZGlh L3Jlc291cmNlcy92aWRlby1jb29raWUtY2hlY2stY29va2llLnBocDoKKwogMjAyMC0wMy0wOSAg SmFzb24gTGF3cmVuY2UgIDxsYXdyZW5jZS5qQGFwcGxlLmNvbT4KIAogICAgICAgICBbIGlPUyBh bmQgTWFjIERlYnVnIF0gZmFzdC9jYW52YXMvd2ViZ2wvc2ltdWxhdGVkLXZlcnRleEF0dHJpYjAt aW52YWxpZC1pbmRpY2llcy5odG1sIGlzIGZsYWt5IHRpbWluZyBvdXQgYW5kIGNyYXNoaW5nLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS9yZXNvdXJjZXMvdmlkZW8t Y29va2llLWNoZWNrLWNvb2tpZS5waHAgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3Jl c291cmNlcy92aWRlby1jb29raWUtY2hlY2stY29va2llLnBocAppbmRleCA0MmQ3NTBmNGM1NDJm YTgwMzYxMjhjNDVkMjRkOGVmOGNlZGZlMTc2Li44ZWVkNWY4Mjg0ZTJjZDg0NmI0ZGUxMTdiNWRj MWNiODA4YTIyMzRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL3Jl c291cmNlcy92aWRlby1jb29raWUtY2hlY2stY29va2llLnBocAorKysgYi9MYXlvdXRUZXN0cy9o dHRwL3Rlc3RzL21lZGlhL3Jlc291cmNlcy92aWRlby1jb29raWUtY2hlY2stY29va2llLnBocApA QCAtMTYsNiArMTYsNyBAQAogCiAgICAgICAgIGhlYWRlcigiQ2FjaGUtQ29udHJvbDogbm8tc3Rv cmUiKTsKICAgICAgICAgaGVhZGVyKCJDb25uZWN0aW9uOiBjbG9zZSIpOworICAgICAgICBoZWFk ZXIoIkNvbnRlbnQtTGVuZ3RoOiAiIC4gZmlsZXNpemUoJGZpbGVOYW1lKSk7CiAKICAgICAgICAg JGZuID0gZm9wZW4oJGZpbGVOYW1lLCAiciIpOwogICAgICAgICBmcGFzc3RocnUoJGZuKTsK 393128 2020-03-10 02:45:27 -0700 2020-03-10 06:56:04 -0700 Patch bug-208803-20200310094525.patch text/plain 2631 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MTkwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMDk0ZmFhMjgxNTEwZGY1Mjg4OTQz M2QxOTc2ZTQzZjkxNzViZjdiYy4uYmMzYzdjNDliYjQ4YmMyNGEzYTQ5ODA4YzlmNDExNzc5ZjMx NjNiNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTEwICBFbnJpcXVlIE9jYcOxYSBH b256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjU3 OTc3KTogW0dUS10gaHR0cC90ZXN0cy9tZWRpYS9obHMvdmlkZW8tY29va2llLmh0bWwgaXMgYSBm bGFreSBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDg4MDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTdXBwbHkgQ29udGVudC1MZW5ndGgsIHNvIFdlYktpdCBHU3RyZWFtZXIgY2FuIGFjdHVh bGx5IGtub3cgd2hlbiB0aGUgZG93bmxvYWQgaGFzIGZpbmlzaGVkCisgICAgICAgIHdpdGhvdXQg bWlzdGFraW5nIEVPRiB3aXRoIGEgc3RhbGwuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21lZGlh L3Jlc291cmNlcy92aWRlby1jb29raWUtY2hlY2stY29va2llLnBocDogU3VwcGx5IENvbnRlbnQt TGVuZ3RoLgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOiBSZW1vdmVk IHRoZSB0ZXN0IGFzIGZhaWxpbmcuCisKIDIwMjAtMDMtMDkgIFphbGFuIEJ1anRhcyAgPHphbGFu QGFwcGxlLmNvbT4KIAogICAgICAgICBbTGF5b3V0VGVzdHNdIERvIG5vdCBleHBvc2UgZGlkQWRk SG9yaXpvbnRhbC9WZXJ0aWNhbFNjcm9sbGJhciBhbmQgd2lsbFJlbW92ZUhvcml6b250YWwvVmVy dGljYWxTY3JvbGxiYXIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEv cmVzb3VyY2VzL3ZpZGVvLWNvb2tpZS1jaGVjay1jb29raWUucGhwIGIvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9tZWRpYS9yZXNvdXJjZXMvdmlkZW8tY29va2llLWNoZWNrLWNvb2tpZS5waHAKaW5k ZXggNDJkNzUwZjRjNTQyZmE4MDM2MTI4YzQ1ZDI0ZDhlZjhjZWRmZTE3Ni4uOGVlZDVmODI4NGUy Y2Q4NDZiNGRlMTE3YjVkYzFjYjgwOGEyMjM0ZiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9tZWRpYS9yZXNvdXJjZXMvdmlkZW8tY29va2llLWNoZWNrLWNvb2tpZS5waHAKKysr IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS9yZXNvdXJjZXMvdmlkZW8tY29va2llLWNo ZWNrLWNvb2tpZS5waHAKQEAgLTE2LDYgKzE2LDcgQEAKIAogICAgICAgICBoZWFkZXIoIkNhY2hl LUNvbnRyb2w6IG5vLXN0b3JlIik7CiAgICAgICAgIGhlYWRlcigiQ29ubmVjdGlvbjogY2xvc2Ui KTsKKyAgICAgICAgaGVhZGVyKCJDb250ZW50LUxlbmd0aDogIiAuIGZpbGVzaXplKCRmaWxlTmFt ZSkpOwogCiAgICAgICAgICRmbiA9IGZvcGVuKCRmaWxlTmFtZSwgInIiKTsKICAgICAgICAgZnBh c3N0aHJ1KCRmbik7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4 cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmlu ZGV4IGVlZjAwYzE3M2FmMTE0MWFkNDlkODhkNTg0Mjk5MzRmZDhjYmI1NjguLjFiZTllZDgxZDZm YWQ1NzJiMjk3OTAzYWJmMWZmY2E3ZjA4ZTAyNjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0 ay9UZXN0RXhwZWN0YXRpb25zCkBAIC0yNzAxLDggKzI3MDEsNiBAQCB3ZWJraXQub3JnL2IvMjA4 NDI5IGZhc3QvY3NzL3VzZXItZHJhZy1ub25lLmh0bWwgWyBUaW1lb3V0IFBhc3MgXQogaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvdjIvY3Jvc3Mt b3JpZ2luLWVmZmVjdHMuc3ViLmh0bWwgWyBNaXNzaW5nIF0KIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvaW50ZXJzZWN0aW9uLW9ic2VydmVyL3YyL2Nyb3NzLW9yaWdpbi1vY2NsdXNp b24uc3ViLmh0bWwgWyBNaXNzaW5nIF0KIAotd2Via2l0Lm9yZy9iLzIwODgwMyBodHRwL3Rlc3Rz L21lZGlhL2hscy92aWRlby1jb29raWUuaHRtbCBbIEZhaWx1cmUgUGFzcyBdCi0KIHdlYmtpdC5v cmcvYi8yMDg4MDkgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvV09GRjIvYmxv Y2tzLWV4dHJhbmVvdXMtZGF0YS0wMDEueGh0IFsgSW1hZ2VPbmx5RmFpbHVyZSBQYXNzIF0KIHdl YmtpdC5vcmcvYi8yMDg4MDkgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3MvV09G RjIvYmxvY2tzLWV4dHJhbmVvdXMtZGF0YS0wMDIueGh0IFsgSW1hZ2VPbmx5RmFpbHVyZSBQYXNz IF0KIHdlYmtpdC5vcmcvYi8yMDg4MDkgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9j c3MvV09GRjIvYmxvY2tzLWV4dHJhbmVvdXMtZGF0YS0wMDMueGh0IFsgSW1hZ2VPbmx5RmFpbHVy ZSBQYXNzIF0K