208796 2020-03-08 20:22:49 -0700 [LFC][IFC] Do not floor the computed intrinsic width values 2020-03-09 07:51:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1627647 0 zalan 2020-03-08 20:22:49 -0700 floored values could lead to unexpected line breaks 1627648 1 webkit-bug-importer 2020-03-08 20:23:07 -0700 <rdar://problem/60209522> 1627649 2 393007 zalan 2020-03-08 20:27:49 -0700 Created attachment 393007 Patch 1627750 3 393007 commit-queue 2020-03-09 07:51:34 -0700 Comment on attachment 393007 Patch Clearing flags on attachment: 393007 Committed r258138: <https://trac.webkit.org/changeset/258138> 1627751 4 commit-queue 2020-03-09 07:51:35 -0700 All reviewed patches have been landed. Closing bug. 393007 2020-03-08 20:27:49 -0700 2020-03-09 07:51:34 -0700 Patch bug-208796-20200308202749.patch text/plain 7608 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzllNGZiYmQ2NzA1ZGZm MGU3MjcyYzQ2MGQ1NzVhZGY5MzBhNGY0Yi4uMzI5MzMwZTYxMzNiMzFiMjdhMWU5OWE2ODUzNDYz NmQ3N2RlMDJlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAzLTA4ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBEbyBub3Qg Zmxvb3IgdGhlIGNvbXB1dGVkIGludHJpbnNpYyB3aWR0aCB2YWx1ZXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODc5NgorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNjAyMDk1MjI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgRmxvb3JlZCBpbnRyaW5zaWMgdmFsdWVzIGNvdWxkIGxlYWQgdG8gdW5leHBl Y3RlZCBsaW5lIGJyZWFrcy4KKyAgICAgICAgKFRoaXMgaGFwcGVucyBiZWNhdXNlIElGQyB1c2Vz IGZsb2F0IGN1cnJlbnRseSwgd2hpbGUgb3RoZXIgbGF5b3V0IHN5c3RlbXMgdXNlIExheW91dFVu aXQuKQorCisgICAgICAgIFRlc3Q6IGZhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvYWJzb2x1 dGUtcG9zaXRpb25lZC1zaW1wbGUtdGFibGUzLmh0bWwKKworICAgICAgICAqIGxheW91dC9MYXlv dXRVbml0cy5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpjZWlsZWRMYXlvdXRVbml0KToK KyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4 dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdDb250ZXh0 Ojpjb21wdXRlZEludHJpbnNpY1dpZHRoQ29uc3RyYWludHMpOgorICAgICAgICAoV2ViQ29yZTo6 TGF5b3V0OjpJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZWRJbnRyaW5zaWNXaWR0aEZv ckNvbnN0cmFpbnQgY29uc3QpOgorICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZUZvcm1hdHRpbmdDb250ZXh0Lmg6CisKIDIwMjAtMDMtMDggIFphbGFuIEJ1anRhcyAgPHph bGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtURkNdIERvIG5vIHRyeSB0byBkaXN0cmli dXRlIGV4dHJhIHNwYWNlIGluIGNhc2Ugb2Ygc2hyaW5rIHRvIGZpdCAobWF4IHByZWZlcnJlZCB3 aWR0aCkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvTGF5b3V0VW5pdHMuaCBi L1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRVbml0cy5oCmluZGV4IGEyYmUzYzlmZjlhNmMy ZDA1ZmY0YzkzYjE0YzUzMmNmMjJmZjNmM2MuLmMxMzExZjljNmU5OTYwOWJlNDMwZjA1ODE0NWQw ZDBlZjM2M2FmMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRVbml0 cy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9MYXlvdXRVbml0cy5oCkBAIC0xODUsNiAr MTg1LDExIEBAIGlubGluZSBMYXlvdXRVbml0IHRvTGF5b3V0VW5pdChJbmxpbmVMYXlvdXRVbml0 IHZhbHVlKQogICAgIHJldHVybiBMYXlvdXRVbml0IHsgdmFsdWUgfTsKIH0KIAoraW5saW5lIExh eW91dFVuaXQgY2VpbGVkTGF5b3V0VW5pdChJbmxpbmVMYXlvdXRVbml0IHZhbHVlKQoreworICAg IHJldHVybiBMYXlvdXRVbml0Ojpmcm9tRmxvYXRDZWlsKHZhbHVlKTsKK30KKwogaW5saW5lIExh eW91dFBvaW50IHRvTGF5b3V0UG9pbnQoY29uc3QgSW5saW5lTGF5b3V0UG9pbnQmIHBvaW50KQog ewogICAgIHJldHVybiBMYXlvdXRQb2ludCB7IHBvaW50IH07CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0 aW5nQ29udGV4dC5jcHAKaW5kZXggZGZmZDkzZTA1MTU0ZWYyYzRmNjYxMTFiY2E5MzZhNTc3OTJi NDkyNy4uNTlhZTg5NWUzODFhMmY0ODg3OTU1OWUzNzU3Nzg5ZGM5YjZmYjg5NSAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGlu Z0NvbnRleHQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5n L0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcApAQCAtMjIyLDE1ICsyMjIsMTcgQEAgRm9ybWF0 dGluZ0NvbnRleHQ6OkludHJpbnNpY1dpZHRoQ29uc3RyYWludHMgSW5saW5lRm9ybWF0dGluZ0Nv bnRleHQ6OmNvbXB1dGVkSW4KICAgICAgICAgICAgIGF1dG8gY29udGVudFdpZHRoID0gKGF2YWls YWJsZVdpZHRoID8gaW50cmluc2ljV2lkdGhzLT5tYXhpbXVtIDogaW50cmluc2ljV2lkdGhzLT5t aW5pbXVtKSAtIGRpc3BsYXlCb3guaG9yaXpvbnRhbE1hcmdpbkJvcmRlckFuZFBhZGRpbmcoKTsK ICAgICAgICAgICAgIGRpc3BsYXlCb3guc2V0Q29udGVudEJveFdpZHRoKGNvbnRlbnRXaWR0aCk7 CiAgICAgICAgIH0KLSAgICAgICAgcmV0dXJuIGNvbXB1dGVkSW50cmluc2ljV2lkdGhGb3JDb25z dHJhaW50KHsgMF9sdSwgdG9MYXlvdXRVbml0KGF2YWlsYWJsZVdpZHRoKSB9KTsKKyAgICAgICAg cmV0dXJuIGNvbXB1dGVkSW50cmluc2ljV2lkdGhGb3JDb25zdHJhaW50KGF2YWlsYWJsZVdpZHRo KTsKICAgICB9OwogCi0gICAgYXV0byBjb25zdHJhaW50cyA9IGdlb21ldHJ5KCkuY29uc3RyYWlu QnlNaW5NYXhXaWR0aChyb290KCksIHsgdG9MYXlvdXRVbml0KG1heGltdW1MaW5lV2lkdGgoMCkp LCB0b0xheW91dFVuaXQobWF4aW11bUxpbmVXaWR0aChtYXhJbmxpbmVMYXlvdXRVbml0KCkpKSB9 KTsKKyAgICBhdXRvIG1pbmltdW1Db250ZW50V2lkdGggPSBjZWlsZWRMYXlvdXRVbml0KG1heGlt dW1MaW5lV2lkdGgoMCkpOworICAgIGF1dG8gbWF4aW11bUNvbnRlbnRXaWR0aCA9IGNlaWxlZExh eW91dFVuaXQobWF4aW11bUxpbmVXaWR0aChtYXhJbmxpbmVMYXlvdXRVbml0KCkpKTsKKyAgICBh dXRvIGNvbnN0cmFpbnRzID0gZ2VvbWV0cnkoKS5jb25zdHJhaW5CeU1pbk1heFdpZHRoKHJvb3Qo KSwgeyBtaW5pbXVtQ29udGVudFdpZHRoLCBtYXhpbXVtQ29udGVudFdpZHRoIH0pOwogICAgIGZv cm1hdHRpbmdTdGF0ZSgpLnNldEludHJpbnNpY1dpZHRoQ29uc3RyYWludHMoY29uc3RyYWludHMp OwogICAgIHJldHVybiBjb25zdHJhaW50czsKIH0KIAotSW5saW5lTGF5b3V0VW5pdCBJbmxpbmVG b3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZWRJbnRyaW5zaWNXaWR0aEZvckNvbnN0cmFpbnQoY29u c3QgSG9yaXpvbnRhbENvbnN0cmFpbnRzJiBob3Jpem9udGFsQ29uc3RyYWludHMpIGNvbnN0CitJ bmxpbmVMYXlvdXRVbml0IElubGluZUZvcm1hdHRpbmdDb250ZXh0Ojpjb21wdXRlZEludHJpbnNp Y1dpZHRoRm9yQ29uc3RyYWludChJbmxpbmVMYXlvdXRVbml0IGF2YWlsYWJsZVdpZHRoKSBjb25z dAogewogICAgIGF1dG8mIGlubGluZUl0ZW1zID0gZm9ybWF0dGluZ1N0YXRlKCkuaW5saW5lSXRl bXMoKTsKICAgICBhdXRvIG1heGltdW1MaW5lV2lkdGggPSBJbmxpbmVMYXlvdXRVbml0IHsgfTsK QEAgLTIzOSw3ICsyNDEsNyBAQCBJbmxpbmVMYXlvdXRVbml0IElubGluZUZvcm1hdHRpbmdDb250 ZXh0Ojpjb21wdXRlZEludHJpbnNpY1dpZHRoRm9yQ29uc3RyYWludChjbwogICAgIGF1dG8gbGF5 b3V0UmFuZ2UgPSBMaW5lTGF5b3V0Q29udGV4dDo6SW5saW5lSXRlbVJhbmdlIHsgMCAsIGlubGlu ZUl0ZW1zLnNpemUoKSB9OwogICAgIHdoaWxlICghbGF5b3V0UmFuZ2UuaXNFbXB0eSgpKSB7CiAg ICAgICAgIC8vIE9ubHkgdGhlIGhvcml6dG9uYWwgYXZhaWxhYmxlIHdpZHRoIGlzIGNvbnN0cmFp bmVkIHdoZW4gY29tcHV0aW5nIGludHJpbnNpYyB3aWR0aC4KLSAgICAgICAgbGluZUJ1aWxkZXIu aW5pdGlhbGl6ZShMaW5lQnVpbGRlcjo6Q29uc3RyYWludHMgeyB7IH0sIGhvcml6b250YWxDb25z dHJhaW50cy5sb2dpY2FsV2lkdGgsIGZhbHNlLCB7IH0gfSk7CisgICAgICAgIGxpbmVCdWlsZGVy LmluaXRpYWxpemUoTGluZUJ1aWxkZXI6OkNvbnN0cmFpbnRzIHsgeyB9LCBhdmFpbGFibGVXaWR0 aCwgZmFsc2UsIHsgfSB9KTsKICAgICAgICAgYXV0byBsaW5lQ29udGVudCA9IGxpbmVMYXlvdXRD b250ZXh0LmxheW91dExpbmUobGluZUJ1aWxkZXIsIGxheW91dFJhbmdlLCB7IH0pOwogICAgICAg ICBsYXlvdXRSYW5nZS5zdGFydCA9ICpsaW5lQ29udGVudC50cmFpbGluZ0lubGluZUl0ZW1JbmRl eCArIDE7CiAgICAgICAgIC8vIEZJWE1FOiBVc2UgbGluZSBsb2dpY2FsIGxlZnQgYW5kIHJpZ2h0 IHRvIHRha2UgZmxvYXRzIGludG8gYWNjb3VudC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmggYi9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4 dC5oCmluZGV4IDUyNzk4NjZmYmVjNDA3OWI1YjlhMTBjMWUyZTM5YjJkNGYwMjRhMGMuLjg4Yjk5 MjBhZjFmOGQ4OTUzOTY5Nzk1ZDQ4ZTlkYjE4ODQwM2E1NzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmgK KysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0 dGluZ0NvbnRleHQuaApAQCAtODAsNyArODAsNyBAQCBwcml2YXRlOgogICAgIHZvaWQgbGluZUxh eW91dChJbmxpbmVJdGVtcyYsIExpbmVMYXlvdXRDb250ZXh0OjpJbmxpbmVJdGVtUmFuZ2UsIGNv bnN0IEhvcml6b250YWxDb25zdHJhaW50cyYsIGNvbnN0IFZlcnRpY2FsQ29uc3RyYWludHMmKTsK IAogICAgIHZvaWQgY29tcHV0ZUludHJpbnNpY1dpZHRoRm9yRm9ybWF0dGluZ1Jvb3QoY29uc3Qg Qm94Jik7Ci0gICAgSW5saW5lTGF5b3V0VW5pdCBjb21wdXRlZEludHJpbnNpY1dpZHRoRm9yQ29u c3RyYWludChjb25zdCBIb3Jpem9udGFsQ29uc3RyYWludHMmKSBjb25zdDsKKyAgICBJbmxpbmVM YXlvdXRVbml0IGNvbXB1dGVkSW50cmluc2ljV2lkdGhGb3JDb25zdHJhaW50KElubGluZUxheW91 dFVuaXQgYXZhaWxhYmxlV2lkdGgpIGNvbnN0OwogCiAgICAgdm9pZCBjb21wdXRlSG9yaXpvbnRh bE1hcmdpbihjb25zdCBCb3gmLCBjb25zdCBIb3Jpem9udGFsQ29uc3RyYWludHMmKTsKICAgICB2 b2lkIGNvbXB1dGVIZWlnaHRBbmRNYXJnaW4oY29uc3QgQm94JiwgY29uc3QgSG9yaXpvbnRhbENv bnN0cmFpbnRzJik7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWZlYjhlZmI4YTI2ODI0MDk1ODRjYmZkNGM1YWZkZGU3MmJl NDgwMy4uNDIxMzg1ZmU3MWFmZmQ0MjUyZmRiYjY3NmNlYmI2NzU0NWY5MWJmMSAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE0IEBACisyMDIwLTAzLTA4ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+ CisKKyAgICAgICAgW0xGQ11bSUZDXSBEbyBub3QgZmxvb3IgdGhlIGNvbXB1dGVkIGludHJpbnNp YyB3aWR0aCB2YWx1ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwODc5NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAyMDk1MjI+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2xheW91dGZv cm1hdHRpbmdjb250ZXh0L2Fic29sdXRlLXBvc2l0aW9uZWQtc2ltcGxlLXRhYmxlMy1leHBlY3Rl ZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2Fi c29sdXRlLXBvc2l0aW9uZWQtc2ltcGxlLXRhYmxlMy5odG1sOiBBZGRlZC4KKwogMjAyMC0wMy0w NyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW1Zlcmlm aWNhdGlvbl0gVXNlIHRoZSB0YWJsZSB3cmFwcGVyIGJveCdzIG9mZnNldCB3aGVuIG1hdGNoaW5n IG91dC1vZi1mbG93IHRhYmxlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9sYXlvdXRm b3JtYXR0aW5nY29udGV4dC9hYnNvbHV0ZS1wb3NpdGlvbmVkLXNpbXBsZS10YWJsZTMtZXhwZWN0 ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvYWJzb2x1 dGUtcG9zaXRpb25lZC1zaW1wbGUtdGFibGUzLWV4cGVjdGVkLmh0bWwKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTQ0 NDEwZmQ1NjQ3ZDQyNjY2ZjdmYWYzMGQ1ODY0MWU3MTg0M2I4NAotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvYWJzb2x1dGUtcG9zaXRp b25lZC1zaW1wbGUtdGFibGUzLWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw3IEBACis8IURPQ1RZ UEUgaHRtbD4gPCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBpbnRlcm5hbDpMYXlvdXRGb3JtYXR0 aW5nQ29udGV4dEVuYWJsZWQ9dHJ1ZSBpbnRlcm5hbDpMYXlvdXRGb3JtYXR0aW5nQ29udGV4dElu dGVncmF0aW9uRW5hYmxlZD1mYWxzZSBdIC0tPgorPHN0eWxlPgorZGl2IHsKKyAgICBwYWRkaW5n OiA0NXB4OworfQorPC9zdHlsZT4KKzxkaXY+dGV4dCBjb250ZW50IHRleHQgY29udGVudDwvZGl2 PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4dC9h YnNvbHV0ZS1wb3NpdGlvbmVkLXNpbXBsZS10YWJsZTMuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv bGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvYWJzb2x1dGUtcG9zaXRpb25lZC1zaW1wbGUtdGFibGUz Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uNDcyMzgxZWM0MDE3YzVjYTdiYjc3NzBiOTYzZmJiZmM1MGFjYTA3 OAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2Nv bnRleHQvYWJzb2x1dGUtcG9zaXRpb25lZC1zaW1wbGUtdGFibGUzLmh0bWwKQEAgLTAsMCArMSw5 IEBACis8IURPQ1RZUEUgaHRtbD4gPCEtLSB3ZWJraXQtdGVzdC1ydW5uZXIgWyBpbnRlcm5hbDpM YXlvdXRGb3JtYXR0aW5nQ29udGV4dEVuYWJsZWQ9dHJ1ZSBpbnRlcm5hbDpMYXlvdXRGb3JtYXR0 aW5nQ29udGV4dEludGVncmF0aW9uRW5hYmxlZD1mYWxzZSBdIC0tPgorPHN0eWxlPgordGFibGUg eworICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKKyAgICB0b3A6IDUwcHg7CisgICAgbGVmdDogNTBw eDsKK30KKzwvc3R5bGU+Cis8dGFibGU+PHRyPjx0ZD50ZXh0IGNvbnRlbnQ8L3RkPjx0ZD50ZXh0 IGNvbnRlbnQ8L3RkPjwvdHI+PC90YWJsZT4K