208774 2020-03-07 15:25:24 -0800 Generalize setSynchronousScrollingReasons() to take a ScrollingNodeID 2020-03-07 20:36:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cmarcelo commit-queue ews-watchlist fred.wang jamesr koivisto luiz simon.fraser thorton tonikitoo webkit-bug-importer zalan oldest_to_newest 1627333 0 simon.fraser 2020-03-07 15:25:24 -0800 Generalize setSynchronousScrollingReasons() to take a ScrollingNodeID 1627334 1 392902 simon.fraser 2020-03-07 15:26:26 -0800 Created attachment 392902 Patch 1627450 2 392902 commit-queue 2020-03-07 20:35:47 -0800 Comment on attachment 392902 Patch Clearing flags on attachment: 392902 Committed r258098: <https://trac.webkit.org/changeset/258098> 1627451 3 commit-queue 2020-03-07 20:35:48 -0800 All reviewed patches have been landed. Closing bug. 1627452 4 webkit-bug-importer 2020-03-07 20:36:16 -0800 <rdar://problem/60195850> 392902 2020-03-07 15:26:26 -0800 2020-03-07 20:35:47 -0800 Patch bug-208774-20200307152625.patch text/plain 7194 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MDc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQzNWM5NTg3OWEzNDk3 N2M3N2JlZTFlYTc0ZDFiNWU5YjNjY2EzOS4uYjIwNWExYjkyNGYwZmNmNmI5YjNkM2I1N2RkOGZh OTgxNzQ2MzM2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAzLTA3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEdlbmVyYWxpemUg c2V0U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKCkgdG8gdGFrZSBhIFNjcm9sbGluZ05vZGVJ RAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4Nzc0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UnbGwg YmUgY2FsbGluZyBzZXRTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMoKSBmb3Igb3ZlcmZsb3cg bm9kZXMgYXQgc29tZSBwb2ludCwKKyAgICAgICAgc28gY2hhbmdlIHRoZSBhcmd1bWVudCBmcm9t IEZyYW1lVmlldyB0byBTY3JvbGxpbmdOb2RlSUQuCisKKyAgICAgICAgKiBwYWdlL3Njcm9sbGlu Zy9Bc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFzeW5j U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyk6Cisg ICAgICAgICogcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5oOgorICAg ICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlNjcm9sbGluZ0Nvb3JkaW5hdG9yOjp1cGRhdGVTeW5jaHJvbm91c1Njcm9sbGlu Z1JlYXNvbnMpOgorICAgICAgICAqIHBhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9y Lmg6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdDb29yZGluYXRvcjo6c2V0U3luY2hyb25v dXNTY3JvbGxpbmdSZWFzb25zKToKKwogMjAyMC0wMy0wNyAgWmFsYW4gQnVqdGFzICA8emFsYW5A YXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10gVXNlIHN0YXJ0LWFsaWduZWQgaG9yaXpv bnRhbCBhZGp1c3RtZW50IHdoZW4ganVzdGlmeSBpcyBub3QgZWxpZ2libGUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4 IGUxOGI0YjI0M2NjOGUzZDk0N2JhMzZlYzBhZGE1NDg3N2EwYjI2YzAuLmI2NzZjZjg3Njg4ZmNk NWZhMGExYmU0ZjMzNzlmZTg2MjQ3MzY2OGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIw MjAtMDMtMDcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAg ICAgR2VuZXJhbGl6ZSBzZXRTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbnMoKSB0byB0YWtlIGEg U2Nyb2xsaW5nTm9kZUlECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMDg3NzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXaGl0ZXNwYWNlLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL0V2ZW50 RGlzcGF0Y2hlci5oOgorCiAyMDIwLTAzLTA3ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUu Y29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgdW5pZmllZCBidWlsZCBmaXg7IGZvcndhcmQgZGVj bGFyZSByZWZlcmVuY2VkIHR5cGVzLiBJbiB0aGlzIGNhc2UsIFdlYkNvcmU6OkltYWdlRGF0YS4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5n Q29vcmRpbmF0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3Jv bGxpbmdDb29yZGluYXRvci5jcHAKaW5kZXggYzVlNTVlYWU0NTgzZDMxMmNhN2U1MmFkODBlZTFk MjZlMGRhMjIxMy4uZWQ3MjAzNjc0MzUyM2Q1YzljOTBiM2VjODQ2MDY3YzAxZmQ3MDhkZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxpbmdDb29y ZGluYXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3Jv bGxpbmdDb29yZGluYXRvci5jcHAKQEAgLTczMiwxNyArNzMyLDE5IEBAIHZvaWQgQXN5bmNTY3Jv bGxpbmdDb29yZGluYXRvcjo6c2V0UmVsYXRlZE92ZXJmbG93U2Nyb2xsaW5nTm9kZXMoU2Nyb2xs aW5nTm9kZUlECiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQogCi12b2lkIEFzeW5j U2Nyb2xsaW5nQ29vcmRpbmF0b3I6OnNldFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyhGcmFt ZVZpZXcmIGZyYW1lVmlldywgT3B0aW9uU2V0PFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29uPiBy ZWFzb25zKQordm9pZCBBc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yOjpzZXRTeW5jaHJvbm91c1Nj cm9sbGluZ1JlYXNvbnMoU2Nyb2xsaW5nTm9kZUlEIG5vZGVJRCwgT3B0aW9uU2V0PFN5bmNocm9u b3VzU2Nyb2xsaW5nUmVhc29uPiByZWFzb25zKQogewotICAgIGF1dG8qIHNjcm9sbGluZ1N0YXRl Tm9kZSA9IHN0YXRpY19jYXN0PFNjcm9sbGluZ1N0YXRlRnJhbWVTY3JvbGxpbmdOb2RlKj4obV9z Y3JvbGxpbmdTdGF0ZVRyZWUtPnN0YXRlTm9kZUZvcklEKGZyYW1lVmlldy5zY3JvbGxpbmdOb2Rl SUQoKSkpOworICAgIGF1dG8qIHNjcm9sbGluZ1N0YXRlTm9kZSA9IHN0YXRpY19jYXN0PFNjcm9s bGluZ1N0YXRlU2Nyb2xsaW5nTm9kZSo+KG1fc2Nyb2xsaW5nU3RhdGVUcmVlLT5zdGF0ZU5vZGVG b3JJRChub2RlSUQpKTsKICAgICBpZiAoIXNjcm9sbGluZ1N0YXRlTm9kZSkKICAgICAgICAgcmV0 dXJuOwogCi0gICAgLy8gVGhlIEZyYW1lVmlldydzIEdyYXBoaWNzTGF5ZXIgaXMgbGlrZWx5IHRv IGJlIG91dC1vZi1zeW5jaCB3aXRoIHRoZSBQbGF0Zm9ybUxheWVyCi0gICAgLy8gYXQgdGhpcyBw b2ludC4gU28gd2UnbGwgdXBkYXRlIGl0IGJlZm9yZSB3ZSBzd2l0Y2ggYmFjayB0byBtYWluIHRo cmVhZCBzY3JvbGxpbmcKLSAgICAvLyBpbiBvcmRlciB0byBhdm9pZCBsYXllciBwb3NpdGlvbmlu ZyBidWdzLgotICAgIGlmIChyZWFzb25zKQotICAgICAgICByZWNvbmNpbGVTY3JvbGxQb3NpdGlv bihmcmFtZVZpZXcsIFNjcm9sbGluZ0xheWVyUG9zaXRpb25BY3Rpb246OlNldCk7CisgICAgaWYg KHJlYXNvbnMgJiYgaXM8U2Nyb2xsaW5nU3RhdGVGcmFtZVNjcm9sbGluZ05vZGU+KHNjcm9sbGlu Z1N0YXRlTm9kZSkpIHsKKyAgICAgICAgLy8gVGhlIEZyYW1lVmlldydzIEdyYXBoaWNzTGF5ZXIg aXMgbGlrZWx5IHRvIGJlIG91dC1vZi1zeW5jaCB3aXRoIHRoZSBQbGF0Zm9ybUxheWVyCisgICAg ICAgIC8vIGF0IHRoaXMgcG9pbnQuIFNvIHdlJ2xsIHVwZGF0ZSBpdCBiZWZvcmUgd2Ugc3dpdGNo IGJhY2sgdG8gbWFpbiB0aHJlYWQgc2Nyb2xsaW5nCisgICAgICAgIC8vIGluIG9yZGVyIHRvIGF2 b2lkIGxheWVyIHBvc2l0aW9uaW5nIGJ1Z3MuCisgICAgICAgIGlmIChhdXRvKiBmcmFtZVZpZXcg PSBmcmFtZVZpZXdGb3JTY3JvbGxpbmdOb2RlKG5vZGVJRCkpCisgICAgICAgICAgICByZWNvbmNp bGVTY3JvbGxQb3NpdGlvbigqZnJhbWVWaWV3LCBTY3JvbGxpbmdMYXllclBvc2l0aW9uQWN0aW9u OjpTZXQpOworICAgIH0KIAogICAgIC8vIEZJWE1FOiBJZGVhbGx5IGFsbCB0aGUgInN5bmNocm9u b3VzU2Nyb2xsaW5nUmVhc29ucyIgZnVuY3Rpb25zIHNob3VsZCBiZSAjaWZkZWZmZWQuCiAjaWYg RU5BQkxFKFNDUk9MTElOR19USFJFQUQpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9w YWdlL3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKaW5kZXggNzhiMzQzMTE0 ODg1NTU4ZDMwMTEyOTdmOTIxMDJkMmQwNzQ2YWUyNi4uNmRhMmU4MzE0NmNlYWYxNzk3MDY0MWFl Y2JhNjdlYjVkZTk2OWJmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxp bmcvQXN5bmNTY3JvbGxpbmdDb29yZGluYXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv c2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaApAQCAtMTMzLDcgKzEzMyw3IEBA IHByaXZhdGU6CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCByZWNvbmNpbGVWaWV3cG9ydENvbnN0 cmFpbmVkTGF5ZXJQb3NpdGlvbnMoU2Nyb2xsaW5nTm9kZUlELCBjb25zdCBMYXlvdXRSZWN0JiB2 aWV3cG9ydFJlY3QsIFNjcm9sbGluZ0xheWVyUG9zaXRpb25BY3Rpb24pIG92ZXJyaWRlOwogICAg IFdFQkNPUkVfRVhQT1JUIHZvaWQgc2Nyb2xsYWJsZUFyZWFTY3JvbGxiYXJMYXllckRpZENoYW5n ZShTY3JvbGxhYmxlQXJlYSYsIFNjcm9sbGJhck9yaWVudGF0aW9uKSBvdmVycmlkZTsKIAotICAg IFdFQkNPUkVfRVhQT1JUIHZvaWQgc2V0U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKEZyYW1l VmlldyYsIE9wdGlvblNldDxTeW5jaHJvbm91c1Njcm9sbGluZ1JlYXNvbj4pIGZpbmFsOworICAg IFdFQkNPUkVfRVhQT1JUIHZvaWQgc2V0U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKFNjcm9s bGluZ05vZGVJRCwgT3B0aW9uU2V0PFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29uPikgZmluYWw7 CiAKICAgICB2aXJ0dWFsIHZvaWQgc2NoZWR1bGVUcmVlU3RhdGVDb21taXQoKSA9IDA7CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5h dG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5h dG9yLmNwcAppbmRleCA4ODg0ZjZiMTgwMmU2ZDczYWRjODllMDJmZDEyODk0OGYzYjRkZjUxLi42 OGYyYmVkZTliN2EwN2M1NWE3MzczNDZmNTg3NDFlZjNjMDUzZTlhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdDb29yZGluYXRvci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCkBA IC0zNDYsNyArMzQ2LDcgQEAgT3B0aW9uU2V0PFN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29uPiBT Y3JvbGxpbmdDb29yZGluYXRvcjo6c3luY2hyb25vdXNTY3JvbGxpbmcKIHZvaWQgU2Nyb2xsaW5n Q29vcmRpbmF0b3I6OnVwZGF0ZVN5bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyhGcmFtZVZpZXcm IGZyYW1lVmlldykKIHsKICAgICBBU1NFUlQoY29vcmRpbmF0ZXNTY3JvbGxpbmdGb3JGcmFtZVZp ZXcoZnJhbWVWaWV3KSk7Ci0gICAgc2V0U3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKGZyYW1l Vmlldywgc3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKGZyYW1lVmlldykpOworICAgIHNldFN5 bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyhmcmFtZVZpZXcuc2Nyb2xsaW5nTm9kZUlEKCksIHN5 bmNocm9ub3VzU2Nyb2xsaW5nUmVhc29ucyhmcmFtZVZpZXcpKTsKIH0KIAogdm9pZCBTY3JvbGxp bmdDb29yZGluYXRvcjo6dXBkYXRlU3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zRm9yQWxsRnJh bWVzKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGlu Z0Nvb3JkaW5hdG9yLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdD b29yZGluYXRvci5oCmluZGV4IDE0ZTA2NDA5YjVjYWYwYWUwZjk0YjRiZTI1M2YxMDk4MTk1NDQ0 ZTQuLjA1MTNmZTc4NzY3MTEyZDNlMzkzMjdmNjRhZWQ4YzJjMDBkNjFmM2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmgKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nQ29vcmRpbmF0b3IuaApA QCAtMTk3LDcgKzE5Nyw3IEBAIHByb3RlY3RlZDoKICAgICBQYWdlKiBtX3BhZ2U7IC8vIEZJWE1F OiBpZGVhbGx5IHRoaXMgd291bGQgYmUgYSByZWZlcmVuY2UgYnV0IGl0IGdldHMgbnVsbGVkIG9u IGFzeW5jIHRlYXJkb3duLgogCiBwcml2YXRlOgotICAgIHZpcnR1YWwgdm9pZCBzZXRTeW5jaHJv bm91c1Njcm9sbGluZ1JlYXNvbnMoRnJhbWVWaWV3JiwgT3B0aW9uU2V0PFN5bmNocm9ub3VzU2Ny b2xsaW5nUmVhc29uPikgeyB9CisgICAgdmlydHVhbCB2b2lkIHNldFN5bmNocm9ub3VzU2Nyb2xs aW5nUmVhc29ucyhTY3JvbGxpbmdOb2RlSUQsIE9wdGlvblNldDxTeW5jaHJvbm91c1Njcm9sbGlu Z1JlYXNvbj4pIHsgfQogCiAgICAgdmlydHVhbCBib29sIGhhc1Zpc2libGVTbG93UmVwYWludFZp ZXdwb3J0Q29uc3RyYWluZWRPYmplY3RzKGNvbnN0IEZyYW1lVmlldyYpIGNvbnN0OwogICAgIHZv aWQgdXBkYXRlU3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKEZyYW1lVmlldyYpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvRXZlbnREaXNwYXRjaGVyLmgg Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuaAppbmRl eCBlZjhlOTJmMzcxODNkMWFiOGVmOGZiMDZmMTJlOGFmMjRjMjc2MDU5Li41YTY4NDg0Nzk3N2Fh ZTU4OTVlNGUwOGU4NjBlNmYxNmZmZjM1ZTY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViUGFnZS9FdmVudERpc3BhdGNoZXIuaApAQCAtODQsNyArODQsNiBAQCBwcml2 YXRlOgogICAgIHZvaWQgZ2VzdHVyZUV2ZW50KFdlYkNvcmU6OlBhZ2VJZGVudGlmaWVyLCBjb25z dCBXZWJHZXN0dXJlRXZlbnQmKTsKICNlbmRpZgogCi0KICAgICAvLyBUaGlzIGlzIGNhbGxlZCBv biB0aGUgbWFpbiB0aHJlYWQuCiAgICAgdm9pZCBkaXNwYXRjaFdoZWVsRXZlbnQoV2ViQ29yZTo6 UGFnZUlkZW50aWZpZXIsIGNvbnN0IFdlYldoZWVsRXZlbnQmKTsKICNpZiBFTkFCTEUoSU9TX1RP VUNIX0VWRU5UUykK