208771 2020-03-07 13:58:33 -0800 [CMake][Win] GenerateSettings.rb are invoked twice in WebCoreBindings.vcxproj and WebCoreTestSupportBindings.vcxproj 2020-03-07 15:20:58 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=181117 P2 Normal --- 1 fujii fujii annulen commit-queue don.olmstead ews-watchlist gyuyoung.kim ryuan.choi sergio oldest_to_newest 1627306 0 fujii 2020-03-07 13:58:33 -0800 [CMake][Win] GenerateSettings.rb are invoked twice in WebCoreBindings.vcxproj and WebCoreTestSupportBindings.vcxproj CMake Visual Studio generator put a custom command of GenerateSettings.rb into both WebCoreBindings.vcxproj and WebCoreTestSupportBindings.vcxproj because both projects are using the generated files as source files. This causes unnecessary recompilation. The fundamental issue of this bug was fixed in CMake side. https://gitlab.kitware.com/cmake/cmake/issues/16767 However, WebCoreTestSupportBindings needs to have a direct or indirect dependency to WebCoreBindings for CMake Visual Studio generator to eliminate duplicated custom commands. Otherwise, GenerateSettings.rb will be triggered in both projects. See also: Bug 198853 – [CMake][Win] CombinedDomains.json is generated twice in JavaScriptCore_CopyPrivateHeaders and JavaScriptCore projects Bug 181117 – [CMake][Win] Visual Studio invokes make_names.pl twice 1627309 1 392897 fujii 2020-03-07 14:04:28 -0800 Created attachment 392897 Patch 1627328 2 392897 commit-queue 2020-03-07 15:20:56 -0800 Comment on attachment 392897 Patch Clearing flags on attachment: 392897 Committed r258083: <https://trac.webkit.org/changeset/258083> 1627329 3 commit-queue 2020-03-07 15:20:58 -0800 All reviewed patches have been landed. Closing bug. 392897 2020-03-07 14:04:28 -0800 2020-03-07 15:20:56 -0800 Patch bug-208771-20200308070427.patch text/plain 3205 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MDc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTliN2FkYjJlMTZlNzll N2NkOGI1ODAyNDhkNDYzMjgyNTFiN2JhYS4uYTBmOTI5ZDQ2ZTFjYjc1NzNhN2RhMWVlNGZmZjEz MTYwMDgwNWYwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMwIEBACisyMDIwLTAzLTA3ICBGdWpp aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtDTWFrZV1b V2luXSBHZW5lcmF0ZVNldHRpbmdzLnJiIGFyZSBpbnZva2VkIHR3aWNlIGluIFdlYkNvcmVCaW5k aW5ncy52Y3hwcm9qIGFuZCBXZWJDb3JlVGVzdFN1cHBvcnRCaW5kaW5ncy52Y3hwcm9qCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg3NzEKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDTWFrZSBWaXN1YWwg U3R1ZGlvIGdlbmVyYXRvciBwdXQgYSBjdXN0b20gY29tbWFuZCBvZgorICAgICAgICBHZW5lcmF0 ZVNldHRpbmdzLnJiIGludG8gYm90aCBXZWJDb3JlQmluZGluZ3MudmN4cHJvaiBhbmQKKyAgICAg ICAgV2ViQ29yZVRlc3RTdXBwb3J0QmluZGluZ3MudmN4cHJvaiBiZWNhdXNlIGJvdGggcHJvamVj dHMgYXJlCisgICAgICAgIHVzaW5nIHRoZSBnZW5lcmF0ZWQgZmlsZXMgYXMgc291cmNlIGZpbGVz LiBUaGlzIGNhdXNlcworICAgICAgICB1bm5lY2Vzc2FyeSByZWNvbXBpbGF0aW9uLgorCisgICAg ICAgIFRoZSBmdW5kYW1lbnRhbCBpc3N1ZSBvZiB0aGlzIGJ1ZyB3YXMgZml4ZWQgaW4gQ01ha2Ug My4xMi4KKyAgICAgICAgPGh0dHBzOi8vZ2l0bGFiLmtpdHdhcmUuY29tL2NtYWtlL2NtYWtlL2lz c3Vlcy8xNjc2Nz4KKyAgICAgICAgQWxsIFdpbmRvd3MgcG9ydHMgYXJlIHVzaW5nIG5ld2VyIENN YWtlIGZvciBWaXN1YWwgU3R1ZGlvIDIwMTkKKyAgICAgICAgc3VwcG9ydC4KKworICAgICAgICBI b3dldmVyLCBXZWJDb3JlVGVzdFN1cHBvcnRCaW5kaW5ncyBuZWVkcyB0byBoYXZlIGEgZGlyZWN0 IG9yCisgICAgICAgIGluZGlyZWN0IGRlcGVuZGVuY3kgdG8gV2ViQ29yZUJpbmRpbmdzIGZvciBD TWFrZSBWaXN1YWwgU3R1ZGlvCisgICAgICAgIGdlbmVyYXRvciB0byBlbGltaW5hdGUgZHVwbGlj YXRlZCBjdXN0b20gY29tbWFuZHMuIE90aGVyd2lzZSwKKyAgICAgICAgR2VuZXJhdGVTZXR0aW5n cy5yYiB3aWxsIGJlIHRyaWdnZXJlZCBpbiBib3RoIHByb2plY3RzLgorCisgICAgICAgICogQ01h a2VMaXN0cy50eHQ6IEFkZGVkIGEgZXhwbGljaXQgZGVwZW5kZW5jeSB0byBXZWJDb3JlQmluZGlu Z3MKKyAgICAgICAgZm9yIFdlYkNvcmVUZXN0U3VwcG9ydEJpbmRpbmdzLgorICAgICAgICAqIFdl YkNvcmVNYWNyb3MuY21ha2U6IFJlbW92ZWQgc3RhbGUgY29tbWVudC4KKwogMjAyMC0wMy0wNSAg U2FtIFdlaW5pZyAgPHdlaW5pZ0BhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBKYXZhU2NyaXB0 Q29yZSByZWxhdGVkIGZlYXR1cmUgZGVmaW5lcyBmcm9tIEZlYXR1cmVEZWZpbmVzLnhjY29uZmln IHRvIFBsYXRmb3JtRW5hYmxlQ29jb2EuaApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01h a2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBjMjJlMDUw MWFhZGIwYThmMDYyMjZiZDZiZWI4MDUxYzZkNDQ3NDBlLi4yZWZjZTBkM2Q5NDUxYzUxNDBmN2Nm YmU2MjIzZTJmZjM5Mjg3ZjUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3Rz LnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dApAQCAtMTgzNyw2ICsxODM3 LDEyIEBAIEdFTkVSQVRFX0JJTkRJTkdTKFdlYkNvcmVUZXN0U3VwcG9ydEJpbmRpbmdzCiAgICAg REVTVElOQVRJT04gJHtXZWJDb3JlX0RFUklWRURfU09VUkNFU19ESVJ9CiAgICAgR0VORVJBVE9S IEpTKQogCisjIFdlYkNvcmVUZXN0U3VwcG9ydEJpbmRpbmdzIG5lZWRzIHRvIGhhdmUgYSBkaXJl Y3Qgb3IgaW5kaXJlY3QKKyMgZGVwZW5kZW5jeSB0byBXZWJDb3JlQmluZGluZ3MgZm9yIENNYWtl IFZpc3VhbCBTdHVkaW8gZ2VuZXJhdG9yIHRvCisjIGVsaW1pbmF0ZSBkdXBsaWNhdGVkIGN1c3Rv bSBjb21tYW5kcy4gT3RoZXJ3aXNlLAorIyBHZW5lcmF0ZVNldHRpbmdzLnJiIHdpbGwgYmUgdHJp Z2dlcmVkIGluIGJvdGggcHJvamVjdHMuCithZGRfZGVwZW5kZW5jaWVzKFdlYkNvcmVUZXN0U3Vw cG9ydEJpbmRpbmdzIFdlYkNvcmVCaW5kaW5ncykKKwogIyBXZWJDb3JlIEpTIEJ1aWx0aW5zCiAK IHNldChXZWJDb3JlX0JVSUxUSU5TX1NPVVJDRVMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L1dlYkNvcmVNYWNyb3MuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlTWFjcm9zLmNtYWtl CmluZGV4IDUwODAzOGJkZWNhYjUyNzc3YmRkNzZlNGVlYWJjZDA0ZjNiN2E4NzIuLjA0MzQ5ZjY3 MzM4ZDdmYTM5NzRiMTQ0N2JkZDU2MTg3MDMzMjg2YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL1dlYkNvcmVNYWNyb3MuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZU1hY3Jv cy5jbWFrZQpAQCAtMTg4LDkgKzE4OCw2IEBAIGVuZG1hY3JvKCkKIG1hY3JvKEdFTkVSQVRFX1NF VFRJTkdTX01BQ1JPUyBfaW5maWxlIF9vdXRmaWxlKQogICAgIHNldChOQU1FU19HRU5FUkFUT1Ig JHtXRUJDT1JFX0RJUn0vU2NyaXB0cy9HZW5lcmF0ZVNldHRpbmdzLnJiKQogCi0gICAgIyBEbyBu b3QgbGlzdCB0aGUgb3V0cHV0IGluIG1vcmUgdGhhbiBvbmUgaW5kZXBlbmRlbnQgdGFyZ2V0IHRo YXQgbWF5Ci0gICAgIyBidWlsZCBpbiBwYXJhbGxlbCBvciB0aGUgdHdvIGluc3RhbmNlcyBvZiB0 aGUgcnVsZSBtYXkgY29uZmxpY3QuCi0gICAgIyA8aHR0cHM6Ly9jbWFrZS5vcmcvY21ha2UvaGVs cC92My4wL2NvbW1hbmQvYWRkX2N1c3RvbV9jb21tYW5kLmh0bWw+CiAgICAgc2V0KF9leHRyYV9v dXRwdXQKICAgICAgICAgJHtXZWJDb3JlX0RFUklWRURfU09VUkNFU19ESVJ9L1NldHRpbmdzLmNw cAogICAgICAgICAke1dlYkNvcmVfREVSSVZFRF9TT1VSQ0VTX0RJUn0vSW50ZXJuYWxTZXR0aW5n c0dlbmVyYXRlZC5oCg==