208765 2020-03-07 09:59:46 -0800 [GPUP] LayoutTest debug assertion crashes: InitDataRegistry::registerInitDataType() called mulitple times with same type 2020-03-07 20:39:19 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue darin eric.carlson peng.liu6 simon.fraser webkit-bug-importer youennf oldest_to_newest 1627230 0 jer.noble 2020-03-07 09:59:46 -0800 [GPUP] LayoutTest debug assertion crashes: InitDataRegistry::registerInitDataType() called mulitple times with same type 1627231 1 392863 jer.noble 2020-03-07 10:01:58 -0800 Created attachment 392863 Patch 1627271 2 392863 darin 2020-03-07 12:41:42 -0800 Comment on attachment 392863 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392863&action=review > Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:220 > + static std::once_flag onceFlag; > + std::call_once(onceFlag, [] { For any one code change, seems OK to use std::call_once to avoid calling multiple times, even when the code isn’t safe to use from multiple threads. But since std::call_once is the thread-safe, more-expensive way of doing it, it might be slight overkill. Not sure what our overall project strategy should be for such things. 1627454 3 392863 commit-queue 2020-03-07 20:38:27 -0800 Comment on attachment 392863 Patch Clearing flags on attachment: 392863 Committed r258099: <https://trac.webkit.org/changeset/258099> 1627455 4 commit-queue 2020-03-07 20:38:29 -0800 All reviewed patches have been landed. Closing bug. 1627456 5 webkit-bug-importer 2020-03-07 20:39:19 -0800 <rdar://problem/60195875> 392863 2020-03-07 10:01:58 -0800 2020-03-07 20:38:27 -0800 Patch bug-208765-20200307100157.patch text/plain 2510 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MDMwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmMxNjU5MTZlZmZiNzdm OGRmMGU1MjIzZmI0YmM2MTI5YmMwYzEwOS4uOGMxMGQxOGQ4YmZiYWI4YzExZGU4ZDg2MzNmMzlj ZmQ3Nzg0YjA3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTA3ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFtHUFVQXSBMYXlvdXRUZXN0 IGRlYnVnIGFzc2VydGlvbiBjcmFzaGVzOiBJbml0RGF0YVJlZ2lzdHJ5OjpyZWdpc3RlckluaXRE YXRhVHlwZSgpIGNhbGxlZCBtdWxpdHBsZSB0aW1lcyB3aXRoIHNhbWUgdHlwZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NzY1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV3JhcCBjYWxscyB0byByZWdp c3RlckluaXREYXRhVHlwZSgpIGluIGEgc3RkOjpjYWxsX29uY2UsIHRvIGVuc3VyZSBpdCdzIG5v dCBjYWxsZWQgbXVsaXBsZSB0aW1lcyB3aGVuCisgICAgICAgIHBsYXRmb3JtUmVnaXN0ZXJGYWN0 b3JpZXMoKSBpcyBjYWxsZWQgbXVsdGlwbGUgdGltZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9hdmZvdW5kYXRpb24vQ0RNRmFpclBsYXlTdHJlYW1pbmcuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q0RNRmFjdG9yeTo6cGxhdGZvcm1SZWdpc3RlckZhY3Rvcmllcyk6CisKIDIwMjAt MDMtMDYgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgW0dQVVBd IE1vdmUgQVZTeXN0ZW1Db250cm9sbGVyIGNvZGUgaW50byB0aGUgR1BVIHByb2Nlc3MKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9DRE1G YWlyUGxheVN0cmVhbWluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9h dmZvdW5kYXRpb24vQ0RNRmFpclBsYXlTdHJlYW1pbmcuY3BwCmluZGV4IGI2YmFiZmNkZTVhMGQ0 YjgxMThkMDNjYzkyZjFkNjE5ZDYxZDc3ZTguLjUwMDAxZjY1NTU1MTFhMDViOTFkZDZjZjRlNzc4 ZWYwZGFjZGNmMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2F2Zm91bmRhdGlvbi9DRE1GYWlyUGxheVN0cmVhbWluZy5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL0NETUZhaXJQbGF5U3RyZWFtaW5nLmNw cApAQCAtMjE2LDggKzIxNiwxMSBAQCB2b2lkIENETUZhY3Rvcnk6OnBsYXRmb3JtUmVnaXN0ZXJG YWN0b3JpZXMoVmVjdG9yPENETUZhY3RvcnkqPiYgZmFjdG9yaWVzKQogICAgIGZhY3Rvcmllcy5h cHBlbmQoJkNETUZhY3RvcnlDbGVhcktleTo6c2luZ2xldG9uKCkpOwogICAgIGZhY3Rvcmllcy5h cHBlbmQoJkNETUZhY3RvcnlGYWlyUGxheVN0cmVhbWluZzo6c2luZ2xldG9uKCkpOwogCi0gICAg SW5pdERhdGFSZWdpc3RyeTo6c2hhcmVkKCkucmVnaXN0ZXJJbml0RGF0YVR5cGUoQ0RNUHJpdmF0 ZUZhaXJQbGF5U3RyZWFtaW5nOjpzaW5mTmFtZSgpLCB7IENETVByaXZhdGVGYWlyUGxheVN0cmVh bWluZzo6c2FuaXRpemVTaW5mLCBDRE1Qcml2YXRlRmFpclBsYXlTdHJlYW1pbmc6OmV4dHJhY3RL ZXlJRHNTaW5mIH0pOwotICAgIEluaXREYXRhUmVnaXN0cnk6OnNoYXJlZCgpLnJlZ2lzdGVySW5p dERhdGFUeXBlKENETVByaXZhdGVGYWlyUGxheVN0cmVhbWluZzo6c2tkTmFtZSgpLCB7IENETVBy aXZhdGVGYWlyUGxheVN0cmVhbWluZzo6c2FuaXRpemVTa2QsIENETVByaXZhdGVGYWlyUGxheVN0 cmVhbWluZzo6ZXh0cmFjdEtleUlEc1NrZCB9KTsKKyAgICBzdGF0aWMgc3RkOjpvbmNlX2ZsYWcg b25jZUZsYWc7CisgICAgc3RkOjpjYWxsX29uY2Uob25jZUZsYWcsIFtdIHsKKyAgICAgICAgSW5p dERhdGFSZWdpc3RyeTo6c2hhcmVkKCkucmVnaXN0ZXJJbml0RGF0YVR5cGUoQ0RNUHJpdmF0ZUZh aXJQbGF5U3RyZWFtaW5nOjpzaW5mTmFtZSgpLCB7IENETVByaXZhdGVGYWlyUGxheVN0cmVhbWlu Zzo6c2FuaXRpemVTaW5mLCBDRE1Qcml2YXRlRmFpclBsYXlTdHJlYW1pbmc6OmV4dHJhY3RLZXlJ RHNTaW5mIH0pOworICAgICAgICBJbml0RGF0YVJlZ2lzdHJ5OjpzaGFyZWQoKS5yZWdpc3Rlcklu aXREYXRhVHlwZShDRE1Qcml2YXRlRmFpclBsYXlTdHJlYW1pbmc6OnNrZE5hbWUoKSwgeyBDRE1Q cml2YXRlRmFpclBsYXlTdHJlYW1pbmc6OnNhbml0aXplU2tkLCBDRE1Qcml2YXRlRmFpclBsYXlT dHJlYW1pbmc6OmV4dHJhY3RLZXlJRHNTa2QgfSk7CisgICAgfSk7CiB9CiAKIENETUZhY3RvcnlG YWlyUGxheVN0cmVhbWluZyYgQ0RNRmFjdG9yeUZhaXJQbGF5U3RyZWFtaW5nOjpzaW5nbGV0b24o KQo=