208762 2020-03-07 08:10:57 -0800 [LFC][IFC] Use start-aligned horizontal adjustment when justify is not eligible. 2020-03-07 09:52:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1627212 0 zalan 2020-03-07 08:10:57 -0800 This is really just a refactoring with no functionality change at this point. 1627213 1 webkit-bug-importer 2020-03-07 08:11:16 -0800 <rdar://problem/60188433> 1627214 2 392859 zalan 2020-03-07 08:16:10 -0800 Created attachment 392859 Patch 1627227 3 392859 commit-queue 2020-03-07 09:52:19 -0800 Comment on attachment 392859 Patch Clearing flags on attachment: 392859 Committed r258073: <https://trac.webkit.org/changeset/258073> 1627228 4 commit-queue 2020-03-07 09:52:20 -0800 All reviewed patches have been landed. Closing bug. 392859 2020-03-07 08:16:10 -0800 2020-03-07 09:52:19 -0800 Patch bug-208762-20200307081609.patch text/plain 5737 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MDU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjExZTY0MjcyZWIxNGE5 ZDE5OWIwY2IyNzU0ZWVjZGE1ZDNhZjJhNS4uYjQ5ZDRlNDE5ZGJiMTRhZTJlZGNjMmZjNGM0Mjgx ZWQ0ZjIwZjIzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTAzLTA3ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBVc2Ugc3Rh cnQtYWxpZ25lZCBob3Jpem9udGFsIGFkanVzdG1lbnQgd2hlbiBqdXN0aWZ5IGlzIG5vdCBlbGln aWJsZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw ODc2MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAxODg0MzM+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIHdlIGFwcGx5ICJ0ZXh0 LWFsaWduOiBzdGFydCIgd2hlbiAidGV4dC1hbGlnbjoganVzdGlmeSIgaXMgbm90IGVsaWdpYmxl LgorICAgICAgICBDdXJyZW50bHkgInRleHQtYWxpZ246IHN0YXJ0IiBpcyBhIG5vLW9wLCBzbyBu byBjaG5hbmdlIGluIGZ1bmN0aW9uYWxpdHkgKHRoaXMgbWlnaHQgY2hhbmdlIGluIHRoZSBmdXR1 cmUpLgorCisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxk ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6YWxpZ25Ib3Jp em9udGFsbHkpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQnVpbGRlcjo6cmVtb3Zl VHJhaWxpbmdUcmltbWFibGVDb250ZW50KToKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0 dGluZy9JbmxpbmVMaW5lQnVpbGRlci5oOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5l QnVpbGRlcjo6aXNUZXh0QWxpZ25KdXN0aWZ5IGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKFdl YkNvcmU6OkxheW91dDo6TGluZUJ1aWxkZXI6OmlzVGV4dEFsaWduUmlnaHQgY29uc3QpOiBEZWxl dGVkLgorCiAyMDIwLTAzLTA3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW0xGQ11bSUZDXSBEbyBub3QgdGV4dC1hbGlnbjoganVzdGlmeSB0aGUgcnVucyBvbiB0 aGUgY3VycmVudCBsaW5lIGlmIHRoZXkgYXJlIGZvbGxvd2VkIGJ5IGEgZm9yY2VkIGJyZWFrCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVM aW5lQnVpbGRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9J bmxpbmVMaW5lQnVpbGRlci5jcHAKaW5kZXggNzYwMTdjMjMxNDI4MDcyMzQ5NDNmMjIyNzkyMmQy ZjM2MGRiMGQ0NC4uN2FlYzMxN2QxNWJjY2I3YzhlOWMyNDRjNTEzODQzM2EyY2VlODhjZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGlu ZUJ1aWxkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5n L0lubGluZUxpbmVCdWlsZGVyLmNwcApAQCAtMjM2LDIwICsyMzYsMzAgQEAgdm9pZCBMaW5lQnVp bGRlcjo6anVzdGlmeVJ1bnMoSW5saW5lTGF5b3V0VW5pdCBhdmFpbGFibGVXaWR0aCkKIHZvaWQg TGluZUJ1aWxkZXI6OmFsaWduSG9yaXpvbnRhbGx5KGNvbnN0IEhhbmdpbmdDb250ZW50JiBoYW5n aW5nQ29udGVudCwgSXNMYXN0TGluZVdpdGhJbmxpbmVDb250ZW50IGlzTGFzdExpbmUpCiB7CiAg ICAgQVNTRVJUKCFtX2lzSW50cmluc2ljU2l6aW5nKTsKKwogICAgIGF1dG8gYXZhaWxhYmxlV2lk dGggPSB0aGlzLT5hdmFpbGFibGVXaWR0aCgpICsgaGFuZ2luZ0NvbnRlbnQud2lkdGgoKTsKICAg ICBpZiAobV9ydW5zLmlzRW1wdHkoKSB8fCBhdmFpbGFibGVXaWR0aCA8PSAwKQogICAgICAgICBy ZXR1cm47CiAKLSAgICBpZiAoaXNUZXh0QWxpZ25KdXN0aWZ5KCkpIHsKLSAgICAgICAgLy8gVW5s ZXNzIG90aGVyd2lzZSBzcGVjaWZpZWQgYnkgdGV4dC1hbGlnbi1sYXN0LCB0aGUgbGFzdCBsaW5l IGJlZm9yZSBhIGZvcmNlZCBicmVhayBvcgotICAgICAgICAvLyB0aGUgZW5kIG9mIHRoZSBibG9j ayBpcyBzdGFydC1hbGlnbmVkLgotICAgICAgICBpZiAoIW1fcnVucy5sYXN0KCkuaXNMaW5lQnJl YWsoKSAmJiBpc0xhc3RMaW5lID09IElzTGFzdExpbmVXaXRoSW5saW5lQ29udGVudDo6Tm8pCi0g ICAgICAgICAgICBqdXN0aWZ5UnVucyhhdmFpbGFibGVXaWR0aCk7CisgICAgYXV0byBjb21wdXRl ZEhvcml6b250YWxBbGlnbm1lbnQgPSBbJl0geworICAgICAgICBBU1NFUlQobV9ob3Jpem9udGFs QWxpZ25tZW50KTsKKyAgICAgICAgaWYgKG1faG9yaXpvbnRhbEFsaWdubWVudCAhPSBUZXh0QWxp Z25Nb2RlOjpKdXN0aWZ5KQorICAgICAgICAgICAgcmV0dXJuICptX2hvcml6b250YWxBbGlnbm1l bnQ7CisgICAgICAgIC8vIFRleHQgaXMganVzdGlmaWVkIGFjY29yZGluZyB0byB0aGUgbWV0aG9k IHNwZWNpZmllZCBieSB0aGUgdGV4dC1qdXN0aWZ5IHByb3BlcnR5LAorICAgICAgICAvLyBpbiBv cmRlciB0byBleGFjdGx5IGZpbGwgdGhlIGxpbmUgYm94LiBVbmxlc3Mgb3RoZXJ3aXNlIHNwZWNp ZmllZCBieSB0ZXh0LWFsaWduLWxhc3QsCisgICAgICAgIC8vIHRoZSBsYXN0IGxpbmUgYmVmb3Jl IGEgZm9yY2VkIGJyZWFrIG9yIHRoZSBlbmQgb2YgdGhlIGJsb2NrIGlzIHN0YXJ0LWFsaWduZWQu CisgICAgICAgIGlmIChtX3J1bnMubGFzdCgpLmlzTGluZUJyZWFrKCkgfHwgaXNMYXN0TGluZSA9 PSBJc0xhc3RMaW5lV2l0aElubGluZUNvbnRlbnQ6OlllcykKKyAgICAgICAgICAgIHJldHVybiBU ZXh0QWxpZ25Nb2RlOjpTdGFydDsKKyAgICAgICAgcmV0dXJuIFRleHRBbGlnbk1vZGU6Okp1c3Rp Znk7CisgICAgfSgpOworCisgICAgaWYgKGNvbXB1dGVkSG9yaXpvbnRhbEFsaWdubWVudCA9PSBU ZXh0QWxpZ25Nb2RlOjpKdXN0aWZ5KSB7CisgICAgICAgIGp1c3RpZnlSdW5zKGF2YWlsYWJsZVdp ZHRoKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGF1dG8gYWRqdXN0bWVudEZvckFs aWdubWVudCA9IFsmXSgpIC0+IE9wdGlvbmFsPElubGluZUxheW91dFVuaXQ+IHsKLSAgICAgICAg c3dpdGNoICgqbV9ob3Jpem9udGFsQWxpZ25tZW50KSB7CisgICAgYXV0byBhZGp1c3RtZW50Rm9y QWxpZ25tZW50ID0gW10gKGF1dG8gaG9yaXpvbnRhbEFsaWdubWVudCwgYXV0byBhdmFpbGFibGVX aWR0aCkgLT4gT3B0aW9uYWw8SW5saW5lTGF5b3V0VW5pdD4geworICAgICAgICBzd2l0Y2ggKGhv cml6b250YWxBbGlnbm1lbnQpIHsKICAgICAgICAgY2FzZSBUZXh0QWxpZ25Nb2RlOjpMZWZ0Ogog ICAgICAgICBjYXNlIFRleHRBbGlnbk1vZGU6OldlYktpdExlZnQ6CiAgICAgICAgIGNhc2UgVGV4 dEFsaWduTW9kZTo6U3RhcnQ6CkBAIC0yNjksNyArMjc5LDcgQEAgdm9pZCBMaW5lQnVpbGRlcjo6 YWxpZ25Ib3Jpem9udGFsbHkoY29uc3QgSGFuZ2luZ0NvbnRlbnQmIGhhbmdpbmdDb250ZW50LCBJ c0xhc3QKICAgICAgICAgcmV0dXJuIHsgfTsKICAgICB9OwogCi0gICAgYXV0byBhZGp1c3RtZW50 ID0gYWRqdXN0bWVudEZvckFsaWdubWVudCgpOworICAgIGF1dG8gYWRqdXN0bWVudCA9IGFkanVz dG1lbnRGb3JBbGlnbm1lbnQoY29tcHV0ZWRIb3Jpem9udGFsQWxpZ25tZW50LCBhdmFpbGFibGVX aWR0aCk7CiAgICAgaWYgKCFhZGp1c3RtZW50KQogICAgICAgICByZXR1cm47CiAgICAgLy8gSG9y aXpvbnRhbCBhbGlnbm1lbnQgbWVhbnMgdGhhdCB3ZSBub3Qgb25seSBhZGp1c3QgdGhlIHJ1bnMg YnV0IGFsc28gbWFrZSBzdXJlCkBAIC0yODgsNyArMjk4LDE0IEBAIHZvaWQgTGluZUJ1aWxkZXI6 OnJlbW92ZVRyYWlsaW5nVHJpbW1hYmxlQ29udGVudCgpCiAKICAgICAvLyBDb21wbGV4IGxpbmUg bGF5b3V0IHF1aXJrOiBrZWVwIHRoZSB0cmFpbGluZyB3aGl0ZXNwYWNlIGFyb3VuZCB3aGVuIGl0 IGlzIGZvbGxvd2VkIGJ5IGEgbGluZSBicmVhaywgdW5sZXNzIHRoZSBjb250ZW50IG92ZXJmbG93 cyB0aGUgbGluZS4KICAgICBpZiAoUnVudGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVy ZXMoKS5sYXlvdXRGb3JtYXR0aW5nQ29udGV4dEludGVncmF0aW9uRW5hYmxlZCgpKSB7Ci0gICAg ICAgIGlmIChtX3J1bnMubGFzdCgpLmlzTGluZUJyZWFrKCkgJiYgYXZhaWxhYmxlV2lkdGgoKSA+ PSAwICYmICFpc1RleHRBbGlnblJpZ2h0KCkpIHsKKyAgICAgICAgYXV0byBpc1RleHRBbGlnblJp Z2h0ID0gWyZdIHsKKyAgICAgICAgICAgIEFTU0VSVChtX2hvcml6b250YWxBbGlnbm1lbnQpOwor ICAgICAgICAgICAgcmV0dXJuIG1faG9yaXpvbnRhbEFsaWdubWVudCA9PSBUZXh0QWxpZ25Nb2Rl OjpSaWdodAorICAgICAgICAgICAgICAgIHx8IG1faG9yaXpvbnRhbEFsaWdubWVudCA9PSBUZXh0 QWxpZ25Nb2RlOjpXZWJLaXRSaWdodAorICAgICAgICAgICAgICAgIHx8IG1faG9yaXpvbnRhbEFs aWdubWVudCA9PSBUZXh0QWxpZ25Nb2RlOjpFbmQ7CisgICAgICAgICAgICB9KCk7CisKKyAgICAg ICAgaWYgKG1fcnVucy5sYXN0KCkuaXNMaW5lQnJlYWsoKSAmJiBhdmFpbGFibGVXaWR0aCgpID49 IDAgJiYgIWlzVGV4dEFsaWduUmlnaHQpIHsKICAgICAgICAgICAgIG1fdHJpbW1hYmxlVHJhaWxp bmdDb250ZW50LnJlc2V0KCk7CiAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVC dWlsZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVM aW5lQnVpbGRlci5oCmluZGV4IDI0NGUzYjYyZGQ4MWNlODU5ZDViZTE4MGYwNzU1NWM2NTY0MzE5 MGUuLjNhZjU3OTUzNTQ3NjExNmEzYjdmYmU3NTJiMzlkMzM2MTE2YmFhZWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVy LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGlu ZUJ1aWxkZXIuaApAQCAtMTg2LDggKzE4Niw2IEBAIHByaXZhdGU6CiAgICAgdm9pZCBhZGp1c3RC YXNlbGluZUFuZExpbmVIZWlnaHQoY29uc3QgUnVuJik7CiAgICAgSW5saW5lTGF5b3V0VW5pdCBy dW5Db250ZW50SGVpZ2h0KGNvbnN0IFJ1biYpIGNvbnN0OwogCi0gICAgYm9vbCBpc1RleHRBbGln bkp1c3RpZnkoKSBjb25zdCB7IHJldHVybiBtX2hvcml6b250YWxBbGlnbm1lbnQgPT0gVGV4dEFs aWduTW9kZTo6SnVzdGlmeTsgfTsKLSAgICBib29sIGlzVGV4dEFsaWduUmlnaHQoKSBjb25zdCB7 IHJldHVybiBtX2hvcml6b250YWxBbGlnbm1lbnQgPT0gVGV4dEFsaWduTW9kZTo6UmlnaHQgfHwg bV9ob3Jpem9udGFsQWxpZ25tZW50ID09IFRleHRBbGlnbk1vZGU6OldlYktpdFJpZ2h0IHx8IG1f aG9yaXpvbnRhbEFsaWdubWVudCA9PSBUZXh0QWxpZ25Nb2RlOjpFbmQ7IH0KICAgICB2b2lkIGp1 c3RpZnlSdW5zKElubGluZUxheW91dFVuaXQgYXZhaWxhYmxlV2lkdGgpOwogCiAgICAgYm9vbCBp c1Zpc3VhbGx5Tm9uRW1wdHkoY29uc3QgUnVuJikgY29uc3Q7Cg==