<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>208732</bug_id>
          
          <creation_ts>2020-03-06 13:09:03 -0800</creation_ts>
          <short_desc>[GPUP] Enable Picture-in-Picture support on Mac</short_desc>
          <delta_ts>2020-03-06 14:13:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Peng Liu">peng.liu6</reporter>
          <assigned_to name="Peng Liu">peng.liu6</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric.carlson</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>jer.noble</cc>
    
    <cc>philipj</cc>
    
    <cc>sergio</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1626832</commentid>
    <comment_count>0</comment_count>
    <who name="Peng Liu">peng.liu6</who>
    <bug_when>2020-03-06 13:09:03 -0800</bug_when>
    <thetext>[GPUP] Enable Picture-in-Picture support on Mac</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1626834</commentid>
    <comment_count>1</comment_count>
      <attachid>392763</attachid>
    <who name="Peng Liu">peng.liu6</who>
    <bug_when>2020-03-06 13:15:04 -0800</bug_when>
    <thetext>Created attachment 392763
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1626835</commentid>
    <comment_count>2</comment_count>
      <attachid>392763</attachid>
    <who name="Eric Carlson">eric.carlson</who>
    <bug_when>2020-03-06 13:18:45 -0800</bug_when>
    <thetext>Comment on attachment 392763
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=392763&amp;action=review

&gt; Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:683
&gt; +    m_cachedState.hasVideo = m_player-&gt;hasVideo();

Oops!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1626857</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-03-06 13:54:25 -0800</bug_when>
    <thetext>&lt;rdar://problem/60169440&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1626868</commentid>
    <comment_count>4</comment_count>
      <attachid>392763</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-03-06 14:13:34 -0800</bug_when>
    <thetext>Comment on attachment 392763
Patch

Clearing flags on attachment: 392763

Committed r258029: &lt;https://trac.webkit.org/changeset/258029&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1626869</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-03-06 14:13:35 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>392763</attachid>
            <date>2020-03-06 13:15:04 -0800</date>
            <delta_ts>2020-03-06 14:13:34 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-208732-20200306131503.patch</filename>
            <type>text/plain</type>
            <size>1694</size>
            <attacher name="Peng Liu">peng.liu6</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU4MDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY1MWU4NTAzN2JhMTQwOTIy
ZGI1MDg5NmZiZmNlMDk0NmQ0MmRkOTEuLmE3YzA2YmViOGEyMDczNzUxZWRjMzMyNTYwOGFlNjNk
OTRhNDc0YjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDMtMDYgIFBlbmcgTGl1
ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVUF0gRW5hYmxlIFBpY3R1cmUt
aW4tUGljdHVyZSBzdXBwb3J0IG9uIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NzMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKworICAgICAgICBS
ZW1vdGVNZWRpYVBsYXllclByb3h5IG5lZWRzIHRvIHNlbmQgImhhc1ZpZGVvIiBzdGF0ZSB0byBN
ZWRpYVBsYXllclByaXZhdGVSZW1vdGUKKyAgICAgICAgaW4gdGhlIFdlYiBwcm9jZXNzIGluIG9y
ZGVyIHRvIGVuYWJsZSB0aGUgUGljdHVyZS1pbi1QaWN0dXJlIG1vZGUgc3VwcG9ydCAob24gTWFj
KS4KKworICAgICAgICAqIEdQVVByb2Nlc3MvbWVkaWEvUmVtb3RlTWVkaWFQbGF5ZXJQcm94eS5j
cHA6CisgICAgICAgIChXZWJLaXQ6OlJlbW90ZU1lZGlhUGxheWVyUHJveHk6OnVwZGF0ZUNhY2hl
ZFN0YXRlKToKKwogMjAyMC0wMy0wNiAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4K
IAogICAgICAgICBVSVByb2Nlc3MgY3Jhc2ggYWZ0ZXIgdXNpbmcgX3ByZXBhcmVGb3JNb3ZlVG9X
aW5kb3csIHRoZW4gZGVhbGxvY2F0aW5nIHRoZSBXS1dlYlZpZXcgYmVmb3JlIG1vdmluZyB0byB0
aGUgd2luZG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVkaWEvUmVt
b3RlTWVkaWFQbGF5ZXJQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWVkaWEv
UmVtb3RlTWVkaWFQbGF5ZXJQcm94eS5jcHAKaW5kZXggZTI5MDM0YjRmMzE1YzFkZTYzYTE3MmE0
ZDNhZDRhZmMzNTAyNTI2Ni4uOTMxOTExNGYyZmZlNzY5YTU2ZTUyZWM5M2ZkOTIzYmQ3NjVkODZm
OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21lZGlhL1JlbW90ZU1lZGlh
UGxheWVyUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9tZWRpYS9SZW1v
dGVNZWRpYVBsYXllclByb3h5LmNwcApAQCAtNjgwLDYgKzY4MCw3IEBAIHZvaWQgUmVtb3RlTWVk
aWFQbGF5ZXJQcm94eTo6dXBkYXRlQ2FjaGVkU3RhdGUoKQogICAgIG1fY2FjaGVkU3RhdGUucGF1
c2VkID0gbV9wbGF5ZXItPnBhdXNlZCgpOwogICAgIG1fY2FjaGVkU3RhdGUubG9hZGluZ1Byb2dy
ZXNzZWQgPSBtX3BsYXllci0+ZGlkTG9hZGluZ1Byb2dyZXNzKCk7CiAgICAgbV9jYWNoZWRTdGF0
ZS5oYXNBdWRpbyA9IG1fcGxheWVyLT5oYXNBdWRpbygpOworICAgIG1fY2FjaGVkU3RhdGUuaGFz
VmlkZW8gPSBtX3BsYXllci0+aGFzVmlkZW8oKTsKIAogICAgIGlmIChtX2J1ZmZlcmVkQ2hhbmdl
ZCkgewogICAgICAgICBtX2J1ZmZlcmVkQ2hhbmdlZCA9IGZhbHNlOwo=
</data>

          </attachment>
      

    </bug>

</bugzilla>