208716 2020-03-06 08:26:19 -0800 [ews] commit queue is not skipping layout tests for rollout patches 2020-03-07 16:15:14 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=208544 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard webkit-bug-importer oldest_to_newest 1626673 0 aakash_jain 2020-03-06 08:26:19 -0800 [ews] commit queue is not skipping layout tests for rollout patches after r257927. e.g.: https://ews-build.webkit-uat.org/#/builders/26/builds/1165 The logic to skip tests was added only for WK1 tests, and in r257927 we should from wk1 to wk2 for commit-queue. We should skip wk2 tests as well in commit-queue in case of rollout patch. 1626674 1 392725 aakash_jain 2020-03-06 08:28:23 -0800 Created attachment 392725 Patch 1627341 2 aakash_jain 2020-03-07 16:14:53 -0800 Committed r258084: <https://trac.webkit.org/changeset/258084> 1627342 3 webkit-bug-importer 2020-03-07 16:15:14 -0800 <rdar://problem/60193629> 392725 2020-03-06 08:28:23 -0800 2020-03-07 16:15:11 -0800 Patch bug-208716-20200306112822.patch text/plain 2900 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1Nzk5NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIwLTAzLTA2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBjb21taXQgcXVldWUgaXMgbm90IHNraXBwaW5nIGxheW91dCB0 ZXN0cyBmb3Igcm9sbG91dCBwYXRjaGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDg3MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToK KyAgICAgICAgKFJ1bldlYktpdFRlc3RzLmRvU3RlcElmKToKKyAgICAgICAgKFJ1bldlYktpdDFU ZXN0cy5kb1N0ZXBJZik6IE1vdmVkIHRvIGJhc2UgY2xhc3MgUnVuV2ViS2l0VGVzdHMuCisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBBZGRl ZCB1bml0LXRlc3QuCisKIDIwMjAtMDMtMDYgIExhdXJvIE1vdXJhIDxsbW91cmFAaWdhbGlhLmNv bT4KIAogICAgICAgICBbV1BFXVtXZWJEcml2ZXJdIE1pbmlCcm93c2VyIHNob3VsZCByZWFjdCB0 byBjbG9zZSBzZXNzaW9uIGNvbW1hbmRzCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZpc2lvbiAyNTc5OTcpCisrKyBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTE1OTgsNiArMTU5 OCw5IEBAIGNsYXNzIFJ1bldlYktpdFRlc3RzKHNoZWxsLlRlc3QpOgogICAgICAgICBzaGVsbC5U ZXN0Ll9faW5pdF9fKHNlbGYsIGxvZ0Vudmlyb249RmFsc2UsICoqa3dhcmdzKQogICAgICAgICBz ZWxmLmluY29ycmVjdExheW91dExpbmVzID0gW10KIAorICAgIGRlZiBkb1N0ZXBJZihzZWxmLCBz dGVwKToKKyAgICAgICAgcmV0dXJuIG5vdCAoc2VsZi5nZXRQcm9wZXJ0eSgncm9sbG91dCcpIGFu ZCBzZWxmLmdldFByb3BlcnR5KCdidWlsZGVybmFtZScsICcnKS5sb3dlcigpID09ICdjb21taXQt cXVldWUnKQorCiAgICAgZGVmIHN0YXJ0KHNlbGYpOgogICAgICAgICBzZWxmLmxvZ19vYnNlcnZl ciA9IGxvZ29ic2VydmVyLkJ1ZmZlckxvZ09ic2VydmVyKHdhbnRTdGRlcnI9VHJ1ZSkKICAgICAg ICAgc2VsZi5hZGRMb2dPYnNlcnZlcignc3RkaW8nLCBzZWxmLmxvZ19vYnNlcnZlcikKQEAgLTE5 MDMsOSArMTkwNiw2IEBAIGNsYXNzIFJ1bldlYktpdDFUZXN0cyhSdW5XZWJLaXRUZXN0cyk6CiAg ICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ3VzZS1kdW1wLXJlbmRlci10cmVlJywgVHJ1ZSkKICAg ICAgICAgcmV0dXJuIFJ1bldlYktpdFRlc3RzLnN0YXJ0KHNlbGYpCiAKLSAgICBkZWYgZG9TdGVw SWYoc2VsZiwgc3RlcCk6Ci0gICAgICAgIHJldHVybiBub3QgKHNlbGYuZ2V0UHJvcGVydHkoJ3Jv bGxvdXQnKSBhbmQgc2VsZi5nZXRQcm9wZXJ0eSgnYnVpbGRlcm5hbWUnLCAnJykubG93ZXIoKSA9 PSAnY29tbWl0LXF1ZXVlJykKLQogCiBjbGFzcyBBcmNoaXZlQnVpbHRQcm9kdWN0KHNoZWxsLlNo ZWxsQ29tbWFuZCk6CiAgICAgY29tbWFuZCA9IFsncHl0aG9uJywgJ1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWx0LXByb2R1Y3QtYXJjaGl2ZScsCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNTc5 OTcpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3Qu cHkJKHdvcmtpbmcgY29weSkKQEAgLTE1MTgsNiArMTUxOCwxNSBAQCB0cyIsInZlcnNpb24iOjQs Im51bV9wYXNzZXMiOjQyMTU4LCJwaXhlCiAgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1 bHQ9V0FSTklOR1MsIHN0YXRlX3N0cmluZz0nMiBmbGFrZXMnKQogICAgICAgICByZXR1cm4gc2Vs Zi5ydW5TdGVwKCkKIAorICAgIGRlZiB0ZXN0X3NraXBfZm9yX3JvbGxvdXRfcGF0Y2hlc19vbl9j b21taXRfcXVldWUoc2VsZik6CisgICAgICAgIHNlbGYuY29uZmlndXJlU3RlcCgpCisgICAgICAg IHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkZXJuYW1lJywgJ0NvbW1pdC1RdWV1ZScpCisgICAgICAg IHNlbGYuc2V0UHJvcGVydHkoJ2Z1bGxQbGF0Zm9ybScsICdtYWMnKQorICAgICAgICBzZWxmLnNl dFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ2RlYnVnJykKKyAgICAgICAgc2VsZi5zZXRQcm9w ZXJ0eSgncm9sbG91dCcsIFRydWUpCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9 U0tJUFBFRCwgc3RhdGVfc3RyaW5nPSdsYXlvdXQtdGVzdHMgKHNraXBwZWQpJykKKyAgICAgICAg cmV0dXJuIHNlbGYucnVuU3RlcCgpCisKICAgICBkZWYgdGVzdF9wYXJzZV9yZXN1bHRzX2pzb25f cmVncmVzc2lvbihzZWxmKToKICAgICAgICAgc2VsZi5jb25maWd1cmVTdGVwKCkKICAgICAgICAg c2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJywgJ2lvcy1zaW11bGF0b3InKQo=