208679 2020-03-05 17:21:12 -0800 REGRESSION(r253759): Web Inspector: Audits: results folder doesn't get selected by pressing Arrow Down key 2020-03-10 18:36:03 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev hi commit-queue hi inspector-bugzilla-changes timothy webkit-bug-importer oldest_to_newest 1626416 0 nvasilyev 2020-03-05 17:21:12 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Audit Tab 3. run any audit 4. select any audit 5. keep pressing ↓ to eventually select the Results folder => folder isn't actually selected, but instead a focus outline can be seen 6. press ↓ again => selection jumps to the first item in the list 1626417 1 webkit-bug-importer 2020-03-05 17:21:22 -0800 <rdar://problem/60108942> 1626440 2 nvasilyev 2020-03-05 18:39:40 -0800 A combination of a couple of odd things cause this bug. _dispatchSelectionDidChangeEvent gets called twice. First time from SelectionController: _dispatchSelectionDidChangeEvent (TreeOutline.js:1131) selectionControllerSelectionDidChange (TreeOutline.js:811) _updateSelectedItems (SelectionController.js:392) selectItem (SelectionController.js:97) _selectItemsFromArrowKey (SelectionController.js:334) handleKeyDown (SelectionController.js:229) _treeKeyDown (TreeOutline.js:669) _treeKeyDown Second time directly from TreeOutline: _dispatchSelectionDidChangeEvent (TreeOutline.js:1131) selectTreeElementInternal (TreeOutline.js:897) select (TreeElement.js:542) _treeKeyDown (TreeOutline.js:682) _treeKeyDown The second call results in ContentViewContainer.prototype.showDefaultContentView: showDefaultContentView (AuditNavigationSidebarPanel.js:71) _treeSelectionDidChange (AuditNavigationSidebarPanel.js:287) dispatch (Object.js:165) dispatchEventToListeners (Object.js:172) _dispatchSelectionDidChangeEvent (TreeOutline.js:1139) selectTreeElementInternal (TreeOutline.js:897) select (TreeElement.js:542) _treeKeyDown (TreeOutline.js:682) _treeKeyDown Which resets treeElement selection. Thus this bug happens. 1626541 3 nvasilyev 2020-03-06 00:33:32 -0800 This didn't regress with r257380. 1626547 4 nvasilyev 2020-03-06 01:14:41 -0800 This broken more than 6 weeks ago. My recent AXI changes had nothing to do with it. Works in r255037 Broken in r252338 http://trac.webkit.org/log/trunk/?mode=follow_copy&rev=255037&stop_rev=252338 A lot of builds in this range are broken so I'm stopping bisecting for now. 1626550 5 nvasilyev 2020-03-06 01:39:10 -0800 This broke in Bug 205435 - Web Inspector: Audit: exiting edit mode with the same selection as before entering edit mode doesn't reselect https://trac.webkit.org/changeset/253759/webkit 1626753 6 392743 hi 2020-03-06 11:08:25 -0800 Created attachment 392743 Patch 1626873 7 392743 nvasilyev 2020-03-06 14:22:21 -0800 Comment on attachment 392743 Patch I think it's fine to duct tape this for now. Ultimately, when allowsRepeatSelection is true, WI.TreeOutline.Event.SelectionDidChange shouldn't fire twice when selection only changes once. 1628467 8 392743 commit-queue 2020-03-10 18:36:01 -0700 Comment on attachment 392743 Patch Clearing flags on attachment: 392743 Committed r258246: <https://trac.webkit.org/changeset/258246> 1628468 9 commit-queue 2020-03-10 18:36:03 -0700 All reviewed patches have been landed. Closing bug. 392743 2020-03-06 11:08:25 -0800 2020-03-10 18:36:01 -0700 Patch bug-208679-20200306110825.patch text/plain 3867 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNmOWJlOGI0M2QxZWE0ZDk2ZmExODU3YjkwODE2 ZTM3NjJlNjNmMzQuLjIxNDYxMzU0NjI0MzllOWIzOTllZGJjNjEzY2YzZTQ0YTEwYzhjZmEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTAzLTA2ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNTM3 NTkpOiBXZWIgSW5zcGVjdG9yOiBBdWRpdHM6IHJlc3VsdHMgZm9sZGVyIGRvZXNuJ3QgZ2V0IHNl bGVjdGVkIGJ5IHByZXNzaW5nIEFycm93IERvd24ga2V5CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg2NzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzYwMTA4OTQyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9BdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFuZWwuanM6 CisgICAgICAgIChXSS5BdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLmluaXRp YWxMYXlvdXQpOgorICAgICAgICAoV0kuQXVkaXROYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnByb3Rv dHlwZS5faGFuZGxlQXVkaXRNYW5hZ2VyRWRpdGluZ0NoYW5nZWQpOgorICAgICAgICBXZSBkbyBh Y3R1YWxseSB3YW50IHRvIHByZXZlbnQgcmVwZWF0IHNlbGVjdGlvbiwgYXMgd2UgbWF5IGVuZCB1 cCBhdHRlbXB0aW5nIHRvIHNlbGVjdCB0aGUKKyAgICAgICAgc2FtZSBgV0kuVHJlZUVsZW1lbnRg IHR3aWNlIGR1ZSB0byB0aGUgbmF0dXJlIG9mIGBXSS5TZWxlY3Rpb25Db250cm9sbGVyYCwgd2hp Y2ggd291bGQgY2FsbAorICAgICAgICB0aHJvdWdoIHRvIGBXSS5OYXZpZ2F0aW9uU2lkZWJhclBh bmVsLnByb3RvdHlwZS5zaG93RGVmYXVsdENvbnRlbnRWaWV3KClgIHdoaWNoIGRlc2VsZWN0cwor ICAgICAgICBhbnkgc2VsZWN0ZWQgYFdJLlRyZWVFbGVtZW50YC4gUmVzZWxlY3RpbmcgdGhlIHBy ZXZpb3VzbHkgc2VsZWN0ZWQgYFdJLlRyZWVFbGVtZW50YCB3aGVuCisgICAgICAgIGV4aXRpbmcg ZWRpdCBtb2RlIGlzIG11Y2ggbW9yZSBvZiBhIHNwZWNpYWwgY2FzZSB0aGFuIGFueSBvZiB0aGUg d2F5cyBmb3IgbW92aW5nIHNlbGVjdGlvbgorICAgICAgICB0byBhIGBXSS5Gb2xkZXJUcmVlRWxl bWVudGAsIHNvIGFkZCBsb2dpYyBqdXN0IGZvciB0aGF0IGNhc2UgaW5zdGVhZCBvZiBhZmZlY3Rp bmcgdGhlIGVudGlyZQorICAgICAgICBgV0kuVHJlZU91dGxpbmVgLiBXaGVuIHJlc3RvcmluZyB0 aGUgc2VsZWN0aW9uIGFmdGVyIGxlYXZpbmcgZWRpdCBtb2RlLCBpZiB0aGUgY3VycmVudGx5Cisg ICAgICAgIHNlbGVjdGVkIGBXSS5UcmVlRWxlbWVudGAgd2FzIGFsc28gdGhlIHByZXZpb3VzbHkg c2VsZWN0ZWQgYFdJLlRyZWVFbGVtZW50YCwgZGVzZWxlY3QgYW5kCisgICAgICAgIHJlc2VsZWN0 IGl0IHNvIHdlJ3JlICJyZXNldCIgYmFjayB0byBhIGZyZXNoIHN0YXRlLgorCiAyMDIwLTAzLTA1 ICBOaWtpdGEgVmFzaWx5ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IEFYSTogYW5ub3RhdGUgdGFiIHBhbmVscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXROYXZpZ2F0aW9uU2lkZWJhclBh bmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRO YXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCmluZGV4IGE1NTdkYzBlY2FjMTVjYmEwMDJiNDZiZjk1 MzgwOGE1NzVjYmI1ZmUuLmNkZTNmYjljZWM1OWIwYzM1ODI3ZGRlZWZkOWU1NGRlY2FhNTJkNzgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1 ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9BdWRpdE5hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMKQEAgLTc3 LDYgKzc3LDggQEAgV0kuQXVkaXROYXZpZ2F0aW9uU2lkZWJhclBhbmVsID0gY2xhc3MgQXVkaXRO YXZpZ2F0aW9uU2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuTmEKICAgICB7CiAgICAgICAgIHN1cGVy LmluaXRpYWxMYXlvdXQoKTsKIAorICAgICAgICB0aGlzLmNvbnRlbnRUcmVlT3V0bGluZS5hbGxv d3NSZXBlYXRTZWxlY3Rpb24gPSBmYWxzZTsKKwogICAgICAgICBsZXQgY29udHJvbHNOYXZpZ2F0 aW9uQmFyID0gbmV3IFdJLk5hdmlnYXRpb25CYXI7CiAKICAgICAgICAgdGhpcy5fc3RhcnRTdG9w QnV0dG9uTmF2aWdhdGlvbkl0ZW0gPSBuZXcgV0kuVG9nZ2xlQnV0dG9uTmF2aWdhdGlvbkl0ZW0o ImF1ZGl0LXN0YXJ0LXN0b3AiLCBXSS5VSVN0cmluZygiU3RhcnQiKSwgV0kuVUlTdHJpbmcoIlN0 b3AiKSwgIkltYWdlcy9BdWRpdFN0YXJ0LnN2ZyIsICJJbWFnZXMvQXVkaXRTdG9wLnN2ZyIsIDEz LCAxMyk7CkBAIC0yMzUsOCArMjM3LDE1IEBAIFdJLkF1ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5l bCA9IGNsYXNzIEF1ZGl0TmF2aWdhdGlvblNpZGViYXJQYW5lbCBleHRlbmRzIFdJLk5hCiAgICAg ICAgICAgICBpZiAodGhpcy5fc2VsZWN0ZWRUcmVlRWxlbWVudEJlZm9yZUVkaXRpbmcpCiAgICAg ICAgICAgICAgICAgdGhpcy5fc2VsZWN0ZWRUcmVlRWxlbWVudEJlZm9yZUVkaXRpbmcuZGVzZWxl Y3QoKTsKICAgICAgICAgfSBlbHNlIGlmICh0aGlzLl9zZWxlY3RlZFRyZWVFbGVtZW50QmVmb3Jl RWRpdGluZykgewotICAgICAgICAgICAgaWYgKCEodGhpcy5fc2VsZWN0ZWRUcmVlRWxlbWVudEJl Zm9yZUVkaXRpbmcucmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXSS5BdWRpdFRlc3RCYXNl KSB8fCAhdGhpcy5fc2VsZWN0ZWRUcmVlRWxlbWVudEJlZm9yZUVkaXRpbmcucmVwcmVzZW50ZWRP YmplY3QuZGlzYWJsZWQpCi0gICAgICAgICAgICAgICAgdGhpcy5fc2VsZWN0ZWRUcmVlRWxlbWVu dEJlZm9yZUVkaXRpbmcuc2VsZWN0KCk7CisgICAgICAgICAgICBpZiAodGhpcy5jb250ZW50VHJl ZU91dGxpbmUuc2VsZWN0ZWRUcmVlRWxlbWVudCA9PT0gdGhpcy5fc2VsZWN0ZWRUcmVlRWxlbWVu dEJlZm9yZUVkaXRpbmcpIHsKKyAgICAgICAgICAgICAgICBjb25zdCBzdXBwcmVzc05vdGlmaWNh dGlvbiA9IHRydWU7CisgICAgICAgICAgICAgICAgdGhpcy5fc2VsZWN0ZWRUcmVlRWxlbWVudEJl Zm9yZUVkaXRpbmcuZGVzZWxlY3Qoc3VwcHJlc3NOb3RpZmljYXRpb24pOworICAgICAgICAgICAg fQorICAgICAgICAgICAgaWYgKCEodGhpcy5fc2VsZWN0ZWRUcmVlRWxlbWVudEJlZm9yZUVkaXRp bmcucmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXSS5BdWRpdFRlc3RCYXNlKSB8fCAhdGhp cy5fc2VsZWN0ZWRUcmVlRWxlbWVudEJlZm9yZUVkaXRpbmcucmVwcmVzZW50ZWRPYmplY3QuZGlz YWJsZWQpIHsKKyAgICAgICAgICAgICAgICBjb25zdCBvbWl0Rm9jdXMgPSBmYWxzZTsKKyAgICAg ICAgICAgICAgICBjb25zdCBzZWxlY3RlZEJ5VXNlciA9IHRydWU7CisgICAgICAgICAgICAgICAg dGhpcy5fc2VsZWN0ZWRUcmVlRWxlbWVudEJlZm9yZUVkaXRpbmcuc2VsZWN0KG9taXRGb2N1cywg c2VsZWN0ZWRCeVVzZXIpOworICAgICAgICAgICAgfQogICAgICAgICAgICAgdGhpcy5fc2VsZWN0 ZWRUcmVlRWxlbWVudEJlZm9yZUVkaXRpbmcgPSBudWxsOwogICAgICAgICB9CiAK