208666 2020-03-05 14:26:09 -0800 Add web page additions to WebPageProxy 2020-03-05 16:21:23 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 katherine_cheney katherine_cheney bfulgham cdumez commit-queue webkit-bug-importer oldest_to_newest 1626292 0 katherine_cheney 2020-03-05 14:26:09 -0800 Add web page additions to WebPageProxy 1626293 1 webkit-bug-importer 2020-03-05 14:26:37 -0800 <rdar://problem/60100413> 1626309 2 392628 katherine_cheney 2020-03-05 14:51:21 -0800 Created attachment 392628 Patch 1626311 3 392628 cdumez 2020-03-05 14:53:28 -0800 Comment on attachment 392628 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392628&action=review > Source/WebKit/UIProcess/WebPageProxy.cpp:282 > +#define WEB_PAGE_PROXY_ADDITIONS_1 Can we find better names? Maybe WEB_PAGE_PROXY_ADDITIONS_ISAPPBOUNDDOMAIN & WEB_PAGE_PROXY_ADDITIONS_SETISNAVIGATINGTOAPPBOUNDDOMAIN ? 1626327 4 392633 katherine_cheney 2020-03-05 15:15:00 -0800 Created attachment 392633 Patch 1626330 5 392633 bfulgham 2020-03-05 15:18:31 -0800 Comment on attachment 392633 Patch r=me 1626380 6 392633 commit-queue 2020-03-05 16:21:22 -0800 Comment on attachment 392633 Patch Clearing flags on attachment: 392633 Committed r257957: <https://trac.webkit.org/changeset/257957> 1626381 7 commit-queue 2020-03-05 16:21:23 -0800 All reviewed patches have been landed. Closing bug. 392628 2020-03-05 14:51:21 -0800 2020-03-05 15:14:59 -0800 Patch bug-208666-20200305145120.patch text/plain 2077 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRiNWRmNTk3ZWViYWMwZjkx YTY0MmZkODI3ZWQ0Y2YyNGZiMGNmM2YuLjFhOTVhNTg5YTlhOWZjN2EzNmNhMjc1Y2U4Zjc1NTE1 NGIyNWQyNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDMtMDUgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHdlYiBwYWdl IGFkZGl0aW9ucyB0byBXZWJQYWdlUHJveHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwODY2NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAxMDA0 MTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5 Ojppc0FwcEJvdW5kRG9tYWluIGNvbnN0KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5 OjpzZXRJc05hdmlnYXRpbmdUb0FwcEJvdW5kRG9tYWluKToKKwogMjAyMC0wMy0wNCAgUGVyIEFy bmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUGFydGlhbGx5IHJldmVy dCByMjU2NzU2LCBzaW5jZSBpdCBpbnRyb2R1Y2VkIGJ1Z3MgcmVsYXRlZCB0byBBY2Nlc3NpYmls aXR5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggYzBlMGUy M2NhOWJjZjBkNmMxYzJlMGE3ZGViOGZlOTI4ZDU4MGVhZi4uMmM2NGVkODQwZjk5ODJmMTlkOWU5 NmQyMjNmNTM1OTQ3ZjAyNGMxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuY3BwCkBAIC0yNzksNyArMjc5LDggQEAKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQog I2luY2x1ZGUgPFdlYktpdEFkZGl0aW9ucy9XZWJQYWdlUHJveHlBZGRpdGlvbnMuaD4KICNlbHNl Ci0jZGVmaW5lIFdFQl9QQUdFX1BST1hZX0FERElUSU9OUworI2RlZmluZSBXRUJfUEFHRV9QUk9Y WV9BRERJVElPTlNfMQorI2RlZmluZSBXRUJfUEFHRV9QUk9YWV9BRERJVElPTlNfMgogI2VuZGlm CiAKIC8vIFRoaXMgY29udHJvbHMgd2hhdCBzdHJhdGVneSB3ZSB1c2UgZm9yIG1vdXNlIHdoZWVs IGNvYWxlc2NpbmcuCkBAIC0zMDk3LDcgKzMwOTgsNyBAQCBwcml2YXRlOgogCiBib29sIFdlYlBh Z2VQcm94eTo6aXNBcHBCb3VuZERvbWFpbihjb25zdCBXZWJDb3JlOjpSZWdpc3RyYWJsZURvbWFp biYgZG9tYWluKSBjb25zdAogewotICAgIFdFQl9QQUdFX1BST1hZX0FERElUSU9OUworICAgIFdF Ql9QQUdFX1BST1hZX0FERElUSU9OU18xCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKQEAgLTMxMDks NiArMzExMCw3IEBAIGJvb2wgV2ViUGFnZVByb3h5Ojppc0FwcEJvdW5kRG9tYWluKGNvbnN0IFVS TCYgdXJsKSBjb25zdAogdm9pZCBXZWJQYWdlUHJveHk6OnNldElzTmF2aWdhdGluZ1RvQXBwQm91 bmREb21haW4oYm9vbCBpc01haW5GcmFtZSwgY29uc3QgVVJMJiByZXF1ZXN0VVJMKQogewogICAg IGlmIChtX3ByZWZlcmVuY2VzLT5pc0luQXBwQnJvd3NlclByaXZhY3lFbmFibGVkKCkgJiYgaXNN YWluRnJhbWUpIHsKKyAgICAgICAgV0VCX1BBR0VfUFJPWFlfQURESVRJT05TXzIKICAgICAgICAg aWYgKCFpc0FwcEJvdW5kRG9tYWluKHJlcXVlc3RVUkwpKSB7CiAgICAgICAgICAgICBtX2NvbmZp Z3VyYXRpb24tPnNldFdlYlZpZXdDYXRlZ29yeShXZWJWaWV3Q2F0ZWdvcnk6OkluQXBwQnJvd3Nl cik7CiAgICAgICAgICAgICBtX2lzTmF2aWdhdGluZ1RvQXBwQm91bmREb21haW4gPSBOYXZpZ2F0 aW5nVG9BcHBCb3VuZERvbWFpbjo6Tm87Cg== 392633 2020-03-05 15:15:00 -0800 2020-03-05 16:21:22 -0800 Patch bug-208666-20200305151459.patch text/plain 2167 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRiNWRmNTk3ZWViYWMwZjkx YTY0MmZkODI3ZWQ0Y2YyNGZiMGNmM2YuLjFhOTVhNTg5YTlhOWZjN2EzNmNhMjc1Y2U4Zjc1NTE1 NGIyNWQyNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDMtMDUgIEthdGUgQ2hl bmV5ICA8a2F0aGVyaW5lX2NoZW5leUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHdlYiBwYWdl IGFkZGl0aW9ucyB0byBXZWJQYWdlUHJveHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwODY2NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAxMDA0 MTM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5 Ojppc0FwcEJvdW5kRG9tYWluIGNvbnN0KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5 OjpzZXRJc05hdmlnYXRpbmdUb0FwcEJvdW5kRG9tYWluKToKKwogMjAyMC0wMy0wNCAgUGVyIEFy bmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgUGFydGlhbGx5IHJldmVy dCByMjU2NzU2LCBzaW5jZSBpdCBpbnRyb2R1Y2VkIGJ1Z3MgcmVsYXRlZCB0byBBY2Nlc3NpYmls aXR5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNw cCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKaW5kZXggYzBlMGUy M2NhOWJjZjBkNmMxYzJlMGE3ZGViOGZlOTI4ZDU4MGVhZi4uZmRiNzI5MDI1YjY5YTQ2ZTA3YmQ2 MDg2ZjhmMjQ4OTNlNjVmMTRiYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJv eHkuY3BwCkBAIC0yNzksNyArMjc5LDggQEAKICNpZiBVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQog I2luY2x1ZGUgPFdlYktpdEFkZGl0aW9ucy9XZWJQYWdlUHJveHlBZGRpdGlvbnMuaD4KICNlbHNl Ci0jZGVmaW5lIFdFQl9QQUdFX1BST1hZX0FERElUSU9OUworI2RlZmluZSBXRUJfUEFHRV9QUk9Y WV9BRERJVElPTlNfSVNBUFBCT1VORERPTUFJTgorI2RlZmluZSBXRUJfUEFHRV9QUk9YWV9BRERJ VElPTlNfU0VUSVNOQVZJR0FUSU5HVE9BUFBCT1VORERPTUFJTgogI2VuZGlmCiAKIC8vIFRoaXMg Y29udHJvbHMgd2hhdCBzdHJhdGVneSB3ZSB1c2UgZm9yIG1vdXNlIHdoZWVsIGNvYWxlc2Npbmcu CkBAIC0zMDk3LDcgKzMwOTgsNyBAQCBwcml2YXRlOgogCiBib29sIFdlYlBhZ2VQcm94eTo6aXNB cHBCb3VuZERvbWFpbihjb25zdCBXZWJDb3JlOjpSZWdpc3RyYWJsZURvbWFpbiYgZG9tYWluKSBj b25zdAogewotICAgIFdFQl9QQUdFX1BST1hZX0FERElUSU9OUworICAgIFdFQl9QQUdFX1BST1hZ X0FERElUSU9OU19JU0FQUEJPVU5ERE9NQUlOCiAgICAgcmV0dXJuIHRydWU7CiB9CiAKQEAgLTMx MDksNiArMzExMCw3IEBAIGJvb2wgV2ViUGFnZVByb3h5Ojppc0FwcEJvdW5kRG9tYWluKGNvbnN0 IFVSTCYgdXJsKSBjb25zdAogdm9pZCBXZWJQYWdlUHJveHk6OnNldElzTmF2aWdhdGluZ1RvQXBw Qm91bmREb21haW4oYm9vbCBpc01haW5GcmFtZSwgY29uc3QgVVJMJiByZXF1ZXN0VVJMKQogewog ICAgIGlmIChtX3ByZWZlcmVuY2VzLT5pc0luQXBwQnJvd3NlclByaXZhY3lFbmFibGVkKCkgJiYg aXNNYWluRnJhbWUpIHsKKyAgICAgICAgV0VCX1BBR0VfUFJPWFlfQURESVRJT05TX1NFVElTTkFW SUdBVElOR1RPQVBQQk9VTkRET01BSU4KICAgICAgICAgaWYgKCFpc0FwcEJvdW5kRG9tYWluKHJl cXVlc3RVUkwpKSB7CiAgICAgICAgICAgICBtX2NvbmZpZ3VyYXRpb24tPnNldFdlYlZpZXdDYXRl Z29yeShXZWJWaWV3Q2F0ZWdvcnk6OkluQXBwQnJvd3Nlcik7CiAgICAgICAgICAgICBtX2lzTmF2 aWdhdGluZ1RvQXBwQm91bmREb21haW4gPSBOYXZpZ2F0aW5nVG9BcHBCb3VuZERvbWFpbjo6Tm87 Cg==