208663 2020-03-05 13:11:06 -0800 [First paint] Fixed sized SVG content should taken into account when computing VNE status 2020-03-05 15:44:04 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue esprehn+autocc ews-watchlist glenn kondapallykalyan pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1626257 0 zalan 2020-03-05 13:11:06 -0800 ssia 1626258 1 webkit-bug-importer 2020-03-05 13:11:30 -0800 <rdar://problem/60096896> 1626263 2 392613 zalan 2020-03-05 13:16:33 -0800 Created attachment 392613 Patch 1626277 3 392613 simon.fraser 2020-03-05 13:48:34 -0800 Comment on attachment 392613 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392613&action=review > Source/WebCore/ChangeLog:9 > + Let's add fixed sized SVG to the list if content we track as VNE pixel count. if -> of > Source/WebCore/rendering/updating/RenderTreeBuilder.cpp:944 > + // SVG content tends to have a fixed size construct. Maybe more words about how we know this is wrong in some ways. 1626313 4 392630 zalan 2020-03-05 14:57:19 -0800 Created attachment 392630 Patch 1626314 5 392631 zalan 2020-03-05 14:58:48 -0800 Created attachment 392631 Patch 1626340 6 392631 commit-queue 2020-03-05 15:44:03 -0800 Comment on attachment 392631 Patch Clearing flags on attachment: 392631 Committed r257952: <https://trac.webkit.org/changeset/257952> 1626341 7 commit-queue 2020-03-05 15:44:04 -0800 All reviewed patches have been landed. Closing bug. 392613 2020-03-05 13:16:33 -0800 2020-03-05 14:57:17 -0800 Patch bug-208663-20200305131633.patch text/plain 2346 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3OTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWEwYjU4NGY4MTE4NDZh MTUzOGRmZWMzOGU0OTIwMTE4NGRkZTI2Yi4uZGNkMWVmMjE3M2ZmNWJmYzQ3MjFhNWYwYmZjYjRj OWEzOGJiYzE3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAzLTA1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0ZpcnN0IHBhaW50XSBGaXhl ZCBzaXplZCBTVkcgY29udGVudCBzaG91bGQgdGFrZW4gaW50byBhY2NvdW50IHdoZW4gY29tcHV0 aW5nIFZORSBzdGF0dXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwODY2MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAwOTY4OTY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTGV0J3MgYWRkIGZpeGVk IHNpemVkIFNWRyB0byB0aGUgbGlzdCBpZiBjb250ZW50IHdlIHRyYWNrIGFzIFZORSBwaXhlbCBj b3VudC4KKyAgICAgICAgSXQgaGVscHMgdG8gcmVhY2ggVk5FIHN0YXR1cyBzb29uZXIgb24geW91 dHViZS5jb20uCisKKyAgICAgICAgKiByZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxk ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVHJlZUJ1aWxkZXI6OnJlcG9ydFZpc3Vh bGx5Tm9uRW1wdHlDb250ZW50KToKKwogMjAyMC0wMy0wNSAgeW91ZW5uIGZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgSW4gY2FzZSBhbiBhY3RpdmF0aW5nIHNlcnZpY2Ugd29y a2VyIGlzIHRlcm1pbmF0ZWQsIGl0IHNob3VsZCBnbyB0byBhY3RpdmF0ZWQgc3RhdGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxk ZXIuY3BwCmluZGV4IDVlYzNjMGMxMjk1Y2MzMWE5YjdlZmFlMGRiNDJhMjJjZDUyODYzZWMuLmQ5 ZmJlNWFlMzg3MDI5ZWRhYTExMzZkMTI2ZGNhNjIzOWRmNDFhNjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVyLmNwcApA QCAtOTM0LDYgKzkzNCwyNCBAQCB2b2lkIFJlbmRlclRyZWVCdWlsZGVyOjpyZXBvcnRWaXN1YWxs eU5vbkVtcHR5Q29udGVudChjb25zdCBSZW5kZXJFbGVtZW50JiBwYXJlbgogICAgICAgICBtX3Zp ZXcuZnJhbWVWaWV3KCkuaW5jcmVtZW50VmlzdWFsbHlOb25FbXB0eVBpeGVsQ291bnQocm91bmRl ZEludFNpemUocmVwbGFjZWRSZW5kZXJlci5pbnRyaW5zaWNTaXplKCkpKTsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KKyAgICBpZiAoaXM8UmVuZGVyU1ZHUm9vdD4oY2hpbGQpKSB7CisgICAgICAg IGF1dG8gZml4ZWRTaXplID0gW10gKGNvbnN0IGF1dG8mIHJlbmRlcmVyKSAtPiBPcHRpb25hbDxJ bnRTaXplPiB7CisgICAgICAgICAgICBhdXRvJiBzdHlsZSA9IHJlbmRlcmVyLnN0eWxlKCk7Cisg ICAgICAgICAgICBpZiAoIXN0eWxlLndpZHRoKCkuaXNGaXhlZCgpIHx8ICFzdHlsZS5oZWlnaHQo KS5pc0ZpeGVkKCkpCisgICAgICAgICAgICAgICAgcmV0dXJuIHsgfTsKKyAgICAgICAgICAgIHJl dHVybiBtYWtlT3B0aW9uYWwoSW50U2l6ZSB7IHN0eWxlLndpZHRoKCkuaW50VmFsdWUoKSwgc3R5 bGUuaGVpZ2h0KCkuaW50VmFsdWUoKSB9KTsKKyAgICAgICAgfTsKKyAgICAgICAgLy8gU1ZHIGNv bnRlbnQgdGVuZHMgdG8gaGF2ZSBhIGZpeGVkIHNpemUgY29uc3RydWN0LgorICAgICAgICBhdXRv IGNhbmRpZGF0ZVNpemUgPSBJbnRTaXplIHsgfTsKKyAgICAgICAgaWYgKGF1dG8gc2l6ZSA9IGZp eGVkU2l6ZShjaGlsZCkpCisgICAgICAgICAgICBjYW5kaWRhdGVTaXplID0gKnNpemU7CisgICAg ICAgIGVsc2UgaWYgKGF1dG8gc2l6ZSA9IGZpeGVkU2l6ZShwYXJlbnQpKQorICAgICAgICAgICAg Y2FuZGlkYXRlU2l6ZSA9ICpzaXplOworCisgICAgICAgIGlmICghY2FuZGlkYXRlU2l6ZS5pc0Vt cHR5KCkpCisgICAgICAgICAgICBtX3ZpZXcuZnJhbWVWaWV3KCkuaW5jcmVtZW50VmlzdWFsbHlO b25FbXB0eVBpeGVsQ291bnQoY2FuZGlkYXRlU2l6ZSk7CisgICAgICAgIHJldHVybjsKKyAgICB9 CiB9CiAKIH0K 392630 2020-03-05 14:57:19 -0800 2020-03-05 14:58:14 -0800 Patch bug-208663-20200305145718.patch text/plain 2473 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3OTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWEwYjU4NGY4MTE4NDZh MTUzOGRmZWMzOGU0OTIwMTE4NGRkZTI2Yi4uZDEwOGNmYzc2OTdjYjU4NDhmZDNkNTAzNTQ2NjY2 ZDEwOGE0OWVkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAzLTA1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0ZpcnN0IHBhaW50XSBGaXhl ZCBzaXplZCBTVkcgY29udGVudCBzaG91bGQgdGFrZW4gaW50byBhY2NvdW50IHdoZW4gY29tcHV0 aW5nIFZORSBzdGF0dXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwODY2MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAwOTY4OTY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIExldCdzIGFkZCBmaXhlZCBz aXplZCBTVkcgdG8gdGhlIGxpc3QgaWYgY29udGVudCB3ZSB0cmFjayBhcyBWTkUgcGl4ZWwgY291 bnQuCisgICAgICAgIEl0IGhlbHBzIHRvIHJlYWNoIFZORSBzdGF0dXMgc29vbmVyIG9uIHlvdXR1 YmUuY29tLgorCisgICAgICAgICogcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRyZWVCdWlsZGVyOjpyZXBvcnRWaXN1YWxs eU5vbkVtcHR5Q29udGVudCk6CisKIDIwMjAtMDMtMDUgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5A YXBwbGUuY29tPgogCiAgICAgICAgIEluIGNhc2UgYW4gYWN0aXZhdGluZyBzZXJ2aWNlIHdvcmtl ciBpcyB0ZXJtaW5hdGVkLCBpdCBzaG91bGQgZ28gdG8gYWN0aXZhdGVkIHN0YXRlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVy LmNwcAppbmRleCA1ZWMzYzBjMTI5NWNjMzFhOWI3ZWZhZTBkYjQyYTIyY2Q1Mjg2M2VjLi40YjI0 YjNiNjljY2ExMjdmNTYyMTBiOWRlNjhjOGNlYmY2NDJmYzU2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAKQEAg LTkzNCw2ICs5MzQsMjQgQEAgdm9pZCBSZW5kZXJUcmVlQnVpbGRlcjo6cmVwb3J0VmlzdWFsbHlO b25FbXB0eUNvbnRlbnQoY29uc3QgUmVuZGVyRWxlbWVudCYgcGFyZW4KICAgICAgICAgbV92aWV3 LmZyYW1lVmlldygpLmluY3JlbWVudFZpc3VhbGx5Tm9uRW1wdHlQaXhlbENvdW50KHJvdW5kZWRJ bnRTaXplKHJlcGxhY2VkUmVuZGVyZXIuaW50cmluc2ljU2l6ZSgpKSk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CisgICAgaWYgKGlzPFJlbmRlclNWR1Jvb3Q+KGNoaWxkKSkgeworICAgICAgICBh dXRvIGZpeGVkU2l6ZSA9IFtdIChjb25zdCBhdXRvJiByZW5kZXJlcikgLT4gT3B0aW9uYWw8SW50 U2l6ZT4geworICAgICAgICAgICAgYXV0byYgc3R5bGUgPSByZW5kZXJlci5zdHlsZSgpOworICAg ICAgICAgICAgaWYgKCFzdHlsZS53aWR0aCgpLmlzRml4ZWQoKSB8fCAhc3R5bGUuaGVpZ2h0KCku aXNGaXhlZCgpKQorICAgICAgICAgICAgICAgIHJldHVybiB7IH07CisgICAgICAgICAgICByZXR1 cm4gbWFrZU9wdGlvbmFsKEludFNpemUgeyBzdHlsZS53aWR0aCgpLmludFZhbHVlKCksIHN0eWxl LmhlaWdodCgpLmludFZhbHVlKCkgfSk7CisgICAgICAgIH07CisgICAgICAgIC8vIFNWRyBjb250 ZW50IHRlbmRzIHRvIGhhdmUgYSBmaXhlZCBzaXplIGNvbnN0cnVjdC4gSG93ZXZlciB0aGlzIGlz IGtub3duIHRvIGJlIGluYWNjdXJhdGUgaW4gY2VydGFpbiBjYXNlcyAoYm94LXNpemluZzogYm9y ZGVyLWJveCkgb3IgZXNwZWNpYWxseSB3aGVuIHRoZSBwYXJlbnQgYm94IGlzIG92ZXJzaXplZC4K KyAgICAgICAgYXV0byBjYW5kaWRhdGVTaXplID0gSW50U2l6ZSB7IH07CisgICAgICAgIGlmIChh dXRvIHNpemUgPSBmaXhlZFNpemUoY2hpbGQpKQorICAgICAgICAgICAgY2FuZGlkYXRlU2l6ZSA9 ICpzaXplOworICAgICAgICBlbHNlIGlmIChhdXRvIHNpemUgPSBmaXhlZFNpemUocGFyZW50KSkK KyAgICAgICAgICAgIGNhbmRpZGF0ZVNpemUgPSAqc2l6ZTsKKworICAgICAgICBpZiAoIWNhbmRp ZGF0ZVNpemUuaXNFbXB0eSgpKQorICAgICAgICAgICAgbV92aWV3LmZyYW1lVmlldygpLmluY3Jl bWVudFZpc3VhbGx5Tm9uRW1wdHlQaXhlbENvdW50KGNhbmRpZGF0ZVNpemUpOworICAgICAgICBy ZXR1cm47CisgICAgfQogfQogCiB9Cg== 392631 2020-03-05 14:58:48 -0800 2020-03-05 15:44:03 -0800 Patch bug-208663-20200305145848.patch text/plain 2473 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3OTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWEwYjU4NGY4MTE4NDZh MTUzOGRmZWMzOGU0OTIwMTE4NGRkZTI2Yi4uNDAzYjBhZDc5NTEwODQ1N2MxZTE1NjFlZmE4YWM3 MGM5NTFmNGY3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAzLTA1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0ZpcnN0IHBhaW50XSBGaXhl ZCBzaXplZCBTVkcgY29udGVudCBzaG91bGQgdGFrZW4gaW50byBhY2NvdW50IHdoZW4gY29tcHV0 aW5nIFZORSBzdGF0dXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwODY2MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAwOTY4OTY+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIExldCdzIGFkZCBmaXhlZCBz aXplZCBTVkcgdG8gdGhlIGxpc3Qgb2YgY29udGVudCB3ZSB0cmFjayBhcyBWTkUgcGl4ZWwgY291 bnQuCisgICAgICAgIEl0IGhlbHBzIHRvIHJlYWNoIFZORSBzdGF0dXMgc29vbmVyIG9uIHlvdXR1 YmUuY29tLgorCisgICAgICAgICogcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRyZWVCdWlsZGVyOjpyZXBvcnRWaXN1YWxs eU5vbkVtcHR5Q29udGVudCk6CisKIDIwMjAtMDMtMDUgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5A YXBwbGUuY29tPgogCiAgICAgICAgIEluIGNhc2UgYW4gYWN0aXZhdGluZyBzZXJ2aWNlIHdvcmtl ciBpcyB0ZXJtaW5hdGVkLCBpdCBzaG91bGQgZ28gdG8gYWN0aXZhdGVkIHN0YXRlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3VwZGF0aW5nL1JlbmRlclRyZWVCdWlsZGVy LmNwcAppbmRleCA1ZWMzYzBjMTI5NWNjMzFhOWI3ZWZhZTBkYjQyYTIyY2Q1Mjg2M2VjLi40YjI0 YjNiNjljY2ExMjdmNTYyMTBiOWRlNjhjOGNlYmY2NDJmYzU2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvdXBkYXRpbmcvUmVuZGVyVHJlZUJ1aWxkZXIuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy91cGRhdGluZy9SZW5kZXJUcmVlQnVpbGRlci5jcHAKQEAg LTkzNCw2ICs5MzQsMjQgQEAgdm9pZCBSZW5kZXJUcmVlQnVpbGRlcjo6cmVwb3J0VmlzdWFsbHlO b25FbXB0eUNvbnRlbnQoY29uc3QgUmVuZGVyRWxlbWVudCYgcGFyZW4KICAgICAgICAgbV92aWV3 LmZyYW1lVmlldygpLmluY3JlbWVudFZpc3VhbGx5Tm9uRW1wdHlQaXhlbENvdW50KHJvdW5kZWRJ bnRTaXplKHJlcGxhY2VkUmVuZGVyZXIuaW50cmluc2ljU2l6ZSgpKSk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CisgICAgaWYgKGlzPFJlbmRlclNWR1Jvb3Q+KGNoaWxkKSkgeworICAgICAgICBh dXRvIGZpeGVkU2l6ZSA9IFtdIChjb25zdCBhdXRvJiByZW5kZXJlcikgLT4gT3B0aW9uYWw8SW50 U2l6ZT4geworICAgICAgICAgICAgYXV0byYgc3R5bGUgPSByZW5kZXJlci5zdHlsZSgpOworICAg ICAgICAgICAgaWYgKCFzdHlsZS53aWR0aCgpLmlzRml4ZWQoKSB8fCAhc3R5bGUuaGVpZ2h0KCku aXNGaXhlZCgpKQorICAgICAgICAgICAgICAgIHJldHVybiB7IH07CisgICAgICAgICAgICByZXR1 cm4gbWFrZU9wdGlvbmFsKEludFNpemUgeyBzdHlsZS53aWR0aCgpLmludFZhbHVlKCksIHN0eWxl LmhlaWdodCgpLmludFZhbHVlKCkgfSk7CisgICAgICAgIH07CisgICAgICAgIC8vIFNWRyBjb250 ZW50IHRlbmRzIHRvIGhhdmUgYSBmaXhlZCBzaXplIGNvbnN0cnVjdC4gSG93ZXZlciB0aGlzIGlz IGtub3duIHRvIGJlIGluYWNjdXJhdGUgaW4gY2VydGFpbiBjYXNlcyAoYm94LXNpemluZzogYm9y ZGVyLWJveCkgb3IgZXNwZWNpYWxseSB3aGVuIHRoZSBwYXJlbnQgYm94IGlzIG92ZXJzaXplZC4K KyAgICAgICAgYXV0byBjYW5kaWRhdGVTaXplID0gSW50U2l6ZSB7IH07CisgICAgICAgIGlmIChh dXRvIHNpemUgPSBmaXhlZFNpemUoY2hpbGQpKQorICAgICAgICAgICAgY2FuZGlkYXRlU2l6ZSA9 ICpzaXplOworICAgICAgICBlbHNlIGlmIChhdXRvIHNpemUgPSBmaXhlZFNpemUocGFyZW50KSkK KyAgICAgICAgICAgIGNhbmRpZGF0ZVNpemUgPSAqc2l6ZTsKKworICAgICAgICBpZiAoIWNhbmRp ZGF0ZVNpemUuaXNFbXB0eSgpKQorICAgICAgICAgICAgbV92aWV3LmZyYW1lVmlldygpLmluY3Jl bWVudFZpc3VhbGx5Tm9uRW1wdHlQaXhlbENvdW50KGNhbmRpZGF0ZVNpemUpOworICAgICAgICBy ZXR1cm47CisgICAgfQogfQogCiB9Cg==