208645 2020-03-05 09:11:15 -0800 [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner 2020-03-05 10:42:16 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard webkit-bug-importer oldest_to_newest 1626104 0 aakash_jain 2020-03-05 09:11:15 -0800 [ews] ValidateCommiterAndReviewer (for commit-queue) should validate emails in case insensitive manner. Some users might have their email in lowercase in contributros.json while it might be in upper case in the bugzilla account. For such cases ValidateCommiterAndReviewer shouldn't fail (e.g.: for Basuke.Suzuki@sony.com in https://ews-build.webkit-uat.org/#/builders/26/builds/1116). 1626106 1 392581 aakash_jain 2020-03-05 09:12:10 -0800 Created attachment 392581 Patch 1626164 2 commit-queue 2020-03-05 10:16:29 -0800 Committed r257925: <https://trac.webkit.org/changeset/257925> All reviewed patches have been landed. Closing bug and clearing flags on attachment 392581. 1626166 3 webkit-bug-importer 2020-03-05 10:17:16 -0800 <rdar://problem/60088938> 392581 2020-03-05 09:12:10 -0800 2020-03-05 10:16:30 -0800 Patch bug-208645-20200305121209.patch text/plain 2326 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NzkxOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIwLTAzLTA1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBWYWxpZGF0ZUNvbW1pdGVyQW5kUmV2aWV3ZXIgc2hvdWxkIHZh bGlkYXRlIGVtYWlscyBpbiBjYXNlIGluc2Vuc2l0aXZlIG1hbm5lcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NjQ1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9ld3Mt YnVpbGQvc3RlcHMucHk6CisgICAgICAgIChWYWxpZGF0ZUNvbW1pdGVyQW5kUmV2aWV3ZXIubG9h ZF9jb250cmlidXRvcnMpOgorICAgICAgICAoVmFsaWRhdGVDb21taXRlckFuZFJldmlld2VyLnN0 YXJ0KToKKwogMjAyMC0wMy0wNCAgQmFzdWtlIFN1enVraSAgPGJhc3VrZS5zdXp1a2lAc29ueS5j b20+CiAKICAgICAgICAgW01TVkNdIEFkZCAubmF0dmlzIHN1cHBvcnQgb2YgV2ViS2l0IHR5cGVz CkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CShyZXZp c2lvbiAyNTc5MTgpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMu cHkJKHdvcmtpbmcgY29weSkKQEAgLTY0NCw3ICs2NDQsNyBAQCBjbGFzcyBWYWxpZGF0ZUNvbW1p dGVyQW5kUmV2aWV3ZXIoYnVpbGRzCiAgICAgICAgIGZvciBrZXksIHZhbHVlIGluIGNvbnRyaWJ1 dG9yc19qc29uLml0ZXJpdGVtcygpOgogICAgICAgICAgICAgZW1haWxzID0gdmFsdWUuZ2V0KCdl bWFpbHMnKQogICAgICAgICAgICAgZm9yIGVtYWlsIGluIGVtYWlsczoKLSAgICAgICAgICAgICAg ICBjb250cmlidXRvcnNbZW1haWxdID0geyduYW1lJzoga2V5LCAnc3RhdHVzJzogdmFsdWUuZ2V0 KCdzdGF0dXMnKX0KKyAgICAgICAgICAgICAgICBjb250cmlidXRvcnNbZW1haWwubG93ZXIoKV0g PSB7J25hbWUnOiBrZXksICdzdGF0dXMnOiB2YWx1ZS5nZXQoJ3N0YXR1cycpfQogICAgICAgICBy ZXR1cm4gY29udHJpYnV0b3JzCiAKICAgICBAZGVmZXIuaW5saW5lQ2FsbGJhY2tzCkBAIC02OTMs MTMgKzY5MywxMyBAQCBjbGFzcyBWYWxpZGF0ZUNvbW1pdGVyQW5kUmV2aWV3ZXIoYnVpbGRzCiAg ICAgICAgICAgICBzZWxmLmRlc2NyaXB0aW9uRG9uZSA9ICdGYWlsZWQgdG8gZ2V0IGNvbnRyaWJ1 dG9ycyBpbmZvcm1hdGlvbicKICAgICAgICAgICAgIHNlbGYuYnVpbGQuYnVpbGRGaW5pc2hlZChb J0ZhaWxlZCB0byBnZXQgY29udHJpYnV0b3JzIGluZm9ybWF0aW9uJ10sIEZBSUxVUkUpCiAgICAg ICAgICAgICByZXR1cm4gTm9uZQotICAgICAgICBwYXRjaF9jb21taXR0ZXIgPSBzZWxmLmdldFBy b3BlcnR5KCdwYXRjaF9jb21taXR0ZXInLCAnJykKKyAgICAgICAgcGF0Y2hfY29tbWl0dGVyID0g c2VsZi5nZXRQcm9wZXJ0eSgncGF0Y2hfY29tbWl0dGVyJywgJycpLmxvd2VyKCkKICAgICAgICAg aWYgbm90IHNlbGYuaXNfY29tbWl0dGVyKHBhdGNoX2NvbW1pdHRlcik6CiAgICAgICAgICAgICBz ZWxmLmZhaWxfYnVpbGQocGF0Y2hfY29tbWl0dGVyLCAnY29tbWl0dGVyJykKICAgICAgICAgICAg IHJldHVybiBOb25lCiAgICAgICAgIHNlbGYuX2FkZFRvTG9nKCdzdGRpbycsICd7fSBpcyBhIHZh bGlkIGNvbW1pdGVyLlxuJy5mb3JtYXQocGF0Y2hfY29tbWl0dGVyKSkKIAotICAgICAgICBwYXRj aF9yZXZpZXdlciA9IHNlbGYuZ2V0UHJvcGVydHkoJ3BhdGNoX3Jldmlld2VyJywgJycpCisgICAg ICAgIHBhdGNoX3Jldmlld2VyID0gc2VsZi5nZXRQcm9wZXJ0eSgncGF0Y2hfcmV2aWV3ZXInLCAn JykubG93ZXIoKQogICAgICAgICBpZiBub3QgcGF0Y2hfcmV2aWV3ZXI6CiAgICAgICAgICAgICAj IFBhdGNoIGRvZXMgbm90IGhhdmUgcisgZmxhZy4gVGhpcyBpcyBhY2NlcHRhYmxlLCBzaW5jZSB0 aGUgQ2hhbmdlTG9nIG1pZ2h0IGhhdmUgJ1Jldmlld2VkIGJ5JyBpbiBpdC4KICAgICAgICAgICAg IHNlbGYuZGVzY3JpcHRpb25Eb25lID0gJ1ZhbGlkYXRlZCBjb21taXR0ZXInCg==