208628 2020-03-05 00:29:19 -0800 Nullptr crash in CompositeEditCommand::moveParagraphWithClones when indenting non-enclosed elements. 2020-03-10 16:41:24 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 shihchieh_lee webkit-unassigned bfulgham commit-queue ews-feeder product-security rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1625975 0 shihchieh_lee 2020-03-05 00:29:19 -0800 <rdar://52011509> ==42480==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000018 (pc 0x7fff4191f32f bp 0x7ffeef05af90 sp 0x7ffeef05af20 T0) ==42480==The signal is caused by a READ memory access. ==42480==Hint: address points to the zero page. #0 0x7fff4191f32e in WebCore::CompositeEditCommand::cloneParagraphUnderNewElement(WebCore::Position const&, WebCore::Position const&, WebCore::Node*, WebCore::Element*) (WebCore:x86_64+0xf0332e) #1 0x7fff4191f9f7 in WebCore::CompositeEditCommand::moveParagraphWithClones(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, WebCore::Element*, WebCore::Node*) (WebCore:x86_64+0xf039f7) #2 0x7fff4194fa9d in WebCore::IndentOutdentCommand::indentIntoBlockquote(WebCore::Position const&, WebCore::Position const&, WTF::RefPtr<WebCore::Element, WTF::DumbPtrTraits<WebCore::Element> >&) (WebCore:x86_64+0xf33a9d) #3 0x7fff4190c087 in WebCore::ApplyBlockElementCommand::formatSelection(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&) (WebCore:x86_64+0xef0087) #4 0x7fff4190afe1 in WebCore::ApplyBlockElementCommand::doApply() (WebCore:x86_64+0xeeefe1) #5 0x7fff40b931d9 in WebCore::CompositeEditCommand::apply() (WebCore:x86_64+0x1771d9) #6 0x7fff41953129 in WebCore::executeIndent(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&) (WebCore:x86_64+0xf37129) #7 0x7fff40bdcc3e in WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&) (WebCore:x86_64+0x1c0c3e) #8 0x7fff40bdc9da in WebCore::jsDocumentPrototypeFunctionExecCommand(JSC::ExecState*) (WebCore:x86_64+0x1c09da) #9 0x30570ec01176 (<unknown module>) #10 0x7fff3706bbdb in llint_entry (JavaScriptCore:x86_64+0x3babdb) #11 0x7fff3705c738 in vmEntryToJavaScript (JavaScriptCore:x86_64+0x3ab738) #12 0x7fff36ceb492 in JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) (JavaScriptCore:x86_64+0x3a492) 1625979 1 shihchieh_lee 2020-03-05 00:48:12 -0800 Root cause: In function IndentOutdentCommand::indentIntoBlockquote, startOfContents is the parent of end and outerBlock, causing unexpected behavior in function CompositeEditCommand::cloneParagraphUnderNewElement. In function cloneParagraphUnderNewElement, when outerBlock is not an ancestor of startOfContents, node traversal above the editable element, causing insertion of the cloned node to fail and the makes the node parentless. Later we try to insert another node to the parent of the cloned node, which is null, resulting in nullptr dereference. 1625991 2 392547 shihchieh_lee 2020-03-05 01:26:57 -0800 Created attachment 392547 Patch 1625992 3 392548 shihchieh_lee 2020-03-05 01:32:36 -0800 Created attachment 392548 Patch 1625994 4 392548 shihchieh_lee 2020-03-05 01:42:27 -0800 Comment on attachment 392548 Patch [121/1819] editing/execCommand/4641880-2.html failed unexpectedly (text diff) stopping WebKitTestRunner(pid 51788) timed out, killing it [391/1819] editing/execCommand/5481523.html failed unexpectedly (text diff) [491/1819] editing/execCommand/5658933-1.html failed unexpectedly (text diff) [509/1819] editing/execCommand/5658933-2.html failed unexpectedly (text diff) [519/1819] editing/execCommand/5658933-3.html failed unexpectedly (text diff) [898/1819] editing/execCommand/indent-div-inside-list.html failed unexpectedly (text diff) [909/1819] editing/execCommand/indent-images-2.html failed unexpectedly (text diff) [917/1819] editing/execCommand/indent-images.html failed unexpectedly (text diff) [923/1819] editing/execCommand/indent-img-twice.html failed unexpectedly (text diff) 1626006 5 392552 shihchieh_lee 2020-03-05 02:48:40 -0800 Created attachment 392552 Patch 1626008 6 shihchieh_lee 2020-03-05 03:02:54 -0800 Ran tests in LayoutTests/editing: 1815 tests ran as expected, 4 didn't: Expected to fail, but passed: (4) editing/mac/selection/context-menu-select-editability.html editing/spelling/spelling-marker-includes-hyphen.html editing/spelling/spelling-markers-in-overlapping-lines-large-font.html editing/spelling/spelling-markers-in-overlapping-lines.html (In reply to Jack from comment #5) > Created attachment 392552 [details] > Patch 1627507 7 shihchieh_lee 2020-03-08 08:39:36 -0700 The modified function is not called in the two failed test cases. fast/scrolling/scroll-animator-overlay-scrollbars-clicked.html fast/scrolling/scroll-animator-overlay-scrollbars-hovered.html 1628416 8 392552 rniwa 2020-03-10 15:53:15 -0700 Comment on attachment 392552 Patch Looks sane to me. 1628417 9 rniwa 2020-03-10 15:53:37 -0700 This is not a security bug. 1628433 10 392552 commit-queue 2020-03-10 16:41:23 -0700 Comment on attachment 392552 Patch Clearing flags on attachment: 392552 Committed r258239: <https://trac.webkit.org/changeset/258239> 1628434 11 commit-queue 2020-03-10 16:41:24 -0700 All reviewed patches have been landed. Closing bug. 392547 2020-03-05 01:26:57 -0800 2020-03-05 01:29:46 -0800 Patch bug-208628-20200305012656.patch text/plain 4259 shihchieh_lee U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg5OGNhZTk2MmRlMDM4 ZjA4Zjg5YWE1MTBkYzBkNjYwMzdkNzI3Mi4uYjhhNzljNDFjNjA1ZTg3ODk2ZDc3M2Y5Y2NlYzQy ODNmZmViZDY2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAzLTA1ICBKYWNr IExlZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2gg aW4gQ29tcG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQYXJhZ3JhcGhXaXRoQ2xvbmVzIHdoZW4gaW5k ZW50aW5nIG5vbi1lbmNsb3NlZCBlbGVtZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODYyOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTIw MTE1MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2hlbiBpbmRlbnRpbmcgYSBub24tZW5jbG9zZWQgcGFyYWdyYXBoLCBxdWl0IGlmIHN0YXJ0IG9m IGNvbnRlbnRzIGlzIG5vdCBhIGRlc2NlbmRhbnQgb2Ygb3V0ZXIgYmxvY2suCisKKyAgICAgICAg VGVzdDogZmFzdC9lZGl0aW5nL2luZGVudC1ub24tZW5jbG9zZWQtZWxlbWVudC1jcmFzaC5odG1s CisKKyAgICAgICAgKiBlZGl0aW5nL0luZGVudE91dGRlbnRDb21tYW5kLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkluZGVudE91dGRlbnRDb21tYW5kOjppbmRlbnRJbnRvQmxvY2txdW90ZSk6CisK IDIwMjAtMDMtMDMgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBbV2ViQXV0aG5dIEltcGxlbWVudCAtW19XS1dlYkF1dGhlbnRpY2F0aW9uUGFuZWxEZWxlZ2F0 ZSBwYW5lbDpkZWNpZGVQb2xpY3lGb3JMb2NhbEF1dGhlbnRpY2F0b3JXaXRoQ29tcGxldGlvbkhh bmRsZXI6XSBTUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5kZW50T3V0 ZGVudENvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9JbmRlbnRPdXRkZW50Q29t bWFuZC5jcHAKaW5kZXggYjFiNTBhZWJmMDg0ZGExNjRmMzkyY2JkMTQ4YTY2YTk1NzAxMjYxMC4u NDc3M2UxMmQzOWIwZGFiZTRiZjFmNjRiY2E5Y2UwZDgzNzRmODkxMCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9JbmRlbnRPdXRkZW50Q29tbWFuZC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9JbmRlbnRPdXRkZW50Q29tbWFuZC5jcHAKQEAgLTExOCw2ICsxMTgs OSBAQCB2b2lkIEluZGVudE91dGRlbnRDb21tYW5kOjppbmRlbnRJbnRvQmxvY2txdW90ZShjb25z dCBQb3NpdGlvbiYgc3RhcnQsIGNvbnN0IFBvcwogICAgICAgICAgICAgaW5zZXJ0Tm9kZUJlZm9y ZSgqdGFyZ2V0QmxvY2txdW90ZSwgKm91dGVyQmxvY2spOwogICAgICAgICBzdGFydE9mQ29udGVu dHMgPSBwb3NpdGlvbkluUGFyZW50QWZ0ZXJOb2RlKHRhcmdldEJsb2NrcXVvdGUuZ2V0KCkpOwog ICAgIH0KKyAgICAKKyAgICBpZiAob3V0ZXJCbG9jay0+aXNEZXNjZW5kYW50T2Yoc3RhcnRPZkNv bnRlbnRzLmRlZXBFcXVpdmFsZW50KCkuY29udGFpbmVyTm9kZSgpKSkKKyAgICAgICAgcmV0dXJu OwogCiAgICAgbW92ZVBhcmFncmFwaFdpdGhDbG9uZXMoc3RhcnRPZkNvbnRlbnRzLCBlbmQsIHRh cmdldEJsb2NrcXVvdGUuZ2V0KCksIG91dGVyQmxvY2suZ2V0KCkpOwogfQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJkOGE1 NzEwNzk0YmYwMTRkMTIxZGQwMjExODhiOWQ5MTBkZjBjYmMuLjI0MmI0NTlkNWRlZGQzNjQ2MWZj Y2ZkNTJmY2NkYmNlOThhZjgwNWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wMy0wNSAg SmFjayBMZWUgIDxzaGloY2hpZWhfbGVlQGFwcGxlLmNvbT4KKworICAgICAgICBOdWxscHRyIGNy YXNoIGluIENvbXBvc2l0ZUVkaXRDb21tYW5kOjptb3ZlUGFyYWdyYXBoV2l0aENsb25lcyB3aGVu IGluZGVudGluZyBub24tZW5jbG9zZWQgZWxlbWVudHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg2MjgKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzUyMDExNTA5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdoZW4gaW5kZW50aW5nIGEgbm9uLWVuY2xvc2VkIHBhcmFncmFwaCwgcXVpdCBpZiBzdGFy dCBvZiBjb250ZW50cyBpcyBub3QgYSBkZXNjZW5kYW50IG9mIG91dGVyIGJsb2NrLgorCisgICAg ICAgICogZmFzdC9lZGl0aW5nL2luZGVudC1ub24tZW5jbG9zZWQtZWxlbWVudC1jcmFzaC1leHBl Y3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZWRpdGluZy9pbmRlbnQtbm9uLWVuY2xv c2VkLWVsZW1lbnQtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMjAtMDMtMDQgIEphc29uIExhd3Jl bmNlICA8bGF3cmVuY2UuakBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTjogKHIyNTc4 NDA/KSBbIE1hYyB3azIgRGVidWcgXSBmYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L2Jsb2Nr LW9ubHkvcmVwbGFjZWQtaW50cmluc2ljLXdpZHRoLXNpbXBsZS5odG1sIGlzIGNyYXNoaW5nLiAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZWRpdGluZy9pbmRlbnQtbm9uLWVuY2xvc2Vk LWVsZW1lbnQtY3Jhc2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9lZGl0aW5nL2lu ZGVudC1ub24tZW5jbG9zZWQtZWxlbWVudC1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u ZDMyOGFhMzI0N2M2MTk3NmJlYWNmYjIxODQyYmJhNzNjYjc0YmM0OAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2Zhc3QvZWRpdGluZy9pbmRlbnQtbm9uLWVuY2xvc2VkLWVsZW1lbnQt Y3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBAQAorVGVzdHMgaW5kZW50aW5nIGEgbm9u LWVuY2xvc2VkIGVsZW1lbnQuIFRoZSB0ZXN0IHBhc3NlcyBpZiBXZWJLaXQgZG9lc24ndCBjcmFz aCBvciBoaXQgYW4gYXNzZXJ0aW9uLgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Vk aXRpbmcvaW5kZW50LW5vbi1lbmNsb3NlZC1lbGVtZW50LWNyYXNoLmh0bWwgYi9MYXlvdXRUZXN0 cy9mYXN0L2VkaXRpbmcvaW5kZW50LW5vbi1lbmNsb3NlZC1lbGVtZW50LWNyYXNoLmh0bWwKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uNWU4N2Q1Y2RjMDczN2UwZTc1NWU5Mzc4MzkwYjNmZTEwOTRhYjBhYQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZWRpdGluZy9pbmRlbnQtbm9uLWVuY2xvc2Vk LWVsZW1lbnQtY3Jhc2guaHRtbApAQCAtMCwwICsxLDEyIEBACis8c2NyaXB0PgorICAgIGlmICh3 aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAg b25sb2FkID0gZnVuY3Rpb24gZnVuKCkgeworICAgICAgICBvdXRlci5wcmVwZW5kKGlubmVyKTsK KyAgICAgICAgVEguaW5zZXJ0QWRqYWNlbnRUZXh0KCJiZWZvcmVCZWdpbiIsIlRlc3RzIGluZGVu dGluZyBhIG5vbi1lbmNsb3NlZCBlbGVtZW50LiBUaGUgdGVzdCBwYXNzZXMgaWYgV2ViS2l0IGRv ZXNuJ3QgY3Jhc2ggb3IgaGl0IGFuIGFzc2VydGlvbi4iKTsKKyAgICAgICAgZG9jdW1lbnQuZ2V0 U2VsZWN0aW9uKCkuc2V0UG9zaXRpb24oQ0cpOworICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFu ZCgiaW5kZW50IiwgZmFsc2UpOworICAgICAgICBkb2N1bWVudC5leGVjQ29tbWFuZCgiaW5kZW50 IiwgZmFsc2UpOworICAgIH0KKzwvc2NyaXB0PgorPGJvZHk+PGRpdj48ZGl2IGlkPW91dGVyPjxz cGFuPjwvc3Bhbj48L2Rpdj48c3Bhbj48L3NwYW4+PC9kaXY+PHNwYW4+PC9zcGFuPjxkaXYgaWQ9 aW5uZXI+PHRhYmxlIGlkPVRBQkxFIGNvbnRlbnRlZGl0YWJsZT10cnVlPjwvZGl2Pjxjb2xncm91 cCBpZD1DRz48L2NvbGdyb3VwPjx0aGVhZCBpZD1USD48L3RoZWFkPgo= 392548 2020-03-05 01:32:36 -0800 2020-03-05 01:42:27 -0800 Patch bug-208628-20200305013236.patch text/plain 4266 shihchieh_lee U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg5OGNhZTk2MmRlMDM4 ZjA4Zjg5YWE1MTBkYzBkNjYwMzdkNzI3Mi4uYjhhNzljNDFjNjA1ZTg3ODk2ZDc3M2Y5Y2NlYzQy ODNmZmViZDY2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAzLTA1ICBKYWNr IExlZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2gg aW4gQ29tcG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQYXJhZ3JhcGhXaXRoQ2xvbmVzIHdoZW4gaW5k ZW50aW5nIG5vbi1lbmNsb3NlZCBlbGVtZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODYyOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTIw MTE1MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2hlbiBpbmRlbnRpbmcgYSBub24tZW5jbG9zZWQgcGFyYWdyYXBoLCBxdWl0IGlmIHN0YXJ0IG9m IGNvbnRlbnRzIGlzIG5vdCBhIGRlc2NlbmRhbnQgb2Ygb3V0ZXIgYmxvY2suCisKKyAgICAgICAg VGVzdDogZmFzdC9lZGl0aW5nL2luZGVudC1ub24tZW5jbG9zZWQtZWxlbWVudC1jcmFzaC5odG1s CisKKyAgICAgICAgKiBlZGl0aW5nL0luZGVudE91dGRlbnRDb21tYW5kLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkluZGVudE91dGRlbnRDb21tYW5kOjppbmRlbnRJbnRvQmxvY2txdW90ZSk6CisK IDIwMjAtMDMtMDMgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KIAogICAgICAg ICBbV2ViQXV0aG5dIEltcGxlbWVudCAtW19XS1dlYkF1dGhlbnRpY2F0aW9uUGFuZWxEZWxlZ2F0 ZSBwYW5lbDpkZWNpZGVQb2xpY3lGb3JMb2NhbEF1dGhlbnRpY2F0b3JXaXRoQ29tcGxldGlvbkhh bmRsZXI6XSBTUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvSW5kZW50T3V0 ZGVudENvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9JbmRlbnRPdXRkZW50Q29t bWFuZC5jcHAKaW5kZXggYjFiNTBhZWJmMDg0ZGExNjRmMzkyY2JkMTQ4YTY2YTk1NzAxMjYxMC4u ODdlYzM5NjUyZDQxMGE3Mjg0YWE2MmNmMGM4NmEzZTU5ZGE4MjNiNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZWRpdGluZy9JbmRlbnRPdXRkZW50Q29tbWFuZC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvZWRpdGluZy9JbmRlbnRPdXRkZW50Q29tbWFuZC5jcHAKQEAgLTExOCw2ICsxMTgs OSBAQCB2b2lkIEluZGVudE91dGRlbnRDb21tYW5kOjppbmRlbnRJbnRvQmxvY2txdW90ZShjb25z dCBQb3NpdGlvbiYgc3RhcnQsIGNvbnN0IFBvcwogICAgICAgICAgICAgaW5zZXJ0Tm9kZUJlZm9y ZSgqdGFyZ2V0QmxvY2txdW90ZSwgKm91dGVyQmxvY2spOwogICAgICAgICBzdGFydE9mQ29udGVu dHMgPSBwb3NpdGlvbkluUGFyZW50QWZ0ZXJOb2RlKHRhcmdldEJsb2NrcXVvdGUuZ2V0KCkpOwog ICAgIH0KKyAgICAKKyAgICBpZiAoIXN0YXJ0T2ZDb250ZW50cy5kZWVwRXF1aXZhbGVudCgpLmNv bnRhaW5lck5vZGUoKS0+aXNEZXNjZW5kYW50T2Yob3V0ZXJCbG9jay5nZXQoKSkpCisgICAgICAg IHJldHVybjsKIAogICAgIG1vdmVQYXJhZ3JhcGhXaXRoQ2xvbmVzKHN0YXJ0T2ZDb250ZW50cywg ZW5kLCB0YXJnZXRCbG9ja3F1b3RlLmdldCgpLCBvdXRlckJsb2NrLmdldCgpKTsKIH0KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRl eCBiZDhhNTcxMDc5NGJmMDE0ZDEyMWRkMDIxMTg4YjlkOTEwZGYwY2JjLi4yNDJiNDU5ZDVkZWRk MzY0NjFmY2NmZDUyZmNjZGJjZTk4YWY4MDVhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAt MDMtMDUgIEphY2sgTGVlICA8c2hpaGNoaWVoX2xlZUBhcHBsZS5jb20+CisKKyAgICAgICAgTnVs bHB0ciBjcmFzaCBpbiBDb21wb3NpdGVFZGl0Q29tbWFuZDo6bW92ZVBhcmFncmFwaFdpdGhDbG9u ZXMgd2hlbiBpbmRlbnRpbmcgbm9uLWVuY2xvc2VkIGVsZW1lbnRzLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NjI4CisgICAgICAgIDxyZGFyOi8v cHJvYmxlbS81MjAxMTUwOT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXaGVuIGluZGVudGluZyBhIG5vbi1lbmNsb3NlZCBwYXJhZ3JhcGgsIHF1aXQg aWYgc3RhcnQgb2YgY29udGVudHMgaXMgbm90IGEgZGVzY2VuZGFudCBvZiBvdXRlciBibG9jay4K KworICAgICAgICAqIGZhc3QvZWRpdGluZy9pbmRlbnQtbm9uLWVuY2xvc2VkLWVsZW1lbnQtY3Jh c2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2VkaXRpbmcvaW5kZW50LW5v bi1lbmNsb3NlZC1lbGVtZW50LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDIwLTAzLTA0ICBKYXNv biBMYXdyZW5jZSAgPGxhd3JlbmNlLmpAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046 IChyMjU3ODQwPykgWyBNYWMgd2syIERlYnVnIF0gZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4 dC9ibG9jay1vbmx5L3JlcGxhY2VkLWludHJpbnNpYy13aWR0aC1zaW1wbGUuaHRtbCBpcyBjcmFz aGluZy4gCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2VkaXRpbmcvaW5kZW50LW5vbi1l bmNsb3NlZC1lbGVtZW50LWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZWRp dGluZy9pbmRlbnQtbm9uLWVuY2xvc2VkLWVsZW1lbnQtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLmQzMjhhYTMyNDdjNjE5NzZiZWFjZmIyMTg0MmJiYTczY2I3NGJjNDgKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2VkaXRpbmcvaW5kZW50LW5vbi1lbmNsb3NlZC1l bGVtZW50LWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1Rlc3RzIGluZGVudGlu ZyBhIG5vbi1lbmNsb3NlZCBlbGVtZW50LiBUaGUgdGVzdCBwYXNzZXMgaWYgV2ViS2l0IGRvZXNu J3QgY3Jhc2ggb3IgaGl0IGFuIGFzc2VydGlvbi4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9lZGl0aW5nL2luZGVudC1ub24tZW5jbG9zZWQtZWxlbWVudC1jcmFzaC5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC9lZGl0aW5nL2luZGVudC1ub24tZW5jbG9zZWQtZWxlbWVudC1jcmFzaC5o dG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAuLjVlODdkNWNkYzA3MzdlMGU3NTVlOTM3ODM5MGIzZmUxMDk0YWIwYWEK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2VkaXRpbmcvaW5kZW50LW5vbi1l bmNsb3NlZC1lbGVtZW50LWNyYXNoLmh0bWwKQEAgLTAsMCArMSwxMiBAQAorPHNjcmlwdD4KKyAg ICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgp OworICAgIG9ubG9hZCA9IGZ1bmN0aW9uIGZ1bigpIHsKKyAgICAgICAgb3V0ZXIucHJlcGVuZChp bm5lcik7CisgICAgICAgIFRILmluc2VydEFkamFjZW50VGV4dCgiYmVmb3JlQmVnaW4iLCJUZXN0 cyBpbmRlbnRpbmcgYSBub24tZW5jbG9zZWQgZWxlbWVudC4gVGhlIHRlc3QgcGFzc2VzIGlmIFdl YktpdCBkb2Vzbid0IGNyYXNoIG9yIGhpdCBhbiBhc3NlcnRpb24uIik7CisgICAgICAgIGRvY3Vt ZW50LmdldFNlbGVjdGlvbigpLnNldFBvc2l0aW9uKENHKTsKKyAgICAgICAgZG9jdW1lbnQuZXhl Y0NvbW1hbmQoImluZGVudCIsIGZhbHNlKTsKKyAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQo ImluZGVudCIsIGZhbHNlKTsKKyAgICB9Cis8L3NjcmlwdD4KKzxib2R5PjxkaXY+PGRpdiBpZD1v dXRlcj48c3Bhbj48L3NwYW4+PC9kaXY+PHNwYW4+PC9zcGFuPjwvZGl2PjxzcGFuPjwvc3Bhbj48 ZGl2IGlkPWlubmVyPjx0YWJsZSBpZD1UQUJMRSBjb250ZW50ZWRpdGFibGU9dHJ1ZT48L2Rpdj48 Y29sZ3JvdXAgaWQ9Q0c+PC9jb2xncm91cD48dGhlYWQgaWQ9VEg+PC90aGVhZD4K 392552 2020-03-05 02:48:40 -0800 2020-03-10 16:41:23 -0700 Patch bug-208628-20200305024839.patch text/plain 4434 shihchieh_lee U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3ODc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDg5OGNhZTk2MmRlMDM4 ZjA4Zjg5YWE1MTBkYzBkNjYwMzdkNzI3Mi4uNTdlMzcxMjQzMGM3Y2M3YzQ0ZjBjOTk0YzkwNzVi N2U4NDUwNjRmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAzLTA1ICBKYWNr IExlZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2gg aW4gQ29tcG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQYXJhZ3JhcGhXaXRoQ2xvbmVzIHdoZW4gaW5k ZW50aW5nIG5vbi1lbmNsb3NlZCBlbGVtZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODYyOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTIw MTE1MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg V2hlbiBpbmRlbnRpbmcgYSBub24tZW5jbG9zZWQgcGFyYWdyYXBoLCBxdWl0IGlmIHN0YXJ0IG9m IGNvbnRlbnRzIGlzIG5vdCBhIGRlc2NlbmRhbnQgb3Igc2libGluZyBvZiBvdXRlciBibG9jay4K KworICAgICAgICBUZXN0OiBmYXN0L2VkaXRpbmcvaW5kZW50LW5vbi1lbmNsb3NlZC1lbGVtZW50 LWNyYXNoLmh0bWwKKworICAgICAgICAqIGVkaXRpbmcvSW5kZW50T3V0ZGVudENvbW1hbmQuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6SW5kZW50T3V0ZGVudENvbW1hbmQ6OmluZGVudEludG9CbG9j a3F1b3RlKToKKwogMjAyMC0wMy0wMyAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29t PgogCiAgICAgICAgIFtXZWJBdXRobl0gSW1wbGVtZW50IC1bX1dLV2ViQXV0aGVudGljYXRpb25Q YW5lbERlbGVnYXRlIHBhbmVsOmRlY2lkZVBvbGljeUZvckxvY2FsQXV0aGVudGljYXRvcldpdGhD b21wbGV0aW9uSGFuZGxlcjpdIFNQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZWRpdGlu Zy9JbmRlbnRPdXRkZW50Q29tbWFuZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0luZGVu dE91dGRlbnRDb21tYW5kLmNwcAppbmRleCBiMWI1MGFlYmYwODRkYTE2NGYzOTJjYmQxNDhhNjZh OTU3MDEyNjEwLi5lOWQ4NDg1YmQyZWRlMTMxMDBiMzRkNGRhNzMxMDZhOTNmNWE3MmE0IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0luZGVudE91dGRlbnRDb21tYW5kLmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0luZGVudE91dGRlbnRDb21tYW5kLmNwcApAQCAt MTE4LDYgKzExOCw5IEBAIHZvaWQgSW5kZW50T3V0ZGVudENvbW1hbmQ6OmluZGVudEludG9CbG9j a3F1b3RlKGNvbnN0IFBvc2l0aW9uJiBzdGFydCwgY29uc3QgUG9zCiAgICAgICAgICAgICBpbnNl cnROb2RlQmVmb3JlKCp0YXJnZXRCbG9ja3F1b3RlLCAqb3V0ZXJCbG9jayk7CiAgICAgICAgIHN0 YXJ0T2ZDb250ZW50cyA9IHBvc2l0aW9uSW5QYXJlbnRBZnRlck5vZGUodGFyZ2V0QmxvY2txdW90 ZS5nZXQoKSk7CiAgICAgfQorICAgIAorICAgIGlmIChzdGFydE9mQ29udGVudHMuZGVlcEVxdWl2 YWxlbnQoKS5jb250YWluZXJOb2RlKCkgJiYgIXN0YXJ0T2ZDb250ZW50cy5kZWVwRXF1aXZhbGVu dCgpLmNvbnRhaW5lck5vZGUoKS0+aXNEZXNjZW5kYW50T2Yob3V0ZXJCbG9jay5nZXQoKSkgJiYg c3RhcnRPZkNvbnRlbnRzLmRlZXBFcXVpdmFsZW50KCkuY29udGFpbmVyTm9kZSgpLT5wYXJlbnRO b2RlKCkgIT0gb3V0ZXJCbG9jay0+cGFyZW50Tm9kZSgpKQorICAgICAgICByZXR1cm47CiAKICAg ICBtb3ZlUGFyYWdyYXBoV2l0aENsb25lcyhzdGFydE9mQ29udGVudHMsIGVuZCwgdGFyZ2V0Qmxv Y2txdW90ZS5nZXQoKSwgb3V0ZXJCbG9jay5nZXQoKSk7CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYmQ4YTU3MTA3OTRi ZjAxNGQxMjFkZDAyMTE4OGI5ZDkxMGRmMGNiYy4uMjM0MDYxMTJjODNkNmM5NjdkMmY1NjViZDZj ZjFjYTM4OTQ0M2FiOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTA1ICBKYWNrIExl ZSAgPHNoaWhjaGllaF9sZWVAYXBwbGUuY29tPgorCisgICAgICAgIE51bGxwdHIgY3Jhc2ggaW4g Q29tcG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQYXJhZ3JhcGhXaXRoQ2xvbmVzIHdoZW4gaW5kZW50 aW5nIG5vbi1lbmNsb3NlZCBlbGVtZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwODYyOAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTIwMTE1 MDk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hl biBpbmRlbnRpbmcgYSBub24tZW5jbG9zZWQgcGFyYWdyYXBoLCBxdWl0IGlmIHN0YXJ0IG9mIGNv bnRlbnRzIGlzIG5vdCBhIGRlc2NlbmRhbnQgb3Igc2libGluZyBvZiBvdXRlciBibG9jay4KKwor ICAgICAgICAqIGZhc3QvZWRpdGluZy9pbmRlbnQtbm9uLWVuY2xvc2VkLWVsZW1lbnQtY3Jhc2gt ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2VkaXRpbmcvaW5kZW50LW5vbi1l bmNsb3NlZC1lbGVtZW50LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDIwLTAzLTA0ICBKYXNvbiBM YXdyZW5jZSAgPGxhd3JlbmNlLmpAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT046IChy MjU3ODQwPykgWyBNYWMgd2syIERlYnVnIF0gZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4dC9i bG9jay1vbmx5L3JlcGxhY2VkLWludHJpbnNpYy13aWR0aC1zaW1wbGUuaHRtbCBpcyBjcmFzaGlu Zy4gCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2VkaXRpbmcvaW5kZW50LW5vbi1lbmNs b3NlZC1lbGVtZW50LWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZWRpdGlu Zy9pbmRlbnQtbm9uLWVuY2xvc2VkLWVsZW1lbnQtY3Jhc2gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAuLmQzMjhhYTMyNDdjNjE5NzZiZWFjZmIyMTg0MmJiYTczY2I3NGJjNDgKLS0tIC9kZXYvbnVs bAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2VkaXRpbmcvaW5kZW50LW5vbi1lbmNsb3NlZC1lbGVt ZW50LWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1Rlc3RzIGluZGVudGluZyBh IG5vbi1lbmNsb3NlZCBlbGVtZW50LiBUaGUgdGVzdCBwYXNzZXMgaWYgV2ViS2l0IGRvZXNuJ3Qg Y3Jhc2ggb3IgaGl0IGFuIGFzc2VydGlvbi4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFz dC9lZGl0aW5nL2luZGVudC1ub24tZW5jbG9zZWQtZWxlbWVudC1jcmFzaC5odG1sIGIvTGF5b3V0 VGVzdHMvZmFzdC9lZGl0aW5nL2luZGVudC1ub24tZW5jbG9zZWQtZWxlbWVudC1jcmFzaC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjVlODdkNWNkYzA3MzdlMGU3NTVlOTM3ODM5MGIzZmUxMDk0YWIwYWEKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2VkaXRpbmcvaW5kZW50LW5vbi1lbmNs b3NlZC1lbGVtZW50LWNyYXNoLmh0bWwKQEAgLTAsMCArMSwxMiBAQAorPHNjcmlwdD4KKyAgICBp ZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOwor ICAgIG9ubG9hZCA9IGZ1bmN0aW9uIGZ1bigpIHsKKyAgICAgICAgb3V0ZXIucHJlcGVuZChpbm5l cik7CisgICAgICAgIFRILmluc2VydEFkamFjZW50VGV4dCgiYmVmb3JlQmVnaW4iLCJUZXN0cyBp bmRlbnRpbmcgYSBub24tZW5jbG9zZWQgZWxlbWVudC4gVGhlIHRlc3QgcGFzc2VzIGlmIFdlYktp dCBkb2Vzbid0IGNyYXNoIG9yIGhpdCBhbiBhc3NlcnRpb24uIik7CisgICAgICAgIGRvY3VtZW50 LmdldFNlbGVjdGlvbigpLnNldFBvc2l0aW9uKENHKTsKKyAgICAgICAgZG9jdW1lbnQuZXhlY0Nv bW1hbmQoImluZGVudCIsIGZhbHNlKTsKKyAgICAgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoImlu ZGVudCIsIGZhbHNlKTsKKyAgICB9Cis8L3NjcmlwdD4KKzxib2R5PjxkaXY+PGRpdiBpZD1vdXRl cj48c3Bhbj48L3NwYW4+PC9kaXY+PHNwYW4+PC9zcGFuPjwvZGl2PjxzcGFuPjwvc3Bhbj48ZGl2 IGlkPWlubmVyPjx0YWJsZSBpZD1UQUJMRSBjb250ZW50ZWRpdGFibGU9dHJ1ZT48L2Rpdj48Y29s Z3JvdXAgaWQ9Q0c+PC9jb2xncm91cD48dGhlYWQgaWQ9VEg+PC90aGVhZD4K