208623 2020-03-04 21:42:12 -0800 Make m_slowRepaintObjects a WeakHashSet 2020-03-04 23:18:27 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue koivisto rniwa simon.fraser webkit-bug-importer zalan oldest_to_newest 1625936 0 simon.fraser 2020-03-04 21:42:12 -0800 Make m_slowRepaintObjects a WeakHashSet 1625937 1 392534 simon.fraser 2020-03-04 21:43:11 -0800 Created attachment 392534 Patch 1625949 2 392534 commit-queue 2020-03-04 22:38:28 -0800 Comment on attachment 392534 Patch Clearing flags on attachment: 392534 Committed r257902: <https://trac.webkit.org/changeset/257902> 1625950 3 commit-queue 2020-03-04 22:38:30 -0800 All reviewed patches have been landed. Closing bug. 1625951 4 webkit-bug-importer 2020-03-04 22:39:14 -0800 <rdar://problem/60072474> 1625961 5 392534 koivisto 2020-03-04 23:18:27 -0800 Comment on attachment 392534 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392534&action=review > Source/WebCore/page/FrameView.h:826 > std::unique_ptr<ListHashSet<RenderEmbeddedObject*>> m_embeddedObjectsToUpdate; We need WeakListHashSet too. 392534 2020-03-04 21:43:11 -0800 2020-03-04 22:38:28 -0800 Patch bug-208623-20200304214310.patch text/plain 6455 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3ODIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmEzNGI4NjlmNjFmMTJh NTZhMmMyOWM0ZWIyODk1M2Y3YzcxZjhkYy4uOWIwZmVjMTA5OTgzYmM5ODJjN2VlZjQxZDc3OTY0 YWEzMjRlODFmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAzLTA0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgbV9zbG93 UmVwYWludE9iamVjdHMgYSBXZWFrSGFzaFNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVXNlIFdlYWtIYXNoU2V0PD4gZm9yIG1fc2xvd1JlcGFpbnRP YmplY3RzLCByYXRoZXIgdGhhbiBhIEhhc2hTZXQgb2YgcmF3IHBvaW50ZXJzLgorCisgICAgICAg ICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpkaWRE ZXN0cm95UmVuZGVyVHJlZSk6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZVZpZXc6OmFkZFNsb3dS ZXBhaW50T2JqZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lVmlldzo6cmVtb3ZlU2xvd1Jl cGFpbnRPYmplY3QpOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3OjpyZXBhaW50U2xvd1Jl cGFpbnRPYmplY3RzKToKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5oOgorCiAyMDIwLTAzLTAz ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFBhdGg6 Om1fcGF0aCBzaG91bGQgYmUgYSBSZXRhaW5QdHI8Q0dNdXRhYmxlUGF0aFJlZj4gb24gcGxhdGZv cm1zIHRoYXQgdXNlIENvcmVHcmFwaGljcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCA5YTM5NDZlMGIxOTU4ZDUzNzI0 NjAwN2I5MTZmN2Q4OGViNmM2YTAyLi44NWEzMzJkNWQwNjU5YTQwYzg5NWVjMWJhODVjZmEzOTQ4 YTU3Yzg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTA0ICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1ha2UgbV9zbG93UmVwYWlu dE9iamVjdHMgYSBXZWFrSGFzaFNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA4NjIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4IG5hbWVzcGFjZSBlcnJvcnMgdHJpZ2dlcmVkIGJ5IEZyYW1lVmll dyBpbmNsdWRlIGNoYW5nZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0FQSVBhZ2VDb25m aWd1cmF0aW9uLmNwcDoKKyAgICAgICAgKEFQSTo6UGFnZUNvbmZpZ3VyYXRpb246OnZpc2l0ZWRM aW5rU3RvcmUpOgorICAgICAgICAoQVBJOjpQYWdlQ29uZmlndXJhdGlvbjo6c2V0VmlzaXRlZExp bmtTdG9yZSk6CisKIDIwMjAtMDMtMDMgIEphbWVzIFNhdmFnZSAgPGphbWVzLnNhdmFnZUBhcHBs ZS5jb20+CiAKICAgICAgICAgUmVmaW5lIFN3aWZ0IEFQSSBmb3IgV0tXZWJWaWV3IEphdmFTY3Jp cHQgbWV0aG9kcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IDc5ZDRkMmU3ZTU0YWY5 MGMwNDUzNTgzNTc0NDFjYzEwZmEyYzFiYjMuLjJiOGUwNDRiZGI2Mjc1NmUwMTcwNzkxOGE0NWRm ZWMzYmViZmRhYTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTU5MCw3ICs1OTAs NyBAQCB2b2lkIEZyYW1lVmlldzo6ZGlkRGVzdHJveVJlbmRlclRyZWUoKQogICAgIEFTU0VSVCgh bV9lbWJlZGRlZE9iamVjdHNUb1VwZGF0ZSB8fCBtX2VtYmVkZGVkT2JqZWN0c1RvVXBkYXRlLT5p c0VtcHR5KCkgfHwgKG1fZW1iZWRkZWRPYmplY3RzVG9VcGRhdGUtPnNpemUoKSA9PSAxICYmIG1f ZW1iZWRkZWRPYmplY3RzVG9VcGRhdGUtPmZpcnN0KCkgPT0gbnVsbHB0cikpOwogCiAgICAgQVNT RVJUKCFtX3ZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3RzIHx8IG1fdmlld3BvcnRDb25zdHJhaW5l ZE9iamVjdHMtPmlzRW1wdHkoKSk7Ci0gICAgQVNTRVJUKCFtX3Nsb3dSZXBhaW50T2JqZWN0cyB8 fCBtX3Nsb3dSZXBhaW50T2JqZWN0cy0+aXNFbXB0eSgpKTsKKyAgICBBU1NFUlQoIW1fc2xvd1Jl cGFpbnRPYmplY3RzIHx8IG1fc2xvd1JlcGFpbnRPYmplY3RzLT5jb21wdXRlc0VtcHR5KCkpOwog CiAgICAgQVNTRVJUKCFmcmFtZSgpLmFuaW1hdGlvbigpLmhhc0FuaW1hdGlvbnMoKSk7CiB9CkBA IC0xNDg1LDkgKzE0ODUsOSBAQCB2b2lkIEZyYW1lVmlldzo6YWRkU2xvd1JlcGFpbnRPYmplY3Qo UmVuZGVyRWxlbWVudCYgcmVuZGVyZXIpCiAgICAgYm9vbCBoYWRTbG93UmVwYWludE9iamVjdHMg PSBoYXNTbG93UmVwYWludE9iamVjdHMoKTsKIAogICAgIGlmICghbV9zbG93UmVwYWludE9iamVj dHMpCi0gICAgICAgIG1fc2xvd1JlcGFpbnRPYmplY3RzID0gbWFrZVVuaXF1ZTxIYXNoU2V0PGNv bnN0IFJlbmRlckVsZW1lbnQqPj4oKTsKKyAgICAgICAgbV9zbG93UmVwYWludE9iamVjdHMgPSBt YWtlVW5pcXVlPFdlYWtIYXNoU2V0PFJlbmRlckVsZW1lbnQ+PigpOwogCi0gICAgbV9zbG93UmVw YWludE9iamVjdHMtPmFkZCgmcmVuZGVyZXIpOworICAgIG1fc2xvd1JlcGFpbnRPYmplY3RzLT5h ZGQocmVuZGVyZXIpOwogICAgIGlmIChoYWRTbG93UmVwYWludE9iamVjdHMpCiAgICAgICAgIHJl dHVybjsKIApAQCAtMTUwNCw4ICsxNTA0LDggQEAgdm9pZCBGcmFtZVZpZXc6OnJlbW92ZVNsb3dS ZXBhaW50T2JqZWN0KFJlbmRlckVsZW1lbnQmIHJlbmRlcmVyKQogICAgIGlmICghbV9zbG93UmVw YWludE9iamVjdHMpCiAgICAgICAgIHJldHVybjsKIAotICAgIG1fc2xvd1JlcGFpbnRPYmplY3Rz LT5yZW1vdmUoJnJlbmRlcmVyKTsKLSAgICBpZiAoIW1fc2xvd1JlcGFpbnRPYmplY3RzLT5pc0Vt cHR5KCkpCisgICAgbV9zbG93UmVwYWludE9iamVjdHMtPnJlbW92ZShyZW5kZXJlcik7CisgICAg aWYgKCFtX3Nsb3dSZXBhaW50T2JqZWN0cy0+Y29tcHV0ZXNFbXB0eSgpKQogICAgICAgICByZXR1 cm47CiAKICAgICBtX3Nsb3dSZXBhaW50T2JqZWN0cyA9IG51bGxwdHI7CkBAIC0yMTU4LDcgKzIx NTgsNyBAQCB2b2lkIEZyYW1lVmlldzo6cmVwYWludFNsb3dSZXBhaW50T2JqZWN0cygpCiAgICAg Ly8gUmVuZGVyZXJzIHdpdGggZml4ZWQgYmFja2dyb3VuZHMgbWF5IGJlIGluIGNvbXBvc2l0aW5n IGxheWVycywgc28gd2UgbmVlZCB0byBleHBsaWNpdGx5CiAgICAgLy8gcmVwYWludCB0aGVtIGFm dGVyIHNjcm9sbGluZy4KICAgICBmb3IgKGF1dG8mIHJlbmRlcmVyIDogKm1fc2xvd1JlcGFpbnRP YmplY3RzKQotICAgICAgICByZW5kZXJlci0+cmVwYWludFNsb3dSZXBhaW50T2JqZWN0KCk7Cisg ICAgICAgIHJlbmRlcmVyLnJlcGFpbnRTbG93UmVwYWludE9iamVjdCgpOwogfQogCiAvLyBOb3Rl IHRoYXQgdGhpcyBnZXRzIGNhbGxlZCBhdCBwYWludGluZyB0aW1lLgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmgKaW5kZXggMmM1MGNiZmUzMjAyYzM2YTdlNGI0MWMzNWU5MDhhZDcwNTgxZjMzMi4uN2Ux MDBhZDUzNzU3MWYyNDhiYzcwZTRiOGQwOGFmYjkwMzExMDE2ZiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5oCkBAIC0zMyw2ICszMyw3IEBACiAjaW5jbHVkZSAiTGF5b3V0UmVjdC5oIgogI2luY2x1 ZGUgIlBhZ2luYXRpb24uaCIKICNpbmNsdWRlICJQYWludFBoYXNlLmgiCisjaW5jbHVkZSAiUmVu ZGVyRWxlbWVudC5oIgogI2luY2x1ZGUgIlJlbmRlclB0ci5oIgogI2luY2x1ZGUgIlNjcm9sbFZp ZXcuaCIKICNpbmNsdWRlICJTdHlsZUNvbG9yLmgiCkBAIC00NCw2ICs0NSw3IEBACiAjaW5jbHVk ZSA8d3RmL0lzb01hbGxvYy5oPgogI2luY2x1ZGUgPHd0Zi9MaXN0SGFzaFNldC5oPgogI2luY2x1 ZGUgPHd0Zi9PcHRpb25TZXQuaD4KKyNpbmNsdWRlIDx3dGYvV2Vha0hhc2hTZXQuaD4KICNpbmNs dWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewpAQCAtMjg5 LDggKzI5MSw4IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgYWRkU2xvd1JlcGFpbnRPYmplY3QoUmVu ZGVyRWxlbWVudCYpOwogICAgIHZvaWQgcmVtb3ZlU2xvd1JlcGFpbnRPYmplY3QoUmVuZGVyRWxl bWVudCYpOwotICAgIGJvb2wgaGFzU2xvd1JlcGFpbnRPYmplY3QoY29uc3QgUmVuZGVyRWxlbWVu dCYgcmVuZGVyZXIpIGNvbnN0IHsgcmV0dXJuIG1fc2xvd1JlcGFpbnRPYmplY3RzICYmIG1fc2xv d1JlcGFpbnRPYmplY3RzLT5jb250YWlucygmcmVuZGVyZXIpOyB9Ci0gICAgYm9vbCBoYXNTbG93 UmVwYWludE9iamVjdHMoKSBjb25zdCB7IHJldHVybiBtX3Nsb3dSZXBhaW50T2JqZWN0cyAmJiBt X3Nsb3dSZXBhaW50T2JqZWN0cy0+c2l6ZSgpOyB9CisgICAgYm9vbCBoYXNTbG93UmVwYWludE9i amVjdChjb25zdCBSZW5kZXJFbGVtZW50JiByZW5kZXJlcikgY29uc3QgeyByZXR1cm4gbV9zbG93 UmVwYWludE9iamVjdHMgJiYgbV9zbG93UmVwYWludE9iamVjdHMtPmNvbnRhaW5zKHJlbmRlcmVy KTsgfQorICAgIGJvb2wgaGFzU2xvd1JlcGFpbnRPYmplY3RzKCkgY29uc3QgeyByZXR1cm4gbV9z bG93UmVwYWludE9iamVjdHMgJiYgbV9zbG93UmVwYWludE9iamVjdHMtPmNvbXB1dGVTaXplKCk7 IH0KIAogICAgIC8vIEluY2x1ZGVzIGZpeGVkLSBhbmQgc3RpY2t5LXBvc2l0aW9uIG9iamVjdHMu CiAgICAgdHlwZWRlZiBIYXNoU2V0PFJlbmRlckxheWVyTW9kZWxPYmplY3QqPiBWaWV3cG9ydENv bnN0cmFpbmVkT2JqZWN0U2V0OwpAQCAtODIyLDcgKzgyNCw3IEBAIHByaXZhdGU6CiAKICAgICBI YXNoU2V0PFdpZGdldCo+IG1fd2lkZ2V0c0luUmVuZGVyVHJlZTsKICAgICBzdGQ6OnVuaXF1ZV9w dHI8TGlzdEhhc2hTZXQ8UmVuZGVyRW1iZWRkZWRPYmplY3QqPj4gbV9lbWJlZGRlZE9iamVjdHNU b1VwZGF0ZTsKLSAgICBzdGQ6OnVuaXF1ZV9wdHI8SGFzaFNldDxjb25zdCBSZW5kZXJFbGVtZW50 Kj4+IG1fc2xvd1JlcGFpbnRPYmplY3RzOworICAgIHN0ZDo6dW5pcXVlX3B0cjxXZWFrSGFzaFNl dDxSZW5kZXJFbGVtZW50Pj4gbV9zbG93UmVwYWludE9iamVjdHM7CiAKICAgICBSZWZQdHI8Q29u dGFpbmVyTm9kZT4gbV9tYWludGFpblNjcm9sbFBvc2l0aW9uQW5jaG9yOwogICAgIFJlZlB0cjxO b2RlPiBtX25vZGVUb0RyYXc7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQVBJUGFnZUNvbmZpZ3VyYXRpb24uY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L0FQSVBhZ2VDb25maWd1cmF0aW9uLmNwcAppbmRleCBjZmNjNGJiYjBlZjc4ZGVjNGFjZGJiM2I5 OWZlOTdjNDA3OTA3YTE3Li4wYTA0MTYzYTQ1ZTVmNmJjNzM5MDlhMDcxYmJiOWM2MGVlMGEzMTgw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQVBJUGFnZUNvbmZpZ3Vy YXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9BUElQYWdlQ29uZmln dXJhdGlvbi5jcHAKQEAgLTE0OCwxMiArMTQ4LDEyIEBAIHZvaWQgUGFnZUNvbmZpZ3VyYXRpb246 OnNldFJlbGF0ZWRQYWdlKFdlYlBhZ2VQcm94eSogcmVsYXRlZFBhZ2UpCiAgICAgbV9yZWxhdGVk UGFnZSA9IHJlbGF0ZWRQYWdlOwogfQogCi1WaXNpdGVkTGlua1N0b3JlKiBQYWdlQ29uZmlndXJh dGlvbjo6dmlzaXRlZExpbmtTdG9yZSgpCitXZWJLaXQ6OlZpc2l0ZWRMaW5rU3RvcmUqIFBhZ2VD b25maWd1cmF0aW9uOjp2aXNpdGVkTGlua1N0b3JlKCkKIHsKICAgICByZXR1cm4gbV92aXNpdGVk TGlua1N0b3JlLmdldCgpOwogfQogCi12b2lkIFBhZ2VDb25maWd1cmF0aW9uOjpzZXRWaXNpdGVk TGlua1N0b3JlKFZpc2l0ZWRMaW5rU3RvcmUqIHZpc2l0ZWRMaW5rU3RvcmUpCit2b2lkIFBhZ2VD b25maWd1cmF0aW9uOjpzZXRWaXNpdGVkTGlua1N0b3JlKFdlYktpdDo6VmlzaXRlZExpbmtTdG9y ZSogdmlzaXRlZExpbmtTdG9yZSkKIHsKICAgICBtX3Zpc2l0ZWRMaW5rU3RvcmUgPSB2aXNpdGVk TGlua1N0b3JlOwogfQo=