208593 2020-03-04 13:18:38 -0800 callAsyncJavaScript with an invalid parameter and no completionHandler should not crash 2020-03-04 13:36:15 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen beidson webkit-bug-importer oldest_to_newest 1625724 0 achristensen 2020-03-04 13:18:38 -0800 callAsyncJavaScript with an invalid parameter should immediately raise an exception 1625728 1 392465 achristensen 2020-03-04 13:20:31 -0800 Created attachment 392465 Patch 1625732 2 beidson 2020-03-04 13:24:26 -0800 Exceptions are not Swift friendly, so we should continue just returning an error. 1625742 3 392470 achristensen 2020-03-04 13:32:08 -0800 Created attachment 392470 Patch 1625746 4 achristensen 2020-03-04 13:35:21 -0800 http://trac.webkit.org/r257876 1625747 5 webkit-bug-importer 2020-03-04 13:36:15 -0800 <rdar://problem/60054026> 392465 2020-03-04 13:20:31 -0800 2020-03-04 13:32:07 -0800 Patch bug-208593-20200304132030.patch text/plain 4837 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTc4NzIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAzLTA0ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgY2FsbEFzeW5jSmF2 YVNjcmlwdCB3aXRoIGFuIGludmFsaWQgcGFyYW1ldGVyIHNob3VsZCBpbW1lZGlhdGVseSByYWlz ZSBhbiBleGNlcHRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwODU5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFdlIGtub3cgaW1tZWRpYXRlbHkgaWYgdGhlIHBhcmFtZXRlcnMgYXJlIHZhbGlkLiAg UmFpc2luZyBhbiBleGNlcHRpb24gd2lsbCBoZWxwIGRldmVsb3BlcnMgZGVidWcgZmFzdGVyLgor CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgt W1dLV2ViVmlldyBfZXZhbHVhdGVKYXZhU2NyaXB0OmFzQXN5bmNGdW5jdGlvbjp3aXRoQXJndW1l bnRzOmZvcmNlVXNlckdlc3R1cmU6Y29tcGxldGlvbkhhbmRsZXI6aW5Xb3JsZDpdKToKKwogMjAy MC0wMy0wNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAg ICAgICAgIFdLV2ViVmlldydzIGZyYW1lcyBhY2Nlc3NvciBzaG91bGQgcmV0dXJuIGEgdHJhdmVy c2FibGUgdHlwZQpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi Vmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2Ev V0tXZWJWaWV3Lm1tCShyZXZpc2lvbiAyNTc4NzIpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC04ODksMTQgKzg4OSwx MSBAQCAtICh2b2lkKV9ldmFsdWF0ZUphdmFTY3JpcHQ6KE5TU3RyaW5nICopCiAgICAgT3B0aW9u YWw8V2ViQ29yZTo6QXJndW1lbnRXaXJlQnl0ZXNNYXA+IGFyZ3VtZW50c01hcDsKICAgICBpZiAo YXNBc3luY0Z1bmN0aW9uKQogICAgICAgICBhcmd1bWVudHNNYXAgPSBXZWJDb3JlOjpBcmd1bWVu dFdpcmVCeXRlc01hcCB7IH07Ci0gICAgTlNTdHJpbmcgKmVycm9yTWVzc2FnZSA9IG5pbDsKIAog ICAgIGZvciAoaWQga2V5IGluIGFyZ3VtZW50cykgewogICAgICAgICBpZCB2YWx1ZSA9IFthcmd1 bWVudHMgb2JqZWN0Rm9yS2V5OmtleV07Ci0gICAgICAgIGlmICghdmFsaWRhdGVBcmd1bWVudCh2 YWx1ZSkpIHsKLSAgICAgICAgICAgIGVycm9yTWVzc2FnZSA9IEAiRnVuY3Rpb24gYXJndW1lbnQg dmFsdWVzIG11c3QgYmUgb25lIG9mIHRoZSBmb2xsb3dpbmcgdHlwZXMsIG9yIGNvbnRhaW4gb25s eSB0aGUgZm9sbG93aW5nIHR5cGVzOiBOU1N0cmluZywgTlNOdW1iZXIsIE5TRGF0ZSwgTlNBcnJh eSwgYW5kIE5TRGljdGlvbmFyeSI7Ci0gICAgICAgICAgICBicmVhazsKLSAgICAgICAgfQorICAg ICAgICBpZiAoIXZhbGlkYXRlQXJndW1lbnQodmFsdWUpKQorICAgICAgICAgICAgW05TRXhjZXB0 aW9uIHJhaXNlOk5TSW52YWxpZEFyZ3VtZW50RXhjZXB0aW9uIGZvcm1hdDpAIkZ1bmN0aW9uIGFy Z3VtZW50IHZhbHVlcyBtdXN0IGJlIG9uZSBvZiB0aGUgZm9sbG93aW5nIHR5cGVzLCBvciBjb250 YWluIG9ubHkgdGhlIGZvbGxvd2luZyB0eXBlczogTlNTdHJpbmcsIE5TTnVtYmVyLCBOU0RhdGUs IE5TQXJyYXksIGFuZCBOU0RpY3Rpb25hcnkiXTsKICAgICAKICAgICAgICAgYXV0byB3aXJlQnl0 ZXMgPSBBUEk6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTo6d2lyZUJ5dGVzRnJvbU5TT2JqZWN0KHZh bHVlKTsKICAgICAgICAgLy8gU2luY2Ugd2UndmUgdmFsaWRhdGVkIHRoZSBpbnB1dCBkaWN0aW9u YXJ5IGFib3ZlLCB3ZSBzaG91bGQgbmV2ZXIgZmFpbCB0byBzZXJpYWxpemUgaXQgaW50byB3aXJl IGJ5dGVzLgpAQCAtOTA0LDIxICs5MDEsNiBAQCAtICh2b2lkKV9ldmFsdWF0ZUphdmFTY3JpcHQ6 KE5TU3RyaW5nICopCiAgICAgICAgIGFyZ3VtZW50c01hcC0+c2V0KGtleSwgKndpcmVCeXRlcyk7 CiAgICAgfQogCi0gICAgaWYgKGVycm9yTWVzc2FnZSkgewotICAgICAgICBSZXRhaW5QdHI8TlNN dXRhYmxlRGljdGlvbmFyeT4gdXNlckluZm8gPSBhZG9wdE5TKFtbTlNNdXRhYmxlRGljdGlvbmFy eSBhbGxvY10gaW5pdF0pOwotCi0gICAgICAgIFt1c2VySW5mbyBzZXRPYmplY3Q6bG9jYWxpemVk RGVzY3JpcHRpb25Gb3JFcnJvckNvZGUoV0tFcnJvckphdmFTY3JpcHRFeGNlcHRpb25PY2N1cnJl ZCkgZm9yS2V5Ok5TTG9jYWxpemVkRGVzY3JpcHRpb25LZXldOwotICAgICAgICBbdXNlckluZm8g c2V0T2JqZWN0OmVycm9yTWVzc2FnZSBmb3JLZXk6X1dLSmF2YVNjcmlwdEV4Y2VwdGlvbk1lc3Nh Z2VFcnJvcktleV07Ci0KLSAgICAgICAgYXV0byBlcnJvciA9IGFkb3B0TlMoW1tOU0Vycm9yIGFs bG9jXSBpbml0V2l0aERvbWFpbjpXS0Vycm9yRG9tYWluIGNvZGU6V0tFcnJvckphdmFTY3JpcHRF eGNlcHRpb25PY2N1cnJlZCB1c2VySW5mbzp1c2VySW5mby5nZXQoKV0pOwotICAgICAgICBkaXNw YXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBbaGFuZGxlciwgZXJyb3JdIHsK LSAgICAgICAgICAgIGF1dG8gcmF3SGFuZGxlciA9ICh2b2lkICheKShpZCwgTlNFcnJvciAqKSlo YW5kbGVyLmdldCgpOwotICAgICAgICAgICAgcmF3SGFuZGxlcihuaWwsIGVycm9yLmdldCgpKTsK LSAgICAgICAgfSk7Ci0KLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQogICAgIF9wYWdlLT5ydW5K YXZhU2NyaXB0SW5NYWluRnJhbWVTY3JpcHRXb3JsZChXZWJDb3JlOjpSdW5KYXZhU2NyaXB0UGFy YW1ldGVycyB7IGphdmFTY3JpcHRTdHJpbmcsICEhYXNBc3luY0Z1bmN0aW9uLCBXVEZNb3ZlKGFy Z3VtZW50c01hcCksICEhZm9yY2VVc2VyR2VzdHVyZSB9LCAqd29ybGQtPl9jb250ZW50V29ybGQu Z2V0KCksIFtoYW5kbGVyXShBUEk6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSogc2VyaWFsaXplZFNj cmlwdFZhbHVlLCBPcHRpb25hbDxXZWJDb3JlOjpFeGNlcHRpb25EZXRhaWxzPiBkZXRhaWxzLCBX ZWJLaXQ6OlNjcmlwdFZhbHVlQ2FsbGJhY2s6OkVycm9yIGVycm9yQ29kZSkgewogICAgICAgICBp ZiAoIWhhbmRsZXIpCiAgICAgICAgICAgICByZXR1cm47CkluZGV4OiBUb29scy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTc4NzQpCisrKyBUb29s cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wMy0wNCAg QWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIGNh bGxBc3luY0phdmFTY3JpcHQgd2l0aCBhbiBpbnZhbGlkIHBhcmFtZXRlciBzaG91bGQgaW1tZWRp YXRlbHkgcmFpc2UgYW4gZXhjZXB0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDg1OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvQXN5bmNG dW5jdGlvbi5tbToKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDIwLTAzLTA0 ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAg V0tXZWJWaWV3J3MgZnJhbWVzIGFjY2Vzc29yIHNob3VsZCByZXR1cm4gYSB0cmF2ZXJzYWJsZSB0 eXBlCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0FzeW5jRnVu Y3Rpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRD b2NvYS9Bc3luY0Z1bmN0aW9uLm1tCShyZXZpc2lvbiAyNTc4NzEpCisrKyBUb29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL0FzeW5jRnVuY3Rpb24ubW0JKHdvcmtpbmcgY29weSkK QEAgLTI3OCw2ICsyNzgsMTQgQEAgVEVTVChBc3luY0Z1bmN0aW9uLCBQcm9taXNlKQogCiAgICAg W3dlYlZpZXcuZ2V0KCkuY29uZmlndXJhdGlvbi5wcm9jZXNzUG9vbCBfZ2FyYmFnZUNvbGxlY3RK YXZhU2NyaXB0T2JqZWN0c0ZvclRlc3RpbmddOwogICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1 bigmZG9uZSk7CisKKyAgICBib29sIGNhdWdodEV4Y2VwdGlvbiA9IGZhbHNlOworICAgIEB0cnkg eworICAgIFt3ZWJWaWV3IGNhbGxBc3luY0phdmFTY3JpcHQ6ZnVuY3Rpb25Cb2R5IGFyZ3VtZW50 czpAeyBAImludmFsaWRwYXJhbWV0ZXIiIDogd2ViVmlldy5nZXQoKSB9IGluQ29udGVudFdvcmxk OldLQ29udGVudFdvcmxkLnBhZ2VXb3JsZCBjb21wbGV0aW9uSGFuZGxlcjpuaWxdOworICAgIH0g QGNhdGNoKE5TRXhjZXB0aW9uKikgeworICAgICAgICBjYXVnaHRFeGNlcHRpb24gPSB0cnVlOwor ICAgIH0KKyAgICBFWFBFQ1RfVFJVRShjYXVnaHRFeGNlcHRpb24pOwogfQogCiB9Cg== 392470 2020-03-04 13:32:08 -0800 2020-03-04 13:32:52 -0800 Patch bug-208593-20200304133208.patch text/plain 2827 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTc4NzIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAzLTA0ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgY2FsbEFzeW5jSmF2 YVNjcmlwdCB3aXRoIGFuIGludmFsaWQgcGFyYW1ldGVyIGFuZCBubyBjb21wbGV0aW9uSGFuZGxl ciBzaG91bGQgbm90IGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDg1OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAgICAo LVtXS1dlYlZpZXcgX2V2YWx1YXRlSmF2YVNjcmlwdDphc0FzeW5jRnVuY3Rpb246d2l0aEFyZ3Vt ZW50czpmb3JjZVVzZXJHZXN0dXJlOmNvbXBsZXRpb25IYW5kbGVyOmluV29ybGQ6XSk6CisKIDIw MjAtMDMtMDQgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAog ICAgICAgICBXS1dlYlZpZXcncyBmcmFtZXMgYWNjZXNzb3Igc2hvdWxkIHJldHVybiBhIHRyYXZl cnNhYmxlIHR5cGUKSW5kZXg6IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXcubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29h L1dLV2ViVmlldy5tbQkocmV2aXNpb24gMjU3ODcyKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtOTA0LDcgKzkwNCw3 IEBAIC0gKHZvaWQpX2V2YWx1YXRlSmF2YVNjcmlwdDooTlNTdHJpbmcgKikKICAgICAgICAgYXJn dW1lbnRzTWFwLT5zZXQoa2V5LCAqd2lyZUJ5dGVzKTsKICAgICB9CiAKLSAgICBpZiAoZXJyb3JN ZXNzYWdlKSB7CisgICAgaWYgKGVycm9yTWVzc2FnZSAmJiBoYW5kbGVyKSB7CiAgICAgICAgIFJl dGFpblB0cjxOU011dGFibGVEaWN0aW9uYXJ5PiB1c2VySW5mbyA9IGFkb3B0TlMoW1tOU011dGFi bGVEaWN0aW9uYXJ5IGFsbG9jXSBpbml0XSk7CiAKICAgICAgICAgW3VzZXJJbmZvIHNldE9iamVj dDpsb2NhbGl6ZWREZXNjcmlwdGlvbkZvckVycm9yQ29kZShXS0Vycm9ySmF2YVNjcmlwdEV4Y2Vw dGlvbk9jY3VycmVkKSBmb3JLZXk6TlNMb2NhbGl6ZWREZXNjcmlwdGlvbktleV07CkluZGV4OiBU b29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAy NTc4NzUpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBA QAorMjAyMC0wMy0wNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3Jn PgorCisgICAgICAgIGNhbGxBc3luY0phdmFTY3JpcHQgd2l0aCBhbiBpbnZhbGlkIHBhcmFtZXRl ciBhbmQgbm8gY29tcGxldGlvbkhhbmRsZXIgc2hvdWxkIG5vdCBjcmFzaAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NTkzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdENvY29hL0FzeW5jRnVuY3Rpb24ubW06CisgICAgICAgIChUZXN0V2ViS2l0QVBJOjpU RVNUKToKKwogMjAyMC0wMy0wNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJr aXQub3JnPgogCiAgICAgICAgIFdLV2ViVmlldydzIGZyYW1lcyBhY2Nlc3NvciBzaG91bGQgcmV0 dXJuIGEgdHJhdmVyc2FibGUgdHlwZQpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9X ZWJLaXRDb2NvYS9Bc3luY0Z1bmN0aW9uLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvQXN5bmNGdW5jdGlvbi5tbQkocmV2aXNpb24gMjU3ODcx KQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Bc3luY0Z1bmN0aW9u Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xODMsNiArMTgzLDggQEAgVEVTVChBc3luY0Z1bmN0aW9u LCBQcm9taXNlKQogewogICAgIGF1dG8gd2ViVmlldyA9IGFkb3B0TlMoW1tUZXN0V0tXZWJWaWV3 IGFsbG9jXSBpbml0V2l0aEZyYW1lOk5TTWFrZVJlY3QoMCwgMCwgODAwLCA2MDApXSk7CiAKKyAg ICBbd2ViVmlldyBjYWxsQXN5bmNKYXZhU2NyaXB0OkAic2hvdWxkbid0IGNyYXNoIiBhcmd1bWVu dHM6QHsgQCJpbnZhbGlkcGFyYW1ldGVyIiA6IHdlYlZpZXcuZ2V0KCkgfSBpbkNvbnRlbnRXb3Js ZDpXS0NvbnRlbnRXb3JsZC5wYWdlV29ybGQgY29tcGxldGlvbkhhbmRsZXI6bmlsXTsKKwogICAg IE5TU3RyaW5nICpmdW5jdGlvbkJvZHkgPSBAInJldHVybiBuZXcgUHJvbWlzZShmdW5jdGlvbihy ZXNvbHZlLCByZWplY3QpIHsgc2V0VGltZW91dChmdW5jdGlvbigpeyByZXNvbHZlKDQyKSB9LCAw KTsgfSkiOwogCiAgICAgYm9vbCBkb25lID0gZmFsc2U7Cg==