208567 2020-03-04 01:33:44 -0800 WebChromeClient::createImageBuffer should not create a connection to GPU Process if page does not want remote rendering 2020-03-04 08:42:51 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf bfulgham commit-queue sabouhallawa simon.fraser thorton webkit-bug-importer wenson_hsieh zalan oldest_to_newest 1625454 0 youennf 2020-03-04 01:33:44 -0800 WebChromeClient::createImageBuffer should not create a connection to GPU Process if page does not want remote rendering 1625456 1 youennf 2020-03-04 01:47:26 -0800 <rdar://problem/60020229> 1625457 2 392394 youennf 2020-03-04 01:49:19 -0800 Created attachment 392394 Patch 1625524 3 392394 commit-queue 2020-03-04 08:32:05 -0800 Comment on attachment 392394 Patch Clearing flags on attachment: 392394 Committed r257845: <https://trac.webkit.org/changeset/257845> 1625525 4 commit-queue 2020-03-04 08:32:06 -0800 All reviewed patches have been landed. Closing bug. 1625528 5 392394 sabouhallawa 2020-03-04 08:41:09 -0800 Comment on attachment 392394 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392394&action=review > Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:-910 > - RenderingMode mode; > - if (m_page.shouldUseRemoteRenderingFor(purpose)) > - mode = shouldAccelerate == ShouldAccelerate::Yes ? RenderingMode::RemoteAccelerated : RenderingMode::RemoteUnaccelerated; > - else if (shouldUseDisplayList == ShouldUseDisplayList::Yes) > - mode = shouldAccelerate == ShouldAccelerate::Yes ? RenderingMode::DisplayListAccelerated : RenderingMode::DisplayListUnaccelerated; > - else > - mode = shouldAccelerate == ShouldAccelerate::Yes ? RenderingMode::Accelerated : RenderingMode::Unaccelerated; > - return ensureRemoteRenderingBackend().createImageBuffer(size, mode, resolutionScale, colorSpace); With this change, the argument 'shouldUseDisplayList' became unused. How does not the compiler catch this? 1625529 6 youennf 2020-03-04 08:42:51 -0800 > With this change, the argument 'shouldUseDisplayList' became unused. How > does not the compiler catch this? WebCore has that constraint, not WebKit. It would be nice to be consistent. 392394 2020-03-04 01:49:19 -0800 2020-03-04 08:32:05 -0800 Patch bug-208567-20200304104918.patch text/plain 6127 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3ODM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdmNDk3N2YzNzI3MDZkMzMw YWFlZjFjMzkzMzUwMGFjNDA2NDI5MjUuLjFkNjhlZDdiM2RlYTA0YWRmZTI0NTgyOTMwOGMyNDhm YWRkOGUxMzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjAtMDMtMDQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYkNocm9tZUNsaWVudDo6Y3Jl YXRlSW1hZ2VCdWZmZXIgc2hvdWxkIG5vdCBjcmVhdGUgYSBjb25uZWN0aW9uIHRvIEdQVSBQcm9j ZXNzIGlmIHBhZ2UgZG9lcyBub3Qgd2FudCByZW1vdGUgcmVuZGVyaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg1NjcKKyAgICAgICAgcmRhcjov L3Byb2JsZW0vNjAwMjAyMjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBNYW51YWxseSB0ZXN0ZWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9n cmFwaGljcy9SZW1vdGVSZW5kZXJpbmdCYWNrZW5kLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVt b3RlUmVuZGVyaW5nQmFja2VuZDo6Y3JlYXRlSW1hZ2VCdWZmZXIpOgorICAgICAgICBNaW5vciBy ZWZhY3RvcmluZyB0byBkaXJlY3RseSB0YWtlIGEgU2hvdWxkQWNjZWxlcmF0ZSBpbnN0ZWFkIG9m IGEgUmVuZGVyaW5nTW9kZS4KKyAgICAgICAgKiBXZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9SZW1v dGVSZW5kZXJpbmdCYWNrZW5kLmg6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9y dC9XZWJDaHJvbWVDbGllbnQuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJDaHJvbWVDbGllbnQ6 OmNyZWF0ZUltYWdlQnVmZmVyIGNvbnN0KToKKyAgICAgICAgSW4gY2FzZSBwYWdlIGRvZXMgbm90 IHdhbnQgdG8gZG8gcmVtb3RlIHJlbmRlcmluZywgZG8gbm90IGNyZWF0ZSBhIHJlbW90ZSBpbWFn ZSBidWZmZXIuCisgICAgICAgIEluc3RlYWQsIHJldHVybiBudWxsIGFuZCBsZXQgdGhlIGNhbGxl ciBjcmVhdGUgYSBsb2NhbCBpbWFnZSBidWZmZXIuCisKIDIwMjAtMDMtMDMgIERldmluIFJvdXNz byAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IHJlLWFkZCBg SW5zcGVjdG9yRnJvbnRlbmRIb3N0YCBzdXBwb3J0IGZvciBtb3ZpbmcgdGhlIGluc3BlY3RlZCB3 aW5kb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3Mv UmVtb3RlUmVuZGVyaW5nQmFja2VuZC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BV L2dyYXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuY3BwCmluZGV4IDM3ZjU4YWQ5YTEyMDIy MWIxY2RjZGFkNmQyNzZiZjU5ZTcxYjk1OWYuLjE5NTgzMTY1YWNmZjhhYzYyNzk1ZWMxNjhjYzkw OWI2YWVlNmM5OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3Jh cGhpY3MvUmVtb3RlUmVuZGVyaW5nQmFja2VuZC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVSZW5kZXJpbmdCYWNrZW5kLmNwcApAQCAtODQsMjAg Kzg0LDE4IEBAIGJvb2wgUmVtb3RlUmVuZGVyaW5nQmFja2VuZDo6d2FpdEZvckNvbW1pdEltYWdl QnVmZmVyRmx1c2hDb250ZXh0KCkKICAgICByZXR1cm4gY29ubmVjdGlvbi0+d2FpdEZvckFuZERp c3BhdGNoSW1tZWRpYXRlbHk8TWVzc2FnZXM6OlJlbW90ZVJlbmRlcmluZ0JhY2tlbmQ6OkNvbW1p dEltYWdlQnVmZmVyRmx1c2hDb250ZXh0PihtX3JlbmRlcmluZ0JhY2tlbmRJZGVudGlmaWVyLCAx X3MsIElQQzo6V2FpdEZvck9wdGlvbjo6SW50ZXJydXB0V2FpdGluZ0lmU3luY01lc3NhZ2VBcnJp dmVzKTsKIH0KIAotc3RkOjp1bmlxdWVfcHRyPEltYWdlQnVmZmVyPiBSZW1vdGVSZW5kZXJpbmdC YWNrZW5kOjpjcmVhdGVJbWFnZUJ1ZmZlcihjb25zdCBGbG9hdFNpemUmIHNpemUsIFJlbmRlcmlu Z01vZGUgcmVuZGVyaW5nTW9kZSwgZmxvYXQgcmVzb2x1dGlvblNjYWxlLCBDb2xvclNwYWNlIGNv bG9yU3BhY2UpCitzdGQ6OnVuaXF1ZV9wdHI8SW1hZ2VCdWZmZXI+IFJlbW90ZVJlbmRlcmluZ0Jh Y2tlbmQ6OmNyZWF0ZUltYWdlQnVmZmVyKGNvbnN0IEZsb2F0U2l6ZSYgc2l6ZSwgU2hvdWxkQWNj ZWxlcmF0ZSBzaG91bGRBY2NlbGVyYXRlLCBmbG9hdCByZXNvbHV0aW9uU2NhbGUsIENvbG9yU3Bh Y2UgY29sb3JTcGFjZSkKIHsKLSAgICBpZiAocmVuZGVyaW5nTW9kZSA9PSBSZW5kZXJpbmdNb2Rl OjpSZW1vdGVBY2NlbGVyYXRlZCkgewotICAgICAgICBpZiAoYXV0byBpbWFnZUJ1ZmZlciA9IEFj Y2VsZXJhdGVkUmVtb3RlSW1hZ2VCdWZmZXI6OmNyZWF0ZShzaXplLCByZW5kZXJpbmdNb2RlLCBy ZXNvbHV0aW9uU2NhbGUsIGNvbG9yU3BhY2UsICp0aGlzKSkgeworICAgIGlmIChzaG91bGRBY2Nl bGVyYXRlID09IFNob3VsZEFjY2VsZXJhdGU6OlllcykgeworICAgICAgICBpZiAoYXV0byBpbWFn ZUJ1ZmZlciA9IEFjY2VsZXJhdGVkUmVtb3RlSW1hZ2VCdWZmZXI6OmNyZWF0ZShzaXplLCBSZW5k ZXJpbmdNb2RlOjpSZW1vdGVBY2NlbGVyYXRlZCwgcmVzb2x1dGlvblNjYWxlLCBjb2xvclNwYWNl LCAqdGhpcykpIHsKICAgICAgICAgICAgIG1faW1hZ2VCdWZmZXJNZXNzYWdlSGFuZGxlck1hcC5h ZGQoaW1hZ2VCdWZmZXItPmltYWdlQnVmZmVySWRlbnRpZmllcigpLCBpbWFnZUJ1ZmZlci5nZXQo KSk7CiAgICAgICAgICAgICByZXR1cm4gaW1hZ2VCdWZmZXI7CiAgICAgICAgIH0KICAgICB9CiAK LSAgICBpZiAocmVuZGVyaW5nTW9kZSA9PSBSZW5kZXJpbmdNb2RlOjpSZW1vdGVBY2NlbGVyYXRl ZCB8fCByZW5kZXJpbmdNb2RlID09IFJlbmRlcmluZ01vZGU6OlJlbW90ZVVuYWNjZWxlcmF0ZWQp IHsKLSAgICAgICAgaWYgKGF1dG8gaW1hZ2VCdWZmZXIgPSBVbmFjY2VsZXJhdGVkUmVtb3RlSW1h Z2VCdWZmZXI6OmNyZWF0ZShzaXplLCByZW5kZXJpbmdNb2RlLCByZXNvbHV0aW9uU2NhbGUsIGNv bG9yU3BhY2UsICp0aGlzKSkgewotICAgICAgICAgICAgbV9pbWFnZUJ1ZmZlck1lc3NhZ2VIYW5k bGVyTWFwLmFkZChpbWFnZUJ1ZmZlci0+aW1hZ2VCdWZmZXJJZGVudGlmaWVyKCksIGltYWdlQnVm ZmVyLmdldCgpKTsKLSAgICAgICAgICAgIHJldHVybiBpbWFnZUJ1ZmZlcjsKLSAgICAgICAgfQor ICAgIGlmIChhdXRvIGltYWdlQnVmZmVyID0gVW5hY2NlbGVyYXRlZFJlbW90ZUltYWdlQnVmZmVy OjpjcmVhdGUoc2l6ZSwgUmVuZGVyaW5nTW9kZTo6UmVtb3RlVW5hY2NlbGVyYXRlZCwgcmVzb2x1 dGlvblNjYWxlLCBjb2xvclNwYWNlLCAqdGhpcykpIHsKKyAgICAgICAgbV9pbWFnZUJ1ZmZlck1l c3NhZ2VIYW5kbGVyTWFwLmFkZChpbWFnZUJ1ZmZlci0+aW1hZ2VCdWZmZXJJZGVudGlmaWVyKCks IGltYWdlQnVmZmVyLmdldCgpKTsKKyAgICAgICAgcmV0dXJuIGltYWdlQnVmZmVyOwogICAgIH0K IAogICAgIHJldHVybiBudWxscHRyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL0dQVS9ncmFwaGljcy9SZW1vdGVSZW5kZXJpbmdCYWNrZW5kLmggYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuaAppbmRleCBk NWI5NzY2ZGZjNzc4ZWIyMGJmNTc4MTg5MTRkNjU0ODJmYzk1YmQ5Li5mNDk2MTU4ZTdkNDBlZWIw NWFjMzk0MzRhZjI0NjMzYmFiYzdmMGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuaAorKysgYi9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL1JlbW90ZVJlbmRlcmluZ0JhY2tlbmQuaApA QCAtNjEsNyArNjEsNyBAQCBwdWJsaWM6CiAgICAgLy8gSVBDOjpNZXNzYWdlUmVjZWl2ZXIKICAg ICB2b2lkIGRpZFJlY2VpdmVNZXNzYWdlKElQQzo6Q29ubmVjdGlvbiYsIElQQzo6RGVjb2RlciYp IG92ZXJyaWRlOwogCi0gICAgc3RkOjp1bmlxdWVfcHRyPFdlYkNvcmU6OkltYWdlQnVmZmVyPiBj cmVhdGVJbWFnZUJ1ZmZlcihjb25zdCBXZWJDb3JlOjpGbG9hdFNpemUmLCBXZWJDb3JlOjpSZW5k ZXJpbmdNb2RlLCBmbG9hdCByZXNvbHV0aW9uU2NhbGUsIFdlYkNvcmU6OkNvbG9yU3BhY2UpOwor ICAgIHN0ZDo6dW5pcXVlX3B0cjxXZWJDb3JlOjpJbWFnZUJ1ZmZlcj4gY3JlYXRlSW1hZ2VCdWZm ZXIoY29uc3QgV2ViQ29yZTo6RmxvYXRTaXplJiwgV2ViQ29yZTo6U2hvdWxkQWNjZWxlcmF0ZSwg ZmxvYXQgcmVzb2x1dGlvblNjYWxlLCBXZWJDb3JlOjpDb2xvclNwYWNlKTsKICAgICB2b2lkIHJl bGVhc2VJbWFnZUJ1ZmZlcihJbWFnZUJ1ZmZlcklkZW50aWZpZXIpOwogCiAgICAgYm9vbCB3YWl0 Rm9yQ3JlYXRlSW1hZ2VCdWZmZXJCYWNrZW5kKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViQ29yZVN1cHBvcnQvV2ViQ2hyb21lQ2xpZW50LmNwcCBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCmluZGV4 IDQ1ZWM3MDlkYjdlZTlhMmRiYzkxYzRkZGJjNGY5NDg0NDMwMmU2OTUuLjI1ZmIwMjA5MzIxMjM2 ODdjNzljMGJlZTc0ZTNlNTRkMjJjNDdiNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJDb3JlU3VwcG9ydC9XZWJDaHJvbWVDbGllbnQuY3BwCkBAIC05 MDAsMTQgKzkwMCwxMCBAQCBSZW1vdGVSZW5kZXJpbmdCYWNrZW5kJiBXZWJDaHJvbWVDbGllbnQ6 OmVuc3VyZVJlbW90ZVJlbmRlcmluZ0JhY2tlbmQoKSBjb25zdAogCiBzdGQ6OnVuaXF1ZV9wdHI8 SW1hZ2VCdWZmZXI+IFdlYkNocm9tZUNsaWVudDo6Y3JlYXRlSW1hZ2VCdWZmZXIoY29uc3QgRmxv YXRTaXplJiBzaXplLCBTaG91bGRBY2NlbGVyYXRlIHNob3VsZEFjY2VsZXJhdGUsIFNob3VsZFVz ZURpc3BsYXlMaXN0IHNob3VsZFVzZURpc3BsYXlMaXN0LCBSZW5kZXJpbmdQdXJwb3NlIHB1cnBv c2UsIGZsb2F0IHJlc29sdXRpb25TY2FsZSwgQ29sb3JTcGFjZSBjb2xvclNwYWNlKSBjb25zdAog ewotICAgIFJlbmRlcmluZ01vZGUgbW9kZTsKLSAgICBpZiAobV9wYWdlLnNob3VsZFVzZVJlbW90 ZVJlbmRlcmluZ0ZvcihwdXJwb3NlKSkKLSAgICAgICAgbW9kZSA9IHNob3VsZEFjY2VsZXJhdGUg PT0gU2hvdWxkQWNjZWxlcmF0ZTo6WWVzID8gUmVuZGVyaW5nTW9kZTo6UmVtb3RlQWNjZWxlcmF0 ZWQgOiBSZW5kZXJpbmdNb2RlOjpSZW1vdGVVbmFjY2VsZXJhdGVkOwotICAgIGVsc2UgaWYgKHNo b3VsZFVzZURpc3BsYXlMaXN0ID09IFNob3VsZFVzZURpc3BsYXlMaXN0OjpZZXMpCi0gICAgICAg IG1vZGUgPSBzaG91bGRBY2NlbGVyYXRlID09IFNob3VsZEFjY2VsZXJhdGU6OlllcyA/IFJlbmRl cmluZ01vZGU6OkRpc3BsYXlMaXN0QWNjZWxlcmF0ZWQgOiBSZW5kZXJpbmdNb2RlOjpEaXNwbGF5 TGlzdFVuYWNjZWxlcmF0ZWQ7Ci0gICAgZWxzZQotICAgICAgICBtb2RlID0gc2hvdWxkQWNjZWxl cmF0ZSA9PSBTaG91bGRBY2NlbGVyYXRlOjpZZXMgPyBSZW5kZXJpbmdNb2RlOjpBY2NlbGVyYXRl ZCA6IFJlbmRlcmluZ01vZGU6OlVuYWNjZWxlcmF0ZWQ7Ci0gICAgcmV0dXJuIGVuc3VyZVJlbW90 ZVJlbmRlcmluZ0JhY2tlbmQoKS5jcmVhdGVJbWFnZUJ1ZmZlcihzaXplLCBtb2RlLCByZXNvbHV0 aW9uU2NhbGUsIGNvbG9yU3BhY2UpOworICAgIGlmICghbV9wYWdlLnNob3VsZFVzZVJlbW90ZVJl bmRlcmluZ0ZvcihwdXJwb3NlKSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKKyAgICByZXR1 cm4gZW5zdXJlUmVtb3RlUmVuZGVyaW5nQmFja2VuZCgpLmNyZWF0ZUltYWdlQnVmZmVyKHNpemUs IHNob3VsZEFjY2VsZXJhdGUsIHJlc29sdXRpb25TY2FsZSwgY29sb3JTcGFjZSk7CiB9CiAKICNl bmRpZiAvLyBFTkFCTEUoR1BVX1BST0NFU1MpCg==