208564 2020-03-04 00:21:25 -0800 Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext 2020-03-04 10:08:18 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 208565 1 dbates dbates achristensen webkit-bug-importer oldest_to_newest 1625438 0 dbates 2020-03-04 00:21:25 -0800 Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext so as to support running them like: run-api-tests --debug TestWebKitAPI.RequestTextInputContext 1625439 1 392384 dbates 2020-03-04 00:24:23 -0800 Created attachment 392384 Patch 1625443 2 392387 dbates 2020-03-04 00:34:12 -0800 Created attachment 392387 Patch 1625590 3 dbates 2020-03-04 10:06:27 -0800 Thanks for the review 1625591 4 392387 dbates 2020-03-04 10:07:02 -0800 Comment on attachment 392387 Patch Clearing flags on attachment: 392387 Committed r257853: <https://trac.webkit.org/changeset/257853> 1625592 5 dbates 2020-03-04 10:07:04 -0800 All reviewed patches have been landed. Closing bug. 1625599 6 webkit-bug-importer 2020-03-04 10:08:18 -0800 <rdar://problem/60044476> 392384 2020-03-04 00:24:23 -0800 2020-03-04 00:34:10 -0800 Patch bug-208564-20200304002422.patch text/plain 2660 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3ODM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzJkMzU2NDBlNDg0OTkwN2E5YjZkOTA0YTRiNjI5MjRl NzljYjhmOC4uNzRmYTk4ZWYwNzk1N2M1ODc1OWZlZmY5OWY3NDBjOWJhZGY2NTc5NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDIwLTAzLTA0ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBPcmdhbml6ZSB0ZXN0cyBpbiBSZXF1ZXN0VGV4dElucHV0Q29udGV4dC5tbSB0ZXN0cyB1 bmRlciB0ZXN0IG5hbWUgUmVxdWVzdFRleHRJbnB1dENvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODU2NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdyb3VwIHRoZSB0ZXN0cyBpbiBSZXF1ZXN0 VGV4dElucHV0Q29udGV4dC5tbSB1bmRlciB0aGUgdGVzdCBjYXNlIG5hbWUgUmVxdWVzdFRleHRJ bnB1dENvbnRleHQKKyAgICAgICAgdG8gbWFrZSBpdCBlYXN5IHRvIHJ1biBqdXN0IHRoZXNlIHRl c3RzLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhlIHRlc3RzIGFyZSBvcmdhbml6ZWQgdW5kZXIg dGhlIHRlc3QgY2FzZSBuYW1lIFdlYktpdC4gVGhpcyBtYWtlcyBpdCBkaWZmaWN1bHQKKyAgICAg ICAgdG8gcnVuIGp1c3QgdGhlc2UgdGVzdHMuIEluc3RlYWYgb3JnYW5pemUgdGhlbSB1bmRlciBS ZXF1ZXN0VGV4dElucHV0Q29udGV4dCBzbyB0aGF0IGEgcGVyc29uCisgICAgICAgIGNhbiBydW4g anVzdCB0aGVzZSB0ZXN0IHVzaW5nOgorICAgICAgICAKKyAgICAgICAgICAgICAgICBydW4tYXBp LXRlc3RzIC0tZGVidWcgVGVzdFdlYktpdEFQSS5SZXF1ZXN0VGV4dElucHV0Q29udGV4dAorCisg ICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9SZXF1ZXN0VGV4dElucHV0 Q29udGV4dC5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIwLTAzLTAzICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFNQSSBfV0tSZXNv dXJjZUxvYWRJbmZvLmxvYWRlZEZyb21DYWNoZQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9SZXF1ZXN0VGV4dElucHV0Q29udGV4dC5tbSBiL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUmVxdWVzdFRleHRJbnB1dENvbnRleHQu bW0KaW5kZXggYjA1MGM1OGI1MzY4MDc3M2ZkNGQyYTI1YWYyNjdiOTU1Yjg3MmU4Ni4uYjk2M2Qx ODUzZmJlYjQ1ZDM2MmQ3OTJkOTZkZTlmMWIxMDc1MTZmYSAxMDA2NDQKLS0tIGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9SZXF1ZXN0VGV4dElucHV0Q29udGV4dC5tbQor KysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1JlcXVlc3RUZXh0SW5w dXRDb250ZXh0Lm1tCkBAIC03Myw3ICs3Myw3IEBAIHN0YXRpYyBOU1N0cmluZyAqYXBwbHlJZnJh bWUoTlNTdHJpbmcgKkhUTUxTdHJpbmcpCiAgICAgcmV0dXJuIGFwcGx5U3R5bGUoW05TU3RyaW5n IHN0cmluZ1dpdGhGb3JtYXQ6QCI8aWZyYW1lIHNyYz1cImRhdGE6dGV4dC9odG1sLCVAXCIgc3R5 bGU9J3Bvc2l0aW9uOiBhYnNvbHV0ZTsgdG9wOiAyMDBweDsnPiIsIFthcHBseVN0eWxlKEhUTUxT dHJpbmcpIHN0cmluZ0J5QWRkaW5nUGVyY2VudEVuY29kaW5nV2l0aEFsbG93ZWRDaGFyYWN0ZXJz OltOU0NoYXJhY3RlclNldCBVUkxQYXRoQWxsb3dlZENoYXJhY3RlclNldF1dXSk7CiB9CiAKLVRF U1QoV2ViS2l0LCBSZXF1ZXN0VGV4dElucHV0Q29udGV4dCkKK1RFU1QoUmVxdWVzdFRleHRJbnB1 dENvbnRleHQsIFNpbXBsZSkKIHsKICAgICBSZXRhaW5QdHI8V0tXZWJWaWV3Q29uZmlndXJhdGlv bj4gY29uZmlndXJhdGlvbiA9IGFkb3B0TlMoW1tXS1dlYlZpZXdDb25maWd1cmF0aW9uIGFsbG9j XSBpbml0XSk7CiAgICAgUmV0YWluUHRyPFRlc3RXS1dlYlZpZXc+IHdlYlZpZXcgPSBhZG9wdE5T KFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgw MCwgNjAwKSBjb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24uZ2V0KCldKTsKQEAgLTE2Nyw3ICsx NjcsNyBAQCBURVNUKFdlYktpdCwgUmVxdWVzdFRleHRJbnB1dENvbnRleHQpCiAgICAgRVhQRUNU X0VRKENHUmVjdE1ha2UoMCwgMCwgMTAwLCAxMDApLCBjb250ZXh0c1sxXS5ib3VuZGluZ1JlY3Qp OwogfQogCi1URVNUKFdlYktpdCwgRElTQUJMRURfRm9jdXNUZXh0SW5wdXRDb250ZXh0KQorVEVT VChSZXF1ZXN0VGV4dElucHV0Q29udGV4dCwgRElTQUJMRURfRm9jdXNUZXh0SW5wdXRDb250ZXh0 KQogewogICAgIFJldGFpblB0cjxXS1dlYlZpZXdDb25maWd1cmF0aW9uPiBjb25maWd1cmF0aW9u ID0gYWRvcHROUyhbW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gYWxsb2NdIGluaXRdKTsKICAgICBX S1ByZWZlcmVuY2VzU2V0VGhyZWFkZWRTY3JvbGxpbmdFbmFibGVkKChXS1ByZWZlcmVuY2VzUmVm KVtjb25maWd1cmF0aW9uIHByZWZlcmVuY2VzXSwgZmFsc2UpOwo= 392387 2020-03-04 00:34:12 -0800 2020-03-04 10:07:02 -0800 Patch bug-208564-20200304003411.patch text/plain 2789 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3ODM1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzJkMzU2NDBlNDg0OTkwN2E5YjZkOTA0YTRiNjI5MjRl NzljYjhmOC4uZmYxNGI1MDIwNDUzNTRlYTk1MWYzOWYyYWU5ZDBlOTkyNjkzNWY1ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIwLTAzLTA0ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBPcmdhbml6ZSB0ZXN0cyBpbiBSZXF1ZXN0VGV4dElucHV0Q29udGV4dC5tbSB0ZXN0cyB1 bmRlciB0ZXN0IG5hbWUgUmVxdWVzdFRleHRJbnB1dENvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODU2NAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdyb3VwIHRoZSB0ZXN0cyBpbiBSZXF1ZXN0 VGV4dElucHV0Q29udGV4dC5tbSB1bmRlciB0aGUgdGVzdCBjYXNlIG5hbWUgUmVxdWVzdFRleHRJ bnB1dENvbnRleHQKKyAgICAgICAgdG8gbWFrZSBpdCBlYXN5IHRvIHJ1biBqdXN0IHRoZXNlIHRl c3RzLgorCisgICAgICAgIEN1cnJlbnRseSwgdGhlIHRlc3RzIGFyZSBvcmdhbml6ZWQgdW5kZXIg dGhlIHRlc3QgY2FzZSBuYW1lIFdlYktpdC4gVGhpcyBtZWFucyB5b3UgbmVlZCB0bworICAgICAg ICBwYXNzIHJ1bi1hcGktdGVzdHMgdGhlIG5hbWUgb2YgZWFjaCBzdWItdGVzdCBhcyB0aGVyZSBp cyBubyBlYXN5IHdheSB0byBydW4gdGhlbSBhbGwgd2l0aG91dAorICAgICAgICBhbHNvIHJ1bm5p bmcgYWxsIHRoZSBUZXN0V2ViS2l0QVBJLldlYktpdCBzdWItdGVzdHMuIEluc3RlYWQgb3JnYW5p emUgdGhlbSB1bmRlciBSZXF1ZXN0VGV4dElucHV0Q29udGV4dAorICAgICAgICBzbyB0aGF0IGEg cGVyc29uIGNhbiBydW4ganVzdCB0aGVzZSB0ZXN0IHVzaW5nOgorICAgICAgICAKKyAgICAgICAg ICAgICAgICBydW4tYXBpLXRlc3RzIC0tZGVidWcgVGVzdFdlYktpdEFQSS5SZXF1ZXN0VGV4dElu cHV0Q29udGV4dAorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9S ZXF1ZXN0VGV4dElucHV0Q29udGV4dC5tbToKKyAgICAgICAgKFRFU1QpOgorCiAyMDIwLTAzLTAz ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAg QWRkIFNQSSBfV0tSZXNvdXJjZUxvYWRJbmZvLmxvYWRlZEZyb21DYWNoZQpkaWZmIC0tZ2l0IGEv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9SZXF1ZXN0VGV4dElucHV0Q29u dGV4dC5tbSBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUmVxdWVzdFRl eHRJbnB1dENvbnRleHQubW0KaW5kZXggYjA1MGM1OGI1MzY4MDc3M2ZkNGQyYTI1YWYyNjdiOTU1 Yjg3MmU4Ni4uYjk2M2QxODUzZmJlYjQ1ZDM2MmQ3OTJkOTZkZTlmMWIxMDc1MTZmYSAxMDA2NDQK LS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9SZXF1ZXN0VGV4dElu cHV0Q29udGV4dC5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L1JlcXVlc3RUZXh0SW5wdXRDb250ZXh0Lm1tCkBAIC03Myw3ICs3Myw3IEBAIHN0YXRpYyBOU1N0 cmluZyAqYXBwbHlJZnJhbWUoTlNTdHJpbmcgKkhUTUxTdHJpbmcpCiAgICAgcmV0dXJuIGFwcGx5 U3R5bGUoW05TU3RyaW5nIHN0cmluZ1dpdGhGb3JtYXQ6QCI8aWZyYW1lIHNyYz1cImRhdGE6dGV4 dC9odG1sLCVAXCIgc3R5bGU9J3Bvc2l0aW9uOiBhYnNvbHV0ZTsgdG9wOiAyMDBweDsnPiIsIFth cHBseVN0eWxlKEhUTUxTdHJpbmcpIHN0cmluZ0J5QWRkaW5nUGVyY2VudEVuY29kaW5nV2l0aEFs bG93ZWRDaGFyYWN0ZXJzOltOU0NoYXJhY3RlclNldCBVUkxQYXRoQWxsb3dlZENoYXJhY3RlclNl dF1dXSk7CiB9CiAKLVRFU1QoV2ViS2l0LCBSZXF1ZXN0VGV4dElucHV0Q29udGV4dCkKK1RFU1Qo UmVxdWVzdFRleHRJbnB1dENvbnRleHQsIFNpbXBsZSkKIHsKICAgICBSZXRhaW5QdHI8V0tXZWJW aWV3Q29uZmlndXJhdGlvbj4gY29uZmlndXJhdGlvbiA9IGFkb3B0TlMoW1tXS1dlYlZpZXdDb25m aWd1cmF0aW9uIGFsbG9jXSBpbml0XSk7CiAgICAgUmV0YWluUHRyPFRlc3RXS1dlYlZpZXc+IHdl YlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhGcmFtZTpOU01h a2VSZWN0KDAsIDAsIDgwMCwgNjAwKSBjb25maWd1cmF0aW9uOmNvbmZpZ3VyYXRpb24uZ2V0KCld KTsKQEAgLTE2Nyw3ICsxNjcsNyBAQCBURVNUKFdlYktpdCwgUmVxdWVzdFRleHRJbnB1dENvbnRl eHQpCiAgICAgRVhQRUNUX0VRKENHUmVjdE1ha2UoMCwgMCwgMTAwLCAxMDApLCBjb250ZXh0c1sx XS5ib3VuZGluZ1JlY3QpOwogfQogCi1URVNUKFdlYktpdCwgRElTQUJMRURfRm9jdXNUZXh0SW5w dXRDb250ZXh0KQorVEVTVChSZXF1ZXN0VGV4dElucHV0Q29udGV4dCwgRElTQUJMRURfRm9jdXNU ZXh0SW5wdXRDb250ZXh0KQogewogICAgIFJldGFpblB0cjxXS1dlYlZpZXdDb25maWd1cmF0aW9u PiBjb25maWd1cmF0aW9uID0gYWRvcHROUyhbW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gYWxsb2Nd IGluaXRdKTsKICAgICBXS1ByZWZlcmVuY2VzU2V0VGhyZWFkZWRTY3JvbGxpbmdFbmFibGVkKChX S1ByZWZlcmVuY2VzUmVmKVtjb25maWd1cmF0aW9uIHByZWZlcmVuY2VzXSwgZmFsc2UpOwo=