208558 2020-03-03 21:34:31 -0800 [LFC][IFC] Display::Run::TextContent::expand(unsigned) is called with the value of -1. 2020-03-04 07:19:21 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1625401 0 zalan 2020-03-03 21:34:31 -0800 shrink it! 1625402 1 webkit-bug-importer 2020-03-03 21:35:02 -0800 <rdar://problem/60026658> 1625490 2 392408 zalan 2020-03-04 06:31:00 -0800 Created attachment 392408 Patch 1625491 3 392408 koivisto 2020-03-04 06:33:13 -0800 Comment on attachment 392408 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392408&action=review > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-836 > - m_textContent->expand(-1); wut > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:837 > + constexpr size_t trailingTrimmableContentLength = 1; > + m_textContent->shrink(trailingTrimmableContentLength); I have concerns. 1625492 4 zalan 2020-03-04 06:34:12 -0800 (In reply to Antti Koivisto from comment #3) > Comment on attachment 392408 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392408&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:-836 > > - m_textContent->expand(-1); > > wut > > > Source/WebCore/layout/inlineformatting/InlineLineBuilder.cpp:837 > > + constexpr size_t trailingTrimmableContentLength = 1; > > + m_textContent->shrink(trailingTrimmableContentLength); > > I have concerns. Me too! 1625501 5 392408 commit-queue 2020-03-04 07:19:20 -0800 Comment on attachment 392408 Patch Clearing flags on attachment: 392408 Committed r257841: <https://trac.webkit.org/changeset/257841> 1625502 6 commit-queue 2020-03-04 07:19:21 -0800 All reviewed patches have been landed. Closing bug. 392408 2020-03-04 06:31:00 -0800 2020-03-04 07:19:20 -0800 Patch bug-208558-20200304063100.patch text/plain 2358 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDBmYzU4YWNmNzZjODE5 NGNkMDA5YWU2ODY1MDg0OGVjN2RhNDI2ZS4uMzdkMDBhOTkwMGQ2ZjI0OWMxNzNlNDAzMjBjMjgy NDcyZGFiNmQ1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAzLTA0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBEaXNwbGF5 OjpSdW46OlRleHRDb250ZW50OjpleHBhbmQodW5zaWduZWQpIGlzIGNhbGxlZCB3aXRoIHRoZSB2 YWx1ZSBvZiAtMS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwODU1OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAwMjY2NTg+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsYXlvdXQvZGlzcGxheXRy ZWUvRGlzcGxheVJ1bi5oOgorICAgICAgICAoV2ViQ29yZTo6RGlzcGxheTo6UnVuOjpUZXh0Q29u dGVudDo6c2hyaW5rKToKKyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVM aW5lQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCdWlsZGVyOjpS dW46OnJlbW92ZVRyYWlsaW5nV2hpdGVzcGFjZSk6CisKIDIwMjAtMDMtMDIgIE1hcmsgTGFtICA8 bWFyay5sYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFNjcmlwdENvbnRyb2xsZXI6OmV4ZWN1dGVJ ZkphdmFTY3JpcHRVUkwoKSB1c2VzIHdyb25nIEpTR2xvYmFsT2JqZWN0LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0cmVlL0Rpc3BsYXlSdW4uaCBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9kaXNwbGF5dHJlZS9EaXNwbGF5UnVuLmgKaW5kZXggMzc1NDQ5YWM3YjIz MWU5YmU1ZDMwOWUxNGFhNzBmZWQ2MWFiZmYyOC4uODdlNDRiNjUzYjcyYmI5MmRiZTY3ZmE5NWE3 ZDIzZWEwMDc2ZjQ3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Rpc3BsYXl0 cmVlL0Rpc3BsYXlSdW4uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvZGlzcGxheXRyZWUv RGlzcGxheVJ1bi5oCkBAIC01NCw2ICs1NCw3IEBAIHN0cnVjdCBSdW4gewogICAgICAgICB2b2lk IHNldE5lZWRzSHlwaGVuKCkgeyBtX25lZWRzSHlwaGVuID0gdHJ1ZTsgfQogCiAgICAgICAgIHZv aWQgZXhwYW5kKHVuc2lnbmVkIGRlbHRhKSB7IG1fbGVuZ3RoICs9IGRlbHRhOyB9CisgICAgICAg IHZvaWQgc2hyaW5rKHVuc2lnbmVkIGRlbHRhKSB7IG1fbGVuZ3RoIC09IGRlbHRhOyB9CiAKICAg ICBwcml2YXRlOgogICAgICAgICB1bnNpZ25lZCBtX3N0YXJ0IHsgMCB9OwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1 aWxkZXIuY3BwCmluZGV4IGUyNGNlZWUwZDE5OWQ5OWE2ZTdiNTczYmM4ZjU3ZThiMWE3Y2UyMDUu LjY0YTAwZTU4ZGE2MTVhZmFhYzNhNjRmMThkNGJmNDVjODY2ZDZlZGQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5l QnVpbGRlci5jcHAKQEAgLTgzMyw3ICs4MzMsOCBAQCB2b2lkIExpbmVCdWlsZGVyOjpSdW46OnJl bW92ZVRyYWlsaW5nV2hpdGVzcGFjZSgpCiAgICAgLy8gQWNjb3JkaW5nIHRvIGh0dHBzOi8vd3d3 LnczLm9yZy9UUi9jc3MtdGV4dC0zLyN3aGl0ZS1zcGFjZS1wcm9wZXJ0eSBtYXRyaXgKICAgICAv LyBUcmltbWFibGUgd2hpdGVzcGFjZSBpcyBhbHdheXMgY29sbGFwc2FibGUgc28gdGhlIGxlbmd0 aCBvZiB0aGUgdHJhaWxpbmcgdHJpbW1hYmxlIHdoaXRlc3BhY2UgaXMgYWx3YXlzIDEgKG9yIG5v bi1leGlzdGVudCkuCiAgICAgQVNTRVJUKG1fdGV4dENvbnRlbnQtPmxlbmd0aCgpKTsKLSAgICBt X3RleHRDb250ZW50LT5leHBhbmQoLTEpOworICAgIGNvbnN0ZXhwciBzaXplX3QgdHJhaWxpbmdU cmltbWFibGVDb250ZW50TGVuZ3RoID0gMTsKKyAgICBtX3RleHRDb250ZW50LT5zaHJpbmsodHJh aWxpbmdUcmltbWFibGVDb250ZW50TGVuZ3RoKTsKICAgICB2aXN1YWxseUNvbGxhcHNlVHJhaWxp bmdXaGl0ZXNwYWNlKCk7CiB9CiAK