208557 2020-03-03 20:47:03 -0800 Web Inspector: set both the page's and the window's appearance when modifying the frontend forced appearance in the case that the frontend is docked 2020-03-03 21:42:16 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 208503 1 hi hi commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck timothy webkit-bug-importer oldest_to_newest 1625385 0 hi 2020-03-03 20:47:03 -0800 # STEPS TO REPRODUCE: 1. inspect any page 2. dock Web Inspector 3. go to the Settings Tab 4. change the Appearance to Dark => nothing happens 5. detach/undock Web Inspector => content shifts to dark appearance 1625392 1 392369 hi 2020-03-03 20:54:57 -0800 Created attachment 392369 Patch 1625403 2 392369 commit-queue 2020-03-03 21:41:04 -0800 Comment on attachment 392369 Patch Clearing flags on attachment: 392369 Committed r257833: <https://trac.webkit.org/changeset/257833> 1625404 3 commit-queue 2020-03-03 21:41:05 -0800 All reviewed patches have been landed. Closing bug. 1625407 4 webkit-bug-importer 2020-03-03 21:42:16 -0800 <rdar://problem/60026792> 392369 2020-03-03 20:54:57 -0800 2020-03-03 21:41:04 -0800 Patch bug-208557-20200303205456.patch text/plain 2912 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5MDdjYTZkZDAyYjk4MDk5MjQ5NjIzN2Y2YTNlYjFkY2UzZDlmZDc4Li5k YmQyYTg4ZGVkNjhjZDhlZDA1ZGZjYjY3Nzk5YmFlZjY0OWQwZDg0IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTkgQEAKKzIwMjAtMDMtMDMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IHNldCBib3RoIHRoZSBwYWdlJ3MgYW5kIHRoZSB3 aW5kb3cncyBhcHBlYXJhbmNlIHdoZW4gbW9kaWZ5aW5nIHRoZSBmcm9udGVuZCBmb3JjZWQgYXBw ZWFyYW5jZSBpbiB0aGUgY2FzZSB0aGF0IHRoZSBmcm9udGVuZCBpcyBkb2NrZWQKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODU1NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3Bl Y3RvckZyb250ZW5kSG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JGcm9udGVu ZEhvc3Q6OnNldEZvcmNlZEFwcGVhcmFuY2UpOgorICAgICAgICBgSW5zcGVjdG9yRnJvbnRlbmRD bGllbnQ6OnNldEZvcmNlZEFwcGVhcmFuY2VgIG9ubHkgaGFzIGFuIGVmZmVjdCB3aGVuIFdlYiBJ bnNwZWN0b3IgaXMKKyAgICAgICAgZGV0YWNoZWQvdW5kb2NrZWQsIG1lYW5pbmcgdGhhdCBjaGFu Z2luZyB0aGUgQXBwZWFyYW5jZSBpbiB0aGUgU2V0dGluZ3MgVGFiIHdoZW4gZG9ja2VkIGhhcwor ICAgICAgICBubyBlZmZlY3QuIEluIGFkZGl0aW9uIHRvIG5vdGlmeWluZyB0aGUgYEluc3BlY3Rv ckZyb250ZW5kQ2xpZW50YCwgd2Ugc2hvdWxkIGFsc28gY2FsbAorICAgICAgICBgUGFnZTo6c2V0 VXNlRGFya0FwcGVhcmFuY2VPdmVycmlkZWAgc28gdGhhdCBpZiBXZWIgSW5zcGVjdG9yIGlzIGRv Y2tlZCwgdGhlIGFwcGVyYW5jZQorICAgICAgICBjaGFuZ2VzLiBUaGUgV2ViIEluc3BlY3RvciBm cm9udGVuZCBwYWdlJ3MgYXBwZXJhbmNlIHdvdWxkIG5vcm1hbGx5IGNoYW5nZSB0byBtYXRjaCB0 aGUKKyAgICAgICAgYXBwZWFyYW5jZSBvZiB0aGUgd2luZG93LCBidXQgd2hlbiBXZWIgSW5zcGVj dG9yIGlzIGRvY2tlZCB0aGVyZSBpcyBubyB3aW5kb3cuCisKIDIwMjAtMDMtMDMgIFphbGFuIEJ1 anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbSW50ZXJuYWxzXSBJbnRyb2R1Y2Ug SW50ZXJuYWxzOjp1cGRhdGVMYXlvdXRBbmRTdHlsZVJlY3Vyc2l2ZWx5CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwCmluZGV4IGQ3NTUx NGM5N2Y5ZjBlODUzOTVjNGY3MDg1Njk5YmY0Zjc4ZTViZGYuLjdiYzMwZDAzNDNjOTQ4NWE2NzEz ZTRhYjNkM2I3NmQ2ZjkwYWY5YmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwCkBAIC0yMzUsMjUgKzIzNSwyNSBAQCBmbG9hdCBJ bnNwZWN0b3JGcm9udGVuZEhvc3Q6Onpvb21GYWN0b3IoKQogdm9pZCBJbnNwZWN0b3JGcm9udGVu ZEhvc3Q6OnNldEZvcmNlZEFwcGVhcmFuY2UoU3RyaW5nIGFwcGVhcmFuY2UpCiB7CiAgICAgaWYg KGFwcGVhcmFuY2UgPT0gImxpZ2h0Il9zKSB7CisgICAgICAgIGlmIChtX2Zyb250ZW5kUGFnZSkK KyAgICAgICAgICAgIG1fZnJvbnRlbmRQYWdlLT5zZXRVc2VEYXJrQXBwZWFyYW5jZU92ZXJyaWRl KGZhbHNlKTsKICAgICAgICAgaWYgKG1fY2xpZW50KQogICAgICAgICAgICAgbV9jbGllbnQtPnNl dEZvcmNlZEFwcGVhcmFuY2UoSW5zcGVjdG9yRnJvbnRlbmRDbGllbnQ6OkFwcGVhcmFuY2U6Okxp Z2h0KTsKLSAgICAgICAgZWxzZSBpZiAobV9mcm9udGVuZFBhZ2UpCi0gICAgICAgICAgICBtX2Zy b250ZW5kUGFnZS0+c2V0VXNlRGFya0FwcGVhcmFuY2VPdmVycmlkZShmYWxzZSk7CiAgICAgICAg IHJldHVybjsKICAgICB9CiAKICAgICBpZiAoYXBwZWFyYW5jZSA9PSAiZGFyayJfcykgeworICAg ICAgICBpZiAobV9mcm9udGVuZFBhZ2UpCisgICAgICAgICAgICBtX2Zyb250ZW5kUGFnZS0+c2V0 VXNlRGFya0FwcGVhcmFuY2VPdmVycmlkZSh0cnVlKTsKICAgICAgICAgaWYgKG1fY2xpZW50KQog ICAgICAgICAgICAgbV9jbGllbnQtPnNldEZvcmNlZEFwcGVhcmFuY2UoSW5zcGVjdG9yRnJvbnRl bmRDbGllbnQ6OkFwcGVhcmFuY2U6OkRhcmspOwotICAgICAgICBlbHNlIGlmIChtX2Zyb250ZW5k UGFnZSkKLSAgICAgICAgICAgIG1fZnJvbnRlbmRQYWdlLT5zZXRVc2VEYXJrQXBwZWFyYW5jZU92 ZXJyaWRlKHRydWUpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCisgICAgaWYgKG1fZnJvbnRl bmRQYWdlKQorICAgICAgICBtX2Zyb250ZW5kUGFnZS0+c2V0VXNlRGFya0FwcGVhcmFuY2VPdmVy cmlkZShXVEY6Om51bGxvcHQpOwogICAgIGlmIChtX2NsaWVudCkKICAgICAgICAgbV9jbGllbnQt PnNldEZvcmNlZEFwcGVhcmFuY2UoSW5zcGVjdG9yRnJvbnRlbmRDbGllbnQ6OkFwcGVhcmFuY2U6 OlN5c3RlbSk7Ci0gICAgZWxzZSBpZiAobV9mcm9udGVuZFBhZ2UpCi0gICAgICAgIG1fZnJvbnRl bmRQYWdlLT5zZXRVc2VEYXJrQXBwZWFyYW5jZU92ZXJyaWRlKFdURjo6bnVsbG9wdCk7CiB9CiAK IFN0cmluZyBJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OnVzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rp b24oKQo=