208549 2020-03-03 17:04:14 -0800 Web Inspector: AXI: can't leave Styles and Computed panels by pressing Tab 2020-03-05 16:47:05 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1625326 0 nvasilyev 2020-03-03 17:04:14 -0800 Once the focus is inside of the Styles or Computed panel, it's trapped there. You can't escape the panel by pressing Tab. Focus cycles inside the panel. Steps: 1. Open Styles panel. 2. Focus on the filter field at the bottom of the sidebar. 3. Press Tab. Expected: Focus moves forward to "Classes" toggle button. Actual: Focus "cycles" back to the top of the sidebar - to the "Active" checkbox. Steps: 1. Focus on the first checkbox - "Active". 2. Press Shift-Tab. Expected: Focus moves to "Styles" sidebar tab. Actual: Focus moves to the filter field at the bottom of the sidebar. 1625327 1 webkit-bug-importer 2020-03-03 17:04:34 -0800 <rdar://problem/60020149> 1625338 2 392354 nvasilyev 2020-03-03 17:18:59 -0800 Created attachment 392354 Patch 1626377 3 392354 hi 2020-03-05 16:19:40 -0800 Comment on attachment 392354 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392354&action=review r=me > Source/WebInspectorUI/UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:419 > + if (event.shiftKey && this._panel.focusLastSection) { Why not mimic `_handleForcedPseudoClassCheckboxKeydown` and have `if (event.key !== "Tab" || !event.shiftKey)` instead? That way, `if (this._panel.focusLastSection)` lines up quite nicely with the `this._panel.focusLastSection();` on the next line :) 1626385 4 392645 nvasilyev 2020-03-05 16:28:38 -0800 Created attachment 392645 Patch 1626397 5 392645 commit-queue 2020-03-05 16:47:03 -0800 Comment on attachment 392645 Patch Clearing flags on attachment: 392645 Committed r257959: <https://trac.webkit.org/changeset/257959> 1626398 6 commit-queue 2020-03-05 16:47:05 -0800 All reviewed patches have been landed. Closing bug. 392354 2020-03-03 17:18:59 -0800 2020-03-05 16:28:38 -0800 Patch patch.txt text/plain 3226 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM4NDAzMTNjNzk0Li45MDA1MmFlZGJlOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDMtMDMgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogQVhJOiBjYW4ndCBsZWF2ZSBTdHlsZXMgYW5kIENvbXB1dGVkIHBhbmVscyBieSBwcmVzc2lu ZyBUYWIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw ODU0OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAwMjAxNDk+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGZvY3VzIGN5Y2xpbmcgaW5z aWRlIG9mIHRoZSBTdHlsZXMgYW5kIENvbXB1dGVkIHBhbmVscy4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qczoKKyAgICAg ICAgKFdJLkdlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwucHJvdG90eXBlLl9oYW5kbGVG b3JjZWRQc2V1ZG9DbGFzc0NoZWNrYm94S2V5ZG93bik6CisgICAgICAgIChXSS5HZW5lcmFsU3R5 bGVEZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5faGFuZGxlRmlsdGVyQmFySW5wdXRGaWVs ZEtleURvd24pOgorCiAyMDIwLTAyLTI3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNv bT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBsb2NhbGl6ZSB0aGUgcGxhY2Vob2xkZXIgIkhl YWRlciIgYW5kICJ2YWx1ZSIgd2hlbiBlZGl0aW5nIGEgbG9jYWwgb3ZlcnJpZGUKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxTdHls ZURldGFpbHNTaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLmpzCmluZGV4IGEzMjI5 NWIxNTQ4Li42YTBmMGU1NWExMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsU3R5bGVE ZXRhaWxzU2lkZWJhclBhbmVsLmpzCkBAIC0yMzYsMjQgKzIzNiwxMiBAQCBXSS5HZW5lcmFsU3R5 bGVEZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQ YW5lbCBleHRlbgogCiAgICAgX2hhbmRsZUZvcmNlZFBzZXVkb0NsYXNzQ2hlY2tib3hLZXlkb3du KHBzZXVkb0NsYXNzLCBldmVudCkKICAgICB7Ci0gICAgICAgIGlmIChldmVudC5rZXkgIT09ICJU YWIiKQorICAgICAgICBpZiAoZXZlbnQua2V5ICE9PSAiVGFiIiB8fCBldmVudC5zaGlmdEtleSkK ICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBsZXQgcHNldWRvQ2xhc3NlcyA9IFdJLkNT U01hbmFnZXIuRm9yY2VhYmxlUHNldWRvQ2xhc3NlczsKLSAgICAgICAgbGV0IGluZGV4ID0gcHNl dWRvQ2xhc3Nlcy5pbmRleE9mKHBzZXVkb0NsYXNzKTsKLSAgICAgICAgaWYgKGV2ZW50LnNoaWZ0 S2V5KSB7Ci0gICAgICAgICAgICBpZiAoaW5kZXggPiAwKSB7Ci0gICAgICAgICAgICAgICAgdGhp cy5fZm9yY2VkUHNldWRvQ2xhc3NDaGVja2JveGVzW3BzZXVkb0NsYXNzZXNbaW5kZXggLSAxXV0u Zm9jdXMoKTsKLSAgICAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwotICAgICAg ICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICB0aGlzLl9maWx0ZXJCYXIuaW5wdXRGaWVs ZC5mb2N1cygpOwotICAgICAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7Ci0gICAg ICAgICAgICB9Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICBpZiAoaW5kZXggPCBwc2V1 ZG9DbGFzc2VzLmxlbmd0aCAtIDEpIHsKLSAgICAgICAgICAgICAgICB0aGlzLl9mb3JjZWRQc2V1 ZG9DbGFzc0NoZWNrYm94ZXNbcHNldWRvQ2xhc3Nlc1tpbmRleCArIDFdXS5mb2N1cygpOwotICAg ICAgICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7Ci0gICAgICAgICAgICB9IGVsc2Ug aWYgKHRoaXMuX3BhbmVsLmZvY3VzRmlyc3RTZWN0aW9uKSB7CisgICAgICAgIGlmIChXSS5DU1NN YW5hZ2VyLkZvcmNlYWJsZVBzZXVkb0NsYXNzZXMubGFzdFZhbHVlID09PSBwc2V1ZG9DbGFzcykg eworICAgICAgICAgICAgLy8gTGFzdCBjaGVja2JveCBpcyBjdXJyZW50bHkgZm9jdXNlZC4KKyAg ICAgICAgICAgIGlmICh0aGlzLl9wYW5lbC5mb2N1c0ZpcnN0U2VjdGlvbikgewogICAgICAgICAg ICAgICAgIHRoaXMuX3BhbmVsLmZvY3VzRmlyc3RTZWN0aW9uKCk7CiAgICAgICAgICAgICAgICAg ZXZlbnQucHJldmVudERlZmF1bHQoKTsKICAgICAgICAgICAgIH0KQEAgLTQyOCwxMyArNDE2LDgg QEAgV0kuR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIEdlbmVyYWxTdHls ZURldGFpbHNTaWRlYmFyUGFuZWwgZXh0ZW4KICAgICAgICAgaWYgKGV2ZW50LmtleSAhPT0gIlRh YiIpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgaWYgKGV2ZW50LnNoaWZ0S2V5KSB7 Ci0gICAgICAgICAgICBpZiAodGhpcy5fcGFuZWwuZm9jdXNMYXN0U2VjdGlvbikgewotICAgICAg ICAgICAgICAgIHRoaXMuX3BhbmVsLmZvY3VzTGFzdFNlY3Rpb24oKTsKLSAgICAgICAgICAgICAg ICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwotICAgICAgICAgICAgfQotICAgICAgICB9IGVsc2Ug ewotICAgICAgICAgICAgdGhpcy5fZm9yY2VkUHNldWRvQ2xhc3NDaGVja2JveGVzW1dJLkNTU01h bmFnZXIuRm9yY2VhYmxlUHNldWRvQ2xhc3Nlc1swXV0uZm9jdXMoKTsKKyAgICAgICAgaWYgKGV2 ZW50LnNoaWZ0S2V5ICYmIHRoaXMuX3BhbmVsLmZvY3VzTGFzdFNlY3Rpb24pIHsKKyAgICAgICAg ICAgIHRoaXMuX3BhbmVsLmZvY3VzTGFzdFNlY3Rpb24oKTsKICAgICAgICAgICAgIGV2ZW50LnBy ZXZlbnREZWZhdWx0KCk7CiAgICAgICAgIH0KICAgICB9Cg== 392645 2020-03-05 16:28:38 -0800 2020-03-05 16:47:03 -0800 Patch patch.txt text/plain 3315 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM4NDAzMTNjNzk0Li42ZTZiNDU0NjdjNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDMtMDMgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogQVhJOiBjYW4ndCBsZWF2ZSBTdHlsZXMgYW5kIENvbXB1dGVkIHBhbmVscyBieSBwcmVzc2lu ZyBUYWIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw ODU0OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjAwMjAxNDk+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgRGV2aW4gUm91c3NvLgorCisgICAgICAgIFJlbW92ZSBmb2N1cyBjeWNsaW5nIGluc2lk ZSBvZiB0aGUgU3R5bGVzIGFuZCBDb21wdXRlZCBwYW5lbHMuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL0dlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuanM6CisgICAgICAg IChXSS5HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5faGFuZGxlRm9y Y2VkUHNldWRvQ2xhc3NDaGVja2JveEtleWRvd24pOgorICAgICAgICAoV0kuR2VuZXJhbFN0eWxl RGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUuX2hhbmRsZUZpbHRlckJhcklucHV0RmllbGRL ZXlEb3duKToKKwogMjAyMC0wMi0yNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogbG9jYWxpemUgdGhlIHBsYWNlaG9sZGVyICJIZWFk ZXIiIGFuZCAidmFsdWUiIHdoZW4gZWRpdGluZyBhIGxvY2FsIG92ZXJyaWRlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsU3R5bGVE ZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0YWlsc1NpZGViYXJQYW5lbC5qcwppbmRleCBhMzIyOTVi MTU0OC4uMWQ0OTUyNzU3Y2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFuZWwuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFN0eWxlRGV0 YWlsc1NpZGViYXJQYW5lbC5qcwpAQCAtMjM2LDI0ICsyMzYsMTIgQEAgV0kuR2VuZXJhbFN0eWxl RGV0YWlsc1NpZGViYXJQYW5lbCA9IGNsYXNzIEdlbmVyYWxTdHlsZURldGFpbHNTaWRlYmFyUGFu ZWwgZXh0ZW4KIAogICAgIF9oYW5kbGVGb3JjZWRQc2V1ZG9DbGFzc0NoZWNrYm94S2V5ZG93bihw c2V1ZG9DbGFzcywgZXZlbnQpCiAgICAgewotICAgICAgICBpZiAoZXZlbnQua2V5ICE9PSAiVGFi IikKKyAgICAgICAgaWYgKGV2ZW50LmtleSAhPT0gIlRhYiIgfHwgZXZlbnQuc2hpZnRLZXkpCiAg ICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgbGV0IHBzZXVkb0NsYXNzZXMgPSBXSS5DU1NN YW5hZ2VyLkZvcmNlYWJsZVBzZXVkb0NsYXNzZXM7Ci0gICAgICAgIGxldCBpbmRleCA9IHBzZXVk b0NsYXNzZXMuaW5kZXhPZihwc2V1ZG9DbGFzcyk7Ci0gICAgICAgIGlmIChldmVudC5zaGlmdEtl eSkgewotICAgICAgICAgICAgaWYgKGluZGV4ID4gMCkgewotICAgICAgICAgICAgICAgIHRoaXMu X2ZvcmNlZFBzZXVkb0NsYXNzQ2hlY2tib3hlc1twc2V1ZG9DbGFzc2VzW2luZGV4IC0gMV1dLmZv Y3VzKCk7Ci0gICAgICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKLSAgICAgICAg ICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgdGhpcy5fZmlsdGVyQmFyLmlucHV0RmllbGQu Zm9jdXMoKTsKLSAgICAgICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwotICAgICAg ICAgICAgfQotICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgaWYgKGluZGV4IDwgcHNldWRv Q2xhc3Nlcy5sZW5ndGggLSAxKSB7Ci0gICAgICAgICAgICAgICAgdGhpcy5fZm9yY2VkUHNldWRv Q2xhc3NDaGVja2JveGVzW3BzZXVkb0NsYXNzZXNbaW5kZXggKyAxXV0uZm9jdXMoKTsKLSAgICAg ICAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwotICAgICAgICAgICAgfSBlbHNlIGlm ICh0aGlzLl9wYW5lbC5mb2N1c0ZpcnN0U2VjdGlvbikgeworICAgICAgICBpZiAoV0kuQ1NTTWFu YWdlci5Gb3JjZWFibGVQc2V1ZG9DbGFzc2VzLmxhc3RWYWx1ZSA9PT0gcHNldWRvQ2xhc3MpIHsK KyAgICAgICAgICAgIC8vIExhc3QgY2hlY2tib3ggaXMgY3VycmVudGx5IGZvY3VzZWQuCisgICAg ICAgICAgICBpZiAodGhpcy5fcGFuZWwuZm9jdXNGaXJzdFNlY3Rpb24pIHsKICAgICAgICAgICAg ICAgICB0aGlzLl9wYW5lbC5mb2N1c0ZpcnN0U2VjdGlvbigpOwogICAgICAgICAgICAgICAgIGV2 ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAgICAgICB9CkBAIC00MjUsMTYgKzQxMywxMSBA QCBXSS5HZW5lcmFsU3R5bGVEZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgR2VuZXJhbFN0eWxl RGV0YWlsc1NpZGViYXJQYW5lbCBleHRlbgogCiAgICAgX2hhbmRsZUZpbHRlckJhcklucHV0Rmll bGRLZXlEb3duKGV2ZW50KQogICAgIHsKLSAgICAgICAgaWYgKGV2ZW50LmtleSAhPT0gIlRhYiIp CisgICAgICAgIGlmIChldmVudC5rZXkgIT09ICJUYWIiIHx8ICFldmVudC5zaGlmdEtleSkKICAg ICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBpZiAoZXZlbnQuc2hpZnRLZXkpIHsKLSAgICAg ICAgICAgIGlmICh0aGlzLl9wYW5lbC5mb2N1c0xhc3RTZWN0aW9uKSB7Ci0gICAgICAgICAgICAg ICAgdGhpcy5fcGFuZWwuZm9jdXNMYXN0U2VjdGlvbigpOwotICAgICAgICAgICAgICAgIGV2ZW50 LnByZXZlbnREZWZhdWx0KCk7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0gZWxzZSB7Ci0gICAg ICAgICAgICB0aGlzLl9mb3JjZWRQc2V1ZG9DbGFzc0NoZWNrYm94ZXNbV0kuQ1NTTWFuYWdlci5G b3JjZWFibGVQc2V1ZG9DbGFzc2VzWzBdXS5mb2N1cygpOworICAgICAgICBpZiAodGhpcy5fcGFu ZWwuZm9jdXNMYXN0U2VjdGlvbikgeworICAgICAgICAgICAgdGhpcy5fcGFuZWwuZm9jdXNMYXN0 U2VjdGlvbigpOwogICAgICAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKICAgICAgICAg fQogICAgIH0K