208548 2020-03-03 17:01:47 -0800 Add signposts for top-level script execution 2020-03-05 16:02:55 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 nham nham achristensen cdumez commit-queue esprehn+autocc ews-watchlist kangil.han nham webkit-bug-importer oldest_to_newest 1625325 0 nham 2020-03-03 17:01:47 -0800 Add signposts for top-level script execution 1625330 1 392350 nham 2020-03-03 17:08:54 -0800 Created attachment 392350 Patch 1625331 2 webkit-bug-importer 2020-03-03 17:09:24 -0800 <rdar://problem/60020308> 1626319 3 nham 2020-03-05 15:04:13 -0800 Alex was a bit concerned about the URL being logged in the signpost, but that is pretty important to making the signpost actually useful. It is sensitive data and WTFSignpost takes care of that by not logging the signpost unless a profiling environment variable is set and the code is running on an AppleInternal system. 1626362 4 392350 commit-queue 2020-03-05 16:02:54 -0800 Comment on attachment 392350 Patch Clearing flags on attachment: 392350 Committed r257955: <https://trac.webkit.org/changeset/257955> 1626363 5 commit-queue 2020-03-05 16:02:55 -0800 All reviewed patches have been landed. Closing bug. 392350 2020-03-03 17:08:54 -0800 2020-03-05 16:02:54 -0800 Patch bug-208548-20200303170853.patch text/plain 3384 nham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU3NzgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2MxZjliYjY5NjJiOWE2 MTc5MGI0Y2ZlMGZmMjkzNmZmOTAwOTg5NC4uZTEzNzg4NDdhODc0Yzc3NjMzMDI1NmE4YzlhYzU0 ZmEzOWI0MzBmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIwLTAzLTAzICBCZW4g TmhhbSAgPG5oYW1AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBzaWducG9zdHMgZm9yIHRvcC1s ZXZlbCBleGVjdXRpb24gb2Ygc2NyaXB0IGVsZW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg1NDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGFkZHMgc2lnbnBvc3RzIGZvciBpbml0aWFs IGdsb2JhbCBzY29wZSBjb2RlIGV2YWx1YXRpb24gb2Ygc2NyaXB0IGVsZW1lbnRzLiBUaGlzIG1h a2VzCisgICAgICAgIGl0IGVhc2llciB0byB1bmRlcnN0YW5kIHdoYXQgY29kZSBpcyBleGVjdXRp bmcgYW5kIGJsb2NraW5nIGluaXRpYWwgSFRNTCBwYXJzaW5nIGZyb20KKyAgICAgICAgY29tcGxl dGluZy4KKworICAgICAgICBJbiB0aGUgbG9uZyBydW4sIGl0IHdvdWxkIGJlIG5pY2UgdG8gZXh0 ZW5kIHRoaXMgdG8gYWxsIHRvcC1sZXZlbCBlbnRyeSBwb2ludHMgYmFjayBpbnRvIEpTCisgICAg ICAgIChlLmcuIHdlIHNob3VsZCBlbWl0IGFuIGludGVydmFsIGlmIHdlIHJlLWVudGVyIGEgc2Ny aXB0IHZpYSBzZXRUaW1lb3V0KS4gSG93ZXZlciwgc3VjaAorICAgICAgICBwcm9iZXMgaGF2ZSBi ZWVuIHJlbW92ZWQgaW4gdGhlIHBhc3QgZm9yIGJlaW5nIHRvbyBub2lzeSBvciBzbG93IChsaWtl IGluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODcx OTYpLCBzbyBsZXQncyBqdXN0IHN0YXJ0IHdpdGggdGhpcyBmb3Igbm93LgorCisgICAgICAgIE5v dGUgdGhhdCB3ZSBkbyBlbWl0IHRoZSBzY3JpcHQgVVJMIGluIHRoZSBzaWducG9zdCwgYnV0IHRo ZSBzaWducG9zdCBpcyBnYXRlZCBiZWhpbmQgYm90aAorICAgICAgICBhbiBlbnZpcm9ubWVudCB2 YXJpYWJsZSBhbmQgYW4gQXBwbGUtaW50ZXJuYWwgY2hlY2sgdG8gcHJldmVudCBhY2NpZGVudGFs bHkgbGVha2luZworICAgICAgICBzZW5zaXRpdmUgaW5mby4KKworICAgICAgICAqIGRvbS9TY3Jp cHRFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6OmV4ZWN1dGVD bGFzc2ljU2NyaXB0KToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdEVsZW1lbnQ6OmV4ZWN1dGVN b2R1bGVTY3JpcHQpOgorCiAyMDIwLTAzLTAzICBLYXRlIENoZW5leSAgPGthdGhlcmluZV9jaGVu ZXlAYXBwbGUuY29tPgogCiAgICAgICAgIENoZWNrIGZvciBuYXZpZ2F0aW9uIHRvIGFwcC1ib3Vu ZCBkb21haW4gZHVyaW5nIHNjcmlwdCBldmFsdWF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9kb20vU2NyaXB0RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vU2NyaXB0RWxl bWVudC5jcHAKaW5kZXggOGUxMDZlMWY5ZGViOGNlZGRmZDJkZTAxZGNhZDY4MGQxMzNjOTJiNi4u ZDM5OWVlMDk3OGYyMmQ1ZjNhZGY1ODJlMTNmZGZkZjFmOTk1NTBjZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL1NjcmlwdEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Rv bS9TY3JpcHRFbGVtZW50LmNwcApAQCAtNTIsNiArNTIsNyBAQAogI2luY2x1ZGUgIlNldHRpbmdz LmgiCiAjaW5jbHVkZSAiVGV4dE5vZGVUcmF2ZXJzYWwuaCIKICNpbmNsdWRlIDx3dGYvU3RkTGli RXh0cmFzLmg+CisjaW5jbHVkZSA8d3RmL1N5c3RlbVRyYWNpbmcuaD4KICNpbmNsdWRlIDx3dGYv dGV4dC9TdHJpbmdCdWlsZGVyLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nSGFzaC5oPgog CkBAIC0zOTIsNyArMzkzLDkgQEAgdm9pZCBTY3JpcHRFbGVtZW50OjpleGVjdXRlQ2xhc3NpY1Nj cmlwdChjb25zdCBTY3JpcHRTb3VyY2VDb2RlJiBzb3VyY2VDb2RlKQogICAgIElnbm9yZURlc3Ry dWN0aXZlV3JpdGVDb3VudEluY3JlbWVudGVyIGlnbm9yZURlc2N0cnVjdGl2ZVdyaXRlQ291bnRJ bmNyZW1lbnRlcihtX2lzRXh0ZXJuYWxTY3JpcHQgPyAmZG9jdW1lbnQgOiBudWxscHRyKTsKICAg ICBDdXJyZW50U2NyaXB0SW5jcmVtZW50ZXIgY3VycmVudFNjcmlwdEluY3JlbWVudGVyKGRvY3Vt ZW50LCBtX2VsZW1lbnQpOwogCisgICAgV1RGQmVnaW5TaWducG9zdCh0aGlzLCAiRXhlY3V0ZSBT Y3JpcHQgRWxlbWVudCIsICJleGVjdXRpbmcgY2xhc3NpYyBzY3JpcHQgZnJvbSBVUkw6ICV7cHVi bGljfXMgYXN5bmM6ICVkIGRlZmVyOiAlZCIsIG1faXNFeHRlcm5hbFNjcmlwdCA/IHNvdXJjZUNv ZGUudXJsKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSA6ICJpbmxpbmUiLCBoYXNBc3luY0F0dHJp YnV0ZSgpLCBoYXNEZWZlckF0dHJpYnV0ZSgpKTsKICAgICBmcmFtZS0+c2NyaXB0KCkuZXZhbHVh dGVJZ25vcmluZ0V4Y2VwdGlvbihzb3VyY2VDb2RlKTsKKyAgICBXVEZFbmRTaWducG9zdCh0aGlz LCAiRXhlY3V0ZSBTY3JpcHQgRWxlbWVudCIpOwogfQogCiB2b2lkIFNjcmlwdEVsZW1lbnQ6OmV4 ZWN1dGVNb2R1bGVTY3JpcHQoTG9hZGFibGVNb2R1bGVTY3JpcHQmIGxvYWRhYmxlTW9kdWxlU2Ny aXB0KQpAQCAtNDA5LDcgKzQxMiw5IEBAIHZvaWQgU2NyaXB0RWxlbWVudDo6ZXhlY3V0ZU1vZHVs ZVNjcmlwdChMb2FkYWJsZU1vZHVsZVNjcmlwdCYgbG9hZGFibGVNb2R1bGVTY3JpCiAgICAgSWdu b3JlRGVzdHJ1Y3RpdmVXcml0ZUNvdW50SW5jcmVtZW50ZXIgaWdub3JlRGVzY3RydWN0aXZlV3Jp dGVDb3VudEluY3JlbWVudGVyKCZkb2N1bWVudCk7CiAgICAgQ3VycmVudFNjcmlwdEluY3JlbWVu dGVyIGN1cnJlbnRTY3JpcHRJbmNyZW1lbnRlcihkb2N1bWVudCwgbV9lbGVtZW50KTsKIAorICAg IFdURkJlZ2luU2lnbnBvc3QodGhpcywgIkV4ZWN1dGUgU2NyaXB0IEVsZW1lbnQiLCAiZXhlY3V0 aW5nIG1vZHVsZSBzY3JpcHQiKTsKICAgICBmcmFtZS0+c2NyaXB0KCkubGlua0FuZEV2YWx1YXRl TW9kdWxlU2NyaXB0KGxvYWRhYmxlTW9kdWxlU2NyaXB0KTsKKyAgICBXVEZFbmRTaWducG9zdCh0 aGlzLCAiRXhlY3V0ZSBTY3JpcHQgRWxlbWVudCIsICJleGVjdXRpbmcgbW9kdWxlIHNjcmlwdCIp OwogfQogCiB2b2lkIFNjcmlwdEVsZW1lbnQ6OmRpc3BhdGNoTG9hZEV2ZW50UmVzcGVjdGluZ1Vz ZXJHZXN0dXJlSW5kaWNhdG9yKCkK