208542 2020-03-03 15:44:33 -0800 Web Inspector: AXI: annotate tab panels 2020-03-05 19:57:37 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1625285 0 nvasilyev 2020-03-03 15:44:33 -0800 With tab panels annotated, VoiceOver reads tab name the 1st time focusing on any element within it. Steps: 1. Open Elements tab 2. Focus on any DOM tree outline item Expected: VoiceOver read the selected tree outline item and then "Elements, tab panel". After that, changing focus to any other element within the Elements tab doesn't not result VoiceOver reading "Elements, tab panel" again. Actual: VoiceOver read the selected tree outline item — nothing about the Elements tab. 1625298 1 392344 nvasilyev 2020-03-03 15:56:19 -0800 Created attachment 392344 Patch 1625299 2 webkit-bug-importer 2020-03-03 15:56:43 -0800 <rdar://problem/60017450> 1626368 3 392344 hi 2020-03-05 16:06:23 -0800 Comment on attachment 392344 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392344&action=review r=me > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: AXI: annotate tab panels Please add an explanation as to why `role="main"` is not sufficient, and why `role="tabpanel"` is better. > Source/WebInspectorUI/UserInterface/Base/Main.js:1822 > + WI._contentElement.ariaLabel = WI.tabBar.selectedTabBarItem?.title || ""; Rather than check `WI.tabBar.selectedTabBarItem` more than once, why not pull it out into a variable and share it with the check below? ``` let selectedTabBarItem = WI.tabBar.selectedTabBarItem; if (selectedTabBarItem) { WI._contentElement.ariaLabel = selectedTabBarItem.title || ""; if (selectedTabBarItem.representedObject.constructor.shouldSaveTab()) WI._selectedTabIndexSetting.value = WI.tabBar.tabBarItems.indexOf(selectedTabBarItem); ``` 1626393 4 392647 nvasilyev 2020-03-05 16:43:01 -0800 Created attachment 392647 Patch 1626471 5 392647 commit-queue 2020-03-05 19:57:35 -0800 Comment on attachment 392647 Patch Clearing flags on attachment: 392647 Committed r257965: <https://trac.webkit.org/changeset/257965> 1626472 6 commit-queue 2020-03-05 19:57:37 -0800 All reviewed patches have been landed. Closing bug. 392344 2020-03-03 15:56:19 -0800 2020-03-05 16:43:01 -0800 Patch patch.txt text/plain 2688 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM4NDAzMTNjNzk0Li5iMjc2MWJhYzQxNiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDMtMDMgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogQVhJOiBhbm5vdGF0ZSB0YWIgcGFuZWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg1NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIExvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3Ry aW5ncy5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qczoKKwogMjAyMC0w Mi0yNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIElu c3BlY3RvcjogbG9jYWxpemUgdGhlIHBsYWNlaG9sZGVyICJIZWFkZXIiIGFuZCAidmFsdWUiIHdo ZW4gZWRpdGluZyBhIGxvY2FsIG92ZXJyaWRlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5q cwppbmRleCAzYjMyNzU3OTYwYy4uNGI4NTA0MjJjNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVk U3RyaW5ncy5qcwpAQCAtMzA4LDcgKzMwOCw2IEBAIGxvY2FsaXplZFN0cmluZ3NbIkNvbnNvbGUg Y2xlYXJlZCBhdCAlcyJdID0gIkNvbnNvbGUgY2xlYXJlZCBhdCAlcyI7CiBsb2NhbGl6ZWRTdHJp bmdzWyJDb25zb2xlIG9wZW5lZCBhdCAlcyJdID0gIkNvbnNvbGUgb3BlbmVkIGF0ICVzIjsKIGxv Y2FsaXplZFN0cmluZ3NbIkNvbnNvbGUgcHJvbXB0Il0gPSAiQ29uc29sZSBwcm9tcHQiOwogbG9j YWxpemVkU3RyaW5nc1siQ29udGFpbmluZyJdID0gIkNvbnRhaW5pbmciOwotbG9jYWxpemVkU3Ry aW5nc1siQ29udGVudCJdID0gIkNvbnRlbnQiOwogbG9jYWxpemVkU3RyaW5nc1siQ29udGVudCBT ZWN1cml0eSBQb2xpY3kgdmlvbGF0aW9uIG9mIGRpcmVjdGl2ZTogJXMiXSA9ICJDb250ZW50IFNl Y3VyaXR5IFBvbGljeSB2aW9sYXRpb24gb2YgZGlyZWN0aXZlOiAlcyI7CiBsb2NhbGl6ZWRTdHJp bmdzWyJDb250aW51YXRpb24gRnJhbWUiXSA9ICJDb250aW51YXRpb24gRnJhbWUiOwogbG9jYWxp emVkU3RyaW5nc1siQ29udGludWUgc2NyaXB0IGV4ZWN1dGlvbiAoJXMgb3IgJXMpIl0gPSAiQ29u dGludWUgc2NyaXB0IGV4ZWN1dGlvbiAoJXMgb3IgJXMpIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRleCAxODZhNDFhMjYyZS4uZDc3 OGMzN2YzMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9C YXNlL01haW4uanMKQEAgLTI5Nyw4ICsyOTcsNyBAQCBXSS5jb250ZW50TG9hZGVkID0gZnVuY3Rp b24oKQogICAgIH0KIAogICAgIFdJLl9jb250ZW50RWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJjb250ZW50Iik7Ci0gICAgV0kuX2NvbnRlbnRFbGVtZW50LnNldEF0dHJpYnV0ZSgi cm9sZSIsICJtYWluIik7Ci0gICAgV0kuX2NvbnRlbnRFbGVtZW50LnNldEF0dHJpYnV0ZSgiYXJp YS1sYWJlbCIsIFdJLlVJU3RyaW5nKCJDb250ZW50IikpOworICAgIFdJLl9jb250ZW50RWxlbWVu dC5yb2xlID0gInRhYnBhbmVsIjsKIAogICAgIFdJLmNsZWFyS2V5Ym9hcmRTaG9ydGN1dCA9IG5l dyBXSS5LZXlib2FyZFNob3J0Y3V0KFdJLktleWJvYXJkU2hvcnRjdXQuTW9kaWZpZXIuQ29tbWFu ZE9yQ29udHJvbCwgIksiLCBXSS5fY2xlYXIpOwogCkBAIC0xODIwLDYgKzE4MTksOCBAQCBXSS5f c2V0dXBWaWV3SGllcmFyY2h5ID0gZnVuY3Rpb24oKQogCiBXSS5fdGFiQnJvd3NlclNlbGVjdGVk VGFiQ29udGVudFZpZXdEaWRDaGFuZ2UgPSBmdW5jdGlvbihldmVudCkKIHsKKyAgICBXSS5fY29u dGVudEVsZW1lbnQuYXJpYUxhYmVsID0gV0kudGFiQmFyLnNlbGVjdGVkVGFiQmFySXRlbT8udGl0 bGUgfHwgIiI7CisKICAgICBpZiAoV0kudGFiQmFyLnNlbGVjdGVkVGFiQmFySXRlbSAmJiBXSS50 YWJCYXIuc2VsZWN0ZWRUYWJCYXJJdGVtLnJlcHJlc2VudGVkT2JqZWN0LmNvbnN0cnVjdG9yLnNo b3VsZFNhdmVUYWIoKSkKICAgICAgICAgV0kuX3NlbGVjdGVkVGFiSW5kZXhTZXR0aW5nLnZhbHVl ID0gV0kudGFiQmFyLnRhYkJhckl0ZW1zLmluZGV4T2YoV0kudGFiQmFyLnNlbGVjdGVkVGFiQmFy SXRlbSk7CiAK 392647 2020-03-05 16:43:01 -0800 2020-03-05 19:57:35 -0800 Patch patch.txt text/plain 3175 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGM4NDAzMTNjNzk0Li40NTk1ZGJhYWJhMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDMtMDMgIE5pa2l0 YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogQVhJOiBhbm5vdGF0ZSB0YWIgcGFuZWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg1NDIKKworICAgICAgICBSZXZpZXdlZCBieSBEZXZpbiBS b3Vzc28uCisKKyAgICAgICAgKiBMb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmlu Z3MuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIFJl bW92ZSBgcm9sZT1tYWluYCBzaW5jZSBpdCB3YXMgcHJvdmlkaW5nIHZlcnkgZ2VuZXJpYyBhbmQg bm90IHVzZWZ1bCBkZXNjcmlwdGlvbiB0byBWb2ljZU92ZXIuCisKIDIwMjAtMDItMjcgIERldmlu IFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGxv Y2FsaXplIHRoZSBwbGFjZWhvbGRlciAiSGVhZGVyIiBhbmQgInZhbHVlIiB3aGVuIGVkaXRpbmcg YSBsb2NhbCBvdmVycmlkZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL0xvY2Fs aXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKaW5kZXggM2Iz Mjc1Nzk2MGMuLjRiODUwNDIyYzU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv TG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMK QEAgLTMwOCw3ICszMDgsNiBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJDb25zb2xlIGNsZWFyZWQgYXQg JXMiXSA9ICJDb25zb2xlIGNsZWFyZWQgYXQgJXMiOwogbG9jYWxpemVkU3RyaW5nc1siQ29uc29s ZSBvcGVuZWQgYXQgJXMiXSA9ICJDb25zb2xlIG9wZW5lZCBhdCAlcyI7CiBsb2NhbGl6ZWRTdHJp bmdzWyJDb25zb2xlIHByb21wdCJdID0gIkNvbnNvbGUgcHJvbXB0IjsKIGxvY2FsaXplZFN0cmlu Z3NbIkNvbnRhaW5pbmciXSA9ICJDb250YWluaW5nIjsKLWxvY2FsaXplZFN0cmluZ3NbIkNvbnRl bnQiXSA9ICJDb250ZW50IjsKIGxvY2FsaXplZFN0cmluZ3NbIkNvbnRlbnQgU2VjdXJpdHkgUG9s aWN5IHZpb2xhdGlvbiBvZiBkaXJlY3RpdmU6ICVzIl0gPSAiQ29udGVudCBTZWN1cml0eSBQb2xp Y3kgdmlvbGF0aW9uIG9mIGRpcmVjdGl2ZTogJXMiOwogbG9jYWxpemVkU3RyaW5nc1siQ29udGlu dWF0aW9uIEZyYW1lIl0gPSAiQ29udGludWF0aW9uIEZyYW1lIjsKIGxvY2FsaXplZFN0cmluZ3Nb IkNvbnRpbnVlIHNjcmlwdCBleGVjdXRpb24gKCVzIG9yICVzKSJdID0gIkNvbnRpbnVlIHNjcmlw dCBleGVjdXRpb24gKCVzIG9yICVzKSI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL01haW4uanMKaW5kZXggMTg2YTQxYTI2MmUuLjQ4ZDYwMmYzNDQ5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4u anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpz CkBAIC0yOTcsOCArMjk3LDcgQEAgV0kuY29udGVudExvYWRlZCA9IGZ1bmN0aW9uKCkKICAgICB9 CiAKICAgICBXSS5fY29udGVudEVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29u dGVudCIpOwotICAgIFdJLl9jb250ZW50RWxlbWVudC5zZXRBdHRyaWJ1dGUoInJvbGUiLCAibWFp biIpOwotICAgIFdJLl9jb250ZW50RWxlbWVudC5zZXRBdHRyaWJ1dGUoImFyaWEtbGFiZWwiLCBX SS5VSVN0cmluZygiQ29udGVudCIpKTsKKyAgICBXSS5fY29udGVudEVsZW1lbnQucm9sZSA9ICJ0 YWJwYW5lbCI7CiAKICAgICBXSS5jbGVhcktleWJvYXJkU2hvcnRjdXQgPSBuZXcgV0kuS2V5Ym9h cmRTaG9ydGN1dChXSS5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1hbmRPckNvbnRyb2ws ICJLIiwgV0kuX2NsZWFyKTsKIApAQCAtMTgyMCw4ICsxODE5LDEzIEBAIFdJLl9zZXR1cFZpZXdI aWVyYXJjaHkgPSBmdW5jdGlvbigpCiAKIFdJLl90YWJCcm93c2VyU2VsZWN0ZWRUYWJDb250ZW50 Vmlld0RpZENoYW5nZSA9IGZ1bmN0aW9uKGV2ZW50KQogewotICAgIGlmIChXSS50YWJCYXIuc2Vs ZWN0ZWRUYWJCYXJJdGVtICYmIFdJLnRhYkJhci5zZWxlY3RlZFRhYkJhckl0ZW0ucmVwcmVzZW50 ZWRPYmplY3QuY29uc3RydWN0b3Iuc2hvdWxkU2F2ZVRhYigpKQotICAgICAgICBXSS5fc2VsZWN0 ZWRUYWJJbmRleFNldHRpbmcudmFsdWUgPSBXSS50YWJCYXIudGFiQmFySXRlbXMuaW5kZXhPZihX SS50YWJCYXIuc2VsZWN0ZWRUYWJCYXJJdGVtKTsKKyAgICBsZXQgc2VsZWN0ZWRUYWJCYXJJdGVt ID0gV0kudGFiQmFyLnNlbGVjdGVkVGFiQmFySXRlbTsKKyAgICBpZiAoc2VsZWN0ZWRUYWJCYXJJ dGVtKSB7CisgICAgICAgIFdJLl9jb250ZW50RWxlbWVudC5hcmlhTGFiZWwgPSBzZWxlY3RlZFRh YkJhckl0ZW0udGl0bGUgfHwgIiI7CisKKyAgICAgICAgaWYgKHNlbGVjdGVkVGFiQmFySXRlbS5y ZXByZXNlbnRlZE9iamVjdC5jb25zdHJ1Y3Rvci5zaG91bGRTYXZlVGFiKCkpCisgICAgICAgICAg ICBXSS5fc2VsZWN0ZWRUYWJJbmRleFNldHRpbmcudmFsdWUgPSBXSS50YWJCYXIudGFiQmFySXRl bXMuaW5kZXhPZihzZWxlY3RlZFRhYkJhckl0ZW0pOworICAgIH0KIAogICAgIGlmIChXSS5kb2Vz Q3VycmVudFRhYlN1cHBvcnRTcGxpdENvbnRlbnRCcm93c2VyKCkpIHsKICAgICAgICAgaWYgKFdJ Ll9zaG91bGRSZXZlYWxTcGl0Q29uc29sZUlmU3VwcG9ydGVkKSB7Cg==