208534 2020-03-03 13:22:26 -0800 [Win] API header file has USE macro 2020-03-03 14:20:04 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue webkit-bug-importer oldest_to_newest 1625207 0 pvollan 2020-03-03 13:22:26 -0800 USE macros should not be used in API header files. 1625212 1 392319 pvollan 2020-03-03 13:26:53 -0800 Created attachment 392319 Patch 1625214 2 392319 bfulgham 2020-03-03 13:29:01 -0800 Comment on attachment 392319 Patch Whoops! 1625215 3 392319 bfulgham 2020-03-03 13:29:58 -0800 Comment on attachment 392319 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=392319&action=review > Source/WebKitLegacy/win/WebKitCOMAPI.h:-45 > -#if USE(CF) I think all configurations of WinCairo still requires CFLite, so I guess we always expect CFBundle to be define. 1625216 4 pvollan 2020-03-03 13:30:46 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 392319 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=392319&action=review > > > Source/WebKitLegacy/win/WebKitCOMAPI.h:-45 > > -#if USE(CF) > > I think all configurations of WinCairo still requires CFLite, so I guess we > always expect CFBundle to be define. Thanks for reviewing! 1625217 5 pvollan 2020-03-03 13:39:53 -0800 rdar://problem/60009752 1625248 6 392319 commit-queue 2020-03-03 14:20:03 -0800 Comment on attachment 392319 Patch Clearing flags on attachment: 392319 Committed r257802: <https://trac.webkit.org/changeset/257802> 1625249 7 commit-queue 2020-03-03 14:20:04 -0800 All reviewed patches have been landed. Closing bug. 392319 2020-03-03 13:26:53 -0800 2020-03-03 14:20:03 -0800 Patch bug-208534-20200303132652.patch text/plain 1214 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1Nzc5OSkKKysrIFNv dXJjZS9XZWJLaXRMZWdhY3kvd2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE0IEBACisyMDIwLTAzLTAzICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4K KworICAgICAgICBbV2luXSBBUEkgaGVhZGVyIGZpbGUgaGFzIFVTRSBtYWNybworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4NTM0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVVNFIG1hY3JvcyBzaG91bGQg bm90IGJlIHVzZWQgaW4gQVBJIGhlYWRlciBmaWxlcy4KKworICAgICAgICAqIFdlYktpdENPTUFQ SS5oOgorCiAyMDIwLTAzLTAyICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAKICAgICAg ICAgQWRkIHJlZmVycmVycG9saWN5IGF0dHJpYnV0ZSBzdXBwb3J0IGZvciBhbmNob3JzCkluZGV4 OiBTb3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJLaXRDT01BUEkuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0TGVnYWN5L3dpbi9XZWJLaXRDT01BUEkuaAkocmV2aXNpb24gMjU3Nzk1KQor KysgU291cmNlL1dlYktpdExlZ2FjeS93aW4vV2ViS2l0Q09NQVBJLmgJKHdvcmtpbmcgY29weSkK QEAgLTQyLDEwICs0Miw4IEBAIGV4dGVybiAiQyIgewogLy8gVGhpcyBieXBhc3NlcyBDb0NyZWF0 ZUluc3RhbmNlIGVudGlyZWx5LCBzbyByZWdpc3RyeSBrZXlzIGFuZCBpc29sYXRlZCBDT00gbWFu aWZlc3RzIGFyZW4ndCBuZWVkZWQuCiBIUkVTVUxUIFdFQktJVF9BUEkgV2ViS2l0Q3JlYXRlSW5z dGFuY2UoUkVGQ0xTSUQsIElVbmtub3duKiBwVW5rT3V0ZXIsIFJFRklJRCwgX0NPTV9PdXRwdHJf IHZvaWQqKiBwcHZPYmplY3QpOwogCi0jaWYgVVNFKENGKQogdHlwZWRlZiBzdHJ1Y3QgX19DRkJ1 bmRsZSogQ0ZCdW5kbGVSZWY7CiBDRkJ1bmRsZVJlZiBXRUJLSVRfQVBJIHdlYktpdEJ1bmRsZSgp OwotI2VuZGlmCiAKIH0KIAo=